154679 2016-02-25 09:44:41 -0800 Enable MallocScribble when detecting leaks 2016-02-25 12:20:10 -0800 1 1 1 Unclassified WebKit Tools / Tests Safari 9 Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ap ap commit-queue darin glenn lforschler oldest_to_newest 1168115 0 ap 2016-02-25 09:44:41 -0800 run-webkit-tests --leaks should automatically enable MallocScribble to better detect leaks. I haven't noticed any difference in my testing, however that's what the man page recommends. 1168116 1 272210 ap 2016-02-25 09:46:10 -0800 Created attachment 272210 proposed patch 1168129 2 272210 ggaren 2016-02-25 10:19:09 -0800 Comment on attachment 272210 proposed patch r=me 1168148 3 272210 commit-queue 2016-02-25 11:10:00 -0800 Comment on attachment 272210 proposed patch Clearing flags on attachment: 272210 Committed r197121: <http://trac.webkit.org/changeset/197121> 1168149 4 commit-queue 2016-02-25 11:10:04 -0800 All reviewed patches have been landed. Closing bug. 1168176 5 ap 2016-02-25 12:20:10 -0800 Looks like this may have improved leaks bot reliability - two test runs after this landed both had ~10% more unique leaks detected than earlier builds. Feb 25 11:31 197122 failure #3219 Failed 5356 total leaks found for a total of 2,421,568 bytes. 212 unique leaks found. 2 failures 8 new passes Feb 25 11:11 197121 failure #3218 Failed 6363 total leaks found for a total of 825,760 bytes. 212 unique leaks found. 8 new passes Feb 25 08:57 197120 failure #3217 Failed 6633 total leaks found for a total of 2,543,504 bytes. 183 unique leaks found. 8 new passes Feb 25 08:38 197118 failure #3216 Failed 5214 total leaks found for a total of 1,477,264 bytes. 186 unique leaks found. 1 failures 8 new passes Feb 25 07:30 197114 failure #3215 Failed 4704 total leaks found for a total of 2,276,736 bytes. 164 unique leaks found. 1 failures 8 new passes Feb 25 02:37 197090 failure #3214 Failed 6043 total leaks found for a total of 2,446,448 bytes. 120 unique leaks found. 8 new passes Feb 24 21:07 197061 failure #3213 Failed 3428 total leaks found for a total of 2,132,768 bytes. 191 unique leaks found. 8 new passes Feb 24 18:55 197060 failure #3212 Failed 5858 total leaks found for a total of 2,453,840 bytes. 188 unique leaks found. 2 failures 8 new passes Feb 24 18:06 197059 failure #3211 Failed 5555 total leaks found for a total of 2,416,576 bytes. 187 unique leaks found. 2 failures 8 new passes Feb 24 17:47 197058 failure #3210 Failed 5430 total leaks found for a total of 1,524,432 bytes. 170 unique leaks found. 1 failures 8 new passes Feb 24 16:31 197057 failure #3209 Failed 5482 total leaks found for a total of 2,405,168 bytes. 190 unique leaks found. 1 failures 8 new passes Feb 24 16:08 197056 failure #3208 Failed 4184 total leaks found for a total of 2,214,768 bytes. 123 unique leaks found. 1 failures 8 new passes Feb 24 15:47 197055 failure #3207 Failed 5014 total leaks found for a total of 2,323,856 bytes. 199 unique leaks found. 1 failures 8 new passes Feb 24 15:28 197054 failure #3206 Failed 4882 total leaks found for a total of 2,313,440 bytes. 185 unique leaks found. 1 failures 8 new passes Feb 24 14:42 197052 failure #3205 Failed 6407 total leaks found for a total of 2,515,024 bytes. 188 unique leaks found. 8 new passes Feb 24 14:22 197051 failure #3204 Failed 4318 total leaks found for a total of 2,457,056 bytes. 182 unique leaks found. 8 new passes Feb 24 14:02 197049 failure #3203 Failed 4834 total leaks found for a total of 596,496 bytes. 142 unique leaks found. 8 new passes Feb 24 13:42 197045 failure #3202 Failed 6008 total leaks found for a total of 747,136 bytes. 197 unique leaks found. 1 failures 8 new passes 272210 2016-02-25 09:46:10 -0800 2016-02-25 11:10:00 -0800 proposed patch MallocScribbleForLeaks.txt text/plain 3131 ap SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE5NzEyMCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE3IEBACisyMDE2LTAyLTI1ICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29t PgorCisgICAgICAgIEVuYWJsZSBNYWxsb2NTY3JpYmJsZSB3aGVuIGRldGVjdGluZyBsZWFrcwor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU0Njc5CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRz L3dlYmtpdHB5L3BvcnQvaW9zLnB5OgorICAgICAgICAoSU9TU2ltdWxhdG9yUG9ydC5zZXR1cF9l bnZpcm9uX2Zvcl9zZXJ2ZXIpOgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvcG9ydC9tYWMu cHk6CisgICAgICAgIChNYWNQb3J0LnNldHVwX2Vudmlyb25fZm9yX3NlcnZlcik6CisgICAgICAg ICogU2NyaXB0cy93ZWJraXRweS9wb3J0L21hY191bml0dGVzdC5weToKKyAgICAgICAgKE1hY1Rl c3QudGVzdF9zZXR1cF9lbnZpcm9uX2Zvcl9zZXJ2ZXIpOgorCiAyMDE2LTAyLTI1ICBFcmljIENh cmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIGZp eCBpT1MgYnVpbGRzIGFmdGVyIHIxOTcxMTQuCkluZGV4OiBUb29scy9TY3JpcHRzL3dlYmtpdHB5 L3BvcnQvaW9zLnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9p b3MucHkJKHJldmlzaW9uIDE5Njk4NCkKKysrIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9p b3MucHkJKHdvcmtpbmcgY29weSkKQEAgLTI2OSw2ICsyNjksOCBAQCBjbGFzcyBJT1NTaW11bGF0 b3JQb3J0KFBvcnQpOgogICAgICAgICAgICAgaWYgc2VsZi5nZXRfb3B0aW9uKCdsZWFrcycpOgog ICAgICAgICAgICAgICAgIGVudlsnTWFsbG9jU3RhY2tMb2dnaW5nJ10gPSAnMScKICAgICAgICAg ICAgICAgICBlbnZbJ19fWFBDX01hbGxvY1N0YWNrTG9nZ2luZyddID0gJzEnCisgICAgICAgICAg ICAgICAgZW52WydNYWxsb2NTY3JpYmJsZSddID0gJzEnCisgICAgICAgICAgICAgICAgZW52Wydf X1hQQ19NYWxsb2NTY3JpYmJsZSddID0gJzEnCiAgICAgICAgICAgICBpZiBzZWxmLmdldF9vcHRp b24oJ2d1YXJkX21hbGxvYycpOgogICAgICAgICAgICAgICAgIHNlbGYuX2FwcGVuZF92YWx1ZV9j b2xvbl9zZXBhcmF0ZWQoZW52LCAnRFlMRF9JTlNFUlRfTElCUkFSSUVTJywgJy91c3IvbGliL2xp YmdtYWxsb2MuZHlsaWInKQogICAgICAgICAgICAgICAgIHNlbGYuX2FwcGVuZF92YWx1ZV9jb2xv bl9zZXBhcmF0ZWQoZW52LCAnX19YUENfRFlMRF9JTlNFUlRfTElCUkFSSUVTJywgJy91c3IvbGli L2xpYmdtYWxsb2MuZHlsaWInKQpJbmRleDogVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L21h Yy5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvbWFjLnB5CShy ZXZpc2lvbiAxOTY5ODQpCisrKyBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvbWFjLnB5CSh3 b3JraW5nIGNvcHkpCkBAIC0xMDIsNiArMTAyLDggQEAgY2xhc3MgTWFjUG9ydChBcHBsZVBvcnQp OgogICAgICAgICAgICAgaWYgc2VsZi5nZXRfb3B0aW9uKCdsZWFrcycpOgogICAgICAgICAgICAg ICAgIGVudlsnTWFsbG9jU3RhY2tMb2dnaW5nJ10gPSAnMScKICAgICAgICAgICAgICAgICBlbnZb J19fWFBDX01hbGxvY1N0YWNrTG9nZ2luZyddID0gJzEnCisgICAgICAgICAgICAgICAgZW52WydN YWxsb2NTY3JpYmJsZSddID0gJzEnCisgICAgICAgICAgICAgICAgZW52WydfX1hQQ19NYWxsb2NT Y3JpYmJsZSddID0gJzEnCiAgICAgICAgICAgICBpZiBzZWxmLmdldF9vcHRpb24oJ2d1YXJkX21h bGxvYycpOgogICAgICAgICAgICAgICAgIHNlbGYuX2FwcGVuZF92YWx1ZV9jb2xvbl9zZXBhcmF0 ZWQoZW52LCAnRFlMRF9JTlNFUlRfTElCUkFSSUVTJywgJy91c3IvbGliL2xpYmdtYWxsb2MuZHls aWInKQogICAgICAgICAgICAgICAgIHNlbGYuX2FwcGVuZF92YWx1ZV9jb2xvbl9zZXBhcmF0ZWQo ZW52LCAnX19YUENfRFlMRF9JTlNFUlRfTElCUkFSSUVTJywgJy91c3IvbGliL2xpYmdtYWxsb2Mu ZHlsaWInKQpJbmRleDogVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L21hY191bml0dGVzdC5w eQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvbWFjX3VuaXR0ZXN0 LnB5CShyZXZpc2lvbiAxOTY5ODQpCisrKyBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvbWFj X3VuaXR0ZXN0LnB5CSh3b3JraW5nIGNvcHkpCkBAIC05Myw2ICs5Myw3IEBAIGNsYXNzIE1hY1Rl c3QocG9ydF90ZXN0Y2FzZS5Qb3J0VGVzdENhc2UKICAgICAgICAgcG9ydCA9IHNlbGYubWFrZV9w b3J0KG9wdGlvbnM9TW9ja09wdGlvbnMobGVha3M9VHJ1ZSwgZ3VhcmRfbWFsbG9jPVRydWUpKQog ICAgICAgICBlbnYgPSBwb3J0LnNldHVwX2Vudmlyb25fZm9yX3NlcnZlcihwb3J0LmRyaXZlcl9u YW1lKCkpCiAgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWwoZW52WydNYWxsb2NTdGFja0xvZ2dpbmcn XSwgJzEnKQorICAgICAgICBzZWxmLmFzc2VydEVxdWFsKGVudlsnTWFsbG9jU2NyaWJibGUnXSwg JzEnKQogICAgICAgICBzZWxmLmFzc2VydEVxdWFsKGVudlsnRFlMRF9JTlNFUlRfTElCUkFSSUVT J10sICcvdXNyL2xpYi9saWJnbWFsbG9jLmR5bGliOi9tb2NrLWJ1aWxkL2xpYldlYkNvcmVUZXN0 U2hpbS5keWxpYicpCiAKICAgICBkZWYgX2Fzc2VydF9zZWFyY2hfcGF0aChzZWxmLCBwb3J0X25h bWUsIGJhc2VsaW5lX3BhdGgsIHNlYXJjaF9wYXRocywgdXNlX3dlYmtpdDI9RmFsc2UpOgo=