15466 2007-10-11 06:55:34 -0700 [gtk] widget does not take focus on mouse click 2007-10-28 09:44:44 -0700 1 1 1 Unclassified WebKit WebKit Misc. 523.x (Safari 3) PC Linux RESOLVED FIXED P2 Normal --- 0 lars.lindner webkit-unassigned oldest_to_newest 58293 0 lars.lindner 2007-10-11 06:55:34 -0700 The current GTK widget does not set the focus if it receives a mouse button pressed event. 58294 1 16627 lars.lindner 2007-10-11 07:03:14 -0700 Created attachment 16627 Grabbing widget focus in mouse press callback. This patch copies the solution of the QT widget, which sets the widget focus in mouse press and double click callback. I also copied a FIXME comment from the QT code. I'm not sure if it is relevant. 58295 2 16628 lars.lindner 2007-10-11 07:05:20 -0700 Created attachment 16628 Grabbing widget focus in mouse press callback. Argh... I missed a tab. Reposting. 58296 3 16629 lars.lindner 2007-10-11 07:07:13 -0700 Created attachment 16629 Grabbing widget focus in mouse press callback. Fixing wrong spaced braces. 58437 4 mjs 2007-10-13 18:45:08 -0700 Someone who knows Gtk should look at this. 59657 5 16629 alp 2007-10-27 22:28:50 -0700 Comment on attachment 16629 Grabbing widget focus in mouse press callback. The focus issues need some real attention, but if this small patch helps your use case then it can go in. 59658 6 alp 2007-10-27 22:34:05 -0700 Landed in r27168. 59699 7 lars.lindner 2007-10-28 09:44:44 -0700 Alp: thanks for accepting it! Yes, it helps my use case because now the focussing in my multi-paned application works as expected. Before clicking in the WebKit widget had the focus still sitting in some other widget and any following key navigation navigated the wrong widget. So it is an improvement from the embedders viewpoint. With this merged I'll try to understand the code and see why the cursor key navigation when having focus doesn't work for me. 16627 2007-10-11 07:03:14 -0700 2007-10-11 07:05:20 -0700 Grabbing widget focus in mouse press callback. grab-focus.patch text/plain 1239 lars.lindner SW5kZXg6IFdlYktpdC9ndGsvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9ndGsvQ2hh bmdlTG9nCShyZXZpc2lvbiAyNjM1NikKKysrIFdlYktpdC9ndGsvQ2hhbmdlTG9nCSh3b3JraW5n IGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDctMTAtMTEgIExhcnMgTGluZG5lciAgPGxhcnMu bGluZG5lckBnbWFpbC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgW2d0a10gd2lkZ2V0IGRvZXMgbm90IHRha2UgZm9jdXMgb24gbW91c2UgY2xp Y2sKKyAgICAgICAgaHR0cDovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU0NjYK KworCUdyYWJiaW5nIHdpZGdldCBmb2N1cyBpbiBtb3VzZSBwcmVzcyBjYWxsYmFjay4KKworICAg ICAgICAqIEFwaS93ZWJraXRndGtwYWdlLmNwcDoKKwogMjAwNy0xMC0xMCAgQWxpY2UgTGl1ICA8 YWxpY2UubGl1QGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBHZW9mZiBHYXJlbi4K SW5kZXg6IFdlYktpdC9ndGsvQXBpL3dlYmtpdGd0a3BhZ2UuY3BwCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdl YktpdC9ndGsvQXBpL3dlYmtpdGd0a3BhZ2UuY3BwCShyZXZpc2lvbiAyNjE4MSkKKysrIFdlYktp dC9ndGsvQXBpL3dlYmtpdGd0a3BhZ2UuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMDIsOSArMTAy LDEzIEBAIHN0YXRpYyBnYm9vbGVhbiB3ZWJraXRfcGFnZV9idXR0b25fZXZlbnQKIAogICAgIGlm IChldmVudC0+dHlwZSA9PSBHREtfQlVUVE9OX1JFTEVBU0UpCiAgICAgICAgIGZyYW1lLT5ldmVu dEhhbmRsZXIoKS0+aGFuZGxlTW91c2VSZWxlYXNlRXZlbnQoUGxhdGZvcm1Nb3VzZUV2ZW50KGV2 ZW50KSk7Ci0gICAgZWxzZQorICAgIGVsc2UgewogICAgICAgICBmcmFtZS0+ZXZlbnRIYW5kbGVy KCktPmhhbmRsZU1vdXNlUHJlc3NFdmVudChQbGF0Zm9ybU1vdXNlRXZlbnQoZXZlbnQpKTsKIAor ICAgICAgICAvL0ZJWE1FIG5lZWQgdG8ga2VlcCB0cmFjayBvZiBzdWJmcmFtZSBmb2N1cyBmb3Ig a2V5IGV2ZW50cyEKKyAgICAgICAgZ3RrX3dpZGdldF9ncmFiX2ZvY3VzIChHVEtfV0lER0VUICh3 aWRnZXQpKTsKKyAgICB9CisKICAgICByZXR1cm4gRkFMU0U7CiB9CiAK 16628 2007-10-11 07:05:20 -0700 2007-10-11 07:07:13 -0700 Grabbing widget focus in mouse press callback. grab-focus.patch text/plain 1246 lars.lindner SW5kZXg6IFdlYktpdC9ndGsvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9ndGsvQ2hh bmdlTG9nCShyZXZpc2lvbiAyNjM1NikKKysrIFdlYktpdC9ndGsvQ2hhbmdlTG9nCSh3b3JraW5n IGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDctMTAtMTEgIExhcnMgTGluZG5lciAgPGxhcnMu bGluZG5lckBnbWFpbC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgW2d0a10gd2lkZ2V0IGRvZXMgbm90IHRha2UgZm9jdXMgb24gbW91c2UgY2xp Y2sKKyAgICAgICAgaHR0cDovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU0NjYK KworICAgICAgICBHcmFiYmluZyB3aWRnZXQgZm9jdXMgaW4gbW91c2UgcHJlc3MgY2FsbGJhY2su CisKKyAgICAgICAgKiBBcGkvd2Via2l0Z3RrcGFnZS5jcHA6CisKIDIwMDctMTAtMTAgIEFsaWNl IExpdSAgPGFsaWNlLmxpdUBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgR2VvZmYg R2FyZW4uCkluZGV4OiBXZWJLaXQvZ3RrL0FwaS93ZWJraXRndGtwYWdlLmNwcAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBXZWJLaXQvZ3RrL0FwaS93ZWJraXRndGtwYWdlLmNwcAkocmV2aXNpb24gMjYxODEpCisr KyBXZWJLaXQvZ3RrL0FwaS93ZWJraXRndGtwYWdlLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTAy LDkgKzEwMiwxMyBAQCBzdGF0aWMgZ2Jvb2xlYW4gd2Via2l0X3BhZ2VfYnV0dG9uX2V2ZW50CiAK ICAgICBpZiAoZXZlbnQtPnR5cGUgPT0gR0RLX0JVVFRPTl9SRUxFQVNFKQogICAgICAgICBmcmFt ZS0+ZXZlbnRIYW5kbGVyKCktPmhhbmRsZU1vdXNlUmVsZWFzZUV2ZW50KFBsYXRmb3JtTW91c2VF dmVudChldmVudCkpOwotICAgIGVsc2UKKyAgICBlbHNlIHsKICAgICAgICAgZnJhbWUtPmV2ZW50 SGFuZGxlcigpLT5oYW5kbGVNb3VzZVByZXNzRXZlbnQoUGxhdGZvcm1Nb3VzZUV2ZW50KGV2ZW50 KSk7CiAKKyAgICAgICAgLy9GSVhNRSBuZWVkIHRvIGtlZXAgdHJhY2sgb2Ygc3ViZnJhbWUgZm9j dXMgZm9yIGtleSBldmVudHMhCisgICAgICAgIGd0a193aWRnZXRfZ3JhYl9mb2N1cyAoR1RLX1dJ REdFVCAod2lkZ2V0KSk7CisgICAgfQorCiAgICAgcmV0dXJuIEZBTFNFOwogfQogCg== 16629 2007-10-11 07:07:13 -0700 2007-10-27 22:28:50 -0700 Grabbing widget focus in mouse press callback. grab-focus.patch text/plain 1244 lars.lindner SW5kZXg6IFdlYktpdC9ndGsvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9ndGsvQ2hh bmdlTG9nCShyZXZpc2lvbiAyNjM1NikKKysrIFdlYktpdC9ndGsvQ2hhbmdlTG9nCSh3b3JraW5n IGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDctMTAtMTEgIExhcnMgTGluZG5lciAgPGxhcnMu bGluZG5lckBnbWFpbC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgW2d0a10gd2lkZ2V0IGRvZXMgbm90IHRha2UgZm9jdXMgb24gbW91c2UgY2xp Y2sKKyAgICAgICAgaHR0cDovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU0NjYK KworICAgICAgICBHcmFiYmluZyB3aWRnZXQgZm9jdXMgaW4gbW91c2UgcHJlc3MgY2FsbGJhY2su CisKKyAgICAgICAgKiBBcGkvd2Via2l0Z3RrcGFnZS5jcHA6CisKIDIwMDctMTAtMTAgIEFsaWNl IExpdSAgPGFsaWNlLmxpdUBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgR2VvZmYg R2FyZW4uCkluZGV4OiBXZWJLaXQvZ3RrL0FwaS93ZWJraXRndGtwYWdlLmNwcAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBXZWJLaXQvZ3RrL0FwaS93ZWJraXRndGtwYWdlLmNwcAkocmV2aXNpb24gMjYxODEpCisr KyBXZWJLaXQvZ3RrL0FwaS93ZWJraXRndGtwYWdlLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTAy LDkgKzEwMiwxMyBAQCBzdGF0aWMgZ2Jvb2xlYW4gd2Via2l0X3BhZ2VfYnV0dG9uX2V2ZW50CiAK ICAgICBpZiAoZXZlbnQtPnR5cGUgPT0gR0RLX0JVVFRPTl9SRUxFQVNFKQogICAgICAgICBmcmFt ZS0+ZXZlbnRIYW5kbGVyKCktPmhhbmRsZU1vdXNlUmVsZWFzZUV2ZW50KFBsYXRmb3JtTW91c2VF dmVudChldmVudCkpOwotICAgIGVsc2UKKyAgICBlbHNlIHsKICAgICAgICAgZnJhbWUtPmV2ZW50 SGFuZGxlcigpLT5oYW5kbGVNb3VzZVByZXNzRXZlbnQoUGxhdGZvcm1Nb3VzZUV2ZW50KGV2ZW50 KSk7CiAKKyAgICAgICAgLy9GSVhNRSBuZWVkIHRvIGtlZXAgdHJhY2sgb2Ygc3ViZnJhbWUgZm9j dXMgZm9yIGtleSBldmVudHMhCisgICAgICAgIGd0a193aWRnZXRfZ3JhYl9mb2N1cyhHVEtfV0lE R0VUKHdpZGdldCkpOworICAgIH0KKwogICAgIHJldHVybiBGQUxTRTsKIH0KIAo=