15465 2007-10-11 06:26:24 -0700 run-webkit-tests is too greedy calculating platform hierarchy 2007-10-14 05:16:32 -0700 1 1 1 Unclassified WebKit Tools / Tests 523.x (Safari 3) Mac OS X 10.4 RESOLVED FIXED P2 Normal --- 1 andrew webkit-unassigned oldest_to_newest 58291 0 andrew 2007-10-11 06:26:24 -0700 run-webkit-tests splits the platform test path at any "-" character, including those in paths that are above the WebKit checkout directory. This causes tests to be searched for in both "WebKit" and "WebKit-fb" if running the WebKit-fb tests when you've got a folder setup like this: ~/WebKit/ -- WebKit trunk checkout ~/WebKit-fb/ -- WebKit feature-branch checkout 58292 1 16626 andrew 2007-10-11 06:27:02 -0700 Created attachment 16626 Fix 58367 2 16626 aroben 2007-10-12 07:03:05 -0700 Comment on attachment 16626 Fix + Fix run-webkit-tests beeing too greedy in trying to split the platform name up Typo: beeing -> being You should put the bugzilla reference in here before you commit. r=me 58497 3 andrew 2007-10-14 05:16:32 -0700 Landed r26592 16626 2007-10-11 06:27:02 -0700 2007-10-12 07:03:05 -0700 Fix run-webkit-tests-greedy.patch text/plain 1440 andrew SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDI2MzU0KQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDctMTAtMTAgIEFuZHJldyBXZWxsaW5ndG9u ICA8cHJvdG9uQHdpcmV0YXBwZWQubmV0PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorICAgICAgICAKKyAgICAgICAgRml4IHJ1bi13ZWJraXQtdGVzdHMgYmVlaW5nIHRv byBncmVlZHkgaW4gdHJ5aW5nIHRvIHNwbGl0IHRoZSBwbGF0Zm9ybSBuYW1lIHVwCisgICAgICAg IGNhdXNpbmcgaXQgdG8gdHJ5IGFuZCBmaW5kIHRlc3RzIGluIGV2ZXJ5IGRpcmVjdG9yeSBhYm92 ZSB0aGUgZmlyc3QgIi0iIGluIHRoZQorICAgICAgICBwYXRoIHRvIHRoZSBMYXlvdXRUZXN0cwor CisgICAgICAgICogU2NyaXB0cy9ydW4td2Via2l0LXRlc3RzOgorCiAyMDA3LTEwLTA4ICBFcmlj IFNlaWRlbCAgPGVyaWNAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBNYXJrIFJv d2UuCkluZGV4OiBXZWJLaXRUb29scy9TY3JpcHRzL3J1bi13ZWJraXQtdGVzdHMKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gV2ViS2l0VG9vbHMvU2NyaXB0cy9ydW4td2Via2l0LXRlc3RzCShyZXZpc2lvbiAyNjM1 NCkKKysrIFdlYktpdFRvb2xzL1NjcmlwdHMvcnVuLXdlYmtpdC10ZXN0cwkod29ya2luZyBjb3B5 KQpAQCAtMTQ2NywxMCArMTQ2NywxMCBAQCBzdWIgYnVpbGRQbGF0Zm9ybUhpZXJhcmNoeSgpCiB7 CiAgICAgbWtwYXRoKCRwbGF0Zm9ybVRlc3REaXJlY3RvcnkpIGlmICgkcGxhdGZvcm0gZXEgInVu ZGVmaW5lZCIgJiYgIS1kICIkcGxhdGZvcm1UZXN0RGlyZWN0b3J5Iik7CiAKLSAgICBteSBAcGxh dGZvcm1zID0gc3BsaXQoJy0nLCAkcGxhdGZvcm1UZXN0RGlyZWN0b3J5KTsKKyAgICBteSBAcGxh dGZvcm1zID0gc3BsaXQoJy0nLCBiYXNlbmFtZSgkcGxhdGZvcm1UZXN0RGlyZWN0b3J5KSk7CiAg ICAgbXkgQGhpZXJhcmNoeTsKICAgICBmb3IgKG15ICRpPTA7ICRpIDwgQHBsYXRmb3JtczsgJGkr KykgewotICAgICAgICBteSAkc2NvcGVkID0gam9pbignLScsIEBwbGF0Zm9ybXNbMC4uKCQjcGxh dGZvcm1zIC0gJGkpXSk7CisgICAgICAgIG15ICRzY29wZWQgPSBjYXRkaXIoZGlybmFtZSgkcGxh dGZvcm1UZXN0RGlyZWN0b3J5KSwgam9pbignLScsIEBwbGF0Zm9ybXNbMC4uKCQjcGxhdGZvcm1z IC0gJGkpXSkpOwogICAgICAgICBwdXNoKEBoaWVyYXJjaHksICRzY29wZWQpIGlmICgtZCAkc2Nv cGVkKTsKICAgICB9CiAK