154643 2016-02-24 10:34:55 -0800 Stackmaps have problems with double register constraints 2016-02-25 10:08:51 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build All All RESOLVED FIXED P2 Normal --- 1 fpizlo fpizlo commit-queue keith_miller mark.lam msaboff saam oldest_to_newest 1167823 0 fpizlo 2016-02-24 10:34:55 -0800 Patch forthcoming. 1167824 1 272117 fpizlo 2016-02-24 10:36:00 -0800 Created attachment 272117 the patch 1167826 2 commit-queue 2016-02-24 10:38:29 -0800 Attachment 272117 did not pass style-queue: ERROR: Source/JavaScriptCore/b3/testb3.cpp:10442: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/b3/testb3.cpp:10449: Consider using CHECK_EQ instead of CHECK(a == b) [readability/check] [2] Total errors found: 2 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 1167827 3 272117 ggaren 2016-02-24 10:41:23 -0800 Comment on attachment 272117 the patch r=me 1168122 4 fpizlo 2016-02-25 10:08:51 -0800 Landed in http://trac.webkit.org/changeset/197037 272117 2016-02-24 10:36:00 -0800 2016-02-24 10:41:23 -0800 the patch blah.patch text/plain 2998 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTk3MDM2KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBA CisyMDE2LTAyLTI0ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg U3RhY2ttYXBzIGhhdmUgcHJvYmxlbXMgd2l0aCBkb3VibGUgcmVnaXN0ZXIgY29uc3RyYWludHMK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1NDY0Mwor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgaXMg Y3VycmVudGx5IGEgYmVuaWduIGJ1Zy4gSSBmb3VuZCBpdCB3aGlsZSBwbGF5aW5nLgorCisgICAg ICAgICogYjMvQjNMb3dlclRvQWlyLmNwcDoKKyAgICAgICAgKEpTQzo6QjM6OkFpcjo6TG93ZXJU b0Fpcjo6ZmlsbFN0YWNrbWFwKToKKyAgICAgICAgKiBiMy90ZXN0YjMuY3BwOgorICAgICAgICAo SlNDOjpCMzo6dGVzdFVSU2hpZnRTZWxmNjQpOgorICAgICAgICAoSlNDOjpCMzo6dGVzdFBhdGNo cG9pbnREb3VibGVSZWdzKToKKyAgICAgICAgKEpTQzo6QjM6Onplcm8pOgorICAgICAgICAoSlND OjpCMzo6cnVuKToKKwogMjAxNi0wMi0yNCAgU2thY2hrb3YgT2xla3NhbmRyICA8Z3NrYWNoa292 QGdtYWlsLmNvbT4KIAogICAgICAgICBbRVM2XSBBcnJvdyBmdW5jdGlvbiBzeW50YXguIEVtaXQg bG9hZGluZyZwdXR0aW5nIHRoaXMvc3VwZXIgb25seSBpZiB0aGV5IGFyZSB1c2VkIGluIGFycm93 IGZ1bmN0aW9uCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYjMvQjNMb3dlclRvQWlyLmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYjMvQjNMb3dlclRvQWlyLmNw cAkocmV2aXNpb24gMTk3MDM1KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2IzL0IzTG93ZXJU b0Fpci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTk5MSw3ICs5OTEsNyBAQCBwcml2YXRlOgogICAg ICAgICAgICAgY2FzZSBWYWx1ZVJlcDo6UmVnaXN0ZXI6CiAgICAgICAgICAgICAgICAgc3RhY2tt YXAtPmVhcmx5Q2xvYmJlcmVkKCkuY2xlYXIodmFsdWUucmVwKCkucmVnKCkpOwogICAgICAgICAg ICAgICAgIGFyZyA9IFRtcCh2YWx1ZS5yZXAoKS5yZWcoKSk7Ci0gICAgICAgICAgICAgICAgYXBw ZW5kKE1vdmUsIGltbU9yVG1wKHZhbHVlLnZhbHVlKCkpLCBhcmcpOworICAgICAgICAgICAgICAg IGFwcGVuZChyZWxheGVkTW92ZUZvclR5cGUodmFsdWUudmFsdWUoKS0+dHlwZSgpKSwgaW1tT3JU bXAodmFsdWUudmFsdWUoKSksIGFyZyk7CiAgICAgICAgICAgICAgICAgYnJlYWs7CiAgICAgICAg ICAgICBjYXNlIFZhbHVlUmVwOjpTdGFja0FyZ3VtZW50OgogICAgICAgICAgICAgICAgIGFyZyA9 IEFyZzo6Y2FsbEFyZyh2YWx1ZS5yZXAoKS5vZmZzZXRGcm9tU1AoKSk7CkluZGV4OiBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvYjMvdGVzdGIzLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNj cmlwdENvcmUvYjMvdGVzdGIzLmNwcAkocmV2aXNpb24gMTk3MDM1KQorKysgU291cmNlL0phdmFT Y3JpcHRDb3JlL2IzL3Rlc3RiMy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTEwNDI2LDYgKzEwNDI2 LDMwIEBAIHZvaWQgdGVzdFVSU2hpZnRTZWxmNjQoKQogICAgIGNoZWNrKDY0KTsKIH0KIAordm9p ZCB0ZXN0UGF0Y2hwb2ludERvdWJsZVJlZ3MoKQoreworICAgIFByb2NlZHVyZSBwcm9jOworICAg IEJhc2ljQmxvY2sqIHJvb3QgPSBwcm9jLmFkZEJsb2NrKCk7CisKKyAgICBWYWx1ZSogYXJnID0g cm9vdC0+YXBwZW5kTmV3PEFyZ3VtZW50UmVnVmFsdWU+KHByb2MsIE9yaWdpbigpLCBGUFJJbmZv Ojphcmd1bWVudEZQUjApOworICAgIAorICAgIFBhdGNocG9pbnRWYWx1ZSogcGF0Y2hwb2ludCA9 IHJvb3QtPmFwcGVuZE5ldzxQYXRjaHBvaW50VmFsdWU+KHByb2MsIERvdWJsZSwgT3JpZ2luKCkp OworICAgIHBhdGNocG9pbnQtPmFwcGVuZChhcmcsIFZhbHVlUmVwKEZQUkluZm86OmZwUmVnVDAp KTsKKyAgICBwYXRjaHBvaW50LT5yZXN1bHRDb25zdHJhaW50ID0gVmFsdWVSZXAoRlBSSW5mbzo6 ZnBSZWdUMCk7CisKKyAgICB1bnNpZ25lZCBudW1DYWxscyA9IDA7CisgICAgcGF0Y2hwb2ludC0+ c2V0R2VuZXJhdG9yKAorICAgICAgICBbJl0gKENDYWxsSGVscGVycyYsIGNvbnN0IFN0YWNrbWFw R2VuZXJhdGlvblBhcmFtcyYpIHsKKyAgICAgICAgICAgIG51bUNhbGxzKys7CisgICAgICAgIH0p OworCisgICAgcm9vdC0+YXBwZW5kTmV3PENvbnRyb2xWYWx1ZT4ocHJvYywgUmV0dXJuLCBPcmln aW4oKSwgcGF0Y2hwb2ludCk7CisKKyAgICBhdXRvIGNvZGUgPSBjb21waWxlKHByb2MpOworICAg IENIRUNLKG51bUNhbGxzID09IDEpOworICAgIENIRUNLKGludm9rZTxkb3VibGU+KCpjb2RlLCA0 Mi41KSA9PSA0Mi41KTsKK30KKwogLy8gTWFrZSBzdXJlIHRoZSBjb21waWxlciBkb2VzIG5vdCB0 cnkgdG8gb3B0aW1pemUgYW55dGhpbmcgb3V0LgogTkVWRVJfSU5MSU5FIGRvdWJsZSB6ZXJvKCkK IHsKQEAgLTExODQyLDYgKzExODY2LDggQEAgdm9pZCBydW4oY29uc3QgY2hhciogZmlsdGVyKQog ICAgIFJVTih0ZXN0VVJTaGlmdFNlbGY2NCgpKTsKICAgICBSVU4odGVzdExTaGlmdFNlbGY2NCgp KTsKIAorICAgIFJVTih0ZXN0UGF0Y2hwb2ludERvdWJsZVJlZ3MoKSk7CisKICAgICBpZiAodGFz a3MuaXNFbXB0eSgpKQogICAgICAgICB1c2FnZSgpOwogCg==