154605 2016-02-23 13:53:50 -0800 WKWebsiteDataStore should conform to NSCoding 2016-02-23 15:33:01 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca ryanhaddad oldest_to_newest 1167534 0 andersca 2016-02-23 13:53:50 -0800 WKWebsiteDataStore should conform to NSCoding 1167536 1 272050 andersca 2016-02-23 13:55:38 -0800 Created attachment 272050 Patch 1167539 2 andersca 2016-02-23 14:08:05 -0800 Committed r196995: <http://trac.webkit.org/changeset/196995> 1167568 3 ryanhaddad 2016-02-23 15:33:01 -0800 This appears to have caused an API test failure <https://build.webkit.org/builders/Apple%20El%20Capitan%20Debug%20WK2%20(Tests)/builds/3172> Tests that failed: Coding.WKWebsiteDataStore_Default ASSERTION FAILED: mainThreadPthread /Volumes/Data/slave/elcapitan-debug/build/Source/WTF/wtf/mac/MainThreadMac.mm(218) : bool WTF::isMainThread() 1 0x106ac7c40 WTFCrash 2 0x106afb6b6 WTF::isMainThread() 3 0x106b29661 WTF::StringImpl::createCFString() 4 0x106b2ad84 WTF::StringImpl::operator NSString*() 5 0x108b83d37 WTF::String::operator NSString*() const 6 0x108be8aef API::WebsiteDataStore::cacheDirectoryFileSystemRepresentation(WTF::String const&) 7 0x108be8a57 API::WebsiteDataStore::defaultApplicationCacheDirectory() 8 0x108be9264 API::WebsiteDataStore::defaultDataStoreConfiguration() 9 0x108be8019 API::WebsiteDataStore::defaultDataStore() 10 0x109758e30 +[WKWebsiteDataStore defaultDataStore] 11 0x10524fd3a Coding_WKWebsiteDataStore_Default_Test::TestBody() 12 0x10529c07a testing::Test::Run() 13 0x10529c95d testing::internal::TestInfoImpl::Run() 14 0x10529d4fd testing::TestCase::Run() 15 0x1052a3482 testing::internal::UnitTestImpl::RunAllTests() 16 0x1052a30f9 testing::UnitTest::Run() 17 0x1051a988e TestWebKitAPI::TestsController::run(int, char**) 18 0x105249da4 main 19 0x7fff839bc5ad start 272050 2016-02-23 13:55:38 -0800 2016-02-23 14:05:59 -0800 Patch bug-154605-20160223135520.patch text/plain 4069 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTk2OTk0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZWIzMjQwZjM5ZDg2MzJh NDM2ZmM2YzYzNjkyYjQ4OGQ0ODI2ZTA2My4uZGJhNTIzY2VhNDk3YzE3M2NkZjIwNzY2NjE3ZmVl YTA3MjIzZWY3NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE3IEBACiAyMDE2LTAyLTIzICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKKyAgICAgICAgV0tXZWJzaXRlRGF0 YVN0b3JlIHNob3VsZCBjb25mb3JtIHRvIE5TQ29kaW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTQ2MDUKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJzaXRl RGF0YVN0b3JlLmg6CisgICAgICAgICogVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYnNpdGVEYXRh U3RvcmUubW06CisgICAgICAgICgtW1dLV2Vic2l0ZURhdGFTdG9yZSBpbml0V2l0aENvZGVyOl0p OgorICAgICAgICAoLVtXS1dlYnNpdGVEYXRhU3RvcmUgZW5jb2RlV2l0aENvZGVyOl0pOgorCisy MDE2LTAyLTIzICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CisKICAgICAg ICAgRml4IGlPUyBidWlsZC4KIAogICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJW aWV3Q29uZmlndXJhdGlvbi5tbToKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9BUEkvQ29jb2EvV0tXZWJzaXRlRGF0YVN0b3JlLmggYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvQVBJL0NvY29hL1dLV2Vic2l0ZURhdGFTdG9yZS5oCmluZGV4IDMyYTgyOGZiM2EwN2M1NzI2 NDg0NjE3Yjk2NWJjMjk1ZmJiN2NhOGYuLjQyNmMyYjJmYWQ5YjQxY2U0ZDcxMWE3YzVlMzYyMGYz NTZmNDlkZjkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2Ev V0tXZWJzaXRlRGF0YVN0b3JlLmgKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9D b2NvYS9XS1dlYnNpdGVEYXRhU3RvcmUuaApAQCAtMzYsNyArMzYsNyBAQCBOU19BU1NVTUVfTk9O TlVMTF9CRUdJTgogIEluZGV4ZWREQiBkYXRhYmFzZXMsIGFuZCBsb2NhbCBzdG9yYWdlLgogICov CiBXS19DTEFTU19BVkFJTEFCTEUoMTBfMTEsIDlfMCkKLUBpbnRlcmZhY2UgV0tXZWJzaXRlRGF0 YVN0b3JlIDogTlNPYmplY3QKK0BpbnRlcmZhY2UgV0tXZWJzaXRlRGF0YVN0b3JlIDogTlNPYmpl Y3QgPE5TQ29kaW5nPgogCiAvKiBAYWJzdHJhY3QgUmV0dXJucyB0aGUgZGVmYXVsdCBkYXRhIHN0 b3JlLiAqLwogKyAoV0tXZWJzaXRlRGF0YVN0b3JlICopZGVmYXVsdERhdGFTdG9yZTsKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJzaXRlRGF0YVN0 b3JlLm1tIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYnNpdGVEYXRh U3RvcmUubW0KaW5kZXggYzczN2FhOGQ4YTMzNWE4NTYxOWMwZDkzNzM5NGQ5ZTQyMzRjMzZhNi4u M2E0OWZiMWM3OTVmZmQ0NjJmNTYyNDZlYjYzN2Q3ZDM0Njk5OTNkYiAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYnNpdGVEYXRhU3RvcmUubW0KKysr IGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYnNpdGVEYXRhU3RvcmUu bW0KQEAgLTUxLDYgKzUxLDMyIEBACiAgICAgW3N1cGVyIGRlYWxsb2NdOwogfQogCistIChpbnN0 YW5jZXR5cGUpaW5pdFdpdGhDb2RlcjooTlNDb2RlciAqKWNvZGVyCit7CisgICAgaWYgKCEoc2Vs ZiA9IFtzdXBlciBpbml0XSkpCisgICAgICAgIHJldHVybiBuaWw7CisKKyAgICBSZXRhaW5QdHI8 V0tXZWJzaXRlRGF0YVN0b3JlPiBkYXRhU3RvcmU7CisgICAgaWYgKFtjb2RlciBkZWNvZGVCb29s Rm9yS2V5OkAiaXNEZWZhdWx0RGF0YVN0b3JlIl0pCisgICAgICAgIGRhdGFTdG9yZSA9IFtXS1dl YnNpdGVEYXRhU3RvcmUgZGVmYXVsdERhdGFTdG9yZV07CisgICAgZWxzZQorICAgICAgICBkYXRh U3RvcmUgPSBbV0tXZWJzaXRlRGF0YVN0b3JlIG5vblBlcnNpc3RlbnREYXRhU3RvcmVdOworCisg ICAgW3NlbGYgcmVsZWFzZV07CisKKyAgICByZXR1cm4gZGF0YVN0b3JlLmxlYWtSZWYoKTsKK30K KworLSAodm9pZCllbmNvZGVXaXRoQ29kZXI6KE5TQ29kZXIgKiljb2RlcgoreworICAgIGlmIChz ZWxmID09IFtXS1dlYnNpdGVEYXRhU3RvcmUgZGVmYXVsdERhdGFTdG9yZV0pIHsKKyAgICAgICAg W2NvZGVyIGVuY29kZUJvb2w6WUVTIGZvcktleTpAImlzRGVmYXVsdERhdGFTdG9yZSJdOworICAg ICAgICByZXR1cm47CisgICAgfQorCisgICAgQVNTRVJUKCFzZWxmLnBlcnNpc3RlbnQpOworfQor CiAtIChCT09MKWlzUGVyc2lzdGVudAogewogICAgIHJldHVybiBfd2Vic2l0ZURhdGFTdG9yZS0+ aXNQZXJzaXN0ZW50KCk7CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cgYi9Ub29scy9DaGFu Z2VMb2cKaW5kZXggNzI3ZjNjNWM4NzU0YWMxZjE2MjEzYTY2NGIwZjlkMjRmYzg1ZGI5YS4uY2Nh YTg4YWZiNzg4YWVkMDNmYTRhYzYxOTMwNTQwY2I4YjQ1YzU3MyAxMDA2NDQKLS0tIGEvVG9vbHMv Q2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE1IEBACiAyMDE2LTAy LTIzICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKKyAgICAgICAgV0tX ZWJzaXRlRGF0YVN0b3JlIHNob3VsZCBjb25mb3JtIHRvIE5TQ29kaW5nCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTQ2MDUKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFRlc3RXZWJLaXRBUEkvVGVzdHMv V2ViS2l0MkNvY29hL0NvZGluZy5tbToKKyAgICAgICAgKFRFU1QpOgorCisyMDE2LTAyLTIzICBB bmRlcnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CisKICAgICAgICAgV0tXZWJWaWV3 Q29uZmlndXJhdGlvbiBzaG91bGQgY29uZm9ybSB0byBOU0NvZGluZwogICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU0NjAyCiAKZGlmZiAtLWdpdCBhL1Rv b2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0MkNvY29hL0NvZGluZy5tbSBiL1Rvb2xzL1Rl c3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0MkNvY29hL0NvZGluZy5tbQppbmRleCAwOTlkODI3ZmQ5 NzFlYTg1MDZkNDQ1N2Y3ZGY1OGJiMjQzYzdkMTIyLi5iZTE0ZWQ0OTdkMzYyMjRkN2ZhNTBmNTNk ZGY0ZmQxYzQyMjBmMjE4IDEwMDY0NAotLS0gYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dl YktpdDJDb2NvYS9Db2RpbmcubW0KKysrIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJL aXQyQ29jb2EvQ29kaW5nLm1tCkBAIC02NSw2ICs2NSwxOCBAQCBURVNUKENvZGluZywgV0tQcmVm ZXJlbmNlcykKICNlbmRpZgogfQogCitURVNUKENvZGluZywgV0tXZWJzaXRlRGF0YVN0b3JlX0Rl ZmF1bHQpCit7CisgICAgYXV0byBhID0gZW5jb2RlQW5kRGVjb2RlKFtXS1dlYnNpdGVEYXRhU3Rv cmUgZGVmYXVsdERhdGFTdG9yZV0pOworICAgIEVYUEVDVF9FUShbV0tXZWJzaXRlRGF0YVN0b3Jl IGRlZmF1bHREYXRhU3RvcmVdLCBhLmdldCgpKTsKK30KKworVEVTVChDb2RpbmcsIFdLV2Vic2l0 ZURhdGFTdG9yZV9Ob25QZXJzaXN0ZW50KQoreworICAgIGF1dG8gYSA9IGVuY29kZUFuZERlY29k ZShbV0tXZWJzaXRlRGF0YVN0b3JlIG5vblBlcnNpc3RlbnREYXRhU3RvcmVdKTsKKyAgICBFWFBF Q1RfRkFMU0UoW2EgaXNQZXJzaXN0ZW50XSk7Cit9CisKIFRFU1QoQ29kaW5nLCBXS1dlYlZpZXdD b25maWd1cmF0aW9uKQogewogICAgIGF1dG8gYSA9IGFkb3B0TlMoW1tXS1dlYlZpZXdDb25maWd1 cmF0aW9uIGFsbG9jXSBpbml0XSk7Cg==