154597 2016-02-23 11:29:08 -0800 WKPreferences should conform to NSCoding 2016-02-23 12:04:32 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca oldest_to_newest 1167481 0 andersca 2016-02-23 11:29:08 -0800 WKPreferences should conform to NSCoding 1167483 1 272038 andersca 2016-02-23 11:30:48 -0800 Created attachment 272038 Patch 1167488 2 272038 sam 2016-02-23 11:54:50 -0800 Comment on attachment 272038 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=272038&action=review > Source/WebKit2/UIProcess/API/Cocoa/WKPreferences.mm:70 > + > + self.minimumFontSize = [coder decodeDoubleForKey:@"minimumFontSize"]; Might be worth adding a comment about how only properties exposed as API get encoded/decoded. 1167493 3 andersca 2016-02-23 12:04:32 -0800 Committed r196987: <http://trac.webkit.org/changeset/196987> 272038 2016-02-23 11:30:48 -0800 2016-02-23 11:54:50 -0800 Patch bug-154597-20160223113030.patch text/plain 2940 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTk2OTgyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNTc0NGY5OTAyZGMzMjUz Njk3YjIxYWMzYjdhNTM4Zjk5YzhhM2YyMS4uYjcyM2RhMDk0ZGI0ODljMDNhMWQzYzY2NGFmNWNk MDQyNTcyYmZlMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE2LTAyLTIzICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CisKKyAgICAgICAgV0tQcmVmZXJlbmNl cyBzaG91bGQgY29uZm9ybSB0byBOU0NvZGluZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU0NTk3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgQWRkIE5TQ29kaW5nIGltcGxlbWVudGF0aW9uLgorCisgICAg ICAgICogVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1ByZWZlcmVuY2VzLmg6CisgICAgICAgICogVUlQ cm9jZXNzL0FQSS9Db2NvYS9XS1ByZWZlcmVuY2VzLm1tOgorICAgICAgICAoLVtXS1ByZWZlcmVu Y2VzIGVuY29kZVdpdGhDb2RlcjpdKToKKyAgICAgICAgKC1bV0tQcmVmZXJlbmNlcyBpbml0V2l0 aENvZGVyOl0pOgorCiAyMDE2LTAyLTIzICBCcmlhbiBCdXJnICA8YmJ1cmdAYXBwbGUuY29tPgog CiAgICAgICAgIENvbm5lY3QgV2ViQXV0b21hdGlvblNlc3Npb24gdG8gaXRzIGJhY2tlbmQgZGlz cGF0Y2hlciBhcyBpZiBpdCB3ZXJlIGFuIGFnZW50IGFuZCBhZGQgc3R1YiBpbXBsZW1lbnRhdGlv bnMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tQcmVm ZXJlbmNlcy5oIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1ByZWZlcmVu Y2VzLmgKaW5kZXggNjYwM2E4OWMwZjZjYzk4MzVmYjM1MTlhYzhhNGZhNDE0OGU0NDFlZS4uOWFi OGU5ODA2YzQwNmViYjBhZDNkMTk2ODQ2MzVhZGU4ZTNlMjY3MCAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1ByZWZlcmVuY2VzLmgKKysrIGIvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1ByZWZlcmVuY2VzLmgKQEAgLTM1LDcgKzM1 LDcgQEAKICBpdHMgd2ViIHZpZXcgY29uZmlndXJhdGlvbi4KICAqLwogV0tfQ0xBU1NfQVZBSUxB QkxFKDEwXzEwLCA4XzApCi1AaW50ZXJmYWNlIFdLUHJlZmVyZW5jZXMgOiBOU09iamVjdAorQGlu dGVyZmFjZSBXS1ByZWZlcmVuY2VzIDogTlNPYmplY3QgPE5TQ29kaW5nPgogCiAvKiEgQGFic3Ry YWN0IFRoZSBtaW5pbXVtIGZvbnQgc2l6ZSBpbiBwb2ludHMuCiAgQGRpc2N1c3Npb24gVGhlIGRl ZmF1bHQgdmFsdWUgaXMgMC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9B UEkvQ29jb2EvV0tQcmVmZXJlbmNlcy5tbSBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkv Q29jb2EvV0tQcmVmZXJlbmNlcy5tbQppbmRleCBlZDkxNTZkZTFjZmZmODljNjZhYTBlNDA5YmQ3 YzhiMDYyNjY4OGM5Li5lYTQ2NTQ4NzBmOWM0MTVmNTM5MGIzNGFiNjc1M2Y5M2I5YTFiY2E3IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29hL1dLUHJlZmVyZW5j ZXMubW0KKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1ByZWZlcmVu Y2VzLm1tCkBAIC01MCw2ICs1MCwzNSBAQAogICAgIFtzdXBlciBkZWFsbG9jXTsKIH0KIAorLSAo dm9pZCllbmNvZGVXaXRoQ29kZXI6KE5TQ29kZXIgKiljb2RlcgoreworICAgIFtjb2RlciBlbmNv ZGVEb3VibGU6c2VsZi5taW5pbXVtRm9udFNpemUgZm9yS2V5OkAibWluaW11bUZvbnRTaXplIl07 CisgICAgW2NvZGVyIGVuY29kZUJvb2w6c2VsZi5qYXZhU2NyaXB0RW5hYmxlZCBmb3JLZXk6QCJq YXZhU2NyaXB0RW5hYmxlZCJdOworICAgIFtjb2RlciBlbmNvZGVCb29sOnNlbGYuamF2YVNjcmlw dENhbk9wZW5XaW5kb3dzQXV0b21hdGljYWxseSBmb3JLZXk6QCJqYXZhU2NyaXB0Q2FuT3Blbldp bmRvd3NBdXRvbWF0aWNhbGx5Il07CisKKyNpZiBQTEFURk9STShNQUMpCisgICAgW2NvZGVyIGVu Y29kZUJvb2w6c2VsZi5qYXZhRW5hYmxlZCBmb3JLZXk6QCJqYXZhRW5hYmxlZCJdOworICAgIFtj b2RlciBlbmNvZGVCb29sOnNlbGYucGx1Z0luc0VuYWJsZWQgZm9yS2V5OkAicGx1Z0luc0VuYWJs ZWQiXTsKKyNlbmRpZgorfQorCistIChpbnN0YW5jZXR5cGUpaW5pdFdpdGhDb2RlcjooTlNDb2Rl ciAqKWNvZGVyCit7CisgICAgaWYgKCEoc2VsZiA9IFtzZWxmIGluaXRdKSkKKyAgICAgICAgcmV0 dXJuIG5pbDsKKworICAgIHNlbGYubWluaW11bUZvbnRTaXplID0gW2NvZGVyIGRlY29kZURvdWJs ZUZvcktleTpAIm1pbmltdW1Gb250U2l6ZSJdOworICAgIHNlbGYuamF2YVNjcmlwdEVuYWJsZWQg PSBbY29kZXIgZGVjb2RlQm9vbEZvcktleTpAImphdmFTY3JpcHRFbmFibGVkIl07CisgICAgc2Vs Zi5qYXZhU2NyaXB0Q2FuT3BlbldpbmRvd3NBdXRvbWF0aWNhbGx5ID0gW2NvZGVyIGRlY29kZUJv b2xGb3JLZXk6QCJqYXZhU2NyaXB0Q2FuT3BlbldpbmRvd3NBdXRvbWF0aWNhbGx5Il07CisKKyNp ZiBQTEFURk9STShNQUMpCisgICAgc2VsZi5qYXZhRW5hYmxlZCA9IFtjb2RlciBkZWNvZGVCb29s Rm9yS2V5OkAiamF2YUVuYWJsZWQiXTsKKyAgICBzZWxmLnBsdWdJbnNFbmFibGVkID0gW2NvZGVy IGRlY29kZUJvb2xGb3JLZXk6QCJwbHVnSW5zRW5hYmxlZCJdOworI2VuZGlmCisKKyAgICByZXR1 cm4gc2VsZjsKK30KKwogLSAoQ0dGbG9hdCltaW5pbXVtRm9udFNpemUKIHsKICAgICByZXR1cm4g X3ByZWZlcmVuY2VzLT5taW5pbXVtRm9udFNpemUoKTsK