154590 2016-02-23 09:29:26 -0800 [css-grid][css-flex] Make OrderIterator a STL iterator class 2024-08-20 12:14:06 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified NEW GoodFirstBug, InRadar P2 Normal --- 60731 1 rego webkit-unassigned jfernandez nathan_solomon rego sgill26 simon.fraser svillar webkit-bug-importer oldest_to_newest 1167421 0 rego 2016-02-23 09:29:26 -0800 OrderIterator is used by Grid Layout and Flexbox. From a comment in bug #154336 it would be nice to make it a STL iterator class: > > Source/WebCore/rendering/RenderGrid.cpp:1184 > > + for (RenderBox* child = m_orderIterator.first(); child; child = m_orderIterator.next()) { > > Perhaps not for this patch but we should make OrderIterator a stl > iterator-like class so that instead of first() and next() we have begin() > and end() and we could do things like > > for (auto child : m_orderIterator) 2054119 1 webkit-bug-importer 2024-08-20 11:04:15 -0700 <rdar://problem/134356478> 2054156 2 nathan_solomon 2024-08-20 11:57:51 -0700 Pull request: https://github.com/WebKit/WebKit/pull/32474 2054169 3 nathan_solomon 2024-08-20 12:14:06 -0700 Pull request: https://github.com/WebKit/WebKit/pull/32475