154581 2016-02-23 03:57:02 -0800 WebRTC: RTCPeerConnection: Sort out responsibilities of close() and stop() 2016-02-24 00:14:57 -0800 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 143211 1 adam.bergkvist webkit-unassigned alex commit-queue eric.carlson oldest_to_newest 1167362 0 adam.bergkvist 2016-02-23 03:57:02 -0800 RTCPeerConnection's stop() and close() could be implemented as one calling the other to avoid duplicating code. 1167363 1 272007 adam.bergkvist 2016-02-23 04:11:17 -0800 Created attachment 272007 Proposed patch 1167723 2 272007 adam.bergkvist 2016-02-23 23:24:12 -0800 Comment on attachment 272007 Proposed patch Thank you 1167733 3 272007 commit-queue 2016-02-24 00:14:53 -0800 Comment on attachment 272007 Proposed patch Clearing flags on attachment: 272007 Committed r197020: <http://trac.webkit.org/changeset/197020> 1167734 4 commit-queue 2016-02-24 00:14:57 -0800 All reviewed patches have been landed. Closing bug. 272007 2016-02-23 04:11:17 -0800 2016-02-24 00:14:53 -0800 Proposed patch pc-stop-close_0.patch text/plain 5716 adam.bergkvist ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBhMmFjZTRjLi43ZTY4ZmRkIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTYtMDIt MjMgIEFkYW0gQmVyZ2t2aXN0ICA8YWRhbS5iZXJna3Zpc3RAZXJpY3Nzb24uY29tPgorCisgICAg ICAgIFdlYlJUQzogUlRDUGVlckNvbm5lY3Rpb246IFNvcnQgb3V0IHJlc3BvbnNpYmlsaXRpZXMg b2YgY2xvc2UoKSBhbmQgc3RvcCgpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xNTQ1ODEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBVcGRhdGVkIHRlc3Qgd2l0aCByZXBsYWNlVHJhY2soKSBjYWxsIGFmdGVy IHRoZSBSVENQZWVyQ29ubmVjdGlvbiBvYmplY3QsIHRoYXQKKyAgICAgICAgY3JlYXRlZCB0aGUg UlRDUnRwU2VuZGVyLCBpcyBjbG9zZWQuCisKKyAgICAgICAgKiBmYXN0L21lZGlhc3RyZWFtL1JU Q1J0cFNlbmRlci1yZXBsYWNlVHJhY2stZXhwZWN0ZWQudHh0OgorICAgICAgICAqIGZhc3QvbWVk aWFzdHJlYW0vUlRDUnRwU2VuZGVyLXJlcGxhY2VUcmFjay5odG1sOgorCiAyMDE2LTAyLTE3ICBN eWxlcyBDLiBNYXhmaWVsZCAgPG1tYXhmaWVsZEBhcHBsZS5jb20+CiAKICAgICAgICAgW0ZvbnQg TG9hZGluZ10gSW1wbGVtZW50IEZvbnRGYWNlU2V0CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9m YXN0L21lZGlhc3RyZWFtL1JUQ1J0cFNlbmRlci1yZXBsYWNlVHJhY2stZXhwZWN0ZWQudHh0IGIv TGF5b3V0VGVzdHMvZmFzdC9tZWRpYXN0cmVhbS9SVENSdHBTZW5kZXItcmVwbGFjZVRyYWNrLWV4 cGVjdGVkLnR4dAppbmRleCAyNzY2OTUyLi4xY2VhMmY3IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9mYXN0L21lZGlhc3RyZWFtL1JUQ1J0cFNlbmRlci1yZXBsYWNlVHJhY2stZXhwZWN0ZWQudHh0 CisrKyBiL0xheW91dFRlc3RzL2Zhc3QvbWVkaWFzdHJlYW0vUlRDUnRwU2VuZGVyLXJlcGxhY2VU cmFjay1leHBlY3RlZC50eHQKQEAgLTE2LDYgKzE2LDEwIEBAIFRoaXMgaXMgYSB2YWxpZCBjYWxs IGJ1dCB3aWxsIGJlIHJlamVjdGVkIHVudGlsIHRoZSBQZWVyQ29ubmVjdGlvbkJhY2tlbmQgaW1w bGVtCiBQQVNTIHByb21pc2Ugc2VuZGVyLnJlcGxhY2VUcmFjayhhdWRpb1RyYWNrMikgcmVqZWN0 ZWQgd2l0aCBbb2JqZWN0IERPTUVycm9yXQogU3RvcCBzZW5kZXIsIGFuZCB0cnkgcmVwbGFjaW5n IHRoZSB0cmFjawogUEFTUyBwcm9taXNlIHNlbmRlci5yZXBsYWNlVHJhY2soYXVkaW9UcmFjazIp IHJlamVjdGVkIHdpdGggW29iamVjdCBET01FcnJvcl0KK0NyZWF0ZSBhIG5ldyBzZW5kZXIKK1BB U1Mgc2VuZGVyID0gcGMuYWRkVHJhY2soYXVkaW9UcmFjazIsIHN0cmVhbSkgZGlkIG5vdCB0aHJv dyBleGNlcHRpb24uCitDbG9zZSBwYyBhbmQgdHJ5IHJlcGxhY2luZyB0aGUgdHJhY2sKK1BBU1Mg cHJvbWlzZSBzZW5kZXIucmVwbGFjZVRyYWNrKGF1ZGlvVHJhY2szKSByZWplY3RlZCB3aXRoIFtv YmplY3QgRE9NRXJyb3JdCiBFbmQgb2YgcHJvbWlzZSBjaGFpbgogUEFTUyBzdWNjZXNzZnVsbHlQ YXJzZWQgaXMgdHJ1ZQogCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L21lZGlhc3RyZWFt L1JUQ1J0cFNlbmRlci1yZXBsYWNlVHJhY2suaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvbWVkaWFz dHJlYW0vUlRDUnRwU2VuZGVyLXJlcGxhY2VUcmFjay5odG1sCmluZGV4IGMwMTNjY2IuLmIwYjI0 ZGIgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3QvbWVkaWFzdHJlYW0vUlRDUnRwU2VuZGVy LXJlcGxhY2VUcmFjay5odG1sCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvbWVkaWFzdHJlYW0vUlRD UnRwU2VuZGVyLXJlcGxhY2VUcmFjay5odG1sCkBAIC0yOSw2ICsyOSw3IEBACiAgICAgICAgICAg ICAgICAgdmlkZW9UcmFjayA9IHN0cmVhbS5nZXRWaWRlb1RyYWNrcygpWzBdOwogCiAgICAgICAg ICAgICAgICAgYXVkaW9UcmFjazIgPSBhdWRpb1RyYWNrLmNsb25lKCk7CisgICAgICAgICAgICAg ICAgYXVkaW9UcmFjazMgPSBhdWRpb1RyYWNrLmNsb25lKCk7CiAKICAgICAgICAgICAgICAgICBz aG91bGRCZSgicGMuZ2V0U2VuZGVycygpLmxlbmd0aCIsICIwIik7CiAKQEAgLTU3LDYgKzU4LDEz IEBACiAgICAgICAgICAgICAgICAgICAgIHJldHVybiBwcm9taXNlU2hvdWxkUmVqZWN0KCJzZW5k ZXIucmVwbGFjZVRyYWNrKGF1ZGlvVHJhY2syKSIpOwogICAgICAgICAgICAgICAgIH0pCiAgICAg ICAgICAgICAgICAgLmNhdGNoKGZ1bmN0aW9uICgpIHsKKyAgICAgICAgICAgICAgICAgICAgZGVi dWcoIkNyZWF0ZSBhIG5ldyBzZW5kZXIiKTsKKyAgICAgICAgICAgICAgICAgICAgc2hvdWxkTm90 VGhyb3coInNlbmRlciA9IHBjLmFkZFRyYWNrKGF1ZGlvVHJhY2syLCBzdHJlYW0pIik7CisgICAg ICAgICAgICAgICAgICAgIGRlYnVnKCJDbG9zZSBwYyBhbmQgdHJ5IHJlcGxhY2luZyB0aGUgdHJh Y2siKTsKKyAgICAgICAgICAgICAgICAgICAgcGMuY2xvc2UoKTsKKyAgICAgICAgICAgICAgICAg ICAgcmV0dXJuIHByb21pc2VTaG91bGRSZWplY3QoInNlbmRlci5yZXBsYWNlVHJhY2soYXVkaW9U cmFjazMpIik7CisgICAgICAgICAgICAgICAgfSkKKyAgICAgICAgICAgICAgICAuY2F0Y2goZnVu Y3Rpb24gKCkgewogICAgICAgICAgICAgICAgICAgICBkZWJ1ZygiRW5kIG9mIHByb21pc2UgY2hh aW4iKTsKICAgICAgICAgICAgICAgICAgICAgZmluaXNoSlNUZXN0KCk7CiAgICAgICAgICAgICAg ICAgfSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cKaW5kZXggMjNjZTRkYi4uODAwNGE4YiAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwz ICsxLDI0IEBACisyMDE2LTAyLTIzICBBZGFtIEJlcmdrdmlzdCAgPGFkYW0uYmVyZ2t2aXN0QGVy aWNzc29uLmNvbT4KKworICAgICAgICBXZWJSVEM6IFJUQ1BlZXJDb25uZWN0aW9uOiBTb3J0IG91 dCByZXNwb25zaWJpbGl0aWVzIG9mIGNsb3NlKCkgYW5kIHN0b3AoKQorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU0NTgxCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTGV0IFJUQ1BlZXJDb25uZWN0aW9uOjpj bG9zZSgpIGNvbnRhaW4gYWxsIHRlYXJkb3duIGxvZ2ljIGJlIGNhbGxlZCBieSBzdG9wKCkuCisg ICAgICAgIGNsb3NlKCkgaXMgYWxzbyByZXNwb25pc2JsZSBmb3Igc3RvcHBpbmcgdGhlIFBlZXJD b25uZWN0aW9uQmFja2VuZCBhbmQgc3RvcHBpbmcKKyAgICAgICAgYWxsIFJUQ1J0cFNlbmRlciBv YmplY3RzLgorCisgICAgICAgIFRlc3QgY292ZXJhZ2U6CisgICAgICAgIGZhc3QvbWVkaWFzdHJl YW0vUlRDUnRwU2VuZGVyLXJlcGxhY2VUcmFjay5odG1sICh1cGRhdGVkKQorICAgICAgICBmYXN0 L21lZGlhc3RyZWFtL1JUQ1BlZXJDb25uZWN0aW9uLWNsb3NlZC1zdGF0ZS5odG1sCisKKyAgICAg ICAgKiBNb2R1bGVzL21lZGlhc3RyZWFtL1JUQ1BlZXJDb25uZWN0aW9uLmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OlJUQ1BlZXJDb25uZWN0aW9uOjpjbG9zZSk6CisgICAgICAgIChXZWJDb3JlOjpS VENQZWVyQ29ubmVjdGlvbjo6c3RvcCk6CisgICAgICAgIChXZWJDb3JlOjpSVENQZWVyQ29ubmVj dGlvbjo6UlRDUGVlckNvbm5lY3Rpb24pOiBEZWxldGVkLgorICAgICAgICAqIE1vZHVsZXMvbWVk aWFzdHJlYW0vUlRDUGVlckNvbm5lY3Rpb24uaDoKKwogMjAxNi0wMi0xOCAgQW5kcmVhcyBLbGlu ZyAgPGFrbGluZ0BhcHBsZS5jb20+CiAKICAgICAgICAgUmVkdWNlIHRpbGluZyBjb3ZlcmFnZSBp bW1lZGlhdGVseSB3aGVuIG1lbW9yeSBwcmVzc3VyZSBoaXRzLgpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvTW9kdWxlcy9tZWRpYXN0cmVhbS9SVENQZWVyQ29ubmVjdGlvbi5jcHAgYi9Tb3Vy Y2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc3RyZWFtL1JUQ1BlZXJDb25uZWN0aW9uLmNwcAppbmRl eCBmNGY4ODk5Li4yZmU4M2Q5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21l ZGlhc3RyZWFtL1JUQ1BlZXJDb25uZWN0aW9uLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1 bGVzL21lZGlhc3RyZWFtL1JUQ1BlZXJDb25uZWN0aW9uLmNwcApAQCAtNzksNyArNzksNiBAQCBS VENQZWVyQ29ubmVjdGlvbjo6UlRDUGVlckNvbm5lY3Rpb24oU2NyaXB0RXhlY3V0aW9uQ29udGV4 dCYgY29udGV4dCwgUmVmUHRyPFJUQwogICAgICwgbV9pY2VHYXRoZXJpbmdTdGF0ZShJY2VHYXRo ZXJpbmdTdGF0ZTo6TmV3KQogICAgICwgbV9pY2VDb25uZWN0aW9uU3RhdGUoSWNlQ29ubmVjdGlv blN0YXRlOjpOZXcpCiAgICAgLCBtX2NvbmZpZ3VyYXRpb24oV1RGTW92ZShjb25maWd1cmF0aW9u KSkKLSAgICAsIG1fc3RvcHBlZChmYWxzZSkKIHsKICAgICBEb2N1bWVudCYgZG9jdW1lbnQgPSBk b3duY2FzdDxEb2N1bWVudD4oY29udGV4dCk7CiAKQEAgLTM2NywxNyArMzY2LDE4IEBAIHZvaWQg UlRDUGVlckNvbm5lY3Rpb246OmNsb3NlKCkKICAgICBpZiAobV9zaWduYWxpbmdTdGF0ZSA9PSBT aWduYWxpbmdTdGF0ZTo6Q2xvc2VkKQogICAgICAgICByZXR1cm47CiAKKyAgICBtX2JhY2tlbmQt PnN0b3AoKTsKKworICAgIG1faWNlQ29ubmVjdGlvblN0YXRlID0gSWNlQ29ubmVjdGlvblN0YXRl OjpDbG9zZWQ7CiAgICAgbV9zaWduYWxpbmdTdGF0ZSA9IFNpZ25hbGluZ1N0YXRlOjpDbG9zZWQ7 CisKKyAgICBmb3IgKGF1dG8mIHNlbmRlciA6IG1fc2VuZGVyU2V0KQorICAgICAgICBzZW5kZXIt PnN0b3AoKTsKIH0KIAogdm9pZCBSVENQZWVyQ29ubmVjdGlvbjo6c3RvcCgpCiB7Ci0gICAgaWYg KG1fc3RvcHBlZCkKLSAgICAgICAgcmV0dXJuOwotCi0gICAgbV9zdG9wcGVkID0gdHJ1ZTsKLSAg ICBtX2ljZUNvbm5lY3Rpb25TdGF0ZSA9IEljZUNvbm5lY3Rpb25TdGF0ZTo6Q2xvc2VkOwotICAg IG1fc2lnbmFsaW5nU3RhdGUgPSBTaWduYWxpbmdTdGF0ZTo6Q2xvc2VkOworICAgIGNsb3NlKCk7 CiB9CiAKIGNvbnN0IGNoYXIqIFJUQ1BlZXJDb25uZWN0aW9uOjphY3RpdmVET01PYmplY3ROYW1l KCkgY29uc3QKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzdHJlYW0v UlRDUGVlckNvbm5lY3Rpb24uaCBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzdHJlYW0v UlRDUGVlckNvbm5lY3Rpb24uaAppbmRleCAyODBhNmZhLi4yNDZlMmQyIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc3RyZWFtL1JUQ1BlZXJDb25uZWN0aW9uLmgKKysr IGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYXN0cmVhbS9SVENQZWVyQ29ubmVjdGlvbi5o CkBAIC0xNDYsOCArMTQ2LDYgQEAgcHJpdmF0ZToKICAgICBzdGQ6OnVuaXF1ZV9wdHI8UGVlckNv bm5lY3Rpb25CYWNrZW5kPiBtX2JhY2tlbmQ7CiAKICAgICBSZWZQdHI8UlRDQ29uZmlndXJhdGlv bj4gbV9jb25maWd1cmF0aW9uOwotCi0gICAgYm9vbCBtX3N0b3BwZWQ7CiB9OwogCiB9IC8vIG5h bWVzcGFjZSBXZWJDb3JlCg==