154580 2016-02-23 02:36:09 -0800 [WinCairo][MediaFoundation] Implement methods to set volume. 2016-02-24 11:49:44 -0800 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 peavo webkit-unassigned achristensen commit-queue oldest_to_newest 1167356 0 peavo 2016-02-23 02:36:09 -0800 The methods to adjust the playback volume has not been implemented yet. 1167357 1 272006 peavo 2016-02-23 02:41:13 -0800 Created attachment 272006 Patch 1167695 2 272006 achristensen 2016-02-23 22:43:26 -0800 Comment on attachment 272006 Patch Looks good. I meant to r+ this earlier, but it crashed as I pushed publish. By the way, I noticed a graphics issue with the MediaFoundation video player where sometimes parts of the video will be a frame ahead of the other parts. It looked like the top left 512px x 512px or so was ahead of the rest. Have you seen that? 1167713 3 272006 commit-queue 2016-02-23 23:05:53 -0800 Comment on attachment 272006 Patch Clearing flags on attachment: 272006 Committed r197015: <http://trac.webkit.org/changeset/197015> 1167714 4 commit-queue 2016-02-23 23:05:56 -0800 All reviewed patches have been landed. Closing bug. 1167766 5 peavo 2016-02-24 04:08:03 -0800 (In reply to comment #2) > Comment on attachment 272006 [details] > Patch > > Looks good. I meant to r+ this earlier, but it crashed as I pushed publish. > By the way, I noticed a graphics issue with the MediaFoundation video player > where sometimes parts of the video will be a frame ahead of the other parts. > It looked like the top left 512px x 512px or so was ahead of the rest. Have > you seen that? No, I haven't seen that. Is it something new? Is it reproducible on a specific page? Thanks for reviewing :) 1167859 6 achristensen 2016-02-24 11:49:44 -0800 (In reply to comment #5) > No, I haven't seen that. Is it something new? Is it reproducible on a > specific page? I saw it on vimeo.com 272006 2016-02-23 02:41:13 -0800 2016-02-23 23:05:53 -0800 Patch bug-154580-20160223114115.patch text/plain 3128 peavo SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE5Njk3MykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE2LTAyLTIzICBQZXIgQXJu ZSBWb2xsYW4gIDxwZWF2b0BvdXRsb29rLmNvbT4KKworICAgICAgICBbV2luQ2Fpcm9dW01lZGlh Rm91bmRhdGlvbl0gSW1wbGVtZW50IG1ldGhvZHMgdG8gc2V0IHZvbHVtZS4KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1NDU4MAorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3Mv d2luL01lZGlhUGxheWVyUHJpdmF0ZU1lZGlhRm91bmRhdGlvbi5jcHA6CisgICAgICAgIChXZWJD b3JlOjpNZWRpYVBsYXllclByaXZhdGVNZWRpYUZvdW5kYXRpb246OnBhdXNlZCk6CisgICAgICAg IChXZWJDb3JlOjpNZWRpYVBsYXllclByaXZhdGVNZWRpYUZvdW5kYXRpb246OnNldFZvbHVtZSk6 CisgICAgICAgIChXZWJDb3JlOjpNZWRpYVBsYXllclByaXZhdGVNZWRpYUZvdW5kYXRpb246OnN1 cHBvcnRzTXV0aW5nKToKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhUGxheWVyUHJpdmF0ZU1lZGlh Rm91bmRhdGlvbjo6c2V0TXV0ZWQpOgorICAgICAgICAoV2ViQ29yZTo6TWVkaWFQbGF5ZXJQcml2 YXRlTWVkaWFGb3VuZGF0aW9uOjpuZXR3b3JrU3RhdGUpOgorICAgICAgICAqIHBsYXRmb3JtL2dy YXBoaWNzL3dpbi9NZWRpYVBsYXllclByaXZhdGVNZWRpYUZvdW5kYXRpb24uaDoKKwogMjAxNi0w Mi0yMyAgWW91ZW5uIEZhYmxldCAgPHlvdWVubi5mYWJsZXRAY3JmLmNhbm9uLmZyPgogCiAgICAg ICAgIFJlZmFjdG9yIERPTSBJdGVyYXRvciBuZXh0IHNpZ25hdHVyZQpJbmRleDogU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvd2luL01lZGlhUGxheWVyUHJpdmF0ZU1lZGlhRm91bmRh dGlvbi5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv d2luL01lZGlhUGxheWVyUHJpdmF0ZU1lZGlhRm91bmRhdGlvbi5jcHAJKHJldmlzaW9uIDE5Njk3 MykKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3dpbi9NZWRpYVBsYXllclBy aXZhdGVNZWRpYUZvdW5kYXRpb24uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yODgsNiArMjg4LDM1 IEBAIGJvb2wgTWVkaWFQbGF5ZXJQcml2YXRlTWVkaWFGb3VuZGF0aW9uOjoKICAgICByZXR1cm4g bV9wYXVzZWQ7CiB9CiAKK3ZvaWQgTWVkaWFQbGF5ZXJQcml2YXRlTWVkaWFGb3VuZGF0aW9uOjpz ZXRWb2x1bWUoZmxvYXQgdm9sdW1lKQoreworICAgIGlmICghTUZHZXRTZXJ2aWNlUHRyKCkpCisg ICAgICAgIHJldHVybjsKKworICAgIENPTVB0cjxJTUZTaW1wbGVBdWRpb1ZvbHVtZT4gYXVkaW9W b2x1bWU7CisgICAgaWYgKFNVQ0NFRURFRChNRkdldFNlcnZpY2VQdHIoKShtX21lZGlhU2Vzc2lv bi5nZXQoKSwgTVJfUE9MSUNZX1ZPTFVNRV9TRVJWSUNFLCBfX3V1aWRvZihJTUZTaW1wbGVBdWRp b1ZvbHVtZSksICh2b2lkICoqKSZhdWRpb1ZvbHVtZSkpKSB7CisgICAgICAgIEhSRVNVTFQgaHIg PSBhdWRpb1ZvbHVtZS0+U2V0TWFzdGVyVm9sdW1lKHZvbHVtZSk7CisgICAgICAgIEFTU0VSVChT VUNDRUVERUQoaHIpKTsKKyAgICB9Cit9CisKK2Jvb2wgTWVkaWFQbGF5ZXJQcml2YXRlTWVkaWFG b3VuZGF0aW9uOjpzdXBwb3J0c011dGluZygpIGNvbnN0Cit7CisgICAgcmV0dXJuIHRydWU7Cit9 CisKK3ZvaWQgTWVkaWFQbGF5ZXJQcml2YXRlTWVkaWFGb3VuZGF0aW9uOjpzZXRNdXRlZChib29s IG11dGVkKQoreworICAgIGlmICghTUZHZXRTZXJ2aWNlUHRyKCkpCisgICAgICAgIHJldHVybjsK KworICAgIENPTVB0cjxJTUZTaW1wbGVBdWRpb1ZvbHVtZT4gYXVkaW9Wb2x1bWU7CisgICAgaWYg KFNVQ0NFRURFRChNRkdldFNlcnZpY2VQdHIoKShtX21lZGlhU2Vzc2lvbi5nZXQoKSwgTVJfUE9M SUNZX1ZPTFVNRV9TRVJWSUNFLCBfX3V1aWRvZihJTUZTaW1wbGVBdWRpb1ZvbHVtZSksICh2b2lk ICoqKSZhdWRpb1ZvbHVtZSkpKSB7CisgICAgICAgIEhSRVNVTFQgaHIgPSBhdWRpb1ZvbHVtZS0+ U2V0TXV0ZShtdXRlZCA/IFRSVUUgOiBGQUxTRSk7CisgICAgICAgIEFTU0VSVChTVUNDRUVERUQo aHIpKTsKKyAgICB9Cit9CisKIE1lZGlhUGxheWVyOjpOZXR3b3JrU3RhdGUgTWVkaWFQbGF5ZXJQ cml2YXRlTWVkaWFGb3VuZGF0aW9uOjpuZXR3b3JrU3RhdGUoKSBjb25zdAogeyAKICAgICBub3RJ bXBsZW1lbnRlZCgpOwpJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvd2lu L01lZGlhUGxheWVyUHJpdmF0ZU1lZGlhRm91bmRhdGlvbi5oCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3dpbi9NZWRpYVBsYXllclByaXZhdGVNZWRpYUZv dW5kYXRpb24uaAkocmV2aXNpb24gMTk2OTczKQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3Mvd2luL01lZGlhUGxheWVyUHJpdmF0ZU1lZGlhRm91bmRhdGlvbi5oCSh3b3JraW5n IGNvcHkpCkBAIC04Myw2ICs4MywxMSBAQCBwdWJsaWM6CiAKICAgICB2aXJ0dWFsIGJvb2wgcGF1 c2VkKCkgY29uc3Q7CiAKKyAgICB2aXJ0dWFsIHZvaWQgc2V0Vm9sdW1lKGZsb2F0KSBvdmVycmlk ZTsKKworICAgIHZpcnR1YWwgYm9vbCBzdXBwb3J0c011dGluZygpIGNvbnN0IG92ZXJyaWRlOwor ICAgIHZpcnR1YWwgdm9pZCBzZXRNdXRlZChib29sKSBvdmVycmlkZTsKKwogICAgIHZpcnR1YWwg TWVkaWFQbGF5ZXI6Ok5ldHdvcmtTdGF0ZSBuZXR3b3JrU3RhdGUoKSBjb25zdDsKICAgICB2aXJ0 dWFsIE1lZGlhUGxheWVyOjpSZWFkeVN0YXRlIHJlYWR5U3RhdGUoKSBjb25zdDsKIAo=