154577 2016-02-23 01:49:11 -0800 Remove IteratorKey and IteratorValue declarations from JSXX class declarations. 2016-02-24 06:17:49 -0800 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 youennf youennf cdumez cgarcia commit-queue mmaxfield oldest_to_newest 1167338 0 youennf 2016-02-23 01:49:11 -0800 Based on bug 154531, we no longer need these type declarations. 1167339 1 271998 youennf 2016-02-23 01:52:37 -0800 Created attachment 271998 Patch 1167480 2 271998 mmaxfield 2016-02-23 11:27:32 -0800 Comment on attachment 271998 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=271998&action=review > Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:-1062 > - if ($interface->iterable) { > - push(@headerContent, "\n"); > - if ($interface->iterable->keyType) { > - my $keyType = GetNativeType($interface->iterable->keyType); > - push(@headerContent, " using IteratorKey = $keyType;\n"); > - } > - my $valueType = GetNativeType($interface->iterable->valueType); > - push(@headerContent, " using IteratorValue = $valueType;\n"); > - } > - Please delete the line from GetNativeType() that special-cases FontFace too. 1167775 3 272112 youennf 2016-02-24 05:19:28 -0800 Created attachment 272112 Patch for landing 1167776 4 youennf 2016-02-24 05:20:29 -0800 Thanks for the review. > Please delete the line from GetNativeType() that special-cases FontFace too. Done in the landing patch. 1167777 5 272112 commit-queue 2016-02-24 06:17:45 -0800 Comment on attachment 272112 Patch for landing Clearing flags on attachment: 272112 Committed r197028: <http://trac.webkit.org/changeset/197028> 1167778 6 commit-queue 2016-02-24 06:17:49 -0800 All reviewed patches have been landed. Closing bug. 271998 2016-02-23 01:52:37 -0800 2016-02-24 05:19:15 -0800 Patch bug-154577-20160223105218.patch text/plain 2610 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMTk2OTcwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTlhMTJhYmNmODE1YjE5 ZmJkZTFhYTU3NThlNzQ5ZTY2MWIxZTNlMC4uZmUxNjUyZGY1NzI5NGNiMjE3OGRlNmIyZjc2OTc4 YjY3MTllNDc2ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE2LTAyLTIzICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uLmZhYmxldEBjcmYuY2Fub24uZnI+CisKKyAgICAgICAgUmVtb3Zl IEl0ZXJhdG9yS2V5IGFuZCBJdGVyYXRvclZhbHVlIGRlY2xhcmF0aW9ucyBmcm9tIEpTWFggY2xh c3MgZGVjbGFyYXRpb25zLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTU0NTc3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgTm8gY2hhbmdlIG9mIGJlaGF2aW9yLgorCisgICAgICAgICogYmluZGluZ3Mvc2Ny aXB0cy9Db2RlR2VuZXJhdG9ySlMucG06CisgICAgICAgIChHZW5lcmF0ZUhlYWRlcik6IERlbGV0 ZWQgZGVjbGFyYXRpb24gb2YgSXRlcmF0b3JLZXkgYW5kIEl0ZXJhdG9yVmFsdWUuCisgICAgICAg ICogYmluZGluZ3Mvc2NyaXB0cy90ZXN0L0pTL0pTVGVzdE9iai5oOgorICAgICAgICAoV2ViQ29y ZTo6SlNUZXN0T2JqOjpjcmVhdGVTdHJ1Y3R1cmUpOiBSZWJhc2luZyBvZiBiaW5kaW5nIHRlc3Qg ZXhwZWN0YXRpb24uCisKIDIwMTYtMDItMjIgIFlvdWVubiBGYWJsZXQgIDx5b3Vlbm4uZmFibGV0 QGNyZi5jYW5vbi5mcj4KIAogICAgICAgICBSZWZhY3RvciBET00gSXRlcmF0b3IgbmV4dCBzaWdu YXR1cmUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdl bmVyYXRvckpTLnBtIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJh dG9ySlMucG0KaW5kZXggMzhhZTNkYzIzMGI4NjdhNjAzZDlhMmViMjY5OTBiYWM1ZjEyNGYxZi4u ZTRjMDA1NzU0MjQ2NTkyNmM0MDM0ZmY4MGRmNmIyODMxMjRjMWYxYSAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9ySlMucG0KKysrIGIvU291 cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9ySlMucG0KQEAgLTEwNTAs MTYgKzEwNTAsNiBAQCBzdWIgR2VuZXJhdGVIZWFkZXIKICAgICAgICAgcHVzaChAaGVhZGVyQ29u dGVudCwgIiAgICBzdGF0aWMgdm9pZCBkZXN0cm95KEpTQzo6SlNDZWxsKik7XG4iKTsKICAgICB9 CiAKLSAgICBpZiAoJGludGVyZmFjZS0+aXRlcmFibGUpIHsKLSAgICAgICAgcHVzaChAaGVhZGVy Q29udGVudCwgIlxuIik7Ci0gICAgICAgIGlmICgkaW50ZXJmYWNlLT5pdGVyYWJsZS0+a2V5VHlw ZSkgewotICAgICAgICAgICAgbXkgJGtleVR5cGUgPSBHZXROYXRpdmVUeXBlKCRpbnRlcmZhY2Ut Pml0ZXJhYmxlLT5rZXlUeXBlKTsKLSAgICAgICAgICAgIHB1c2goQGhlYWRlckNvbnRlbnQsICIg ICAgdXNpbmcgSXRlcmF0b3JLZXkgPSAka2V5VHlwZTtcbiIpOwotICAgICAgICB9Ci0gICAgICAg IG15ICR2YWx1ZVR5cGUgPSBHZXROYXRpdmVUeXBlKCRpbnRlcmZhY2UtPml0ZXJhYmxlLT52YWx1 ZVR5cGUpOwotICAgICAgICBwdXNoKEBoZWFkZXJDb250ZW50LCAiICAgIHVzaW5nIEl0ZXJhdG9y VmFsdWUgPSAkdmFsdWVUeXBlO1xuIik7Ci0gICAgfQotCiAgICAgIyBDbGFzcyBpbmZvCiAgICAg aWYgKCRpbnRlcmZhY2VOYW1lIGVxICJOb2RlIikgewogICAgICAgICBwdXNoKEBoZWFkZXJDb250 ZW50LCAiXG4iKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMv dGVzdC9KUy9KU1Rlc3RPYmouaCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvdGVz dC9KUy9KU1Rlc3RPYmouaAppbmRleCA5MTc5MjQ5NGIzYWNlOWZlNzdlZDI0MmM3NGUxZmIzZWJh MmYwMzczLi43MzRmMjM2YmZmZjUzOGM0MTI1ZjVmMzFiNjYzZDU4NDI5YmI2ODUyIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL3Rlc3QvSlMvSlNUZXN0T2JqLmgK KysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy90ZXN0L0pTL0pTVGVzdE9iai5o CkBAIC00NSw5ICs0NSw2IEBAIHB1YmxpYzoKICAgICBzdGF0aWMgYm9vbCBnZXRPd25Qcm9wZXJ0 eVNsb3QoSlNDOjpKU09iamVjdCosIEpTQzo6RXhlY1N0YXRlKiwgSlNDOjpQcm9wZXJ0eU5hbWUs IEpTQzo6UHJvcGVydHlTbG90Jik7CiAgICAgc3RhdGljIHZvaWQgZGVzdHJveShKU0M6OkpTQ2Vs bCopOwogCi0gICAgdXNpbmcgSXRlcmF0b3JLZXkgPSBTdHJpbmc7Ci0gICAgdXNpbmcgSXRlcmF0 b3JWYWx1ZSA9IFRlc3RPYmoqOwotCiAgICAgREVDTEFSRV9JTkZPOwogCiAgICAgc3RhdGljIEpT Qzo6U3RydWN0dXJlKiBjcmVhdGVTdHJ1Y3R1cmUoSlNDOjpWTSYgdm0sIEpTQzo6SlNHbG9iYWxP YmplY3QqIGdsb2JhbE9iamVjdCwgSlNDOjpKU1ZhbHVlIHByb3RvdHlwZSkK 272112 2016-02-24 05:19:28 -0800 2016-02-24 06:17:45 -0800 Patch for landing bug-154577-20160224141909.patch text/plain 3151 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMTk3MDI3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggN2JiMzlkMDYxNjgzNGJl NGZjYWFkMjlmMWJiMjZhZWM3ZDI2MGY4Ni4uYzVmNGY5ODJlMzkyMGNmMDUzYjk2ZGU2MWY4Nzkw MTRmZmRhYWEwMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE5IEBACiAyMDE2LTAyLTI0ICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uLmZhYmxldEBjcmYuY2Fub24uZnI+CiAKKyAgICAgICAgUmVtb3Zl IEl0ZXJhdG9yS2V5IGFuZCBJdGVyYXRvclZhbHVlIGRlY2xhcmF0aW9ucyBmcm9tIEpTWFggY2xh c3MgZGVjbGFyYXRpb25zLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTU0NTc3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTXlsZXMgQy4gTWF4ZmllbGQu CisKKyAgICAgICAgTm8gY2hhbmdlIG9mIGJlaGF2aW9yLgorCisgICAgICAgICogYmluZGluZ3Mv c2NyaXB0cy9Db2RlR2VuZXJhdG9ySlMucG06CisgICAgICAgIChHZW5lcmF0ZUhlYWRlcik6IERl bGV0ZWQgZGVjbGFyYXRpb24gb2YgSXRlcmF0b3JLZXkgYW5kIEl0ZXJhdG9yVmFsdWUuCisgICAg ICAgICogYmluZGluZ3Mvc2NyaXB0cy90ZXN0L0pTL0pTVGVzdE9iai5oOgorICAgICAgICAoV2Vi Q29yZTo6SlNUZXN0T2JqOjpjcmVhdGVTdHJ1Y3R1cmUpOiBSZWJhc2luZyBvZiBiaW5kaW5nIHRl c3QgZXhwZWN0YXRpb24uCisKKzIwMTYtMDItMjQgIFlvdWVubiBGYWJsZXQgIDx5b3Vlbm4uZmFi bGV0QGNyZi5jYW5vbi5mcj4KKwogICAgICAgICBbRmV0Y2ggQVBJXSBSZWZhY3RvciBGZXRjaEhl YWRlcnMgaW5pdGlhbGl6YXRpb24gd2l0aCBpdGVyYXRvcnMKICAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1NDUzNwogCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JKUy5wbSBiL1NvdXJjZS9XZWJD b3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckpTLnBtCmluZGV4IDM4YWUzZGMyMzBi ODY3YTYwM2Q5YTJlYjI2OTkwYmFjNWYxMjRmMWYuLjYxZjA3OWY2ZTU1NjljOTE3NmU3ODBkMWYx NjFlNDM5ZGRkNTEzZmEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Njcmlw dHMvQ29kZUdlbmVyYXRvckpTLnBtCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Njcmlw dHMvQ29kZUdlbmVyYXRvckpTLnBtCkBAIC0xMDUwLDE2ICsxMDUwLDYgQEAgc3ViIEdlbmVyYXRl SGVhZGVyCiAgICAgICAgIHB1c2goQGhlYWRlckNvbnRlbnQsICIgICAgc3RhdGljIHZvaWQgZGVz dHJveShKU0M6OkpTQ2VsbCopO1xuIik7CiAgICAgfQogCi0gICAgaWYgKCRpbnRlcmZhY2UtPml0 ZXJhYmxlKSB7Ci0gICAgICAgIHB1c2goQGhlYWRlckNvbnRlbnQsICJcbiIpOwotICAgICAgICBp ZiAoJGludGVyZmFjZS0+aXRlcmFibGUtPmtleVR5cGUpIHsKLSAgICAgICAgICAgIG15ICRrZXlU eXBlID0gR2V0TmF0aXZlVHlwZSgkaW50ZXJmYWNlLT5pdGVyYWJsZS0+a2V5VHlwZSk7Ci0gICAg ICAgICAgICBwdXNoKEBoZWFkZXJDb250ZW50LCAiICAgIHVzaW5nIEl0ZXJhdG9yS2V5ID0gJGtl eVR5cGU7XG4iKTsKLSAgICAgICAgfQotICAgICAgICBteSAkdmFsdWVUeXBlID0gR2V0TmF0aXZl VHlwZSgkaW50ZXJmYWNlLT5pdGVyYWJsZS0+dmFsdWVUeXBlKTsKLSAgICAgICAgcHVzaChAaGVh ZGVyQ29udGVudCwgIiAgICB1c2luZyBJdGVyYXRvclZhbHVlID0gJHZhbHVlVHlwZTtcbiIpOwot ICAgIH0KLQogICAgICMgQ2xhc3MgaW5mbwogICAgIGlmICgkaW50ZXJmYWNlTmFtZSBlcSAiTm9k ZSIpIHsKICAgICAgICAgcHVzaChAaGVhZGVyQ29udGVudCwgIlxuIik7CkBAIC00MDM5LDcgKzQw MjksNiBAQCBzdWIgR2V0TmF0aXZlVHlwZQogICAgIG15ICRzdmdOYXRpdmVUeXBlID0gJGNvZGVH ZW5lcmF0b3ItPkdldFNWR1R5cGVOZWVkaW5nVGVhck9mZigkdHlwZSk7CiAgICAgcmV0dXJuICIk e3N2Z05hdGl2ZVR5cGV9KiIgaWYgJHN2Z05hdGl2ZVR5cGU7CiAgICAgcmV0dXJuICJSZWZQdHI8 RE9NU3RyaW5nTGlzdD4iIGlmICR0eXBlIGVxICJET01TdHJpbmdMaXN0IjsKLSAgICByZXR1cm4g IlJlZlB0cjxGb250RmFjZT4iIGlmICR0eXBlIGVxICJGb250RmFjZSI7CiAgICAgcmV0dXJuICJS ZWZQdHI8JHt0eXBlfT4iIGlmICRjb2RlR2VuZXJhdG9yLT5Jc1R5cGVkQXJyYXlUeXBlKCR0eXBl KSBhbmQgbm90ICR0eXBlIGVxICJBcnJheUJ1ZmZlciI7CiAgICAgcmV0dXJuICRuYXRpdmVUeXBl eyR0eXBlfSBpZiBleGlzdHMgJG5hdGl2ZVR5cGV7JHR5cGV9OwogCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL3Rlc3QvSlMvSlNUZXN0T2JqLmggYi9Tb3VyY2Uv V2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL3Rlc3QvSlMvSlNUZXN0T2JqLmgKaW5kZXggOTE3OTI0 OTRiM2FjZTlmZTc3ZWQyNDJjNzRlMWZiM2ViYTJmMDM3My4uNzM0ZjIzNmJmZmY1MzhjNDEyNWY1 ZjMxYjY2M2Q1ODQyOWJiNjg1MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mv c2NyaXB0cy90ZXN0L0pTL0pTVGVzdE9iai5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdz L3NjcmlwdHMvdGVzdC9KUy9KU1Rlc3RPYmouaApAQCAtNDUsOSArNDUsNiBAQCBwdWJsaWM6CiAg ICAgc3RhdGljIGJvb2wgZ2V0T3duUHJvcGVydHlTbG90KEpTQzo6SlNPYmplY3QqLCBKU0M6OkV4 ZWNTdGF0ZSosIEpTQzo6UHJvcGVydHlOYW1lLCBKU0M6OlByb3BlcnR5U2xvdCYpOwogICAgIHN0 YXRpYyB2b2lkIGRlc3Ryb3koSlNDOjpKU0NlbGwqKTsKIAotICAgIHVzaW5nIEl0ZXJhdG9yS2V5 ID0gU3RyaW5nOwotICAgIHVzaW5nIEl0ZXJhdG9yVmFsdWUgPSBUZXN0T2JqKjsKLQogICAgIERF Q0xBUkVfSU5GTzsKIAogICAgIHN0YXRpYyBKU0M6OlN0cnVjdHVyZSogY3JlYXRlU3RydWN0dXJl KEpTQzo6Vk0mIHZtLCBKU0M6OkpTR2xvYmFsT2JqZWN0KiBnbG9iYWxPYmplY3QsIEpTQzo6SlNW YWx1ZSBwcm90b3R5cGUpCg==