154567 2016-02-22 17:20:46 -0800 Web Inspector: Timelines sidebar and overview attempt to access undefined properties when FPS instrument is absent 2016-02-22 18:31:03 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 mattbaker mattbaker bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1167258 0 mattbaker 2016-02-22 17:20:46 -0800 * SUMMARY TimelineOverview settings are undefined when FPS instrument is absent. 1167259 1 mattbaker 2016-02-22 17:21:03 -0800 <rdar://problem/24781536> 1167271 2 271973 mattbaker 2016-02-22 17:39:19 -0800 Created attachment 271973 [Patch] Proposed Fix 1167272 3 271973 joepeck 2016-02-22 17:40:55 -0800 Comment on attachment 271973 [Patch] Proposed Fix r=me 1167283 4 271973 commit-queue 2016-02-22 18:30:58 -0800 Comment on attachment 271973 [Patch] Proposed Fix Clearing flags on attachment: 271973 Committed r196968: <http://trac.webkit.org/changeset/196968> 1167284 5 commit-queue 2016-02-22 18:31:03 -0800 All reviewed patches have been landed. Closing bug. 271973 2016-02-22 17:39:19 -0800 2016-02-22 18:30:58 -0800 [Patch] Proposed Fix bug-154567-20160222173901.patch text/plain 4564 mattbaker U3VidmVyc2lvbiBSZXZpc2lvbjogMTk2OTY3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCA3 N2RkNjc2YzIxMDUzYjQ1ZjYzYTcwMzkxYzU1ZTgyZWU5NWEzODVmLi5iZWIyNDc5YTgwZGU5NGVm YmQ5NDkwZGQ4ZDA5NGMyYzI1NzQwOTAzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMiBAQAorMjAxNi0wMi0yMiAgTWF0dCBCYWtlciAgPG1hdHRiYWtlckBhcHBsZS5jb20+ CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogVGltZWxpbmVzIHNpZGViYXIgYW5kIG92ZXJ2aWV3 IGF0dGVtcHQgdG8gYWNjZXNzIHVuZGVmaW5lZCBwcm9wZXJ0aWVzIHdoZW4gRlBTIGluc3RydW1l bnQgaXMgYWJzZW50CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xNTQ1NjcKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzI0NzgxNTM2PgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9W aWV3cy9UaW1lbGluZU92ZXJ2aWV3LmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlRpbWVsaW5l T3ZlcnZpZXcpOgorICAgICAgICBUaGUgdmlld01vZGUgcHJvcGVydHkgc2hvdWxkIGJlIGluIGEg dmFsaWQgc3RhdGUgYmVmb3JlIGF0dGVtcHRpbmcKKyAgICAgICAgdG8gYWNjZXNzIHRoZSBjdXJy ZW50IHZpZXcgbW9kZSBzZXR0aW5ncy4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3Mv VGltZWxpbmVTaWRlYmFyUGFuZWwuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuVGltZWxpbmVT aWRlYmFyUGFuZWwucHJvdG90eXBlLmdldCBtaW5pbXVtV2lkdGgpOgorICAgICAgICAoV2ViSW5z cGVjdG9yLlRpbWVsaW5lU2lkZWJhclBhbmVsLnByb3RvdHlwZS5fdXBkYXRlVmlld01vZGVJZk5l ZWRlZCk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuVGltZWxpbmVTaWRlYmFyUGFuZWwpOgorICAg ICAgICBBZGRlZCBtaXNzaW5nIGNoZWNrcyBmb3IgRlBTSW5zdHJ1bWVudCBzdXBwb3J0LgorCiAy MDE2LTAyLTIyICBOaWtpdGEgVmFzaWx5ZXYgIDxudmFzaWx5ZXZAYXBwbGUuY29tPgogCiAgICAg ICAgIFJFR1JFU1NJT04gKHIxOTY2MjApOiBXZWIgSW5zcGVjdG9yOiBGaWx0ZXIgYmFyIGluIHRo ZSBsZWZ0IHNpZGViYXIgaXMgMXB4IHNob3J0ZXIgdGhhbiB0aGUgY29uc29sZSBwcm9tcHQKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RpbWVs aW5lT3ZlcnZpZXcuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3 cy9UaW1lbGluZU92ZXJ2aWV3LmpzCmluZGV4IGUxMjc4Mzk4NTE3ZjE0NDg4YTllOGNjZTk3ZDI0 MWUzOWY2OWE1ODIuLjUzMzI4OTdjMTQyMWMwNmIxZGQ4MTBhZTZiZTZkY2Q5NjQ0Y2EyN2UgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RpbWVs aW5lT3ZlcnZpZXcuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2Uv Vmlld3MvVGltZWxpbmVPdmVydmlldy5qcwpAQCAtODUsNiArODUsNyBAQCBXZWJJbnNwZWN0b3Iu VGltZWxpbmVPdmVydmlldyA9IGNsYXNzIFRpbWVsaW5lT3ZlcnZpZXcgZXh0ZW5kcyBXZWJJbnNw ZWN0b3IuVmlldwogICAgICAgICB0aGlzLl9tb3VzZVdoZWVsRGVsdGEgPSAwOwogICAgICAgICB0 aGlzLl9jYWNoZWRTY3JvbGxDb250YWluZXJXaWR0aCA9IE5hTjsKICAgICAgICAgdGhpcy5fdGlt ZWxpbmVSdWxlclNlbGVjdGlvbkNoYW5nZWQgPSBmYWxzZTsKKyAgICAgICAgdGhpcy5fdmlld01v ZGUgPSBXZWJJbnNwZWN0b3IuVGltZWxpbmVPdmVydmlldy5WaWV3TW9kZS5UaW1lbGluZXM7CiAK ICAgICAgICAgZm9yIChsZXQgaW5zdHJ1bWVudCBvZiB0aGlzLl9yZWNvcmRpbmcuaW5zdHJ1bWVu dHMpCiAgICAgICAgICAgICB0aGlzLl9pbnN0cnVtZW50QWRkZWQoaW5zdHJ1bWVudCk7CkBAIC05 Miw3ICs5Myw3IEBAIFdlYkluc3BlY3Rvci5UaW1lbGluZU92ZXJ2aWV3ID0gY2xhc3MgVGltZWxp bmVPdmVydmlldyBleHRlbmRzIFdlYkluc3BlY3Rvci5WaWV3CiAgICAgICAgIGlmICghV2ViSW5z cGVjdG9yLnRpbWVsaW5lTWFuYWdlci5pc0NhcHR1cmluZ1BhZ2VSZWxvYWQoKSkKICAgICAgICAg ICAgIHRoaXMuX3Jlc2V0U2VsZWN0aW9uKCk7CiAKLSAgICAgICAgdGhpcy52aWV3TW9kZSA9IFdl Ykluc3BlY3Rvci5UaW1lbGluZU92ZXJ2aWV3LlZpZXdNb2RlLlRpbWVsaW5lczsKKyAgICAgICAg dGhpcy5fdmlld01vZGVEaWRDaGFuZ2UoKTsKICAgICB9CiAKICAgICAvLyBQdWJsaWMKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RpbWVsaW5l U2lkZWJhclBhbmVsLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmll d3MvVGltZWxpbmVTaWRlYmFyUGFuZWwuanMKaW5kZXggOTI5MDNjYzI5Y2IwMjU0NzUxZThkYmEy M2Q3MTE4MDQ0YmQ4OTgzNS4uMGRhMGM0M2I0ZmU2NGVlNzQxOGU4MTQ2Y2MzYzljNTA2Mzc0MTVm YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3Mv VGltZWxpbmVTaWRlYmFyUGFuZWwuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJ bnRlcmZhY2UvVmlld3MvVGltZWxpbmVTaWRlYmFyUGFuZWwuanMKQEAgLTE4Niw3ICsxODYsNyBA QCBXZWJJbnNwZWN0b3IuVGltZWxpbmVTaWRlYmFyUGFuZWwgPSBjbGFzcyBUaW1lbGluZVNpZGVi YXJQYW5lbCBleHRlbmRzIFdlYkluc3BlYwogCiAgICAgZ2V0IG1pbmltdW1XaWR0aCgpCiAgICAg ewotICAgICAgICBpZiAodGhpcy5fdmlld01vZGVOYXZpZ2F0aW9uQmFyKQorICAgICAgICBpZiAo V2ViSW5zcGVjdG9yLkZQU0luc3RydW1lbnQuc3VwcG9ydGVkKCkpCiAgICAgICAgICAgICByZXR1 cm4gTWF0aC5tYXgodGhpcy5fcmVwbGF5TmF2aWdhdGlvbkJhci5taW5pbXVtV2lkdGgsIHRoaXMu X3ZpZXdNb2RlTmF2aWdhdGlvbkJhci5taW5pbXVtV2lkdGgpOwogICAgICAgICByZXR1cm4gdGhp cy5fcmVwbGF5TmF2aWdhdGlvbkJhci5taW5pbXVtV2lkdGg7CiAgICAgfQpAQCAtODk5LDYgKzg5 OSwxMCBAQCBXZWJJbnNwZWN0b3IuVGltZWxpbmVTaWRlYmFyUGFuZWwgPSBjbGFzcyBUaW1lbGlu ZVNpZGViYXJQYW5lbCBleHRlbmRzIFdlYkluc3BlYwogCiAgICAgX3JlZnJlc2hGcmFtZVNlbGVj dGlvbkNoYXJ0KCkKICAgICB7CisgICAgICAgIGNvbnNvbGUuYXNzZXJ0KFdlYkluc3BlY3Rvci5G UFNJbnN0cnVtZW50LnN1cHBvcnRlZCgpKTsKKyAgICAgICAgaWYgKCFXZWJJbnNwZWN0b3IuRlBT SW5zdHJ1bWVudC5zdXBwb3J0ZWQoKSkKKyAgICAgICAgICAgIHJldHVybjsKKwogICAgICAgICBp ZiAoIXRoaXMudmlzaWJsZSkKICAgICAgICAgICAgIHJldHVybjsKIApAQCAtMTAzNCwxNSArMTAz OCwxMyBAQCBXZWJJbnNwZWN0b3IuVGltZWxpbmVTaWRlYmFyUGFuZWwgPSBjbGFzcyBUaW1lbGlu ZVNpZGViYXJQYW5lbCBleHRlbmRzIFdlYkluc3BlYwogCiAgICAgICAgIHRoaXMuX3ZpZXdNb2Rl ID0gbmV3Vmlld01vZGU7CiAKLSAgICAgICAgaWYgKHRoaXMuX3ZpZXdNb2RlID09PSBXZWJJbnNw ZWN0b3IuVGltZWxpbmVPdmVydmlldy5WaWV3TW9kZS5UaW1lbGluZXMpIHsKLSAgICAgICAgICAg IHRoaXMuX3RpbWVsaW5lc1RyZWVPdXRsaW5lLmhpZGRlbiA9IGZhbHNlOwotICAgICAgICAgICAg dGhpcy5fZnJhbWVTZWxlY3Rpb25DaGFydFNlY3Rpb24uY29sbGFwc2VkID0gdHJ1ZTsKLSAgICAg ICAgfSBlbHNlIHsKLSAgICAgICAgICAgIHRoaXMuX3RpbWVsaW5lc1RyZWVPdXRsaW5lLmhpZGRl biA9IHRydWU7Ci0gICAgICAgICAgICB0aGlzLl9mcmFtZVNlbGVjdGlvbkNoYXJ0U2VjdGlvbi5j b2xsYXBzZWQgPSBmYWxzZTsKLSAgICAgICAgfQorICAgICAgICBsZXQgaXNTaG93aW5nVGltZWxp bmVzID0gdGhpcy5fdmlld01vZGUgPT09IFdlYkluc3BlY3Rvci5UaW1lbGluZU92ZXJ2aWV3LlZp ZXdNb2RlLlRpbWVsaW5lczsKKyAgICAgICAgdGhpcy5fdGltZWxpbmVzVHJlZU91dGxpbmUuaGlk ZGVuID0gIWlzU2hvd2luZ1RpbWVsaW5lczsKIAotICAgICAgICB0aGlzLl92aWV3TW9kZU5hdmln YXRpb25CYXIuc2VsZWN0ZWROYXZpZ2F0aW9uSXRlbSA9IHRoaXMuX3ZpZXdNb2RlOworICAgICAg ICBpZiAoV2ViSW5zcGVjdG9yLkZQU0luc3RydW1lbnQuc3VwcG9ydGVkKCkpIHsKKyAgICAgICAg ICAgIHRoaXMuX2ZyYW1lU2VsZWN0aW9uQ2hhcnRTZWN0aW9uLmNvbGxhcHNlZCA9IGlzU2hvd2lu Z1RpbWVsaW5lczsKKyAgICAgICAgICAgIHRoaXMuX3ZpZXdNb2RlTmF2aWdhdGlvbkJhci5zZWxl Y3RlZE5hdmlnYXRpb25JdGVtID0gdGhpcy5fdmlld01vZGU7CisgICAgICAgIH0KICAgICB9CiB9 OwogCg==