154562 2016-02-22 15:44:36 -0800 Refactor script that updates fullscreen buttons. 2016-02-23 16:31:16 -0800 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 adachan adachan oldest_to_newest 1167222 0 adachan 2016-02-22 15:44:36 -0800 Centralize all logic to add/update picture-in-picture button in updatePictureInPictureButton(). 1167223 1 adachan 2016-02-22 15:45:43 -0800 <rdar://problem/24550383> 1167260 2 271969 adachan 2016-02-22 17:21:31 -0800 Created attachment 271969 Patch 1167554 3 adachan 2016-02-23 14:52:03 -0800 Found a small issue that I need to fix. Posting a new patch shortly. 1167556 4 272054 adachan 2016-02-23 14:57:45 -0800 Created attachment 272054 Patch 1167587 5 adachan 2016-02-23 16:31:16 -0800 Committed: http://trac.webkit.org/changeset/197005 271969 2016-02-22 17:21:31 -0800 2016-02-23 14:52:14 -0800 Patch bug-154562-20160222172114.patch text/plain 3402 adachan U3VidmVyc2lvbiBSZXZpc2lvbjogMTk2OTY0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTQ0MDExYzA4ZmI3NmYw MjQ1YjZhYWQwNTQ0NDJmMTk3OTJjYzI2NS4uNDFkMDcwZTI0N2FjMmQ0N2VlYzRkOTM5Y2YyNmYy MWM5OTE0OGE1ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE2LTAyLTIyICBBZGEg Q2hhbiAgPGFkYWNoYW5AYXBwbGUuY29tPgorCisgICAgICAgIFJlZmFjdG9yIHNjcmlwdCB0aGF0 IHVwZGF0ZXMgZnVsbHNjcmVlbiBidXR0b25zLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU0NTYyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgQWxzbyBleHBvc2UgZXh0cmEgcHJvcGVydHkgYW5kIGVsZW1l bnQgaW4gZ2V0Q3VycmVudENvbnRyb2xzU3RhdHVzKCkgZm9yIGZ1dHVyZSB0ZXN0aW5nLgorCisg ICAgICAgICogTW9kdWxlcy9tZWRpYWNvbnRyb2xzL21lZGlhQ29udHJvbHNBcHBsZS5qczoKKyAg ICAgICAgKENvbnRyb2xsZXIucHJvdG90eXBlLnVwZGF0ZVBpY3R1cmVJblBpY3R1cmVCdXR0b24p OgorICAgICAgICAoQ29udHJvbGxlci5wcm90b3R5cGUudXBkYXRlRnVsbHNjcmVlbkJ1dHRvbnMp OgorCiAyMDE2LTAyLTE2ICBBZGEgQ2hhbiAgPGFkYWNoYW5AYXBwbGUuY29tPgogCiAgICAgICAg IEltcGxlbWVudCBiYXNpYyBmdW5jdGlvbmFsaXR5IGluIFdlYlZpZGVvRnVsbHNjcmVlbkludGVy ZmFjZU1hYy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFjb250cm9s cy9tZWRpYUNvbnRyb2xzQXBwbGUuanMgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhY29u dHJvbHMvbWVkaWFDb250cm9sc0FwcGxlLmpzCmluZGV4IDE4ODVjMzhlZjc1MzUwZmQzNTQ2ZWRj NzlkYTgzOGZlZDU3OGVkNmYuLjM0OGE5OGE3YjFhOTRiNWEzMWJkYWM1ZmM3MmIyNWFjZTZhZDc3 NmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFjb250cm9scy9tZWRp YUNvbnRyb2xzQXBwbGUuanMKKysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYWNvbnRy b2xzL21lZGlhQ29udHJvbHNBcHBsZS5qcwpAQCAtODIwLDcgKzgyMCwxMiBAQCBDb250cm9sbGVy LnByb3RvdHlwZSA9IHsKICAgICB7CiAgICAgICAgIHZhciBzaG91bGRTaG93UGljdHVyZUluUGlj dHVyZUJ1dHRvbiA9IENvbnRyb2xsZXIuZ1NpbXVsYXRlUGljdHVyZUluUGljdHVyZUF2YWlsYWJs ZSB8fCAoJ3dlYmtpdFN1cHBvcnRzUHJlc2VudGF0aW9uTW9kZScgaW4gdGhpcy52aWRlbyAmJiB0 aGlzLnZpZGVvLndlYmtpdFN1cHBvcnRzUHJlc2VudGF0aW9uTW9kZSgncGljdHVyZS1pbi1waWN0 dXJlJykpOwogICAgICAgICBpZiAoc2hvdWxkU2hvd1BpY3R1cmVJblBpY3R1cmVCdXR0b24pIHsK LSAgICAgICAgICAgIHRoaXMuY29udHJvbHMucGFuZWwuYXBwZW5kQ2hpbGQodGhpcy5jb250cm9s cy5waWN0dXJlSW5QaWN0dXJlQnV0dG9uKTsKKyAgICAgICAgICAgIGlmICghdGhpcy5jb250cm9s cy5waWN0dXJlSW5QaWN0dXJlQnV0dG9uLnBhcmVudEVsZW1lbnQpIHsKKyAgICAgICAgICAgICAg ICBpZiAodGhpcy5jb250cm9scy5mdWxsc2NyZWVuQnV0dG9uLnBhcmVudEVsZW1lbnQgPT0gdGhp cy5jb250cm9scy5wYW5lbCkKKyAgICAgICAgICAgICAgICAgICAgdGhpcy5jb250cm9scy5wYW5l bC5pbnNlcnRCZWZvcmUodGhpcy5jb250cm9scy5waWN0dXJlSW5QaWN0dXJlQnV0dG9uLCB0aGlz LmNvbnRyb2xzLmZ1bGxzY3JlZW5CdXR0b24pOworICAgICAgICAgICAgICAgIGVsc2UKKyAgICAg ICAgICAgICAgICAgICAgdGhpcy5jb250cm9scy5wYW5lbC5hcHBlbmRDaGlsZCh0aGlzLmNvbnRy b2xzLnBpY3R1cmVJblBpY3R1cmVCdXR0b24pOworICAgICAgICAgICAgfQogICAgICAgICAgICAg dGhpcy5jb250cm9scy5waWN0dXJlSW5QaWN0dXJlQnV0dG9uLmNsYXNzTGlzdC5yZW1vdmUodGhp cy5DbGFzc05hbWVzLmhpZGRlbik7CiAgICAgICAgIH0gZWxzZQogICAgICAgICAgICAgdGhpcy5j b250cm9scy5waWN0dXJlSW5QaWN0dXJlQnV0dG9uLmNsYXNzTGlzdC5hZGQodGhpcy5DbGFzc05h bWVzLmhpZGRlbik7CkBAIC0xMTM4LDcgKzExNDMsNyBAQCBDb250cm9sbGVyLnByb3RvdHlwZSA9 IHsKICAgICB7CiAgICAgICAgIHZhciBzaG91bGRCZUhpZGRlbiA9ICF0aGlzLnZpZGVvLndlYmtp dFN1cHBvcnRzRnVsbHNjcmVlbiB8fCAhdGhpcy5oYXNWaWRlbygpOwogICAgICAgICB0aGlzLmNv bnRyb2xzLmZ1bGxzY3JlZW5CdXR0b24uY2xhc3NMaXN0LnRvZ2dsZSh0aGlzLkNsYXNzTmFtZXMu aGlkZGVuLCBzaG91bGRCZUhpZGRlbiAmJiAhdGhpcy5pc0Z1bGxTY3JlZW4oKSk7Ci0gICAgICAg IHRoaXMuY29udHJvbHMucGljdHVyZUluUGljdHVyZUJ1dHRvbi5jbGFzc0xpc3QudG9nZ2xlKHRo aXMuQ2xhc3NOYW1lcy5oaWRkZW4sIHNob3VsZEJlSGlkZGVuKTsKKyAgICAgICAgdGhpcy51cGRh dGVQaWN0dXJlSW5QaWN0dXJlQnV0dG9uKCk7CiAgICAgICAgIHRoaXMuc2V0TmVlZHNVcGRhdGVG b3JEaXNwbGF5ZWRXaWR0aCgpOwogICAgICAgICB0aGlzLnVwZGF0ZUxheW91dEZvckRpc3BsYXll ZFdpZHRoKCk7CiAgICAgfSwKQEAgLTIyNDgsMTIgKzIyNTMsMTcgQEAgQ29udHJvbGxlci5wcm90 b3R5cGUgPSB7CiAgICAgICAgICAgICB9LAogICAgICAgICAgICAgewogICAgICAgICAgICAgICAg IG5hbWU6ICJQaWN0dXJlLWluLXBpY3R1cmUgQnV0dG9uIiwKLSAgICAgICAgICAgICAgICBvYmpl Y3Q6IHRoaXMuY29udHJvbHMucGljdHVyZUluUGljdHVyZUJ1dHRvbgorICAgICAgICAgICAgICAg IG9iamVjdDogdGhpcy5jb250cm9scy5waWN0dXJlSW5QaWN0dXJlQnV0dG9uLAorICAgICAgICAg ICAgICAgIGV4dHJhUHJvcGVydGllczogWyJwYXJlbnRFbGVtZW50Il0sCiAgICAgICAgICAgICB9 LAogICAgICAgICAgICAgewogICAgICAgICAgICAgICAgIG5hbWU6ICJUcmFjayBNZW51IiwKICAg ICAgICAgICAgICAgICBvYmplY3Q6IHRoaXMuY2FwdGlvbk1lbnUKICAgICAgICAgICAgIH0sCisg ICAgICAgICAgICB7CisgICAgICAgICAgICAgICAgbmFtZTogIklubGluZSBwbGF5YmFjayBwbGFj ZWhvbGRlciIsCisgICAgICAgICAgICAgICAgb2JqZWN0OiB0aGlzLmNvbnRyb2xzLmlubGluZVBs YXliYWNrUGxhY2Vob2xkZXIsCisgICAgICAgICAgICB9LAogICAgICAgICBdOwogCiAgICAgICAg IGVsZW1lbnRzLmZvckVhY2goZnVuY3Rpb24gKGVsZW1lbnQpIHsK 272054 2016-02-23 14:57:45 -0800 2016-02-23 16:22:07 -0800 Patch bug-154562-20160223145729.patch text/plain 3677 adachan U3VidmVyc2lvbiBSZXZpc2lvbjogMTk2OTgzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzU4NjgxMTFhNzFmY2Ni Y2JhNDU0YTQzMzE2OTNlNDMzYmMwZWRjMS4uZDJhODZhZjg3OTkzZDEyMGJlNTQ2OWNlMmM1MTRl N2IwN2I0NjRhOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE2LTAyLTIyICBBZGEg Q2hhbiAgPGFkYWNoYW5AYXBwbGUuY29tPgorCisgICAgICAgIFJlZmFjdG9yIHNjcmlwdCB0aGF0 IHVwZGF0ZXMgZnVsbHNjcmVlbiBidXR0b25zLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU0NTYyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ LgorCisgICAgICAgIEFsc28gZXhwb3NlIGV4dHJhIHByb3BlcnR5IGFuZCBlbGVtZW50IGluIGdl dEN1cnJlbnRDb250cm9sc1N0YXR1cygpIGZvciBmdXR1cmUgdGVzdGluZy4KKworICAgICAgICAq IE1vZHVsZXMvbWVkaWFjb250cm9scy9tZWRpYUNvbnRyb2xzQXBwbGUuanM6CisgICAgICAgIChD b250cm9sbGVyLnByb3RvdHlwZS51cGRhdGVQaWN0dXJlSW5QaWN0dXJlQnV0dG9uKToKKyAgICAg ICAgKENvbnRyb2xsZXIucHJvdG90eXBlLnVwZGF0ZUZ1bGxzY3JlZW5CdXR0b25zKToKKwogMjAx Ni0wMi0yMyAgTWFudWVsIFJlZ28gQ2FzYXNub3ZhcyAgPHJlZ29AaWdhbGlhLmNvbT4KIAogICAg ICAgICBbY3NzLWdyaWRdIEF2b2lkIGR1cGxpY2F0ZWQgY2FsbHMgdG8gcmVzb2x1dGlvbiBjb2Rl CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhY29udHJvbHMvbWVkaWFD b250cm9sc0FwcGxlLmpzIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYWNvbnRyb2xzL21l ZGlhQ29udHJvbHNBcHBsZS5qcwppbmRleCAxODg1YzM4ZWY3NTM1MGZkMzU0NmVkYzc5ZGE4Mzhm ZWQ1NzhlZDZmLi40M2NmZWJjMzAyZGJhMmU1NDFiMTMyNjFjMTgxOThmYjJlMTAzZGFkIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhY29udHJvbHMvbWVkaWFDb250cm9s c0FwcGxlLmpzCisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFjb250cm9scy9tZWRp YUNvbnRyb2xzQXBwbGUuanMKQEAgLTgxOCw5ICs4MTgsMTQgQEAgQ29udHJvbGxlci5wcm90b3R5 cGUgPSB7CiAKICAgICB1cGRhdGVQaWN0dXJlSW5QaWN0dXJlQnV0dG9uOiBmdW5jdGlvbigpCiAg ICAgewotICAgICAgICB2YXIgc2hvdWxkU2hvd1BpY3R1cmVJblBpY3R1cmVCdXR0b24gPSBDb250 cm9sbGVyLmdTaW11bGF0ZVBpY3R1cmVJblBpY3R1cmVBdmFpbGFibGUgfHwgKCd3ZWJraXRTdXBw b3J0c1ByZXNlbnRhdGlvbk1vZGUnIGluIHRoaXMudmlkZW8gJiYgdGhpcy52aWRlby53ZWJraXRT dXBwb3J0c1ByZXNlbnRhdGlvbk1vZGUoJ3BpY3R1cmUtaW4tcGljdHVyZScpKTsKKyAgICAgICAg dmFyIHNob3VsZFNob3dQaWN0dXJlSW5QaWN0dXJlQnV0dG9uID0gKENvbnRyb2xsZXIuZ1NpbXVs YXRlUGljdHVyZUluUGljdHVyZUF2YWlsYWJsZSB8fCAoJ3dlYmtpdFN1cHBvcnRzUHJlc2VudGF0 aW9uTW9kZScgaW4gdGhpcy52aWRlbyAmJiB0aGlzLnZpZGVvLndlYmtpdFN1cHBvcnRzUHJlc2Vu dGF0aW9uTW9kZSgncGljdHVyZS1pbi1waWN0dXJlJykpKSAmJiB0aGlzLmhhc1ZpZGVvKCk7CiAg ICAgICAgIGlmIChzaG91bGRTaG93UGljdHVyZUluUGljdHVyZUJ1dHRvbikgewotICAgICAgICAg ICAgdGhpcy5jb250cm9scy5wYW5lbC5hcHBlbmRDaGlsZCh0aGlzLmNvbnRyb2xzLnBpY3R1cmVJ blBpY3R1cmVCdXR0b24pOworICAgICAgICAgICAgaWYgKCF0aGlzLmNvbnRyb2xzLnBpY3R1cmVJ blBpY3R1cmVCdXR0b24ucGFyZW50RWxlbWVudCkgeworICAgICAgICAgICAgICAgIGlmICh0aGlz LmNvbnRyb2xzLmZ1bGxzY3JlZW5CdXR0b24ucGFyZW50RWxlbWVudCA9PSB0aGlzLmNvbnRyb2xz LnBhbmVsKQorICAgICAgICAgICAgICAgICAgICB0aGlzLmNvbnRyb2xzLnBhbmVsLmluc2VydEJl Zm9yZSh0aGlzLmNvbnRyb2xzLnBpY3R1cmVJblBpY3R1cmVCdXR0b24sIHRoaXMuY29udHJvbHMu ZnVsbHNjcmVlbkJ1dHRvbik7CisgICAgICAgICAgICAgICAgZWxzZQorICAgICAgICAgICAgICAg ICAgICB0aGlzLmNvbnRyb2xzLnBhbmVsLmFwcGVuZENoaWxkKHRoaXMuY29udHJvbHMucGljdHVy ZUluUGljdHVyZUJ1dHRvbik7CisgICAgICAgICAgICB9CiAgICAgICAgICAgICB0aGlzLmNvbnRy b2xzLnBpY3R1cmVJblBpY3R1cmVCdXR0b24uY2xhc3NMaXN0LnJlbW92ZSh0aGlzLkNsYXNzTmFt ZXMuaGlkZGVuKTsKICAgICAgICAgfSBlbHNlCiAgICAgICAgICAgICB0aGlzLmNvbnRyb2xzLnBp Y3R1cmVJblBpY3R1cmVCdXR0b24uY2xhc3NMaXN0LmFkZCh0aGlzLkNsYXNzTmFtZXMuaGlkZGVu KTsKQEAgLTExMzgsNyArMTE0Myw3IEBAIENvbnRyb2xsZXIucHJvdG90eXBlID0gewogICAgIHsK ICAgICAgICAgdmFyIHNob3VsZEJlSGlkZGVuID0gIXRoaXMudmlkZW8ud2Via2l0U3VwcG9ydHNG dWxsc2NyZWVuIHx8ICF0aGlzLmhhc1ZpZGVvKCk7CiAgICAgICAgIHRoaXMuY29udHJvbHMuZnVs bHNjcmVlbkJ1dHRvbi5jbGFzc0xpc3QudG9nZ2xlKHRoaXMuQ2xhc3NOYW1lcy5oaWRkZW4sIHNo b3VsZEJlSGlkZGVuICYmICF0aGlzLmlzRnVsbFNjcmVlbigpKTsKLSAgICAgICAgdGhpcy5jb250 cm9scy5waWN0dXJlSW5QaWN0dXJlQnV0dG9uLmNsYXNzTGlzdC50b2dnbGUodGhpcy5DbGFzc05h bWVzLmhpZGRlbiwgc2hvdWxkQmVIaWRkZW4pOworICAgICAgICB0aGlzLnVwZGF0ZVBpY3R1cmVJ blBpY3R1cmVCdXR0b24oKTsKICAgICAgICAgdGhpcy5zZXROZWVkc1VwZGF0ZUZvckRpc3BsYXll ZFdpZHRoKCk7CiAgICAgICAgIHRoaXMudXBkYXRlTGF5b3V0Rm9yRGlzcGxheWVkV2lkdGgoKTsK ICAgICB9LApAQCAtMjI0OCwxMiArMjI1MywxNyBAQCBDb250cm9sbGVyLnByb3RvdHlwZSA9IHsK ICAgICAgICAgICAgIH0sCiAgICAgICAgICAgICB7CiAgICAgICAgICAgICAgICAgbmFtZTogIlBp Y3R1cmUtaW4tcGljdHVyZSBCdXR0b24iLAotICAgICAgICAgICAgICAgIG9iamVjdDogdGhpcy5j b250cm9scy5waWN0dXJlSW5QaWN0dXJlQnV0dG9uCisgICAgICAgICAgICAgICAgb2JqZWN0OiB0 aGlzLmNvbnRyb2xzLnBpY3R1cmVJblBpY3R1cmVCdXR0b24sCisgICAgICAgICAgICAgICAgZXh0 cmFQcm9wZXJ0aWVzOiBbInBhcmVudEVsZW1lbnQiXSwKICAgICAgICAgICAgIH0sCiAgICAgICAg ICAgICB7CiAgICAgICAgICAgICAgICAgbmFtZTogIlRyYWNrIE1lbnUiLAogICAgICAgICAgICAg ICAgIG9iamVjdDogdGhpcy5jYXB0aW9uTWVudQogICAgICAgICAgICAgfSwKKyAgICAgICAgICAg IHsKKyAgICAgICAgICAgICAgICBuYW1lOiAiSW5saW5lIHBsYXliYWNrIHBsYWNlaG9sZGVyIiwK KyAgICAgICAgICAgICAgICBvYmplY3Q6IHRoaXMuY29udHJvbHMuaW5saW5lUGxheWJhY2tQbGFj ZWhvbGRlciwKKyAgICAgICAgICAgIH0sCiAgICAgICAgIF07CiAKICAgICAgICAgZWxlbWVudHMu Zm9yRWFjaChmdW5jdGlvbiAoZWxlbWVudCkgewo=