154552 2016-02-22 12:42:15 -0800 JSValue::isConstructor and JSValue::isFunction should check getConstructData and getCallData 2016-02-22 14:25:29 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 saam saam benjamin cdumez fpizlo ggaren gskachkov keith_miller mark.lam msaboff oliver ryanhaddad sukolsak ysuzuki oldest_to_newest 1167149 0 saam 2016-02-22 12:42:15 -0800 ... 1167164 1 271947 saam 2016-02-22 13:14:50 -0800 Created attachment 271947 patch 1167166 2 271947 mark.lam 2016-02-22 13:17:15 -0800 Comment on attachment 271947 patch r=me 1167192 3 saam 2016-02-22 14:25:09 -0800 landed in: http://trac.webkit.org/changeset/196959 1167194 4 saam 2016-02-22 14:25:29 -0800 *** Bug 154543 has been marked as a duplicate of this bug. *** 271947 2016-02-22 13:14:50 -0800 2016-02-22 13:17:15 -0800 patch a-backup.diff text/plain 3257 saam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTk2OTUyKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIyIEBA CisyMDE2LTAyLTIyICBTYWFtIGJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAg IEpTVmFsdWU6OmlzQ29uc3RydWN0b3IgYW5kIEpTVmFsdWU6OmlzRnVuY3Rpb24gc2hvdWxkIGNo ZWNrIGdldENvbnN0cnVjdERhdGEgYW5kIGdldENhbGxEYXRhCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTQ1NTIKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBFUzYgUHJveHkgYnJlYWtzIG91ciBpc0Z1bmN0 aW9uKCkgYW5kIGlzQ29uc3RydWN0b3IoKSBKU1ZhbHVlIG1ldGhvZHMuCisgICAgICAgIFRoZXkg cmV0dXJuIGZhbHNlIG9uIGEgUHJveHkgd2l0aCBpbnRlcm5hbCBbW0NhbGxdXSBhbmQgW1tDb25z dHJ1Y3RdXQorICAgICAgICBwcm9wZXJ0aWVzLiBJdCBzZWVtcyBzYWZlc3QsIG1vc3QgZm9yd2Fy ZCBsb29raW5nLCBhbmQgbW9zdCBhZGhlcmVudAorICAgICAgICB0byB0aGUgc3BlY2lmaWNhdGlv biB0byBjaGVjayBnZXRDYWxsRGF0YSgpIGFuZCBnZXRDb25zdHJ1Y3REYXRhKCkgdG8KKyAgICAg ICAgaW1wbGVtZW50IHRoZXNlIGZ1bmN0aW9ucy4KKworICAgICAgICAqIHJ1bnRpbWUvSW50ZXJu YWxGdW5jdGlvbi5jcHA6CisgICAgICAgIChKU0M6OkludGVybmFsRnVuY3Rpb246OmNyZWF0ZVN1 YmNsYXNzU3RydWN0dXJlKToKKyAgICAgICAgKiBydW50aW1lL0pTQ0pTVmFsdWVJbmxpbmVzLmg6 CisgICAgICAgIChKU0M6OkpTVmFsdWU6OmlzRnVuY3Rpb24pOgorICAgICAgICAoSlNDOjpKU1Zh bHVlOjppc0NvbnN0cnVjdG9yKToKKwogMjAxNi0wMi0yMiAgS2VpdGggTWlsbGVyICA8a2VpdGhf bWlsbGVyQGFwcGxlLmNvbT4KIAogICAgICAgICBVc2UgU3ltYm9sLnNwZWNpZXMgaW4gdGhlIGJ1 aWx0aW4gVHlwZWRBcnJheS5wcm90b3R5cGUgZnVuY3Rpb25zCkluZGV4OiBTb3VyY2UvSmF2YVNj cmlwdENvcmUvcnVudGltZS9JbnRlcm5hbEZ1bmN0aW9uLmNwcAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9JbnRlcm5hbEZ1bmN0aW9uLmNwcAkocmV2aXNpb24g MTk2OTUwKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSW50ZXJuYWxGdW5jdGlv bi5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTg0LDcgKzg0LDcgQEAgU3RydWN0dXJlKiBJbnRlcm5h bEZ1bmN0aW9uOjpjcmVhdGVTdWJjbAogICAgIFZNJiB2bSA9IGV4ZWMtPnZtKCk7CiAgICAgLy8g V2UgYWxsb3cgbmV3VGFyZ2V0ID09IEpTVmFsdWUoKSBiZWNhdXNlIHRoZSBBUEkgbmVlZHMgdG8g YmUgYWJsZSB0byBjcmVhdGUgY2xhc3NlcyB3aXRob3V0IGhhdmluZyBhIHJlYWwgSlMgZnJhbWUu CiAgICAgLy8gU2luY2Ugd2UgZG9uJ3QgYWxsb3cgc3ViY2xhc3NpbmcgaW4gdGhlIEFQSSB3ZSBq dXN0IHRyZWF0IG5ld1RhcmdldCA9PSBKU1ZhbHVlKCkgYXMgbmV3VGFyZ2V0ID09IGV4ZWMtPmNh bGxlZSgpCi0gICAgQVNTRVJUKCFuZXdUYXJnZXQgfHwgbmV3VGFyZ2V0LmlzRnVuY3Rpb24oKSk7 CisgICAgQVNTRVJUKCFuZXdUYXJnZXQgfHwgbmV3VGFyZ2V0LmlzQ29uc3RydWN0b3IoKSk7CiAK ICAgICBpZiAobmV3VGFyZ2V0ICYmIG5ld1RhcmdldCAhPSBleGVjLT5jYWxsZWUoKSkgewogICAg ICAgICAvLyBuZXdUYXJnZXQgbWF5IGJlIGFuIEludGVybmFsRnVuY3Rpb24gaWYgd2Ugd2VyZSBj YWxsZWQgZnJvbSBSZWZsZWN0LmNvbnN0cnVjdC4KSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29y ZS9ydW50aW1lL0pTQ0pTVmFsdWVJbmxpbmVzLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFT Y3JpcHRDb3JlL3J1bnRpbWUvSlNDSlNWYWx1ZUlubGluZXMuaAkocmV2aXNpb24gMTk2OTUwKQor KysgU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNDSlNWYWx1ZUlubGluZXMuaAkod29y a2luZyBjb3B5KQpAQCAtNjc5LDE3ICs2NzksMjAgQEAgaW5saW5lIEpTT2JqZWN0KiBKU1ZhbHVl Ojp0b09iamVjdChFeGVjUwogCiBpbmxpbmUgYm9vbCBKU1ZhbHVlOjppc0Z1bmN0aW9uKCkgY29u c3QKIHsKLSAgICByZXR1cm4gaXNDZWxsKCkgJiYgKGFzQ2VsbCgpLT5pbmhlcml0cyhKU0Z1bmN0 aW9uOjppbmZvKCkpIHx8IGFzQ2VsbCgpLT5pbmhlcml0cyhJbnRlcm5hbEZ1bmN0aW9uOjppbmZv KCkpKTsKKyAgICBpZiAoIWlzQ2VsbCgpKQorICAgICAgICByZXR1cm4gZmFsc2U7CisgICAgSlND ZWxsKiBjZWxsID0gYXNDZWxsKCk7CisgICAgQ2FsbERhdGEgaWdub3JlZDsKKyAgICByZXR1cm4g Y2VsbC0+bWV0aG9kVGFibGUoKS0+Z2V0Q2FsbERhdGEoY2VsbCwgaWdub3JlZCkgIT0gQ2FsbFR5 cGVOb25lOwogfQogCi0vLyBGSVhNRTogV2UgY291bGQgZG8gdGhpcyBpbiBhIHNtYXJ0ZXIgd2F5 LiBTZWU6IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTM2NzAKIGlu bGluZSBib29sIEpTVmFsdWU6OmlzQ29uc3RydWN0b3IoKSBjb25zdAogewotICAgIGlmIChpc0Z1 bmN0aW9uKCkpIHsKLSAgICAgICAgQ29uc3RydWN0RGF0YSBkYXRhOwotICAgICAgICByZXR1cm4g Z2V0Q29uc3RydWN0RGF0YSgqdGhpcywgZGF0YSkgIT0gQ29uc3RydWN0VHlwZU5vbmU7Ci0gICAg fQotICAgIHJldHVybiBmYWxzZTsKKyAgICBpZiAoIWlzQ2VsbCgpKQorICAgICAgICByZXR1cm4g ZmFsc2U7CisgICAgSlNDZWxsKiBjZWxsID0gYXNDZWxsKCk7CisgICAgQ29uc3RydWN0RGF0YSBp Z25vcmVkOworICAgIHJldHVybiBjZWxsLT5tZXRob2RUYWJsZSgpLT5nZXRDb25zdHJ1Y3REYXRh KGNlbGwsIGlnbm9yZWQpICE9IENvbnN0cnVjdFR5cGVOb25lOwogfQogCiAvLyB0aGlzIG1ldGhv ZCBpcyBoZXJlIHRvIGJlIGFmdGVyIHRoZSBpbmxpbmUgZGVjbGFyYXRpb24gb2YgSlNDZWxsOjpp bmhlcml0cwo=