154524 2016-02-21 17:26:35 -0800 [iOS Simulator] js/number-toLocaleString.html failing 2016-02-27 19:33:18 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build iPhone / iPad Unspecified RESOLVED FIXED P2 Normal --- 1 ryanhaddad webkit-unassigned ap commit-queue sukolsak oldest_to_newest 1166897 0 ryanhaddad 2016-02-21 17:26:35 -0800 [iOS Simulator] js/number-toLocaleString.html failing This test has been failing since r196850 <https://build.webkit.org/results/Apple%20iOS%209%20Simulator%20Release%20WK2%20(Tests)/r196881%20(3304)/results.html> <http://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=js%2Fnumber-toLocaleString.html> --- /Volumes/Data/slave/ios-simulator-9-release-tests-wk2/build/layout-test-results/js/number-toLocaleString-expected.txt +++ /Volumes/Data/slave/ios-simulator-9-release-tests-wk2/build/layout-test-results/js/number-toLocaleString-actual.txt @@ -20,7 +20,7 @@ PASS (0).toLocaleString() is "0" PASS new Number(1).toLocaleString() is "1" PASS (0).toLocaleString('i') threw exception RangeError: invalid language tag: i. -PASS Infinity.toLocaleString() is "∞" +FAIL Infinity.toLocaleString() should be ∞. Was INF. PASS (123456.789).toLocaleString('ar') is "١٢٣٬٤٥٦٫٧٨٩" PASS (123456.789).toLocaleString('zh-Hans-CN-u-nu-hanidec') is "一二三,四五六.七八九" PASS (123.456).toLocaleString('en', { maximumSignificantDigits: 3 }) is "123" 1166900 1 ryanhaddad 2016-02-21 17:31:07 -0800 Landed an ios-simulator baseline for this test in <http://trac.webkit.org/projects/webkit/changeset/196884> to get the bots back to green. 1166927 2 sukolsak 2016-02-21 20:50:22 -0800 I believe this is the same issue as Bug 152448. It is because Intl.NumberFormat uses POSIX locale. The current proposed patch should fix it. 1167032 3 sukolsak 2016-02-22 08:58:08 -0800 One way to reproduce this case: $ LANG=en_US.UTF-8 ./jsc -e "print(Infinity.toLocaleString())" ∞ $ LANG=en_US_POSIX.UTF-8 ./jsc -e "print(Infinity.toLocaleString())" INF 1168933 4 sukolsak 2016-02-27 17:40:37 -0800 This issue has been fixed by https://trac.webkit.org/changeset/197261 Infinity.toLocaleString() now returns "∞" as it should. https://build.webkit.org/results/Apple%20iOS%209%20Simulator%20Release%20WK2%20%28Tests%29/r197261%20%283481%29/results.html 1168937 5 272429 sukolsak 2016-02-27 17:45:32 -0800 Created attachment 272429 Patch 1168948 6 272429 commit-queue 2016-02-27 19:33:13 -0800 Comment on attachment 272429 Patch Clearing flags on attachment: 272429 Committed r197264: <http://trac.webkit.org/changeset/197264> 1168949 7 commit-queue 2016-02-27 19:33:18 -0800 All reviewed patches have been landed. Closing bug. 272429 2016-02-27 17:45:32 -0800 2016-02-27 19:33:13 -0800 Patch bug-154524-20160227174637.patch text/plain 3438 sukolsak U3VidmVyc2lvbiBSZXZpc2lvbjogMTk3MjYzCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNDg4OWUyZTY4OTViNTIxNjA0NDk4 MmQ0ODNmNmViNWZmZWE5MDRiYi4uMWI3YzRiZjUwM2Y5NGNkMjBjZDgxMjc4NGYyMmU1NzgxMTAx YzVmMSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE2LTAyLTI3ICBTdWtvbHNhayBTYWtzaHV3 b25nICA8c3Vrb2xzYWtAZ21haWwuY29tPgorCisgICAgICAgIFJlbW92aW5nIGlvcy1zaW11bGF0 b3IgYmFzZWxpbmUgZm9yIGpzL251bWJlci10b0xvY2FsZVN0cmluZy5odG1sCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTQ1MjQKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgZGVmYXVsdCBsb2NhbGUg aXNzdWUgaGFzIGJlZW4gZml4ZWQgaW4gcjE5NzI2MS4KKyAgICAgICAgSW5maW5pdHkudG9Mb2Nh bGVTdHJpbmcoKSBzaG91bGQgcmV0dXJuICLiiJ4iIGFzIGV4cGVjdGVkLgorCisgICAgICAgICog cGxhdGZvcm0vaW9zLXNpbXVsYXRvci9qcy9udW1iZXItdG9Mb2NhbGVTdHJpbmctZXhwZWN0ZWQu dHh0OiBSZW1vdmVkLgorCiAyMDE2LTAyLTI3ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5j b20+CiAKICAgICAgICAgUHJldmVudCBjcm9zcy1vcmlnaW4gYWNjZXNzIHRvIExvY2F0aW9uLmFz c2lnbigpIC8gTG9jYXRpb24ucmVsb2FkKCkKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRm b3JtL2lvcy1zaW11bGF0b3IvanMvbnVtYmVyLXRvTG9jYWxlU3RyaW5nLWV4cGVjdGVkLnR4dCBi L0xheW91dFRlc3RzL3BsYXRmb3JtL2lvcy1zaW11bGF0b3IvanMvbnVtYmVyLXRvTG9jYWxlU3Ry aW5nLWV4cGVjdGVkLnR4dApkZWxldGVkIGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMTBmODYxNzk2 ZDYyNmU0N2FlYmZkMTM3ZWU2YjU0NmZkNDI5OGY4OS4uMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9pb3Mtc2ltdWxhdG9y L2pzL251bWJlci10b0xvY2FsZVN0cmluZy1leHBlY3RlZC50eHQKKysrIC9kZXYvbnVsbApAQCAt MSwzMCArMCwwIEBACi1UaGlzIHRlc3QgY2hlY2tzIHRoZSBiZWhhdmlvciBvZiBOdW1iZXIucHJv dG90eXBlLnRvTG9jYWxlU3RyaW5nIGFzIGRlc2NyaWJlZCBpbiB0aGUgRUNNQVNjcmlwdCBJbnRl cm5hdGlvbmFsaXphdGlvbiBBUEkgU3BlY2lmaWNhdGlvbiAoRUNNQS00MDIgMi4wKS4KLQotT24g c3VjY2VzcywgeW91IHdpbGwgc2VlIGEgc2VyaWVzIG9mICJQQVNTIiBtZXNzYWdlcywgZm9sbG93 ZWQgYnkgIlRFU1QgQ09NUExFVEUiLgotCi0KLVBBU1MgTnVtYmVyLnByb3RvdHlwZS50b0xvY2Fs ZVN0cmluZy5sZW5ndGggaXMgMAotUEFTUyBPYmplY3QuZ2V0T3duUHJvcGVydHlEZXNjcmlwdG9y KE51bWJlci5wcm90b3R5cGUsICd0b0xvY2FsZVN0cmluZycpLmVudW1lcmFibGUgaXMgZmFsc2UK LVBBU1MgT2JqZWN0LmdldE93blByb3BlcnR5RGVzY3JpcHRvcihOdW1iZXIucHJvdG90eXBlLCAn dG9Mb2NhbGVTdHJpbmcnKS5jb25maWd1cmFibGUgaXMgdHJ1ZQotUEFTUyBPYmplY3QuZ2V0T3du UHJvcGVydHlEZXNjcmlwdG9yKE51bWJlci5wcm90b3R5cGUsICd0b0xvY2FsZVN0cmluZycpLndy aXRhYmxlIGlzIHRydWUKLVBBU1MgTnVtYmVyLnByb3RvdHlwZS50b0xvY2FsZVN0cmluZy5jYWxs KDApIGRpZCBub3QgdGhyb3cgZXhjZXB0aW9uLgotUEFTUyBOdW1iZXIucHJvdG90eXBlLnRvTG9j YWxlU3RyaW5nLmNhbGwoTmFOKSBkaWQgbm90IHRocm93IGV4Y2VwdGlvbi4KLVBBU1MgTnVtYmVy LnByb3RvdHlwZS50b0xvY2FsZVN0cmluZy5jYWxsKEluZmluaXR5KSBkaWQgbm90IHRocm93IGV4 Y2VwdGlvbi4KLVBBU1MgTnVtYmVyLnByb3RvdHlwZS50b0xvY2FsZVN0cmluZy5jYWxsKG5ldyBO dW1iZXIpIGRpZCBub3QgdGhyb3cgZXhjZXB0aW9uLgotUEFTUyBOdW1iZXIucHJvdG90eXBlLnRv TG9jYWxlU3RyaW5nLmNhbGwoKSB0aHJldyBleGNlcHRpb24gVHlwZUVycm9yOiBOdW1iZXIucHJv dG90eXBlLnRvTG9jYWxlU3RyaW5nIGNhbGxlZCBvbiBpbmNvbXBhdGlibGUgdW5kZWZpbmVkLgot UEFTUyBOdW1iZXIucHJvdG90eXBlLnRvTG9jYWxlU3RyaW5nLmNhbGwodW5kZWZpbmVkKSB0aHJl dyBleGNlcHRpb24gVHlwZUVycm9yOiBOdW1iZXIucHJvdG90eXBlLnRvTG9jYWxlU3RyaW5nIGNh bGxlZCBvbiBpbmNvbXBhdGlibGUgdW5kZWZpbmVkLgotUEFTUyBOdW1iZXIucHJvdG90eXBlLnRv TG9jYWxlU3RyaW5nLmNhbGwobnVsbCkgdGhyZXcgZXhjZXB0aW9uIFR5cGVFcnJvcjogTnVtYmVy LnByb3RvdHlwZS50b0xvY2FsZVN0cmluZyBjYWxsZWQgb24gaW5jb21wYXRpYmxlIG9iamVjdC4K LVBBU1MgTnVtYmVyLnByb3RvdHlwZS50b0xvY2FsZVN0cmluZy5jYWxsKCcxJykgdGhyZXcgZXhj ZXB0aW9uIFR5cGVFcnJvcjogTnVtYmVyLnByb3RvdHlwZS50b0xvY2FsZVN0cmluZyBjYWxsZWQg b24gaW5jb21wYXRpYmxlIHN0cmluZy4KLVBBU1MgTnVtYmVyLnByb3RvdHlwZS50b0xvY2FsZVN0 cmluZy5jYWxsKFtdKSB0aHJldyBleGNlcHRpb24gVHlwZUVycm9yOiBOdW1iZXIucHJvdG90eXBl LnRvTG9jYWxlU3RyaW5nIGNhbGxlZCBvbiBpbmNvbXBhdGlibGUgb2JqZWN0LgotUEFTUyBOdW1i ZXIucHJvdG90eXBlLnRvTG9jYWxlU3RyaW5nLmNhbGwoU3ltYm9sKCkpIHRocmV3IGV4Y2VwdGlv biBUeXBlRXJyb3I6IE51bWJlci5wcm90b3R5cGUudG9Mb2NhbGVTdHJpbmcgY2FsbGVkIG9uIGlu Y29tcGF0aWJsZSBzeW1ib2wuCi1QQVNTICgwKS50b0xvY2FsZVN0cmluZygpIGlzICIwIgotUEFT UyBuZXcgTnVtYmVyKDEpLnRvTG9jYWxlU3RyaW5nKCkgaXMgIjEiCi1QQVNTICgwKS50b0xvY2Fs ZVN0cmluZygnaScpIHRocmV3IGV4Y2VwdGlvbiBSYW5nZUVycm9yOiBpbnZhbGlkIGxhbmd1YWdl IHRhZzogaS4KLUZBSUwgSW5maW5pdHkudG9Mb2NhbGVTdHJpbmcoKSBzaG91bGQgYmUg4oieLiBX YXMgSU5GLgotUEFTUyAoMTIzNDU2Ljc4OSkudG9Mb2NhbGVTdHJpbmcoJ2FyJykgaXMgItmh2aLZ o9ms2aTZpdmm2avZp9mo2akiCi1QQVNTICgxMjM0NTYuNzg5KS50b0xvY2FsZVN0cmluZygnemgt SGFucy1DTi11LW51LWhhbmlkZWMnKSBpcyAi5LiA5LqM5LiJLOWbm+S6lOWFrS7kuIPlhavkuZ0i Ci1QQVNTICgxMjMuNDU2KS50b0xvY2FsZVN0cmluZygnZW4nLCB7IG1heGltdW1TaWduaWZpY2Fu dERpZ2l0czogMyB9KSBpcyAiMTIzIgotUEFTUyBzdWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQot Ci1URVNUIENPTVBMRVRFCi0K