154490 2016-02-19 19:10:08 -0800 Land release assertions to help track down a possible HTMLCollection lifetime bug 2016-03-31 16:59:16 -0700 1 1 1 Unclassified WebKit Bindings WebKit Nightly Build Unspecified Unspecified REOPENED InRadar P2 Normal --- 1 cdumez cdumez barraclough commit-queue esprehn+autocc ggaren gyuyoung.kim kondapallykalyan rniwa webkit-bug-importer oldest_to_newest 1166662 0 cdumez 2016-02-19 19:10:08 -0800 Land release assertions to help track down a possible HTMLCollection lifetime bug. 1166663 1 cdumez 2016-02-19 19:10:28 -0800 rdar://problem/24457478 1166668 2 271841 cdumez 2016-02-19 19:16:38 -0800 Created attachment 271841 Patch 1166674 3 271841 commit-queue 2016-02-19 20:41:03 -0800 Comment on attachment 271841 Patch Clearing flags on attachment: 271841 Committed r196854: <http://trac.webkit.org/changeset/196854> 1166675 4 commit-queue 2016-02-19 20:41:07 -0800 All reviewed patches have been landed. Closing bug. 1179683 5 cdumez 2016-03-31 16:59:16 -0700 Reverted r196854 for reason: We do not need those assertions anymore as it seems <rdar://problem/24457478> is fixed Committed r198931: <http://trac.webkit.org/changeset/198931> 271841 2016-02-19 19:16:38 -0800 2016-02-19 20:41:03 -0800 Patch bug-154490-20160219191619.patch text/plain 5279 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMTk2ODE5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjQ3Y2JkN2JlOGYzM2Rh ODNkMDJjNmJhZTY0NmZkODkzZjZkYzgwOC4uOGExMzIzNjYxZjMyNjI4NzM2ODRiYWE3NDA3OTYx M2MxMzBjOWZjMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE2LTAyLTE5ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgTGFuZCByZWxlYXNlIGFzc2Vy dGlvbnMgdG8gaGVscCB0cmFjayBkb3duIGEgcG9zc2libGUgSFRNTENvbGxlY3Rpb24gbGlmZXRp bWUgYnVnCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x NTQ0OTAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBM YW5kIHJlbGVhc2UgYXNzZXJ0aW9ucyB0byBoZWxwIHRyYWNrIGRvd24gYSBwb3NzaWJsZSBIVE1M Q29sbGVjdGlvbgorICAgICAgICBsaWZldGltZSBidWc6IDxyZGFyOi8vcHJvYmxlbS8yNDQ1NzQ3 OD4uCisKKyAgICAgICAgKiBiaW5kaW5ncy9qcy9KU0hUTUxDb2xsZWN0aW9uQ3VzdG9tLmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OkpTSFRNTENvbGxlY3Rpb246OmdldE93blByb3BlcnR5TmFtZXMp OgorICAgICAgICAqIGh0bWwvSFRNTENvbGxlY3Rpb24uY3BwOgorICAgICAgICAoV2ViQ29yZTo6 SFRNTENvbGxlY3Rpb246OkhUTUxDb2xsZWN0aW9uKToKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxD b2xsZWN0aW9uOjp+SFRNTENvbGxlY3Rpb24pOgorICAgICAgICAqIGh0bWwvSFRNTENvbGxlY3Rp b24uaDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxDb2xsZWN0aW9uOjp3YXNEZWxldGlvblN0YXJ0 ZWQpOgorICAgICAgICAqIGh0bWwvSFRNTENvbGxlY3Rpb24uaWRsOgorCiAyMDE2LTAyLTE5ICBa YWxhbiBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CiAKICAgICAgICAgQmxvY2tlZCBwbHVnLWlu IHBsYWNlaG9sZGVyIGlzIHNvbWV0aW1lcyBub3Qgc2hvd24uCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9iaW5kaW5ncy9qcy9KU0hUTUxDb2xsZWN0aW9uQ3VzdG9tLmNwcCBiL1NvdXJjZS9X ZWJDb3JlL2JpbmRpbmdzL2pzL0pTSFRNTENvbGxlY3Rpb25DdXN0b20uY3BwCmluZGV4IDg4OTcw NWFmZTBkODM2ZmM2ZWI1YjkxODI5Zjk4MDA4MzEyYTZiZDcuLjk0MTU4M2M4YzBjYTk0ZWJlMmM4 ZTNhYWQ1OGM1MTA1NDQwZTAyNmYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdz L2pzL0pTSFRNTENvbGxlY3Rpb25DdXN0b20uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRp bmdzL2pzL0pTSFRNTENvbGxlY3Rpb25DdXN0b20uY3BwCkBAIC03Nyw0ICs3NywyMyBAQCBKU1Zh bHVlIHRvSlMoRXhlY1N0YXRlKiwgSlNET01HbG9iYWxPYmplY3QqIGdsb2JhbE9iamVjdCwgSFRN TENvbGxlY3Rpb24qIGNvbGxlYwogICAgIHJldHVybiBDUkVBVEVfRE9NX1dSQVBQRVIoZ2xvYmFs T2JqZWN0LCBIVE1MQ29sbGVjdGlvbiwgY29sbGVjdGlvbik7CiB9CiAKKy8vIEZJWE1FOiBUaGVz ZSBjdXN0b20gYmluZGluZ3MgYXJlIG9ubHkgbmVlZGVkIHRlbXBvcmFyaWx5IHRvIGFkZCByZWxl YXNlIGFzc2VydGlvbnMgaW4gb3JkZXIgdG8gaGVscAorLy8gdHJhY2sgZG93biBhIHBvc3NpYmxl IGxpZmV0aW1lIGlzc3VlIChyZGFyOi8vcHJvYmxlbS8yNDQ1NzQ3OCkuCit2b2lkIEpTSFRNTENv bGxlY3Rpb246OmdldE93blByb3BlcnR5TmFtZXMoSlNPYmplY3QqIG9iamVjdCwgRXhlY1N0YXRl KiBzdGF0ZSwgUHJvcGVydHlOYW1lQXJyYXkmIHByb3BlcnR5TmFtZXMsIEVudW1lcmF0aW9uTW9k ZSBtb2RlKQoreworICAgIGF1dG8qIHRoaXNPYmplY3QgPSBqc0R5bmFtaWNDYXN0PEpTSFRNTENv bGxlY3Rpb24qPihvYmplY3QpOworICAgIFJFTEVBU0VfQVNTRVJUX1dJVEhfTUVTU0FHRSh0aGlz T2JqZWN0LCAiQmFkIGNhc3QgZnJvbSBKU09iamVjdCB0byBKU0hUTUxDb2xsZWN0aW9uIik7Cisg ICAgUkVMRUFTRV9BU1NFUlRfV0lUSF9NRVNTQUdFKHRoaXNPYmplY3QtPndyYXBwZWQoKS5yZWZD b3VudCgpID4gMCwgIldyYXBwZWQgb2JqZWN0IGlzIGRlYWQiKTsKKyAgICBSRUxFQVNFX0FTU0VS VF9XSVRIX01FU1NBR0UoIXRoaXNPYmplY3QtPndyYXBwZWQoKS53YXNEZWxldGlvblN0YXJ0ZWQo KSwgIldyYXBwZWQgb2JqZWN0IGlzIGJlaW5nIGRlc3Ryb3llZCIpOworICAgIFJFTEVBU0VfQVNT RVJUX1dJVEhfTUVTU0FHRSghY3VycmVudFdvcmxkKHN0YXRlKS5pc05vcm1hbCgpIHx8IHRoaXNP YmplY3QtPndyYXBwZWQoKS53cmFwcGVyKCksICJXcmFwcGVyIGlzIGRlYWQiKTsKKworICAgIGZv ciAodW5zaWduZWQgaSA9IDAsIGNvdW50ID0gdGhpc09iamVjdC0+d3JhcHBlZCgpLmxlbmd0aCgp OyBpIDwgY291bnQ7ICsraSkKKyAgICAgICAgcHJvcGVydHlOYW1lcy5hZGQoSWRlbnRpZmllcjo6 ZnJvbShzdGF0ZSwgaSkpOworICAgIGlmIChtb2RlLmluY2x1ZGVEb250RW51bVByb3BlcnRpZXMo KSkgeworICAgICAgICBmb3IgKGF1dG8mIHByb3BlcnR5TmFtZSA6IHRoaXNPYmplY3QtPndyYXBw ZWQoKS5zdXBwb3J0ZWRQcm9wZXJ0eU5hbWVzKCkpCisgICAgICAgICAgICBwcm9wZXJ0eU5hbWVz LmFkZChJZGVudGlmaWVyOjpmcm9tU3RyaW5nKHN0YXRlLCBwcm9wZXJ0eU5hbWUpKTsKKyAgICB9 CisgICAgQmFzZTo6Z2V0T3duUHJvcGVydHlOYW1lcyh0aGlzT2JqZWN0LCBzdGF0ZSwgcHJvcGVy dHlOYW1lcywgbW9kZSk7Cit9CisKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTENvbGxlY3Rpb24uY3BwIGIvU291cmNlL1dlYkNvcmUv aHRtbC9IVE1MQ29sbGVjdGlvbi5jcHAKaW5kZXggNmEyZjE1ZjZkMDkwZGU1OTY4ZmM5YzVjOWUy Yjc5ZTllZWFjZjRmNi4uM2NhMWUyMmFhNmYxNTA2ODFlN2MxODkxZWE3YWU5NmQwMGZlZDc3OSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MQ29sbGVjdGlvbi5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvaHRtbC9IVE1MQ29sbGVjdGlvbi5jcHAKQEAgLTEwOSw2ICsxMDksNyBA QCBIVE1MQ29sbGVjdGlvbjo6SFRNTENvbGxlY3Rpb24oQ29udGFpbmVyTm9kZSYgb3duZXJOb2Rl LCBDb2xsZWN0aW9uVHlwZSB0eXBlKQogICAgICwgbV9jb2xsZWN0aW9uVHlwZSh0eXBlKQogICAg ICwgbV9pbnZhbGlkYXRpb25UeXBlKGludmFsaWRhdGlvblR5cGVFeGNsdWRpbmdJZEFuZE5hbWVB dHRyaWJ1dGVzKHR5cGUpKQogICAgICwgbV9yb290VHlwZShyb290VHlwZUZyb21Db2xsZWN0aW9u VHlwZSh0eXBlKSkKKyAgICAsIG1fd2FzRGVsZXRpb25TdGFydGVkKGZhbHNlKQogewogICAgIEFT U0VSVChtX3Jvb3RUeXBlID09IHN0YXRpY19jYXN0PHVuc2lnbmVkPihyb290VHlwZUZyb21Db2xs ZWN0aW9uVHlwZSh0eXBlKSkpOwogICAgIEFTU0VSVChtX2ludmFsaWRhdGlvblR5cGUgPT0gc3Rh dGljX2Nhc3Q8dW5zaWduZWQ+KGludmFsaWRhdGlvblR5cGVFeGNsdWRpbmdJZEFuZE5hbWVBdHRy aWJ1dGVzKHR5cGUpKSk7CkBAIC0xMTcsNiArMTE4LDggQEAgSFRNTENvbGxlY3Rpb246OkhUTUxD b2xsZWN0aW9uKENvbnRhaW5lck5vZGUmIG93bmVyTm9kZSwgQ29sbGVjdGlvblR5cGUgdHlwZSkK IAogSFRNTENvbGxlY3Rpb246On5IVE1MQ29sbGVjdGlvbigpCiB7CisgICAgbV93YXNEZWxldGlv blN0YXJ0ZWQgPSB0cnVlOworCiAgICAgaWYgKGhhc05hbWVkRWxlbWVudENhY2hlKCkpCiAgICAg ICAgIGRvY3VtZW50KCkuY29sbGVjdGlvbldpbGxDbGVhcklkTmFtZU1hcCgqdGhpcyk7CiAKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTENvbGxlY3Rpb24uaCBiL1NvdXJjZS9X ZWJDb3JlL2h0bWwvSFRNTENvbGxlY3Rpb24uaAppbmRleCBiN2Y0Zjc4N2QxNTVhOTUzMWM1MGJk NDA5OTJmNjY5NTk3ZjUyMzkzLi44Njc0YzZhYTFiMGY0MGYwMDU3ZTQ2NTUwNDQ0YjYzMGEzMjUy YmFhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxDb2xsZWN0aW9uLmgKKysr IGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MQ29sbGVjdGlvbi5oCkBAIC04NSw2ICs4NSw4IEBA IHB1YmxpYzoKIAogICAgIGJvb2wgaGFzTmFtZWRFbGVtZW50Q2FjaGUoKSBjb25zdDsKIAorICAg IGJvb2wgd2FzRGVsZXRpb25TdGFydGVkKCkgeyByZXR1cm4gbV93YXNEZWxldGlvblN0YXJ0ZWQ7 IH0KKwogcHJvdGVjdGVkOgogICAgIEhUTUxDb2xsZWN0aW9uKENvbnRhaW5lck5vZGUmIGJhc2Us IENvbGxlY3Rpb25UeXBlKTsKIApAQCAtMTA4LDYgKzExMCw4IEBAIHByb3RlY3RlZDoKICAgICBj b25zdCB1bnNpZ25lZCBtX2NvbGxlY3Rpb25UeXBlIDogNTsKICAgICBjb25zdCB1bnNpZ25lZCBt X2ludmFsaWRhdGlvblR5cGUgOiA0OwogICAgIGNvbnN0IHVuc2lnbmVkIG1fcm9vdFR5cGUgOiAx OworICAgIC8vIEZJWE1FOiBUaGlzIGZsYWcgaXMgaGVyZSB0ZW1wb3JhcmlseSB0byBoZWxwIHRy YWNrIGRvd24gYSBwb3NzaWJsZSBsaWZldGltZSBpc3N1ZSAocmRhcjovL3Byb2JsZW0vMjQ0NTc0 NzgpLgorICAgIHVuc2lnbmVkIG1fd2FzRGVsZXRpb25TdGFydGVkIDogMTsKIH07CiAKIGlubGlu ZSBDb250YWluZXJOb2RlJiBIVE1MQ29sbGVjdGlvbjo6cm9vdE5vZGUoKSBjb25zdApkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MQ29sbGVjdGlvbi5pZGwgYi9Tb3VyY2UvV2Vi Q29yZS9odG1sL0hUTUxDb2xsZWN0aW9uLmlkbAppbmRleCBlNTU0NTlhODZjMTljNjE3NmU1Yzky OGU5NTc2ZDMyMjdlMWQ2MzNhLi45ZmYwMGNjM2M2ZmI1OWJjMWNmMGZjODJmNzI2ZDUxZmI4M2Fj OWEyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxDb2xsZWN0aW9uLmlkbAor KysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxDb2xsZWN0aW9uLmlkbApAQCAtMjMsNiArMjMs NyBAQAogICAgIEdlbmVyYXRlSXNSZWFjaGFibGU9SW1wbE93bmVyTm9kZVJvb3QsCiAgICAgT2Jq Q1BvbHltb3JwaGljLAogICAgIFJlcG9ydEV4dHJhTWVtb3J5Q29zdCwKKyAgICBDdXN0b21FbnVt ZXJhdGVQcm9wZXJ0eQogXSBpbnRlcmZhY2UgSFRNTENvbGxlY3Rpb24gewogICAgIHJlYWRvbmx5 IGF0dHJpYnV0ZSB1bnNpZ25lZCBsb25nIGxlbmd0aDsKIAo=