154483 2016-02-19 17:07:13 -0800 Do not require UDate in LocaleICU with !ENABLE_DATE_AND_TIME_INPUT_TYPES 2016-02-20 08:42:26 -0800 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 olivier.blin webkit-unassigned annulen commit-queue darin ewmailing mcatanzaro zan oldest_to_newest 1166628 0 olivier.blin 2016-02-19 17:07:13 -0800 initializeShortDateFormat(), dateFormat(), m_shortDateFormat and m_didCreateShortDateFormat should be moved under flag, since they are only used by code under the ENABLE_DATE_AND_TIME_INPUT_TYPES flag. This helps to build with a light ICU that does not provide UDate features (with UCONFIG_NO_FORMATTING). 1166630 1 271829 olivier.blin 2016-02-19 17:09:10 -0800 Created attachment 271829 Patch 1166724 2 271829 mcatanzaro 2016-02-20 07:53:38 -0800 Comment on attachment 271829 Patch I guess it's right; I looked in bug #101007 for some explanation of why short data format was not behind this flag, but couldn't find any justification for this. 1166731 3 271829 commit-queue 2016-02-20 08:42:21 -0800 Comment on attachment 271829 Patch Clearing flags on attachment: 271829 Committed r196861: <http://trac.webkit.org/changeset/196861> 1166732 4 commit-queue 2016-02-20 08:42:26 -0800 All reviewed patches have been landed. Closing bug. 271829 2016-02-19 17:09:10 -0800 2016-02-20 08:42:21 -0800 Patch bug-154483-20160220020850.patch text/plain 5413 olivier.blin U3VidmVyc2lvbiBSZXZpc2lvbjogMTk2ODE5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTgyNWEzOGMzMmU1MWEy Y2Y3NDQ5NWFkNmFjNDkwMjZkZTAzN2QyNS4uNzYzMTZhYmQ1NTlmNzU2NGUxZmE4YzVjOTQzNDVl NDQyMDg3ZTQ3YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI2IEBACiAyMDE2LTAyLTE5ICBPbGl2 aWVyIEJsaW4gIDxvbGl2aWVyLmJsaW5Ac29mdGF0aG9tZS5jb20+CiAKKyAgICAgICAgRG8gbm90 IHJlcXVpcmUgVURhdGUgaW4gTG9jYWxlSUNVIHdpdGggIUVOQUJMRV9EQVRFX0FORF9USU1FX0lO UFVUX1RZUEVTCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xNTQ0ODMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBQdXQgaW5pdGlhbGl6ZVNob3J0RGF0ZUZvcm1hdCgpLCBkYXRlRm9ybWF0KCksIG1fc2hvcnRE YXRlRm9ybWF0IGFuZAorICAgICAgICBtX2RpZENyZWF0ZVNob3J0RGF0ZUZvcm1hdCB1bmRlciBm bGFnLCBzaW5jZSB0aGV5IGFyZSBvbmx5IHVzZWQgYnkKKyAgICAgICAgY29kZSB1bmRlciB0aGUg RU5BQkxFX0RBVEVfQU5EX1RJTUVfSU5QVVRfVFlQRVMgZmxhZy4KKworICAgICAgICBUaGlzIGhl bHBzIHRvIGJ1aWxkIHdpdGggYSBsaWdodCBJQ1UgdGhhdCBkb2VzIG5vdCBwcm92aWRlIFVEYXRl CisgICAgICAgIGZlYXR1cmVzICh3aXRoIFVDT05GSUdfTk9fRk9STUFUVElORykuCisKKyAgICAg ICAgKiBwbGF0Zm9ybS90ZXh0L0xvY2FsZUlDVS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpMb2Nh bGVJQ1U6OkxvY2FsZUlDVSk6CisgICAgICAgIChXZWJDb3JlOjpMb2NhbGVJQ1U6On5Mb2NhbGVJ Q1UpOgorICAgICAgICAoV2ViQ29yZTo6Y3JlYXRlRmFsbGJhY2tNb250aExhYmVscyk6IERlbGV0 ZWQuCisgICAgICAgIChXZWJDb3JlOjpjcmVhdGVGYWxsYmFja0FNUE1MYWJlbHMpOiBEZWxldGVk LgorICAgICAgICAqIHBsYXRmb3JtL3RleHQvTG9jYWxlSUNVLmg6CisKKzIwMTYtMDItMTkgIE9s aXZpZXIgQmxpbiAgPG9saXZpZXIuYmxpbkBzb2Z0YXRob21lLmNvbT4KKwogICAgICAgICBSZW1v dmUgZGVjbGFyYXRpb24gb2YgdW5pbXBsZW1lbnRlZCBtZXRob2RzIGluIExvY2FsZUlDVQogICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU0NDgyCiAKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3RleHQvTG9jYWxlSUNVLmNwcCBiL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL3RleHQvTG9jYWxlSUNVLmNwcAppbmRleCA0Nzg4ZjQyY2Qx YWI2NjAzNmEzNGY3MWQwODNiNjZjZjc1MDdiZmM4Li44MWVlZGRjNTEzNDZlMzQ4MmM2YzEyMjA1 NjZmNzk0YWViOGI0Mjk0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS90ZXh0 L0xvY2FsZUlDVS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vdGV4dC9Mb2NhbGVJ Q1UuY3BwCkBAIC01MSwxMiArNTEsMTIgQEAgc3RkOjp1bmlxdWVfcHRyPExvY2FsZT4gTG9jYWxl OjpjcmVhdGUoY29uc3QgQXRvbWljU3RyaW5nJiBsb2NhbGUpCiBMb2NhbGVJQ1U6OkxvY2FsZUlD VShjb25zdCBjaGFyKiBsb2NhbGUpCiAgICAgOiBtX2xvY2FsZShsb2NhbGUpCiAgICAgLCBtX251 bWJlckZvcm1hdCgwKQotICAgICwgbV9zaG9ydERhdGVGb3JtYXQoMCkKICAgICAsIG1fZGlkQ3Jl YXRlRGVjaW1hbEZvcm1hdChmYWxzZSkKLSAgICAsIG1fZGlkQ3JlYXRlU2hvcnREYXRlRm9ybWF0 KGZhbHNlKQogI2lmIEVOQUJMRShEQVRFX0FORF9USU1FX0lOUFVUX1RZUEVTKQorICAgICwgbV9z aG9ydERhdGVGb3JtYXQoMCkKICAgICAsIG1fbWVkaXVtVGltZUZvcm1hdCgwKQogICAgICwgbV9z aG9ydFRpbWVGb3JtYXQoMCkKKyAgICAsIG1fZGlkQ3JlYXRlU2hvcnREYXRlRm9ybWF0KGZhbHNl KQogICAgICwgbV9kaWRDcmVhdGVUaW1lRm9ybWF0KGZhbHNlKQogI2VuZGlmCiB7CkBAIC02NSw4 ICs2NSw4IEBAIExvY2FsZUlDVTo6TG9jYWxlSUNVKGNvbnN0IGNoYXIqIGxvY2FsZSkKIExvY2Fs ZUlDVTo6fkxvY2FsZUlDVSgpCiB7CiAgICAgdW51bV9jbG9zZShtX251bWJlckZvcm1hdCk7Ci0g ICAgdWRhdF9jbG9zZShtX3Nob3J0RGF0ZUZvcm1hdCk7CiAjaWYgRU5BQkxFKERBVEVfQU5EX1RJ TUVfSU5QVVRfVFlQRVMpCisgICAgdWRhdF9jbG9zZShtX3Nob3J0RGF0ZUZvcm1hdCk7CiAgICAg dWRhdF9jbG9zZShtX21lZGl1bVRpbWVGb3JtYXQpOwogICAgIHVkYXRfY2xvc2UobV9zaG9ydFRp bWVGb3JtYXQpOwogI2VuZGlmCkBAIC0xMzAsNiArMTMwLDcgQEAgdm9pZCBMb2NhbGVJQ1U6Omlu aXRpYWxpemVMb2NhbGVEYXRhKCkKICAgICBzZXRMb2NhbGVEYXRhKHN5bWJvbHMsIGRlY2ltYWxU ZXh0QXR0cmlidXRlKFVOVU1fUE9TSVRJVkVfUFJFRklYKSwgZGVjaW1hbFRleHRBdHRyaWJ1dGUo VU5VTV9QT1NJVElWRV9TVUZGSVgpLCBkZWNpbWFsVGV4dEF0dHJpYnV0ZShVTlVNX05FR0FUSVZF X1BSRUZJWCksIGRlY2ltYWxUZXh0QXR0cmlidXRlKFVOVU1fTkVHQVRJVkVfU1VGRklYKSk7CiB9 CiAKKyNpZiBFTkFCTEUoREFURV9BTkRfVElNRV9JTlBVVF9UWVBFUykKIGJvb2wgTG9jYWxlSUNV Ojppbml0aWFsaXplU2hvcnREYXRlRm9ybWF0KCkKIHsKICAgICBpZiAobV9kaWRDcmVhdGVTaG9y dERhdGVGb3JtYXQpCkBAIC0xNDYsNyArMTQ3LDYgQEAgVURhdGVGb3JtYXQqIExvY2FsZUlDVTo6 b3BlbkRhdGVGb3JtYXQoVURhdGVGb3JtYXRTdHlsZSB0aW1lU3R5bGUsIFVEYXRlRm9ybWF0U3QK ICAgICByZXR1cm4gdWRhdF9vcGVuKHRpbWVTdHlsZSwgZGF0ZVN0eWxlLCBtX2xvY2FsZS5kYXRh KCksIGdtdFRpbWV6b25lLCBXVEZfQVJSQVlfTEVOR1RIKGdtdFRpbWV6b25lKSwgMCwgLTEsICZz dGF0dXMpOwogfQogCi0jaWYgRU5BQkxFKERBVEVfQU5EX1RJTUVfSU5QVVRfVFlQRVMpCiBzdGF0 aWMgU3RyaW5nIGdldERhdGVGb3JtYXRQYXR0ZXJuKGNvbnN0IFVEYXRlRm9ybWF0KiBkYXRlRm9y bWF0KQogewogICAgIGlmICghZGF0ZUZvcm1hdCkKQEAgLTE4Nyw5ICsxODcsNyBAQCBzdGQ6OnVu aXF1ZV9wdHI8VmVjdG9yPFN0cmluZz4+IExvY2FsZUlDVTo6Y3JlYXRlTGFiZWxWZWN0b3IoY29u c3QgVURhdGVGb3JtYXQqCiAgICAgfQogICAgIHJldHVybiBXVEZNb3ZlKGxhYmVscyk7CiB9Ci0j ZW5kaWYKIAotI2lmIEVOQUJMRShEQVRFX0FORF9USU1FX0lOUFVUX1RZUEVTKQogc3RhdGljIHN0 ZDo6dW5pcXVlX3B0cjxWZWN0b3I8U3RyaW5nPj4gY3JlYXRlRmFsbGJhY2tNb250aExhYmVscygp CiB7CiAgICAgYXV0byBsYWJlbHMgPSBzdGQ6Om1ha2VfdW5pcXVlPFZlY3RvcjxTdHJpbmc+Pigp OwpAQCAtMjExLDkgKzIwOSw3IEBAIGNvbnN0IFZlY3RvcjxTdHJpbmc+JiBMb2NhbGVJQ1U6Om1v bnRoTGFiZWxzKCkKICAgICBtX21vbnRoTGFiZWxzID0gY3JlYXRlRmFsbGJhY2tNb250aExhYmVs cygpOwogICAgIHJldHVybiAqbV9tb250aExhYmVsczsKIH0KLSNlbmRpZgogCi0jaWYgRU5BQkxF KERBVEVfQU5EX1RJTUVfSU5QVVRfVFlQRVMpCiBzdGF0aWMgc3RkOjp1bmlxdWVfcHRyPFZlY3Rv cjxTdHJpbmc+PiBjcmVhdGVGYWxsYmFja0FNUE1MYWJlbHMoKQogewogICAgIGF1dG8gbGFiZWxz ID0gc3RkOjptYWtlX3VuaXF1ZTxWZWN0b3I8U3RyaW5nPj4oKTsKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL3RleHQvTG9jYWxlSUNVLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS90ZXh0L0xvY2FsZUlDVS5oCmluZGV4IGJlMmNlYWRjYWUzZGI4YTQ2ZDM2ZDIwOWQ2ZTAy OWFlMGExOTM1NzguLjQ0YmIxODgwZjA0NjI4N2Y5MGMyODkwOWRiNjU4ZDM4M2U4N2Y2MzAgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3RleHQvTG9jYWxlSUNVLmgKKysrIGIv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vdGV4dC9Mb2NhbGVJQ1UuaApAQCAtNjgsMTkgKzY4LDE3 IEBAIHByaXZhdGU6CiAgICAgU3RyaW5nIGRlY2ltYWxUZXh0QXR0cmlidXRlKFVOdW1iZXJGb3Jt YXRUZXh0QXR0cmlidXRlKTsKICAgICB2aXJ0dWFsIHZvaWQgaW5pdGlhbGl6ZUxvY2FsZURhdGEo KSBvdmVycmlkZTsKIAorI2lmIEVOQUJMRShEQVRFX0FORF9USU1FX0lOUFVUX1RZUEVTKQogICAg IGJvb2wgaW5pdGlhbGl6ZVNob3J0RGF0ZUZvcm1hdCgpOwogICAgIFVEYXRlRm9ybWF0KiBvcGVu RGF0ZUZvcm1hdChVRGF0ZUZvcm1hdFN0eWxlIHRpbWVTdHlsZSwgVURhdGVGb3JtYXRTdHlsZSBk YXRlU3R5bGUpIGNvbnN0OwogCi0jaWYgRU5BQkxFKERBVEVfQU5EX1RJTUVfSU5QVVRfVFlQRVMp CiAgICAgc3RkOjp1bmlxdWVfcHRyPFZlY3RvcjxTdHJpbmc+PiBjcmVhdGVMYWJlbFZlY3Rvcihj b25zdCBVRGF0ZUZvcm1hdCosIFVEYXRlRm9ybWF0U3ltYm9sVHlwZSwgaW50MzJfdCBzdGFydElu ZGV4LCBpbnQzMl90IHNpemUpOwogICAgIHZvaWQgaW5pdGlhbGl6ZURhdGVUaW1lRm9ybWF0KCk7 CiAjZW5kaWYKIAogICAgIENTdHJpbmcgbV9sb2NhbGU7CiAgICAgVU51bWJlckZvcm1hdCogbV9u dW1iZXJGb3JtYXQ7Ci0gICAgVURhdGVGb3JtYXQqIG1fc2hvcnREYXRlRm9ybWF0OwogICAgIGJv b2wgbV9kaWRDcmVhdGVEZWNpbWFsRm9ybWF0OwotICAgIGJvb2wgbV9kaWRDcmVhdGVTaG9ydERh dGVGb3JtYXQ7CiAKICNpZiBFTkFCTEUoREFURV9BTkRfVElNRV9JTlBVVF9UWVBFUykKICAgICBz dGQ6OnVuaXF1ZV9wdHI8VmVjdG9yPFN0cmluZz4+IG1fbW9udGhMYWJlbHM7CkBAIC05MSwxMiAr ODksMTQgQEAgcHJpdmF0ZToKICAgICBTdHJpbmcgbV90aW1lRm9ybWF0V2l0aG91dFNlY29uZHM7 CiAgICAgU3RyaW5nIG1fZGF0ZVRpbWVGb3JtYXRXaXRoU2Vjb25kczsKICAgICBTdHJpbmcgbV9k YXRlVGltZUZvcm1hdFdpdGhvdXRTZWNvbmRzOworICAgIFVEYXRlRm9ybWF0KiBtX3Nob3J0RGF0 ZUZvcm1hdDsKICAgICBVRGF0ZUZvcm1hdCogbV9tZWRpdW1UaW1lRm9ybWF0OwogICAgIFVEYXRl Rm9ybWF0KiBtX3Nob3J0VGltZUZvcm1hdDsKICAgICBWZWN0b3I8U3RyaW5nPiBtX3Nob3J0TW9u dGhMYWJlbHM7CiAgICAgVmVjdG9yPFN0cmluZz4gbV9zdGFuZEFsb25lTW9udGhMYWJlbHM7CiAg ICAgVmVjdG9yPFN0cmluZz4gbV9zaG9ydFN0YW5kQWxvbmVNb250aExhYmVsczsKICAgICBWZWN0 b3I8U3RyaW5nPiBtX3RpbWVBTVBNTGFiZWxzOworICAgIGJvb2wgbV9kaWRDcmVhdGVTaG9ydERh dGVGb3JtYXQ7CiAgICAgYm9vbCBtX2RpZENyZWF0ZVRpbWVGb3JtYXQ7CiAjZW5kaWYKIH07Cg==