154476 2016-02-19 14:54:34 -0800 Add the support for universal slave password 2016-02-20 17:54:10 -0800 1 1 1 Unclassified WebKit Perf Dashboard WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rniwa rniwa ap cdumez commit-queue dburkart rniwa oldest_to_newest 1166569 0 rniwa 2016-02-19 14:54:34 -0800 There should be a mechanism to share a single password across bots. 1166570 1 rniwa 2016-02-19 14:55:38 -0800 <rdar://problem/16204634>. 1166572 2 271808 rniwa 2016-02-19 14:57:19 -0800 Created attachment 271808 Adds the support 1166734 3 271808 ddkilzer 2016-02-20 09:02:54 -0800 Comment on attachment 271808 Adds the support r=me 1166793 4 271808 rniwa 2016-02-20 17:05:43 -0800 Comment on attachment 271808 Adds the support Thanks for the review! 1166794 5 271808 commit-queue 2016-02-20 17:54:05 -0800 Comment on attachment 271808 Adds the support Clearing flags on attachment: 271808 Committed r196870: <http://trac.webkit.org/changeset/196870> 1166795 6 commit-queue 2016-02-20 17:54:10 -0800 All reviewed patches have been landed. Closing bug. 271808 2016-02-19 14:57:19 -0800 2016-02-20 17:54:05 -0800 Adds the support bug-154476-20160219145700.patch text/plain 7285 rniwa SW5kZXg6IFdlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g V2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL0NoYW5nZUxvZwkocmV2aXNpb24gMTk2ODM1KQorKysg V2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE3IEBACisyMDE2LTAyLTE5ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgor CisgICAgICAgIEFkZCB0aGUgc3VwcG9ydCBmb3IgdW5pdmVyc2FsIHNsYXZlIHBhc3N3b3JkCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTQ0NzYKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGRlZCB0aGUg c3VwcG9ydCBmb3IgdW5pdmVyc2FsU2xhdmVQYXNzd29yZC4KKworICAgICAgICAqIGNvbmZpZy5q c29uOgorICAgICAgICAqIHB1YmxpYy9pbmNsdWRlL3JlcG9ydC1wcm9jZXNzb3IucGhwOgorICAg ICAgICAoUmVwb3J0UHJvY2Vzc29yOjpwcm9jZXNzKToKKyAgICAgICAgKFJlcG9ydFByb2Nlc3Nv cjo6YXV0aGVudGljYXRlX2FuZF9jb25zdHJ1Y3RfYnVpbGRfZGF0YSk6IEV4dHJhY3RlZCBmcm9t IHByb2Nlc3MoKS4KKwogMjAxNi0wMi0xOSAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9y Zz4KIAogICAgICAgICBBbmFseXNpcyB0YXNrcyBwYWdlIGNvbXBsYWlucyBhYm91dCBtaXNzaW5n IHJlcG9zaXRvcnkgYnV0IHdpdGggYSB3cm9uZyBuYW1lCkluZGV4OiBXZWJzaXRlcy9wZXJmLndl YmtpdC5vcmcvY29uZmlnLmpzb24KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2Vic2l0ZXMvcGVyZi53ZWJraXQu b3JnL2NvbmZpZy5qc29uCShyZXZpc2lvbiAxOTY4MzUpCisrKyBXZWJzaXRlcy9wZXJmLndlYmtp dC5vcmcvY29uZmlnLmpzb24JKHdvcmtpbmcgY29weSkKQEAgLTEwLDYgKzEwLDcgQEAKICAgICAg ICAgInBhc3N3b3JkIjogInBhc3N3b3JkIiwKICAgICAgICAgIm5hbWUiOiAid2Via2l0LXBlcmYt ZGIiCiAgICAgfSwKKyAgICAidW5pdmVyc2FsU2xhdmVQYXNzd29yZCI6IG51bGwsCiAgICAgIm1h aW50ZW5hbmNlTW9kZSI6IGZhbHNlLAogICAgICJtYWludGVuYW5jZURpcmVjdG9yeSI6ICJyZXBv cnRlZC8iLAogICAgICJ0ZXN0U2VydmVyIjogewpJbmRleDogV2Vic2l0ZXMvcGVyZi53ZWJraXQu b3JnL3B1YmxpYy9pbmNsdWRlL3JlcG9ydC1wcm9jZXNzb3IucGhwCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdl YnNpdGVzL3BlcmYud2Via2l0Lm9yZy9wdWJsaWMvaW5jbHVkZS9yZXBvcnQtcHJvY2Vzc29yLnBo cAkocmV2aXNpb24gMTk2ODM1KQorKysgV2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL3B1YmxpYy9p bmNsdWRlL3JlcG9ydC1wcm9jZXNzb3IucGhwCSh3b3JraW5nIGNvcHkpCkBAIC0zMiwxNCArMzIs NDMgQEAgY2xhc3MgUmVwb3J0UHJvY2Vzc29yIHsKICAgICAgICAgYXJyYXlfa2V5X2V4aXN0cygn YnVpbGRlck5hbWUnLCAkcmVwb3J0KSBvciAkdGhpcy0+ZXhpdF93aXRoX2Vycm9yKCdNaXNzaW5n QnVpbGRlck5hbWUnKTsKICAgICAgICAgYXJyYXlfa2V5X2V4aXN0cygnYnVpbGRUaW1lJywgJHJl cG9ydCkgb3IgJHRoaXMtPmV4aXRfd2l0aF9lcnJvcignTWlzc2luZ0J1aWxkVGltZScpOwogCisg ICAgICAgICRidWlsZF9kYXRhID0gJHRoaXMtPmF1dGhlbnRpY2F0ZV9hbmRfY29uc3RydWN0X2J1 aWxkX2RhdGEoJHJlcG9ydCwgJGV4aXN0aW5nX3JlcG9ydF9pZCk7CisgICAgICAgIGlmICghJGV4 aXN0aW5nX3JlcG9ydF9pZCkKKyAgICAgICAgICAgICR0aGlzLT5zdG9yZV9yZXBvcnQoJHJlcG9y dCwgJGJ1aWxkX2RhdGEpOworCisgICAgICAgICR0aGlzLT5lbnN1cmVfYWdncmVnYXRvcnMoKTsK KworICAgICAgICAkdGhpcy0+cnVucyA9IG5ldyBUZXN0UnVuc0dlbmVyYXRvcigkdGhpcy0+ZGIs ICR0aGlzLT5uYW1lX3RvX2FnZ3JlZ2F0b3JfaWQsICR0aGlzLT5yZXBvcnRfaWQpOworICAgICAg ICAkdGhpcy0+cmVjdXJzaXZlbHlfZW5zdXJlX3Rlc3RzKCRyZXBvcnRbJ3Rlc3RzJ10pOworCisg ICAgICAgICR0aGlzLT5ydW5zLT5hZ2dyZWdhdGUoKTsKKyAgICAgICAgJHRoaXMtPnJ1bnMtPmNv bXB1dGVfY2FjaGVzKCk7CisKKyAgICAgICAgJHBsYXRmb3JtX2lkID0gJHRoaXMtPmRiLT5zZWxl Y3Rfb3JfaW5zZXJ0X3JvdygncGxhdGZvcm1zJywgJ3BsYXRmb3JtJywgYXJyYXkoJ25hbWUnID0+ ICRyZXBvcnRbJ3BsYXRmb3JtJ10pKTsKKyAgICAgICAgaWYgKCEkcGxhdGZvcm1faWQpCisgICAg ICAgICAgICAkdGhpcy0+ZXhpdF93aXRoX2Vycm9yKCdGYWlsZWRUb0luc2VydFBsYXRmb3JtJywg YXJyYXkoJ25hbWUnID0+ICRyZXBvcnRbJ3BsYXRmb3JtJ10pKTsKKworICAgICAgICAvLyBGSVhN RTogRGVwcmVjYXRlIGFuZCB1bnN1cHBvcnQgImpvYklkIi4KKyAgICAgICAgJGJ1aWxkX2lkID0g JHRoaXMtPnJlc29sdmVfYnVpbGRfaWQoJGJ1aWxkX2RhdGEsIGFycmF5X2dldCgkcmVwb3J0LCAn cmV2aXNpb25zJywgYXJyYXkoKSksCisgICAgICAgICAgICBhcnJheV9nZXQoJHJlcG9ydCwgJ2pv YklkJywgYXJyYXlfZ2V0KCRyZXBvcnQsICdidWlsZFJlcXVlc3QnKSkpOworCisgICAgICAgICR0 aGlzLT5ydW5zLT5jb21taXQoJHBsYXRmb3JtX2lkLCAkYnVpbGRfaWQpOworICAgIH0KKworICAg IHByaXZhdGUgZnVuY3Rpb24gYXV0aGVudGljYXRlX2FuZF9jb25zdHJ1Y3RfYnVpbGRfZGF0YSgm JHJlcG9ydCwgJGV4aXN0aW5nX3JlcG9ydF9pZCkgewogICAgICAgICAkYnVpbGRlcl9pbmZvID0g YXJyYXkoJ25hbWUnID0+ICRyZXBvcnRbJ2J1aWxkZXJOYW1lJ10pOwogICAgICAgICAkc2xhdmVf bmFtZSA9IGFycmF5X2dldCgkcmVwb3J0LCAnc2xhdmVOYW1lJywgTlVMTCk7CiAgICAgICAgICRz bGF2ZV9pZCA9IE5VTEw7CiAgICAgICAgIGlmICghJGV4aXN0aW5nX3JlcG9ydF9pZCkgewogICAg ICAgICAgICAgJGhhc2ggPSBOVUxMOwogICAgICAgICAgICAgaWYgKCRzbGF2ZV9uYW1lICYmIGFy cmF5X2tleV9leGlzdHMoJ3NsYXZlUGFzc3dvcmQnLCAkcmVwb3J0KSkgewotICAgICAgICAgICAg ICAgICRoYXNoID0gaGFzaCgnc2hhMjU2JywgJHJlcG9ydFsnc2xhdmVQYXNzd29yZCddKTsKLSAg ICAgICAgICAgICAgICAkc2xhdmUgPSAkdGhpcy0+ZGItPnNlbGVjdF9maXJzdF9yb3coJ2J1aWxk X3NsYXZlcycsICdzbGF2ZScsIGFycmF5KCduYW1lJyA9PiAkc2xhdmVfbmFtZSwgJ3Bhc3N3b3Jk X2hhc2gnID0+ICRoYXNoKSk7CisgICAgICAgICAgICAgICAgJHVuaXZlcnNhbF9wYXNzd29yZCA9 IGNvbmZpZygndW5pdmVyc2FsU2xhdmVQYXNzd29yZCcpOworICAgICAgICAgICAgICAgIGlmICgk dW5pdmVyc2FsX3Bhc3N3b3JkICYmICR1bml2ZXJzYWxfcGFzc3dvcmQgPT0gJHJlcG9ydFsnc2xh dmVQYXNzd29yZCddKQorICAgICAgICAgICAgICAgICAgICAkc2xhdmUgPSAkdGhpcy0+ZGItPnNl bGVjdF9maXJzdF9yb3coJ2J1aWxkX3NsYXZlcycsICdzbGF2ZScsIGFycmF5KCduYW1lJyA9PiAk c2xhdmVfbmFtZSkpOworICAgICAgICAgICAgICAgIGVsc2UgeworICAgICAgICAgICAgICAgICAg ICAkaGFzaCA9IGhhc2goJ3NoYTI1NicsICRyZXBvcnRbJ3NsYXZlUGFzc3dvcmQnXSk7CisgICAg ICAgICAgICAgICAgICAgICRzbGF2ZSA9ICR0aGlzLT5kYi0+c2VsZWN0X2ZpcnN0X3JvdygnYnVp bGRfc2xhdmVzJywgJ3NsYXZlJywgYXJyYXkoJ25hbWUnID0+ICRzbGF2ZV9uYW1lLCAncGFzc3dv cmRfaGFzaCcgPT4gJGhhc2gpKTsKKyAgICAgICAgICAgICAgICB9CiAgICAgICAgICAgICAgICAg aWYgKCRzbGF2ZSkKICAgICAgICAgICAgICAgICAgICAgJHNsYXZlX2lkID0gJHNsYXZlWydzbGF2 ZV9pZCddOwogICAgICAgICAgICAgfSBlbHNlIGlmIChhcnJheV9rZXlfZXhpc3RzKCdidWlsZGVy UGFzc3dvcmQnLCAkcmVwb3J0KSkKQEAgLTY4LDM3ICs5NywxNyBAQCBjbGFzcyBSZXBvcnRQcm9j ZXNzb3IgewogICAgICAgICAgICAgICAgICRzbGF2ZV9pZCA9ICR0aGlzLT5kYi0+c2VsZWN0X29y X2luc2VydF9yb3coJ2J1aWxkX3NsYXZlcycsICdzbGF2ZScsIGFycmF5KCduYW1lJyA9PiAkc2xh dmVfbmFtZSkpOwogICAgICAgICB9CiAKLSAgICAgICAgJGJ1aWxkX2RhdGEgPSAkdGhpcy0+Y29u c3RydWN0X2J1aWxkX2RhdGEoJHJlcG9ydCwgJGJ1aWxkZXJfaWQsICRzbGF2ZV9pZCk7Ci0gICAg ICAgIGlmICghJGV4aXN0aW5nX3JlcG9ydF9pZCkKLSAgICAgICAgICAgICR0aGlzLT5zdG9yZV9y ZXBvcnQoJHJlcG9ydCwgJGJ1aWxkX2RhdGEpOwotCi0gICAgICAgICR0aGlzLT5lbnN1cmVfYWdn cmVnYXRvcnMoKTsKLQotICAgICAgICAkdGhpcy0+cnVucyA9IG5ldyBUZXN0UnVuc0dlbmVyYXRv cigkdGhpcy0+ZGIsICR0aGlzLT5uYW1lX3RvX2FnZ3JlZ2F0b3JfaWQsICR0aGlzLT5yZXBvcnRf aWQpOwotICAgICAgICAkdGhpcy0+cmVjdXJzaXZlbHlfZW5zdXJlX3Rlc3RzKCRyZXBvcnRbJ3Rl c3RzJ10pOwotCi0gICAgICAgICR0aGlzLT5ydW5zLT5hZ2dyZWdhdGUoKTsKLSAgICAgICAgJHRo aXMtPnJ1bnMtPmNvbXB1dGVfY2FjaGVzKCk7Ci0KLSAgICAgICAgJHBsYXRmb3JtX2lkID0gJHRo aXMtPmRiLT5zZWxlY3Rfb3JfaW5zZXJ0X3JvdygncGxhdGZvcm1zJywgJ3BsYXRmb3JtJywgYXJy YXkoJ25hbWUnID0+ICRyZXBvcnRbJ3BsYXRmb3JtJ10pKTsKLSAgICAgICAgaWYgKCEkcGxhdGZv cm1faWQpCi0gICAgICAgICAgICAkdGhpcy0+ZXhpdF93aXRoX2Vycm9yKCdGYWlsZWRUb0luc2Vy dFBsYXRmb3JtJywgYXJyYXkoJ25hbWUnID0+ICRyZXBvcnRbJ3BsYXRmb3JtJ10pKTsKLQotICAg ICAgICAvLyBGSVhNRTogRGVwcmVjYXRlIGFuZCB1bnN1cHBvcnQgImpvYklkIi4KLSAgICAgICAg JGJ1aWxkX2lkID0gJHRoaXMtPnJlc29sdmVfYnVpbGRfaWQoJGJ1aWxkX2RhdGEsIGFycmF5X2dl dCgkcmVwb3J0LCAncmV2aXNpb25zJywgYXJyYXkoKSksCi0gICAgICAgICAgICBhcnJheV9nZXQo JHJlcG9ydCwgJ2pvYklkJywgYXJyYXlfZ2V0KCRyZXBvcnQsICdidWlsZFJlcXVlc3QnKSkpOwot Ci0gICAgICAgICR0aGlzLT5ydW5zLT5jb21taXQoJHBsYXRmb3JtX2lkLCAkYnVpbGRfaWQpOwor ICAgICAgICByZXR1cm4gJHRoaXMtPmNvbnN0cnVjdF9idWlsZF9kYXRhKCRyZXBvcnQsICRidWls ZGVyX2lkLCAkc2xhdmVfaWQpOwogICAgIH0KIAotICAgIHByaXZhdGUgZnVuY3Rpb24gY29uc3Ry dWN0X2J1aWxkX2RhdGEoJHJlcG9ydCwgJGJ1aWxkZXJfaWQsICRzbGF2ZV9pZCkgeworICAgIHBy aXZhdGUgZnVuY3Rpb24gY29uc3RydWN0X2J1aWxkX2RhdGEoJiRyZXBvcnQsICRidWlsZGVyX2lk LCAkc2xhdmVfaWQpIHsKICAgICAgICAgYXJyYXlfa2V5X2V4aXN0cygnYnVpbGROdW1iZXInLCAk cmVwb3J0KSBvciAkdGhpcy0+ZXhpdF93aXRoX2Vycm9yKCdNaXNzaW5nQnVpbGROdW1iZXInKTsK ICAgICAgICAgYXJyYXlfa2V5X2V4aXN0cygnYnVpbGRUaW1lJywgJHJlcG9ydCkgb3IgJHRoaXMt PmV4aXRfd2l0aF9lcnJvcignTWlzc2luZ0J1aWxkVGltZScpOwogCiAgICAgICAgIHJldHVybiBh cnJheSgnYnVpbGRlcicgPT4gJGJ1aWxkZXJfaWQsICdzbGF2ZScgPT4gJHNsYXZlX2lkLCAnbnVt YmVyJyA9PiAkcmVwb3J0WydidWlsZE51bWJlciddLCAndGltZScgPT4gJHJlcG9ydFsnYnVpbGRU aW1lJ10pOwogICAgIH0KIAotICAgIHByaXZhdGUgZnVuY3Rpb24gc3RvcmVfcmVwb3J0KCRyZXBv cnQsICRidWlsZF9kYXRhKSB7CisgICAgcHJpdmF0ZSBmdW5jdGlvbiBzdG9yZV9yZXBvcnQoJiRy ZXBvcnQsICRidWlsZF9kYXRhKSB7CiAgICAgICAgIGFzc2VydCghJHRoaXMtPnJlcG9ydF9pZCk7 CiAgICAgICAgICR0aGlzLT5yZXBvcnRfaWQgPSAkdGhpcy0+ZGItPmluc2VydF9yb3coJ3JlcG9y dHMnLCAncmVwb3J0JywgYXJyYXkoCiAgICAgICAgICAgICAnYnVpbGRlcicgPT4gJGJ1aWxkX2Rh dGFbJ2J1aWxkZXInXSwKQEAgLTExOCw3ICsxMjcsNyBAQCBjbGFzcyBSZXBvcnRQcm9jZXNzb3Ig ewogICAgICAgICB9CiAgICAgfQogCi0gICAgcHJpdmF0ZSBmdW5jdGlvbiByZXNvbHZlX2J1aWxk X2lkKCRidWlsZF9kYXRhLCAkcmV2aXNpb25zLCAkYnVpbGRfcmVxdWVzdF9pZCkgeworICAgIHBy aXZhdGUgZnVuY3Rpb24gcmVzb2x2ZV9idWlsZF9pZCgmJGJ1aWxkX2RhdGEsICRyZXZpc2lvbnMs ICRidWlsZF9yZXF1ZXN0X2lkKSB7CiAgICAgICAgIC8vIEZJWE1FOiBUaGlzIGNvZGUgaGFzIGEg cmFjZSBjb25kaXRpb24uIFNlZSA8cmRhcjovL3Byb2JsZW0vMTU4NzYzMDM+LgogICAgICAgICAk cmVzdWx0cyA9ICR0aGlzLT5kYi0+cXVlcnlfYW5kX2ZldGNoX2FsbCgiU0VMRUNUIGJ1aWxkX2lk LCBidWlsZF9zbGF2ZSBGUk9NIGJ1aWxkcwogICAgICAgICAgICAgV0hFUkUgYnVpbGRfYnVpbGRl ciA9ICQxIEFORCBidWlsZF9udW1iZXIgPSAkMiBBTkQgYnVpbGRfdGltZSA8PSAkMyBBTkQgYnVp bGRfdGltZSArIGludGVydmFsICcxIGRheScgPiAkMyIsCkBAIC0xNjgsNyArMTc3LDcgQEAgY2xh c3MgUmVwb3J0UHJvY2Vzc29yIHsKICAgICAgICAgcmV0dXJuICRidWlsZF9pZDsKICAgICB9CiAK LSAgICBwcml2YXRlIGZ1bmN0aW9uIHJlY3Vyc2l2ZWx5X2Vuc3VyZV90ZXN0cygkdGVzdHMsICRw YXJlbnRfaWQgPSBOVUxMLCAkbGV2ZWwgPSAwKSB7CisgICAgcHJpdmF0ZSBmdW5jdGlvbiByZWN1 cnNpdmVseV9lbnN1cmVfdGVzdHMoJiR0ZXN0cywgJHBhcmVudF9pZCA9IE5VTEwsICRsZXZlbCA9 IDApIHsKICAgICAgICAgZm9yZWFjaCAoJHRlc3RzIGFzICR0ZXN0X25hbWUgPT4gJHRlc3QpIHsK ICAgICAgICAgICAgICR0ZXN0X2lkID0gJHRoaXMtPmRiLT5zZWxlY3Rfb3JfaW5zZXJ0X3Jvdygn dGVzdHMnLCAndGVzdCcsICRwYXJlbnRfaWQgPyBhcnJheSgnbmFtZScgPT4gJHRlc3RfbmFtZSwg J3BhcmVudCcgPT4gJHBhcmVudF9pZCkgOiBhcnJheSgnbmFtZScgPT4gJHRlc3RfbmFtZSksCiAg ICAgICAgICAgICAgICAgYXJyYXkoJ25hbWUnID0+ICR0ZXN0X25hbWUsICdwYXJlbnQnID0+ICRw YXJlbnRfaWQsICd1cmwnID0+IGFycmF5X2dldCgkdGVzdCwgJ3VybCcpKSk7Cg==