154442 2016-02-18 23:46:54 -0800 Add isJSString(JSCell*) variant to avoid Cell->JSValue->Cell conversion 2016-02-19 02:39:35 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 joepeck joepeck commit-queue ggaren keith_miller mark.lam msaboff saam oldest_to_newest 1166356 0 joepeck 2016-02-18 23:46:54 -0800 Unlike isJSArray and isJSNonFinalObject functions which have JSCell and JSValue variants, the isJSString helper only had a JSValue variant. Add the cell variant to avoid possible extra unnecessary conversions. The JSC::JSValue(JSCell*) constructor is not explicit. 1166357 1 271739 joepeck 2016-02-18 23:47:33 -0800 Created attachment 271739 [PATCH] Proposed Fix 1166379 2 271739 commit-queue 2016-02-19 02:39:31 -0800 Comment on attachment 271739 [PATCH] Proposed Fix Clearing flags on attachment: 271739 Committed r196810: <http://trac.webkit.org/changeset/196810> 1166380 3 commit-queue 2016-02-19 02:39:35 -0800 All reviewed patches have been landed. Closing bug. 271739 2016-02-18 23:47:33 -0800 2016-02-19 02:39:31 -0800 [PATCH] Proposed Fix cell.patch text/plain 1465 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGU3MGYzMTcuLmQ2OGFjMGMgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE2LTAyLTE4ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgQWRkIGlzSlNTdHJpbmcoSlNDZWxs KikgdmFyaWFudCB0byBhdm9pZCBDZWxsLT5KU1ZhbHVlLT5DZWxsIGNvbnZlcnNpb24KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1NDQ0MgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcnVudGltZS9KU1N0 cmluZy5oOgorICAgICAgICAoSlNDOjppc0pTU3RyaW5nKToKKwogMjAxNi0wMi0xOCAgQmVuamFt aW4gUG91bGFpbiAgPGJwb3VsYWluQGFwcGxlLmNvbT4KIAogICAgICAgICBbSlNDXSBJbXByb3Zl IHRoZSBpbnN0cnVjdGlvbiBzZWxlY3Rpb24gb2YgU2VsZWN0CmRpZmYgLS1naXQgYS9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvcnVudGltZS9KU1N0cmluZy5oIGIvU291cmNlL0phdmFTY3JpcHRDb3Jl L3J1bnRpbWUvSlNTdHJpbmcuaAppbmRleCBiYWY1OGZmLi5jZWJmODMzIDEwMDY0NAotLS0gYS9T b3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU1N0cmluZy5oCisrKyBiL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS9ydW50aW1lL0pTU3RyaW5nLmgKQEAgLTYyLDYgKzYyLDcgQEAgSlNTdHJpbmcq IGpzT3duZWRTdHJpbmcoRXhlY1N0YXRlKiwgY29uc3QgU3RyaW5nJik7CiAKIEpTUm9wZVN0cmlu ZyoganNTdHJpbmdCdWlsZGVyKFZNKik7CiAKK2Jvb2wgaXNKU1N0cmluZyhKU0NlbGwqKTsKIGJv b2wgaXNKU1N0cmluZyhKU1ZhbHVlKTsKIEpTU3RyaW5nKiBhc1N0cmluZyhKU1ZhbHVlKTsKIApA QCAtNjQ2LDkgKzY0NywxNCBAQCBBTFdBWVNfSU5MSU5FIGJvb2wgSlNTdHJpbmc6OmdldFN0cmlu Z1Byb3BlcnR5U2xvdChFeGVjU3RhdGUqIGV4ZWMsIHVuc2lnbmVkIHBybwogICAgIHJldHVybiBm YWxzZTsKIH0KIAoraW5saW5lIGJvb2wgaXNKU1N0cmluZyhKU0NlbGwqIGNlbGwpCit7CisgICAg cmV0dXJuIGNlbGwtPnR5cGUoKSA9PSBTdHJpbmdUeXBlOworfQorCiBpbmxpbmUgYm9vbCBpc0pT U3RyaW5nKEpTVmFsdWUgdikKIHsKLSAgICByZXR1cm4gdi5pc0NlbGwoKSAmJiB2LmFzQ2VsbCgp LT50eXBlKCkgPT0gU3RyaW5nVHlwZTsKKyAgICByZXR1cm4gdi5pc0NlbGwoKSAmJiBpc0pTU3Ry aW5nKHYuYXNDZWxsKCkpOwogfQogCiBBTFdBWVNfSU5MSU5FIFN0cmluZ1ZpZXcgSlNSb3BlU3Ry aW5nOjp1bnNhZmVWaWV3KEV4ZWNTdGF0ZSYgc3RhdGUpIGNvbnN0Cg==