154421 2016-02-18 15:32:40 -0800 Modern IDB: Fix IDBGetResult encoder/decoder 2016-02-18 16:42:03 -0800 1 1 1 Unclassified WebKit WebCore Misc. Safari 9 Unspecified Unspecified RESOLVED FIXED P2 Normal --- 149117 153808 1 beidson beidson achristensen alecflett commit-queue jsbell oldest_to_newest 1166208 0 beidson 2016-02-18 15:32:40 -0800 Modern IDB: Fix IDBGetResult encoder/decoder It was implemented in WK2 and therefore missing an internal flag. 1166209 1 271703 beidson 2016-02-18 15:34:37 -0800 Created attachment 271703 Patch v1 1166251 2 271703 commit-queue 2016-02-18 16:41:59 -0800 Comment on attachment 271703 Patch v1 Clearing flags on attachment: 271703 Committed r196786: <http://trac.webkit.org/changeset/196786> 1166252 3 commit-queue 2016-02-18 16:42:03 -0800 All reviewed patches have been landed. Closing bug. 271703 2016-02-18 15:34:37 -0800 2016-02-18 16:41:59 -0800 Patch v1 patch text/plain 6292 beidson ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBkZTAxNTZlLi42MmI4NTcxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjAg QEAKIDIwMTYtMDItMTggIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgogCisgICAg ICAgIE1vZGVybiBJREI6IEZpeCBJREJHZXRSZXN1bHQgZW5jb2Rlci9kZWNvZGVyLgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU0NDIxCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBh cyBNb2Rlcm4gSURCIGlzIHN0aWxsIGRpc2FibGVkIGZvciBXSzIuCisgICAgICAgIAorICAgICAg ICBCdXQgaWYgeW91IG1hbnVhbGx5IGVuYWJsZSBpdCwgIkJhc2ljIEluZGV4ZWREQiBTZWVtcyBU byBXb3JrIgorCisgICAgICAgICogTW9kdWxlcy9pbmRleGVkZGIvSURCR2V0UmVzdWx0Lmg6Cisg ICAgICAgIChXZWJDb3JlOjpJREJHZXRSZXN1bHQ6OmVuY29kZSk6CisgICAgICAgIChXZWJDb3Jl OjpJREJHZXRSZXN1bHQ6OmRlY29kZSk6CisKKzIwMTYtMDItMTggIEJyYWR5IEVpZHNvbiAgPGJl aWRzb25AYXBwbGUuY29tPgorCiAgICAgICAgIE1vZGVybiBJREI6IEltcGxlbWVudCBzZXJ2ZXIt PmNsaWVudCBvcGVyYXRpb25zIGluIFdLMi4KICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE1NDQxMQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9N b2R1bGVzL2luZGV4ZWRkYi9JREJHZXRSZXN1bHQuaCBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMv aW5kZXhlZGRiL0lEQkdldFJlc3VsdC5oCmluZGV4IDI0MThjMDUuLmM2NmY2ZDYgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvaW5kZXhlZGRiL0lEQkdldFJlc3VsdC5oCisrKyBi L1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvaW5kZXhlZGRiL0lEQkdldFJlc3VsdC5oCkBAIC05Myw2 ICs5Myw5IEBAIHB1YmxpYzoKICAgICBjb25zdCBJREJLZXlQYXRoJiBrZXlQYXRoKCkgY29uc3Qg eyByZXR1cm4gbV9rZXlQYXRoOyB9CiAgICAgYm9vbCBpc0RlZmluZWQoKSBjb25zdCB7IHJldHVy biBtX2lzRGVmaW5lZDsgfQogCisgICAgdGVtcGxhdGU8Y2xhc3MgRW5jb2Rlcj4gdm9pZCBlbmNv ZGUoRW5jb2RlciYpIGNvbnN0OworICAgIHRlbXBsYXRlPGNsYXNzIERlY29kZXI+IHN0YXRpYyBi b29sIGRlY29kZShEZWNvZGVyJiwgSURCR2V0UmVzdWx0Jik7CisKICAgICAvLyBGSVhNRTogV2hl biByZW1vdmluZyBMZWdhY3lJREIsIHJlbW92ZSB0aGVzZSBzZXR0ZXJzLgogICAgIC8vIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTA4NTQKIApAQCAtMTExLDYgKzEx NCw0NSBAQCBwcml2YXRlOgogICAgIGJvb2wgbV9pc0RlZmluZWQgeyB0cnVlIH07CiB9OwogCit0 ZW1wbGF0ZTxjbGFzcyBFbmNvZGVyPgordm9pZCBJREJHZXRSZXN1bHQ6OmVuY29kZShFbmNvZGVy JiBlbmNvZGVyKSBjb25zdAoreworICAgIGVuY29kZXIgPDwgbV9rZXlEYXRhIDw8IG1fcHJpbWFy eUtleURhdGEgPDwgbV9rZXlQYXRoIDw8IG1faXNEZWZpbmVkOworCisgICAgZW5jb2RlciA8PCAh IW1fdmFsdWVCdWZmZXIuZGF0YSgpOworICAgIGlmIChtX3ZhbHVlQnVmZmVyLmRhdGEoKSkKKyAg ICAgICAgZW5jb2RlciA8PCAqbV92YWx1ZUJ1ZmZlci5kYXRhKCk7Cit9CisKK3RlbXBsYXRlPGNs YXNzIERlY29kZXI+Citib29sIElEQkdldFJlc3VsdDo6ZGVjb2RlKERlY29kZXImIGRlY29kZXIs IElEQkdldFJlc3VsdCYgcmVzdWx0KQoreworICAgIGlmICghZGVjb2Rlci5kZWNvZGUocmVzdWx0 Lm1fa2V5RGF0YSkpCisgICAgICAgIHJldHVybiBmYWxzZTsKKworICAgIGlmICghZGVjb2Rlci5k ZWNvZGUocmVzdWx0Lm1fcHJpbWFyeUtleURhdGEpKQorICAgICAgICByZXR1cm4gZmFsc2U7CisK KyAgICBpZiAoIWRlY29kZXIuZGVjb2RlKHJlc3VsdC5tX2tleVBhdGgpKQorICAgICAgICByZXR1 cm4gZmFsc2U7CisKKyAgICBpZiAoIWRlY29kZXIuZGVjb2RlKHJlc3VsdC5tX2lzRGVmaW5lZCkp CisgICAgICAgIHJldHVybiBmYWxzZTsKKworICAgIGJvb2wgaGFzT2JqZWN0OworICAgIGlmICgh ZGVjb2Rlci5kZWNvZGUoaGFzT2JqZWN0KSkKKyAgICAgICAgcmV0dXJuIGZhbHNlOworCisgICAg aWYgKGhhc09iamVjdCkgeworICAgICAgICBWZWN0b3I8dWludDhfdD4gdmFsdWU7CisgICAgICAg IGlmICghZGVjb2Rlci5kZWNvZGUodmFsdWUpKQorICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwor ICAgICAgICByZXN1bHQubV92YWx1ZUJ1ZmZlciA9IFRocmVhZFNhZmVEYXRhQnVmZmVyOjphZG9w dFZlY3Rvcih2YWx1ZSk7CisgICAgfQorCisgICAgcmV0dXJuIHRydWU7Cit9CisKIH0gLy8gbmFt ZXNwYWNlIFdlYkNvcmUKIAogI2VuZGlmIC8vIEVOQUJMRShJTkRFWEVEX0RBVEFCQVNFKQpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCmluZGV4IDU4NmExMDIuLjgxMDJmNzIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKQEAgLTEsNSArMSwyMSBAQAog MjAxNi0wMi0xOCAgQnJhZHkgRWlkc29uICA8YmVpZHNvbkBhcHBsZS5jb20+CiAKKyAgICAgICAg TW9kZXJuIElEQjogRml4IElEQkdldFJlc3VsdCBlbmNvZGVyL2RlY29kZXIuCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTQ0MjEKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMsIGFzIE1v ZGVybiBJREIgaXMgc3RpbGwgZGlzYWJsZWQgZm9yIFdLMi4KKyAgICAgICAgCisgICAgICAgIEJ1 dCBpZiB5b3UgbWFudWFsbHkgZW5hYmxlIGl0LCAiQmFzaWMgSW5kZXhlZERCIFNlZW1zIFRvIFdv cmsiCisKKyAgICAgICAgKiBTaGFyZWQvV2ViQ29yZUFyZ3VtZW50Q29kZXJzLmNwcDoKKyAgICAg ICAgKElQQzo6QXJndW1lbnRDb2RlcjxJREJHZXRSZXN1bHQ+OjplbmNvZGUpOiBEZWxldGVkLgor ICAgICAgICAoSVBDOjpBcmd1bWVudENvZGVyPElEQkdldFJlc3VsdD46OmRlY29kZSk6IERlbGV0 ZWQuCisgICAgICAgICogU2hhcmVkL1dlYkNvcmVBcmd1bWVudENvZGVycy5oOgorCisyMDE2LTAy LTE4ICBCcmFkeSBFaWRzb24gIDxiZWlkc29uQGFwcGxlLmNvbT4KKwogICAgICAgICBNb2Rlcm4g SURCOiBJbXBsZW1lbnQgc2VydmVyLT5jbGllbnQgb3BlcmF0aW9ucyBpbiBXSzIuCiAgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTQ0MTEKIApkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdDIvU2hhcmVkL1dlYkNvcmVBcmd1bWVudENvZGVycy5jcHAgYi9T b3VyY2UvV2ViS2l0Mi9TaGFyZWQvV2ViQ29yZUFyZ3VtZW50Q29kZXJzLmNwcAppbmRleCBlN2Yz YzNjLi4xYTcwODI2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvV2ViQ29yZUFy Z3VtZW50Q29kZXJzLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvV2ViQ29yZUFyZ3Vt ZW50Q29kZXJzLmNwcApAQCAtMTgyMyw1NCArMTgyMyw2IEBAIGJvb2wgQXJndW1lbnRDb2RlcjxG aWx0ZXJPcGVyYXRpb25zPjo6ZGVjb2RlKEFyZ3VtZW50RGVjb2RlciYgZGVjb2RlciwgRmlsdGVy T3BlCiB9CiAjZW5kaWYgLy8gIVVTRShDT09SRElOQVRFRF9HUkFQSElDUykKIAotI2lmIEVOQUJM RShJTkRFWEVEX0RBVEFCQVNFKQotCi12b2lkIEFyZ3VtZW50Q29kZXI8SURCR2V0UmVzdWx0Pjo6 ZW5jb2RlKEFyZ3VtZW50RW5jb2RlciYgZW5jb2RlciwgY29uc3QgSURCR2V0UmVzdWx0JiByZXN1 bHQpCi17Ci0gICAgYm9vbCBudWxsRGF0YSA9ICFyZXN1bHQudmFsdWVCdWZmZXIoKS5kYXRhKCk7 Ci0gICAgZW5jb2RlciA8PCBudWxsRGF0YTsKLQotICAgIGlmICghbnVsbERhdGEpCi0gICAgICAg IGVuY29kZXIgPDwgRGF0YVJlZmVyZW5jZShyZXN1bHQudmFsdWVCdWZmZXIoKS5kYXRhKCktPmRh dGEoKSwgcmVzdWx0LnZhbHVlQnVmZmVyKCkuZGF0YSgpLT5zaXplKCkpOwotCi0gICAgZW5jb2Rl ciA8PCByZXN1bHQua2V5RGF0YSgpIDw8IHJlc3VsdC5rZXlQYXRoKCk7Ci19Ci0KLWJvb2wgQXJn dW1lbnRDb2RlcjxJREJHZXRSZXN1bHQ+OjpkZWNvZGUoQXJndW1lbnREZWNvZGVyJiBkZWNvZGVy LCBJREJHZXRSZXN1bHQmIHJlc3VsdCkKLXsKLSAgICBib29sIG51bGxEYXRhOwotICAgIGlmICgh ZGVjb2Rlci5kZWNvZGUobnVsbERhdGEpKQotICAgICAgICByZXR1cm4gZmFsc2U7Ci0KLSAgICBp ZiAobnVsbERhdGEpCi0gICAgICAgIHJlc3VsdC5zZXRWYWx1ZUJ1ZmZlcih7IH0pOwotICAgIGVs c2UgewotICAgICAgICBEYXRhUmVmZXJlbmNlIGRhdGE7Ci0gICAgICAgIGlmICghZGVjb2Rlci5k ZWNvZGUoZGF0YSkpCi0gICAgICAgICAgICByZXR1cm4gZmFsc2U7Ci0KLSAgICAgICAgVmVjdG9y PHVpbnQ4X3Q+IHZlY3RvcihkYXRhLnNpemUoKSk7Ci0gICAgICAgIG1lbWNweSh2ZWN0b3IuZGF0 YSgpLCBkYXRhLmRhdGEoKSwgZGF0YS5zaXplKCkpOwotICAgICAgICByZXN1bHQuc2V0VmFsdWVC dWZmZXIoVGhyZWFkU2FmZURhdGFCdWZmZXI6OmFkb3B0VmVjdG9yKHZlY3RvcikpOwotICAgIH0K LQotICAgIElEQktleURhdGEga2V5RGF0YTsKLSAgICBpZiAoIWRlY29kZXIuZGVjb2RlKGtleURh dGEpKQotICAgICAgICByZXR1cm4gZmFsc2U7Ci0KLSAgICByZXN1bHQuc2V0S2V5RGF0YShrZXlE YXRhKTsKLQotICAgIElEQktleVBhdGgga2V5UGF0aDsKLSAgICBpZiAoIWRlY29kZXIuZGVjb2Rl KGtleVBhdGgpKQotICAgICAgICByZXR1cm4gZmFsc2U7Ci0KLSAgICByZXN1bHQuc2V0S2V5UGF0 aChrZXlQYXRoKTsKLQotICAgIHJldHVybiB0cnVlOwotfQotCi0jZW5kaWYgLy8gRU5BQkxFKElO REVYRURfREFUQUJBU0UpCi0KIHZvaWQgQXJndW1lbnRDb2RlcjxTZXNzaW9uSUQ+OjplbmNvZGUo QXJndW1lbnRFbmNvZGVyJiBlbmNvZGVyLCBjb25zdCBTZXNzaW9uSUQmIHNlc3Npb25JRCkKIHsK ICAgICBlbmNvZGVyIDw8IHNlc3Npb25JRC5zZXNzaW9uSUQoKTsKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQyL1NoYXJlZC9XZWJDb3JlQXJndW1lbnRDb2RlcnMuaCBiL1NvdXJjZS9XZWJLaXQy L1NoYXJlZC9XZWJDb3JlQXJndW1lbnRDb2RlcnMuaAppbmRleCA4YTJlMGQyLi5hNWRkNWVjIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvV2ViQ29yZUFyZ3VtZW50Q29kZXJzLmgK KysrIGIvU291cmNlL1dlYktpdDIvU2hhcmVkL1dlYkNvcmVBcmd1bWVudENvZGVycy5oCkBAIC00 Nyw3ICs0Nyw2IEBAIGNsYXNzIEZsb2F0Um91bmRlZFJlY3Q7CiBjbGFzcyBGbG9hdFNpemU7CiBj bGFzcyBGaXhlZFBvc2l0aW9uVmlld3BvcnRDb25zdHJhaW50czsKIGNsYXNzIEhUVFBIZWFkZXJN YXA7Ci1jbGFzcyBJREJHZXRSZXN1bHQ7CiBjbGFzcyBJbnRQb2ludDsKIGNsYXNzIEludFJlY3Q7 CiBjbGFzcyBJbnRTaXplOwpAQCAtNDAzLDEzICs0MDIsNiBAQCB0ZW1wbGF0ZTw+IHN0cnVjdCBB cmd1bWVudENvZGVyPFdlYkNvcmU6OkZpbHRlck9wZXJhdGlvbj4gewogYm9vbCBkZWNvZGVGaWx0 ZXJPcGVyYXRpb24oQXJndW1lbnREZWNvZGVyJiwgUmVmUHRyPFdlYkNvcmU6OkZpbHRlck9wZXJh dGlvbj4mKTsKICNlbmRpZgogCi0jaWYgRU5BQkxFKElOREVYRURfREFUQUJBU0UpCi10ZW1wbGF0 ZTw+IHN0cnVjdCBBcmd1bWVudENvZGVyPFdlYkNvcmU6OklEQkdldFJlc3VsdD4gewotICAgIHN0 YXRpYyB2b2lkIGVuY29kZShBcmd1bWVudEVuY29kZXImLCBjb25zdCBXZWJDb3JlOjpJREJHZXRS ZXN1bHQmKTsKLSAgICBzdGF0aWMgYm9vbCBkZWNvZGUoQXJndW1lbnREZWNvZGVyJiwgV2ViQ29y ZTo6SURCR2V0UmVzdWx0Jik7Ci19OwotI2VuZGlmIC8vIEVOQUJMRShJTkRFWEVEX0RBVEFCQVNF KQotCiB0ZW1wbGF0ZTw+IHN0cnVjdCBBcmd1bWVudENvZGVyPFdlYkNvcmU6OlNlc3Npb25JRD4g ewogICAgIHN0YXRpYyB2b2lkIGVuY29kZShBcmd1bWVudEVuY29kZXImLCBjb25zdCBXZWJDb3Jl OjpTZXNzaW9uSUQmKTsKICAgICBzdGF0aWMgYm9vbCBkZWNvZGUoQXJndW1lbnREZWNvZGVyJiwg V2ViQ29yZTo6U2Vzc2lvbklEJik7Cg==