154406 2016-02-18 12:41:52 -0800 Web Inspector: CSS var() function should be syntax highlighted 2016-02-19 15:56:28 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Local Build All All RESOLVED FIXED InRadar P2 Normal --- 1 timothy mattbaker bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1166142 0 timothy 2016-02-18 12:41:52 -0800 The var() is black, while the text inside is highlighted correctly as a property now. 1166143 1 webkit-bug-importer 2016-02-18 12:42:16 -0800 <rdar://problem/24726136> 1166222 2 mattbaker 2016-02-18 15:50:53 -0800 "var" is in the valueKeywords_ array in External/CodeMirror/css.js, so it seems like it should just work. "calc" is in the same array, and appears correctly. 1166243 3 timothy 2016-02-18 16:15:09 -0800 We replace CodeMirrors valueKeywords in WebInspector.CSSCompletions.requestCSSCompletions. 1166536 4 271796 mattbaker 2016-02-19 14:01:16 -0800 Created attachment 271796 [Patch] Proposed Fix 1166589 5 271796 commit-queue 2016-02-19 15:56:23 -0800 Comment on attachment 271796 [Patch] Proposed Fix Clearing flags on attachment: 271796 Committed r196843: <http://trac.webkit.org/changeset/196843> 1166590 6 commit-queue 2016-02-19 15:56:28 -0800 All reviewed patches have been landed. Closing bug. 271796 2016-02-19 14:01:16 -0800 2016-02-19 15:56:23 -0800 [Patch] Proposed Fix bug-154406-20160219140059.patch text/plain 2646 mattbaker U3VidmVyc2lvbiBSZXZpc2lvbjogMTk2ODI3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCBk MThmOGNhMzk4YWUxM2ZmNDkwZTA1NDhkYmFkMWQwODUwZTg4NzAyLi45OWU1ODhjMjU5ZDdkNmMz ZGZkYzhlMDdmMzgwOWM0MWMxOGEzNmY1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOCBAQAorMjAxNi0wMi0xOSAgTWF0dCBCYWtlciAgPG1hdHRiYWtlckBhcHBsZS5jb20+ CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogQ1NTIHZhcigpIGZ1bmN0aW9uIHNob3VsZCBiZSBz eW50YXggaGlnaGxpZ2h0ZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE1NDQwNgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMjQ3MjYxMzY+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJm YWNlL01vZGVscy9DU1NDb21wbGV0aW9ucy5qczoKKyAgICAgICAgQWRkZWQgInZhciIgdG8gQ29k ZU1pcnJvciB2YWx1ZSBrZXl3b3JkcyBmb3Igc3ludGF4IGhpZ2hsaWdodGluZy4KKworICAgICAg ICAqIFVzZXJJbnRlcmZhY2UvTW9kZWxzL0NTU0tleXdvcmRDb21wbGV0aW9ucy5qczoKKyAgICAg ICAgKFdlYkluc3BlY3Rvci5DU1NLZXl3b3JkQ29tcGxldGlvbnMuZm9yUHJvcGVydHkpOgorICAg ICAgICBBZGRlZCAidmFyIiB0byBhY2NlcHRlZCBrZXl3b3JkcyBmb3IgYXV0by1jb21wbGV0aW9u LgorCiAyMDE2LTAyLTE4ICBEZXZpbiBSb3Vzc28gIDxkY3JvdXNzbyt3ZWJraXRAZ21haWwuY29t PgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IFN0eWxlcyBTaWRlYmFyIGZvY3VzIGp1bXBzIHdo ZW4gdHJ5aW5nIHRvIGVkaXQgYSBjb2xvcgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3Rv clVJL1VzZXJJbnRlcmZhY2UvTW9kZWxzL0NTU0NvbXBsZXRpb25zLmpzIGIvU291cmNlL1dlYklu c3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvTW9kZWxzL0NTU0NvbXBsZXRpb25zLmpzCmluZGV4IDI3 NTVlYjVjYmU2NDM1M2UzOGQwMGRjZmUxMDMzZGQzNWFjODdlNzAuLmJjNDY1NTVlN2NjYzIwZDcx ZWEzYjhkYTBmZjE0ZjY4MWFiNjEwMzkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JV SS9Vc2VySW50ZXJmYWNlL01vZGVscy9DU1NDb21wbGV0aW9ucy5qcworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Nb2RlbHMvQ1NTQ29tcGxldGlvbnMuanMKQEAgLTk3 LDcgKzk3LDcgQEAgV2ViSW5zcGVjdG9yLkNTU0NvbXBsZXRpb25zID0gY2xhc3MgQ1NTQ29tcGxl dGlvbnMKICAgICAgICAgICAgICAgICByZXR1cm47CiAKICAgICAgICAgICAgIHZhciBwcm9wZXJ0 eU5hbWVzRm9yQ29kZU1pcnJvciA9IHt9OwotICAgICAgICAgICAgdmFyIHZhbHVlS2V5d29yZHNG b3JDb2RlTWlycm9yID0geyJpbmhlcml0IjogdHJ1ZSwgImluaXRpYWwiOiB0cnVlLCAidW5zZXQi OiB0cnVlLCAicmV2ZXJ0IjogdHJ1ZX07CisgICAgICAgICAgICB2YXIgdmFsdWVLZXl3b3Jkc0Zv ckNvZGVNaXJyb3IgPSB7ImluaGVyaXQiOiB0cnVlLCAiaW5pdGlhbCI6IHRydWUsICJ1bnNldCI6 IHRydWUsICJyZXZlcnQiOiB0cnVlLCAidmFyIjogdHJ1ZX07CiAgICAgICAgICAgICB2YXIgY29s b3JLZXl3b3Jkc0ZvckNvZGVNaXJyb3IgPSB7fTsKIAogICAgICAgICAgICAgZnVuY3Rpb24gbmFt ZUZvckNvZGVNaXJyb3IobmFtZSkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9V c2VySW50ZXJmYWNlL01vZGVscy9DU1NLZXl3b3JkQ29tcGxldGlvbnMuanMgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Nb2RlbHMvQ1NTS2V5d29yZENvbXBsZXRpb25zLmpz CmluZGV4IDc2NWQzZmEwYWU2MDk3ZmQ3NjVkM2E1MzhiNThkM2Q1MzVhOGE4YzcuLmI2MTY4Y2Zj ZTU5OTNkOWExNWI5ZjcyMmQ0ZmY1MDFhYTFjN2VlYTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJ bnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL01vZGVscy9DU1NLZXl3b3JkQ29tcGxldGlvbnMuanMK KysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvTW9kZWxzL0NTU0tleXdv cmRDb21wbGV0aW9ucy5qcwpAQCAtMzMsNyArMzMsNyBAQCBXZWJJbnNwZWN0b3IuQ1NTS2V5d29y ZENvbXBsZXRpb25zID0ge307CiAKIFdlYkluc3BlY3Rvci5DU1NLZXl3b3JkQ29tcGxldGlvbnMu Zm9yUHJvcGVydHkgPSBmdW5jdGlvbihwcm9wZXJ0eU5hbWUpCiB7Ci0gICAgbGV0IGFjY2VwdGVk S2V5d29yZHMgPSBbImluaXRpYWwiLCAidW5zZXQiLCAicmV2ZXJ0Il07CisgICAgbGV0IGFjY2Vw dGVkS2V5d29yZHMgPSBbImluaXRpYWwiLCAidW5zZXQiLCAicmV2ZXJ0IiwgInZhcigpIl07CiAg ICAgbGV0IGlzTm90UHJlZml4ZWQgPSBwcm9wZXJ0eU5hbWUuY2hhckF0KDApICE9PSAiLSI7CiAK ICAgICBpZiAocHJvcGVydHlOYW1lIGluIFdlYkluc3BlY3Rvci5DU1NLZXl3b3JkQ29tcGxldGlv bnMuX3Byb3BlcnR5S2V5d29yZE1hcCkK