154397 2016-02-18 10:02:53 -0800 Remove two unused functions 2024-02-25 06:54:52 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified REOPENED P2 Normal --- 154402 1 andersca andersca ahmad.saleem792 ap bfulgham commit-queue dpino gyuyoung.kim jh718.park mcatanzaro ossy oldest_to_newest 1166066 0 andersca 2016-02-18 10:02:53 -0800 Remove two unused functions 1166067 1 271666 andersca 2016-02-18 10:03:38 -0800 Created attachment 271666 Patch 1166082 2 andersca 2016-02-18 10:44:48 -0800 Committed r196765: <http://trac.webkit.org/changeset/196765> 1166098 3 commit-queue 2016-02-18 10:59:16 -0800 Re-opened since this is blocked by bug 154402 1166369 4 ossy 2016-02-19 01:59:24 -0800 (In reply to comment #2) > Committed r196765: <http://trac.webkit.org/changeset/196765> No, they aren't unused at all, as the EFL EWS noticed. But of course, you have the right to break EFL build whenever you want, but in this case the title of the bug is incorrect. 1908100 5 ahmad.saleem792 2022-10-25 08:34:41 -0700 WKPluginSiteDataManager -> this was removed in below: https://bugs.webkit.org/show_bug.cgi?id=154470 & Commit: https://github.com/WebKit/WebKit/commit/a430103e139d9b5fa6fee8116ef572215fbbd4b7 WKResourceCacheManagerRef was changed into this and still present in Webkit: https://github.com/WebKit/WebKit/commit/add72885f51729c2161735fabcda3f4af61d0d34 Do we need anything from this bug or we can mark this as "RESOLVED WONTFIX"? Thanks! 2016661 6 ahmad.saleem792 2024-02-24 15:36:40 -0800 Can we do this clean-up? https://github.com/WebKit/WebKit/blob/bcb2f892a5d1c79d21b6df3222186a81f014e059/Source/WebKit/UIProcess/API/C/WKContext.cpp#L437C27-L437C60 WKResourceCacheManagerRef WKContextGetResourceCacheManager(WKContextRef context) { return reinterpret_cast<WKResourceCacheManagerRef>(WKWebsiteDataStoreGetDefaultDataStore()); } 2016684 7 ahmad.saleem792 2024-02-25 04:54:45 -0800 @Michael & Diego - Is this used for WebKitGTK / WPE build? https://github.com/WebKit/WebKit/blob/bcb2f892a5d1c79d21b6df3222186a81f014e059/Source/WebKit/UIProcess/API/C/WKContext.cpp#L437C27-L437C60 WKResourceCacheManagerRef WKContextGetResourceCacheManager(WKContextRef context) { return reinterpret_cast<WKResourceCacheManagerRef>(WKWebsiteDataStoreGetDefaultDataStore()); } 2016692 8 mcatanzaro 2024-02-25 06:54:52 -0800 It's clearly not used by anything: $ git grep WKContextGetResourceCacheManager WebKit/UIProcess/API/C/WKContext.cpp:WKResourceCacheManagerRef WKContextGetResourceCacheManager(WKContextRef context) WebKit/UIProcess/API/C/WKContext.h:WK_EXPORT WKResourceCacheManagerRef WKContextGetResourceCacheManager(WKContextRef context) WK_C_API_DEPRECATED_WITH_REPLACEMENT(WKWebsiteDataStoreGetDefaultDataStore); WebKit/mac/WebKit2.order:_WKContextGetResourceCacheManager I don't know what the rules are for removing old C APIs, though. I think these APIs are not public on any port? But we clearly still attempt to maintain API stability for some reason? If so, then I guess it stays. 271666 2016-02-18 10:03:38 -0800 2016-02-18 10:38:48 -0800 Patch bug-154397-20160218100328.patch text/plain 2967 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTk2NjYwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZWQ0MTg4YzcyZThhYTk4 NTE4NTM0NjM2OThhMjNhNjljNTk5OTUzYi4uMjczYWQ1NmJlNWQyMWRlYWQ1NjM1NzM2MDE1OTdj MTBkMGEwOTFkMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE2LTAyLTE4ICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CisKKyAgICAgICAgUmVtb3ZlIHR3byB1 bnVzZWQgZnVuY3Rpb25zCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xNTQzOTcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvQy9XS0NvbnRleHQuY3BwOgorICAgICAgICAoV0tDb250 ZXh0R2V0UGx1Z2luU2l0ZURhdGFNYW5hZ2VyKTogRGVsZXRlZC4KKyAgICAgICAgKFdLQ29udGV4 dEdldFJlc291cmNlQ2FjaGVNYW5hZ2VyKTogRGVsZXRlZC4KKyAgICAgICAgKiBVSVByb2Nlc3Mv QVBJL0MvV0tDb250ZXh0Lmg6CisKIDIwMTYtMDItMTYgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVy c2NhQGFwcGxlLmNvbT4KIAogICAgICAgICBSZW1vdmUgV2ViS2l0MiBoZWFkZXIgY3J1ZnQKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQy9XS0NvbnRleHQuY3BwIGIv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9DL1dLQ29udGV4dC5jcHAKaW5kZXggNzY4MGU3 Yjg4YmMyYjE4ZjBmNzBjOWY1ZjViN2U3NDk2ZTk4MjE1ZC4uZDM4MDIwNzFjNGQ3NDUxNjkxMmQ5 M2NhM2FkOGIwM2U3ZjZlOTRjYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L0FQSS9DL1dLQ29udGV4dC5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9D L1dLQ29udGV4dC5jcHAKQEAgLTQ1MywyMSArNDUzLDYgQEAgV0tOb3RpZmljYXRpb25NYW5hZ2Vy UmVmIFdLQ29udGV4dEdldE5vdGlmaWNhdGlvbk1hbmFnZXIoV0tDb250ZXh0UmVmIGNvbnRleHRS ZWYKICAgICByZXR1cm4gdG9BUEkodG9JbXBsKGNvbnRleHRSZWYpLT5zdXBwbGVtZW50PFdlYk5v dGlmaWNhdGlvbk1hbmFnZXJQcm94eT4oKSk7CiB9CiAKLVdLUGx1Z2luU2l0ZURhdGFNYW5hZ2Vy UmVmIFdLQ29udGV4dEdldFBsdWdpblNpdGVEYXRhTWFuYWdlcihXS0NvbnRleHRSZWYgY29udGV4 dCkKLXsKLSNpZiBFTkFCTEUoTkVUU0NBUEVfUExVR0lOX0FQSSkKLSAgICByZXR1cm4gcmVpbnRl cnByZXRfY2FzdDxXS1BsdWdpblNpdGVEYXRhTWFuYWdlclJlZj4oV0tDb250ZXh0R2V0V2Vic2l0 ZURhdGFTdG9yZShjb250ZXh0KSk7Ci0jZWxzZQotICAgIFVOVVNFRF9QQVJBTShjb250ZXh0KTsK LSAgICByZXR1cm4gbnVsbHB0cjsKLSNlbmRpZgotfQotCi1XS1Jlc291cmNlQ2FjaGVNYW5hZ2Vy UmVmIFdLQ29udGV4dEdldFJlc291cmNlQ2FjaGVNYW5hZ2VyKFdLQ29udGV4dFJlZiBjb250ZXh0 KQotewotICAgIHJldHVybiByZWludGVycHJldF9jYXN0PFdLUmVzb3VyY2VDYWNoZU1hbmFnZXJS ZWY+KFdLQ29udGV4dEdldFdlYnNpdGVEYXRhU3RvcmUoY29udGV4dCkpOwotfQotCiB2b2lkIFdL Q29udGV4dFN0YXJ0TWVtb3J5U2FtcGxlcihXS0NvbnRleHRSZWYgY29udGV4dFJlZiwgV0tEb3Vi bGVSZWYgaW50ZXJ2YWwpCiB7CiAgICAgdG9JbXBsKGNvbnRleHRSZWYpLT5zdGFydE1lbW9yeVNh bXBsZXIodG9JbXBsKGludGVydmFsKS0+dmFsdWUoKSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvQVBJL0MvV0tDb250ZXh0LmggYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvQVBJL0MvV0tDb250ZXh0LmgKaW5kZXggZjkyMWZkMjMzMDE2MDBlYzJmYWJiNzAyNmUwMTM4 MjJkYTkxM2JmMS4uZWVkZjA4NjUxN2Q1Y2U1YjY1MTQ3MTk2MWVjYWMzMzM2M2FjY2MxMiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9DL1dLQ29udGV4dC5oCisrKyBi L1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQy9XS0NvbnRleHQuaApAQCAtMTMzLDggKzEz Myw2IEBAIFdLX0VYUE9SVCBXS0tleVZhbHVlU3RvcmFnZU1hbmFnZXJSZWYgV0tDb250ZXh0R2V0 S2V5VmFsdWVTdG9yYWdlTWFuYWdlcihXS0NvbnRlCiBXS19FWFBPUlQgV0tNZWRpYUNhY2hlTWFu YWdlclJlZiBXS0NvbnRleHRHZXRNZWRpYUNhY2hlTWFuYWdlcihXS0NvbnRleHRSZWYgY29udGV4 dCk7CiBXS19FWFBPUlQgV0tNZWRpYVNlc3Npb25Gb2N1c01hbmFnZXJSZWYgV0tDb250ZXh0R2V0 TWVkaWFTZXNzaW9uRm9jdXNNYW5hZ2VyKFdLQ29udGV4dFJlZiBjb250ZXh0KTsKIFdLX0VYUE9S VCBXS05vdGlmaWNhdGlvbk1hbmFnZXJSZWYgV0tDb250ZXh0R2V0Tm90aWZpY2F0aW9uTWFuYWdl cihXS0NvbnRleHRSZWYgY29udGV4dCk7Ci1XS19FWFBPUlQgV0tQbHVnaW5TaXRlRGF0YU1hbmFn ZXJSZWYgV0tDb250ZXh0R2V0UGx1Z2luU2l0ZURhdGFNYW5hZ2VyKFdLQ29udGV4dFJlZiBjb250 ZXh0KTsKLVdLX0VYUE9SVCBXS1Jlc291cmNlQ2FjaGVNYW5hZ2VyUmVmIFdLQ29udGV4dEdldFJl c291cmNlQ2FjaGVNYW5hZ2VyKFdLQ29udGV4dFJlZiBjb250ZXh0KTsKIAogdHlwZWRlZiB2b2lk ICgqV0tDb250ZXh0R2V0U3RhdGlzdGljc0Z1bmN0aW9uKShXS0RpY3Rpb25hcnlSZWYgc3RhdGlz dGljcywgV0tFcnJvclJlZiBlcnJvciwgdm9pZCogZnVuY3Rpb25Db250ZXh0KTsKIFdLX0VYUE9S VCB2b2lkIFdLQ29udGV4dEdldFN0YXRpc3RpY3MoV0tDb250ZXh0UmVmIGNvbnRleHQsIHZvaWQq IGZ1bmN0aW9uQ29udGV4dCwgV0tDb250ZXh0R2V0U3RhdGlzdGljc0Z1bmN0aW9uIGZ1bmN0aW9u KTsK