154395 2016-02-18 06:07:40 -0800 Fix pessimizing-move warnings 2016-02-19 07:56:33 -0800 1 1 1 Unclassified WebKit New Bugs Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 145121 1 ossy ossy commit-queue oldest_to_newest 1166010 0 ossy 2016-02-18 06:07:40 -0800 ../../Source/WebCore/platform/graphics/efl/CairoUtilitiesEfl.cpp:85:12: warning: moving a local object in a return statement prevents copy elision [-Wpessimizing-move] return std::move<WTF::CheckMoveParameter>(image); ^ ../../Source/WebCore/platform/graphics/efl/CairoUtilitiesEfl.cpp:85:12: note: remove std::move call here return std::move<WTF::CheckMoveParameter>(image); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ~ ../../Source/WebCore/platform/graphics/surfaces/GLTransportSurface.cpp:56:16: warning: moving a local object in a return statement prevents copy elision [-Wpessimizing-move] return std::move<WTF::CheckMoveParameter>(surface); ^ ../../Source/WebCore/platform/graphics/surfaces/GLTransportSurface.cpp:56:16: note: remove std::move call here return std::move<WTF::CheckMoveParameter>(surface); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ~ ../../Source/WebCore/platform/graphics/surfaces/GLTransportSurface.cpp:223:12: warning: moving a local object in a return statement prevents copy elision [-Wpessimizing-move] return std::move<WTF::CheckMoveParameter>(client); ^ ../../Source/WebCore/platform/graphics/surfaces/GLTransportSurface.cpp:223:12: note: remove std::move call here return std::move<WTF::CheckMoveParameter>(client); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ~ 1166011 1 271657 ossy 2016-02-18 06:08:36 -0800 Created attachment 271657 Patch 1166381 2 271657 commit-queue 2016-02-19 02:48:58 -0800 Comment on attachment 271657 Patch Clearing flags on attachment: 271657 Committed r196811: <http://trac.webkit.org/changeset/196811> 1166382 3 commit-queue 2016-02-19 02:49:02 -0800 All reviewed patches have been landed. Closing bug. 271657 2016-02-18 06:08:36 -0800 2016-02-19 02:48:58 -0800 Patch bug-154395-20160218150816.patch text/plain 2365 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTk2NzU0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjNjZTRkYmRhYjMyZTU0 NTYzYTQ4NGYzMTk2ZDZlMzRkNGIwMThmOS4uMThkN2M1M2RkMmQwZTBkMGQ0ZWM4MDAyNDdkMTU0 NzMyMGVkOWRhOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE2LTAyLTE4ICBDc2Fi YSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisKKyAgICAgICAgRml4IHBlc3NpbWl6 aW5nLW1vdmUgd2FybmluZ3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE1NDM5NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvZWZsL0NhaXJvVXRpbGl0aWVzRWZsLmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OmV2YXNPYmplY3RGcm9tQ2Fpcm9JbWFnZVN1cmZhY2UpOgorICAg ICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL3N1cmZhY2VzL0dMVHJhbnNwb3J0U3VyZmFjZS5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpHTFRyYW5zcG9ydFN1cmZhY2U6OmNyZWF0ZVRyYW5zcG9ydFN1 cmZhY2UpOgorICAgICAgICAoV2ViQ29yZTo6R0xUcmFuc3BvcnRTdXJmYWNlQ2xpZW50OjpjcmVh dGVUcmFuc3BvcnRTdXJmYWNlQ2xpZW50KToKKwogMjAxNi0wMi0xOCAgQW5kcmVhcyBLbGluZyAg PGFrbGluZ0BhcHBsZS5jb20+CiAKICAgICAgICAgUmVkdWNlIHRpbGluZyBjb3ZlcmFnZSBpbW1l ZGlhdGVseSB3aGVuIG1lbW9yeSBwcmVzc3VyZSBoaXRzLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZWZsL0NhaXJvVXRpbGl0aWVzRWZsLmNwcCBiL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2VmbC9DYWlyb1V0aWxpdGllc0VmbC5jcHAKaW5k ZXggMmZlYjE0Mjk2YTNmNWJiZjgwZDVjMmE4YWE5NjY0ZjYxNDdkNTBiYy4uM2Y1MzgxY2MxZmRj ODBiMmFiZWM0ZjQ2YWQ0NGQ4ZWI1MTY4NjA1MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvZWZsL0NhaXJvVXRpbGl0aWVzRWZsLmNwcAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9lZmwvQ2Fpcm9VdGlsaXRpZXNFZmwuY3BwCkBAIC04 Miw3ICs4Miw3IEBAIEVmbFVuaXF1ZVB0cjxFdmFzX09iamVjdD4gZXZhc09iamVjdEZyb21DYWly b0ltYWdlU3VyZmFjZShFdmFzKiBjYW52YXMsIGNhaXJvX3N1CiAKICAgICBldmFzX29iamVjdF9p bWFnZV9kYXRhX2NvcHlfc2V0KGltYWdlLmdldCgpLCBkYXRhKTsKIAotICAgIHJldHVybiBXVEZN b3ZlKGltYWdlKTsKKyAgICByZXR1cm4gaW1hZ2U7CiB9CiAKIFBhc3NSZWZQdHI8Y2Fpcm9fc3Vy ZmFjZV90PiBjcmVhdGVTdXJmYWNlRm9yQmFja2luZ1N0b3JlKEVjb3JlX0V2YXMqIGVlKQpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc3VyZmFjZXMvR0xUcmFu c3BvcnRTdXJmYWNlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3N1cmZh Y2VzL0dMVHJhbnNwb3J0U3VyZmFjZS5jcHAKaW5kZXggYzY0Nzk1Y2Y1NzU0MDFkNDdkYmJiMzFh MWYwNGJiYTI4OGNlNzUwYS4uZDEwM2U1YmVlZmYwYzZlNDM2YjE5MWNiMjcwODUyMWU3Nzc1NTg0 MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc3VyZmFjZXMv R0xUcmFuc3BvcnRTdXJmYWNlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9zdXJmYWNlcy9HTFRyYW5zcG9ydFN1cmZhY2UuY3BwCkBAIC01Myw3ICs1Myw3IEBAIHN0 ZDo6dW5pcXVlX3B0cjxHTFRyYW5zcG9ydFN1cmZhY2U+IEdMVHJhbnNwb3J0U3VyZmFjZTo6Y3Jl YXRlVHJhbnNwb3J0U3VyZmFjZShjCiAjZW5kaWYKIAogICAgIGlmIChzdXJmYWNlICYmIHN1cmZh Y2UtPmhhbmRsZSgpICYmIHN1cmZhY2UtPmRyYXdhYmxlKCkpCi0gICAgICAgIHJldHVybiBXVEZN b3ZlKHN1cmZhY2UpOworICAgICAgICByZXR1cm4gc3VyZmFjZTsKIAogICAgIHJldHVybiBudWxs cHRyOwogfQpAQCAtMjIwLDcgKzIyMCw3IEBAIHN0ZDo6dW5pcXVlX3B0cjxHTFRyYW5zcG9ydFN1 cmZhY2VDbGllbnQ+IEdMVHJhbnNwb3J0U3VyZmFjZUNsaWVudDo6Y3JlYXRlVHJhbnNwCiAgICAg ICAgIHJldHVybiBudWxscHRyOwogICAgIH0KIAotICAgIHJldHVybiBXVEZNb3ZlKGNsaWVudCk7 CisgICAgcmV0dXJuIGNsaWVudDsKIH0KIAogCg==