154384 2016-02-17 22:23:01 -0800 Web Inspector: Option-clicking on the a CSS property sometimes doesn't work 2016-02-26 09:15:09 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 nvasilyev hi bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1165926 0 nvasilyev 2016-02-17 22:23:01 -0800 Exceptions: [Error] Assertion Failed _associateRelatedProperties (DOMNodeStyles.js:906) _updateStyleCascade (DOMNodeStyles.js:796) fetchedInlineStyles (DOMNodeStyles.js:140) fetchedInlineStyles _dispatchResponseToCallback (InspectorBackend.js:297) _dispatchResponse (InspectorBackend.js:270) dispatch (InspectorBackend.js:149) dispatchNextQueuedMessageFromBackend (MessageDispatcher.js:42) [Error] Assertion Failed tokenTrackingControllerHighlightedRangeWasClicked (CSSStyleDeclarationTextEditor.js:1631) _mouseButtonWasReleasedOverEditor (CodeMirrorTokenTrackingController.js:404:90) handleEvent (CodeMirrorTokenTrackingController.js:255) This bug has been around for a long time, it isn't a regression from Bug 154082. 1165927 1 webkit-bug-importer 2016-02-17 22:23:24 -0800 <rdar://problem/24714755> 1165936 2 nvasilyev 2016-02-17 22:30:06 -0800 Steps: 1. Open Elements tab 2. In the styles sidebar, select "Styles - Rules" 3. Select some element that has CSS rules 4. Option-click on a CSS property, Resources tab should open 5. Go back to Elements tab 6. Option-Click on the same property Expected: Resource tab opens again. Actual: Nothing happens. An exception is thrown. Notes: Option-clicking on a CSS variable, e.g. var(--border-color), has the same problem. 1166307 3 nvasilyev 2016-02-18 21:19:41 -0800 Devin, you're probably the best person to know what's going on in there. 1168435 4 272308 hi 2016-02-25 23:48:31 -0800 Created attachment 272308 Patch 1168438 5 nvasilyev 2016-02-25 23:59:38 -0800 (In reply to comment #4) > Created attachment 272308 [details] > Patch I can confirm this fixes the bug. Good job! 1168522 6 272308 commit-queue 2016-02-26 09:15:05 -0800 Comment on attachment 272308 Patch Clearing flags on attachment: 272308 Committed r197169: <http://trac.webkit.org/changeset/197169> 1168523 7 commit-queue 2016-02-26 09:15:09 -0800 All reviewed patches have been landed. Closing bug. 272308 2016-02-25 23:48:31 -0800 2016-02-26 09:15:05 -0800 Patch bug-154384-20160226004815.patch text/plain 2057 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGVmMzE1ZGFkN2M0OGNmODJmZWQ0OTBiZDRhYzEx NmFhNDI4NzAzZDguLmMzOTA5ZDYzMmM5ZmZmYjM1ZWMwZDI5NWUyMWE3YWEyMzRiZmMyZTcgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE2LTAyLTI1ICBEZXZp biBSb3Vzc28gIDxkY3JvdXNzbyt3ZWJraXRAZ21haWwuY29tPgorCisgICAgICAgIFdlYiBJbnNw ZWN0b3I6IE9wdGlvbi1jbGlja2luZyBvbiB0aGUgYSBDU1MgcHJvcGVydHkgc29tZXRpbWVzIGRv ZXNuJ3Qgd29yaworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTU0Mzg0CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8yNDcxNDc1NT4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJdCBzZWVtcyBhcyB0aG91Z2gg dGhlcmUgd2VyZSByYWNlIGNvbmRpdGlvbnMgYmV0d2VlbiBDb2RlTWlycm9yJ3MgZXZlbnQKKyAg ICAgICAgYW5kIHRoZSBuYXRpdmUgbW91c2Vtb3ZlIHN1Y2ggdGhhdCBpZiBDb2RlTWlycm9yIGZp cmVkIHNlY29uZCwgdGhlIGN1cnJlbnQKKyAgICAgICAgY2FuZGlkYXRlIHdhcyBjbGVhcmVkLCBh bmQgd291bGQgbm90IHJlc2V0IGl0c2VsZiB1bnRpbCB0aGUgY3Vyc29yIHdhcworICAgICAgICBt b3ZlZCwgYXQgd2hpY2ggcG9pbnQgdGhlIHNhbWUgaXNzdWUgY291bGQgaGFwcGVuLiBUbyBmaXgg dGhpcywgdGhlIGN1cnJlbnQKKyAgICAgICAgY2FuZGlkYXRlIGlzIG5vIGxvbmdlciBjbGVhcmVk IGJ5IENvZGVNaXJyb3IncyBldmVudCBhbmQgaXMgaW5zdGVhZCBvbmx5CisgICAgICAgIG1vZGlm aWVkIGJ5IHRoZSBuYXRpdmUgbW91c2UtZXZlbnRzLgorCisgICAgICAgICogVXNlckludGVyZmFj ZS9Db250cm9sbGVycy9Db2RlTWlycm9yVG9rZW5UcmFja2luZ0NvbnRyb2xsZXIuanM6CisgICAg ICAgIChXZWJJbnNwZWN0b3IuQ29kZU1pcnJvclRva2VuVHJhY2tpbmdDb250cm9sbGVyLnByb3Rv dHlwZS5faGlkZVBvcG92ZXIpOgorCiAyMDE2LTAyLTI1ICBOaWtpdGEgVmFzaWx5ZXYgIDxudmFz aWx5ZXZAYXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IFVuaWZ5IHNlbGVjdGVk IGl0ZW0gY29sb3JzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVy ZmFjZS9Db250cm9sbGVycy9Db2RlTWlycm9yVG9rZW5UcmFja2luZ0NvbnRyb2xsZXIuanMgYi9T b3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Db250cm9sbGVycy9Db2RlTWlycm9y VG9rZW5UcmFja2luZ0NvbnRyb2xsZXIuanMKaW5kZXggMGM5ZWRjYWI3OGM3NTNmZjM1M2RmYmU4 MjlkNzBiOTg1ODJmOTRmZC4uYjI2M2NhODJiNzgwOGY2MDdiNDEyYmMxMzU3ODNlMmNiYjUxZGRi ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQ29udHJv bGxlcnMvQ29kZU1pcnJvclRva2VuVHJhY2tpbmdDb250cm9sbGVyLmpzCisrKyBiL1NvdXJjZS9X ZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0NvbnRyb2xsZXJzL0NvZGVNaXJyb3JUb2tlblRy YWNraW5nQ29udHJvbGxlci5qcwpAQCAtMjc2LDggKzI3Niw2IEBAIFdlYkluc3BlY3Rvci5Db2Rl TWlycm9yVG9rZW5UcmFja2luZ0NvbnRyb2xsZXIgPSBjbGFzcyBDb2RlTWlycm9yVG9rZW5UcmFj a2luZ0NvCiAgICAgICAgICAgICBjb25zdCBmb3JjZUhpZGVQb3BvdmVyID0gdHJ1ZTsKICAgICAg ICAgICAgIHRoaXMuX2RlbGVnYXRlLnRva2VuVHJhY2tpbmdDb250cm9sbGVySGlnaGxpZ2h0ZWRS YW5nZVJlbGVhc2VkKHRoaXMsIGZvcmNlSGlkZVBvcG92ZXIpOwogICAgICAgICB9Ci0KLSAgICAg ICAgdGhpcy5fY2FuZGlkYXRlID0gbnVsbDsKICAgICB9CiAKICAgICBfbW91c2VFbnRlcmVkKGV2 ZW50KQo=