15437 2007-10-09 07:50:10 -0700 XPath substring-after function is broken 2007-10-09 12:09:37 -0700 1 1 1 Unclassified WebKit XML 523.x (Safari 3) All All RESOLVED FIXED http://amachang.art-code.org/xpath_functional_test/ P2 Normal --- 15448 1 nanto ap oldest_to_newest 58155 0 nanto 2007-10-09 07:50:10 -0700 The substring-after function returns a substring begining at <length of search string>, instead of <length of search string> + <found index>. alert(document.evaluate("substring-after('abcde', 'd')", document, null, XPathResult.STRING_TYPE, null).stringValue); "e" in Gecko and Opera, "bcde" in WebKit. This is revealed in amachang's XPath test (see the URL field). 58161 1 16595 ap 2007-10-09 09:31:34 -0700 Created attachment 16595 proposed fix 58163 2 16595 mitz 2007-10-09 09:39:03 -0700 Comment on attachment 16595 proposed fix r=me 58170 3 ap 2007-10-09 12:09:37 -0700 Committed revision 26173 (feature branch). 16595 2007-10-09 09:31:34 -0700 2007-10-09 09:39:03 -0700 proposed fix 15437r1_patch.txt text/plain 7561 ap SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAyNjE3MCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMDctMTAtMDkgIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEB3ZWJr aXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IGh0dHA6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1NDM3CisgICAgICAgIFhQ YXRoIHN1YnN0cmluZy1hZnRlciBmdW5jdGlvbiBpcyBicm9rZW4KKworICAgICAgICBUZXN0OiBm YXN0L3hwYXRoL3N1YnN0cmluZy1hZnRlci5odG1sCisKKyAgICAgICAgKiB4bWwvWFBhdGhGdW5j dGlvbnMuY3BwOgorICAgICAgICAoV2ViQ29yZTo6WFBhdGg6OkZ1blN1YnN0cmluZ0FmdGVyOjpl dmFsdWF0ZSk6IEZpeCBpdCBmb3IgcmVhbCB0aGlzIHRpbWUsIGhvcGVmdWxseS4KKwogMjAwNy0x MC0wOSAgUm9iIEJ1aXMgIDxidWlzQGtkZS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTWFj aWVqLgpJbmRleDogV2ViQ29yZS94bWwvWFBhdGhGdW5jdGlvbnMuY3BwCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFdlYkNvcmUveG1sL1hQYXRoRnVuY3Rpb25zLmNwcAkocmV2aXNpb24gMjYxNzApCisrKyBXZWJD b3JlL3htbC9YUGF0aEZ1bmN0aW9ucy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQ0MSwxNCArNDQx LDExIEBAIFZhbHVlIEZ1blN1YnN0cmluZ0FmdGVyOjpldmFsdWF0ZSgpIGNvbnMKICAgICBTdHJp bmcgczEgPSBhcmcoMCktPmV2YWx1YXRlKCkudG9TdHJpbmcoKTsKICAgICBTdHJpbmcgczIgPSBh cmcoMSktPmV2YWx1YXRlKCkudG9TdHJpbmcoKTsKIAotICAgIGlmIChzMi5pc0VtcHR5KCkpCi0g ICAgICAgIHJldHVybiBzMjsKLQogICAgIGludCBpID0gczEuZmluZChzMik7CiAgICAgaWYgKGkg PT0gLTEpCiAgICAgICAgIHJldHVybiAiIjsKIAotICAgIHJldHVybiBzMS5zdWJzdHJpbmcoczIu bGVuZ3RoKCkpOworICAgIHJldHVybiBzMS5zdWJzdHJpbmcoaSArIHMyLmxlbmd0aCgpKTsKIH0K IAogVmFsdWUgRnVuU3Vic3RyaW5nOjpldmFsdWF0ZSgpIGNvbnN0CkluZGV4OiBMYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lv biAyNjE3MCkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE3IEBACisyMDA3LTEwLTA5ICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAd2Via2l0Lm9y Zz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBodHRw Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTQzNworICAgICAgICBYUGF0aCBz dWJzdHJpbmctYWZ0ZXIgZnVuY3Rpb24gaXMgYnJva2VuCisKKyAgICAgICAgKiBmYXN0L3hwYXRo L3N1YnN0cmluZy1hZnRlci1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZhc3QveHBh dGgvc3Vic3RyaW5nLWFmdGVyLmh0bWw6IEFkZGVkLgorCisgICAgICAgICogZmFzdC94cGF0aC80 WFBhdGgvQ29yZS90ZXN0X2NvcmVfZnVuY3Rpb25zLWV4cGVjdGVkLnR4dDoKKyAgICAgICAgKiBm YXN0L3hwYXRoLzRYUGF0aC9Db3JlL3Rlc3RfY29yZV9mdW5jdGlvbnMuaHRtbDoKKyAgICAgICAg Rml4ZWQgYW4gaW5jb3JyZWN0IHRlc3QgKG5vdCBzdXJlIHdoYXQgbWFkZSBtZSB0aGluayB0aGF0 IGl0IHdhcyByaWdodCkuCisKIDIwMDctMTAtMDkgIFJvYiBCdWlzICA8YnVpc0BrZGUub3JnPgog CiAgICAgICAgIFJldmlld2VkIGJ5IE1hY2llai4KSW5kZXg6IExheW91dFRlc3RzL2Zhc3QveHBh dGgvc3Vic3RyaW5nLWFmdGVyLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0 cy9mYXN0L3hwYXRoL3N1YnN0cmluZy1hZnRlci1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCisr KyBMYXlvdXRUZXN0cy9mYXN0L3hwYXRoL3N1YnN0cmluZy1hZnRlci1leHBlY3RlZC50eHQJKHJl dmlzaW9uIDApCkBAIC0wLDAgKzEsMTEgQEAKK1Rlc3QgZm9yIGJ1ZyAxNTQzNzogWFBhdGggc3Vi c3RyaW5nLWFmdGVyIGZ1bmN0aW9uIGlzIGJyb2tlbi4KKworUEFTUyBkb2N1bWVudC5ldmFsdWF0 ZSgic3Vic3RyaW5nLWFmdGVyKCdhYmNkZScsICdkJykiLCBkb2N1bWVudCwgbnVsbCwgWFBhdGhS ZXN1bHQuU1RSSU5HX1RZUEUsIG51bGwpLnN0cmluZ1ZhbHVlIGlzICdlJworUEFTUyBkb2N1bWVu dC5ldmFsdWF0ZSgic3Vic3RyaW5nLWFmdGVyKCdhYmNkZScsICdmJykiLCBkb2N1bWVudCwgbnVs bCwgWFBhdGhSZXN1bHQuU1RSSU5HX1RZUEUsIG51bGwpLnN0cmluZ1ZhbHVlIGlzICcnCitQQVNT IGRvY3VtZW50LmV2YWx1YXRlKCJzdWJzdHJpbmctYWZ0ZXIoJ2FiY2RlJywgJycpIiwgZG9jdW1l bnQsIG51bGwsIFhQYXRoUmVzdWx0LlNUUklOR19UWVBFLCBudWxsKS5zdHJpbmdWYWx1ZSBpcyAn YWJjZGUnCitQQVNTIGRvY3VtZW50LmV2YWx1YXRlKCJzdWJzdHJpbmctYWZ0ZXIoJzE5OTkvMDQv MDEnLCAnLycpIiwgZG9jdW1lbnQsIG51bGwsIFhQYXRoUmVzdWx0LlNUUklOR19UWVBFLCBudWxs KS5zdHJpbmdWYWx1ZSBpcyAnMDQvMDEnCitQQVNTIGRvY3VtZW50LmV2YWx1YXRlKCJzdWJzdHJp bmctYWZ0ZXIoJzE5OTkvMDQvMDEnLCAnMTknKSIsIGRvY3VtZW50LCBudWxsLCBYUGF0aFJlc3Vs dC5TVFJJTkdfVFlQRSwgbnVsbCkuc3RyaW5nVmFsdWUgaXMgJzk5LzA0LzAxJworUEFTUyBzdWNj ZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQorCitURVNUIENPTVBMRVRFCisKClByb3BlcnR5IGNoYW5n ZXMgb246IExheW91dFRlc3RzL2Zhc3QveHBhdGgvc3Vic3RyaW5nLWFmdGVyLWV4cGVjdGVkLnR4 dApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCk5hbWU6IHN2bjptaW1lLXR5cGUKICAgKyB0ZXh0L3BsYWluCk5hbWU6IHN2 bjplb2wtc3R5bGUKICAgKyBuYXRpdmUKCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L3hwYXRoL3N1 YnN0cmluZy1hZnRlci5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QveHBhdGgv c3Vic3RyaW5nLWFmdGVyLmh0bWwJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L3hw YXRoL3N1YnN0cmluZy1hZnRlci5odG1sCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDI0IEBACis8 IURPQ1RZUEUgSFRNTCBQVUJMSUMgIi0vL0lFVEYvL0RURCBIVE1MLy9FTiI+Cis8aHRtbD4KKzxo ZWFkPgorPGxpbmsgcmVsPSJzdHlsZXNoZWV0IiBocmVmPSIuLi9qcy9yZXNvdXJjZXMvanMtdGVz dC1zdHlsZS5jc3MiPgorPHNjcmlwdCBzcmM9Ii4uL2pzL3Jlc291cmNlcy9qcy10ZXN0LXByZS5q cyI+PC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9keT4KKzxwPlRlc3QgZm9yIDxhIGhyZWY9Imh0dHA6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1NDM3Ij5idWcgMTU0Mzc8L2E+Ogor WFBhdGggc3Vic3RyaW5nLWFmdGVyIGZ1bmN0aW9uIGlzIGJyb2tlbi48L3A+Cis8ZGl2IGlkPSJj b25zb2xlIj48L2Rpdj4KKworPHNjcmlwdD4KKyAgICBzaG91bGRCZSgiZG9jdW1lbnQuZXZhbHVh dGUoXCJzdWJzdHJpbmctYWZ0ZXIoJ2FiY2RlJywgJ2QnKVwiLCBkb2N1bWVudCwgbnVsbCwgWFBh dGhSZXN1bHQuU1RSSU5HX1RZUEUsIG51bGwpLnN0cmluZ1ZhbHVlIiwgIidlJyIpOworICAgIHNo b3VsZEJlKCJkb2N1bWVudC5ldmFsdWF0ZShcInN1YnN0cmluZy1hZnRlcignYWJjZGUnLCAnZicp XCIsIGRvY3VtZW50LCBudWxsLCBYUGF0aFJlc3VsdC5TVFJJTkdfVFlQRSwgbnVsbCkuc3RyaW5n VmFsdWUiLCAiJyciKTsKKyAgICBzaG91bGRCZSgiZG9jdW1lbnQuZXZhbHVhdGUoXCJzdWJzdHJp bmctYWZ0ZXIoJ2FiY2RlJywgJycpXCIsIGRvY3VtZW50LCBudWxsLCBYUGF0aFJlc3VsdC5TVFJJ TkdfVFlQRSwgbnVsbCkuc3RyaW5nVmFsdWUiLCAiJ2FiY2RlJyIpOworICAgIHNob3VsZEJlKCJk b2N1bWVudC5ldmFsdWF0ZShcInN1YnN0cmluZy1hZnRlcignMTk5OS8wNC8wMScsICcvJylcIiwg ZG9jdW1lbnQsIG51bGwsIFhQYXRoUmVzdWx0LlNUUklOR19UWVBFLCBudWxsKS5zdHJpbmdWYWx1 ZSIsICInMDQvMDEnIik7CisgICAgc2hvdWxkQmUoImRvY3VtZW50LmV2YWx1YXRlKFwic3Vic3Ry aW5nLWFmdGVyKCcxOTk5LzA0LzAxJywgJzE5JylcIiwgZG9jdW1lbnQsIG51bGwsIFhQYXRoUmVz dWx0LlNUUklOR19UWVBFLCBudWxsKS5zdHJpbmdWYWx1ZSIsICInOTkvMDQvMDEnIik7CisKKyAg ICB2YXIgc3VjY2Vzc2Z1bGx5UGFyc2VkID0gdHJ1ZTsKKworPC9zY3JpcHQ+Cis8c2NyaXB0IHNy Yz0iLi4vanMvcmVzb3VyY2VzL2pzLXRlc3QtcG9zdC5qcyI+PC9zY3JpcHQ+Cis8L2JvZHk+Cis8 L2h0bWw+CgpQcm9wZXJ0eSBjaGFuZ2VzIG9uOiBMYXlvdXRUZXN0cy9mYXN0L3hwYXRoL3N1YnN0 cmluZy1hZnRlci5odG1sCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KTmFtZTogc3ZuOm1pbWUtdHlwZQogICArIHRleHQv aHRtbAoKSW5kZXg6IExheW91dFRlc3RzL2Zhc3QveHBhdGgvNFhQYXRoL0NvcmUvdGVzdF9jb3Jl X2Z1bmN0aW9ucy1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC94 cGF0aC80WFBhdGgvQ29yZS90ZXN0X2NvcmVfZnVuY3Rpb25zLWV4cGVjdGVkLnR4dAkocmV2aXNp b24gMjYxNzApCisrKyBMYXlvdXRUZXN0cy9mYXN0L3hwYXRoLzRYUGF0aC9Db3JlL3Rlc3RfY29y ZV9mdW5jdGlvbnMtZXhwZWN0ZWQudHh0CSh3b3JraW5nIGNvcHkpCkBAIC0yMyw3ICsyMyw3IEBA IFBBU1MgRE9NLmV2YWx1YXRlKCJjb250YWlucygvL0NISUxEMSwgJycKIFBBU1MgRE9NLmV2YWx1 YXRlKCJzdWJzdHJpbmctYmVmb3JlKCczLjE0SGknLCAnSGknKSIsIENISUxEMSwgbnVsbCwgWFBh dGhSZXN1bHQuQU5ZX1RZUEUsIG51bGwpLnN0cmluZ1ZhbHVlIGlzICIzLjE0IgogUEFTUyBET00u ZXZhbHVhdGUoInN1YnN0cmluZy1iZWZvcmUoJzMuMTRIaScsICcnKSIsIENISUxEMSwgbnVsbCwg WFBhdGhSZXN1bHQuQU5ZX1RZUEUsIG51bGwpLnN0cmluZ1ZhbHVlIGlzICIiCiBQQVNTIERPTS5l dmFsdWF0ZSgic3Vic3RyaW5nLWFmdGVyKCczLjE0SGknLCAnMy4xNCcpIiwgQ0hJTEQxLCBudWxs LCBYUGF0aFJlc3VsdC5BTllfVFlQRSwgbnVsbCkuc3RyaW5nVmFsdWUgaXMgIkhpIgotUEFTUyBE T00uZXZhbHVhdGUoInN1YnN0cmluZy1hZnRlcignMy4xNEhpJywgJycpIiwgQ0hJTEQxLCBudWxs LCBYUGF0aFJlc3VsdC5BTllfVFlQRSwgbnVsbCkuc3RyaW5nVmFsdWUgaXMgIiIKK1BBU1MgRE9N LmV2YWx1YXRlKCJzdWJzdHJpbmctYWZ0ZXIoJzMuMTRIaScsICcnKSIsIENISUxEMSwgbnVsbCwg WFBhdGhSZXN1bHQuQU5ZX1RZUEUsIG51bGwpLnN0cmluZ1ZhbHVlIGlzICIzLjE0SGkiCiBQQVNT IERPTS5ldmFsdWF0ZSgic3Vic3RyaW5nKCczLjE0SGknLCAnMy4xNCcpIiwgQ0hJTEQxLCBudWxs LCBYUGF0aFJlc3VsdC5BTllfVFlQRSwgbnVsbCkuc3RyaW5nVmFsdWUgaXMgIjE0SGkiCiBQQVNT IERPTS5ldmFsdWF0ZSgic3Vic3RyaW5nKCczLjE0SGknLCAnMy4xNCcsIDEpIiwgQ0hJTEQxLCBu dWxsLCBYUGF0aFJlc3VsdC5BTllfVFlQRSwgbnVsbCkuc3RyaW5nVmFsdWUgaXMgIjEiCiBQQVNT IERPTS5ldmFsdWF0ZSgic3Vic3RyaW5nKCcxMjM0NScsIDIsIDMpIiwgQ0hJTEQxLCBudWxsLCBY UGF0aFJlc3VsdC5BTllfVFlQRSwgbnVsbCkuc3RyaW5nVmFsdWUgaXMgIjIzNCIKSW5kZXg6IExh eW91dFRlc3RzL2Zhc3QveHBhdGgvNFhQYXRoL0NvcmUvdGVzdF9jb3JlX2Z1bmN0aW9ucy5odG1s Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QveHBhdGgvNFhQYXRoL0NvcmUvdGVzdF9j b3JlX2Z1bmN0aW9ucy5odG1sCShyZXZpc2lvbiAyNjE3MCkKKysrIExheW91dFRlc3RzL2Zhc3Qv eHBhdGgvNFhQYXRoL0NvcmUvdGVzdF9jb3JlX2Z1bmN0aW9ucy5odG1sCSh3b3JraW5nIGNvcHkp CkBAIC01Nyw3ICs1Nyw3IEBACiAgICAgc2hvdWxkQmUoJ0RPTS5ldmFsdWF0ZSgic3Vic3RyaW5n LWJlZm9yZShcJzMuMTRIaVwnLCBcJ0hpXCcpIiwgQ0hJTEQxLCBudWxsLCBYUGF0aFJlc3VsdC5B TllfVFlQRSwgbnVsbCkuc3RyaW5nVmFsdWUnLCAnIjMuMTQiJyk7CiAgICAgc2hvdWxkQmUoJ0RP TS5ldmFsdWF0ZSgic3Vic3RyaW5nLWJlZm9yZShcJzMuMTRIaVwnLCBcJ1wnKSIsIENISUxEMSwg bnVsbCwgWFBhdGhSZXN1bHQuQU5ZX1RZUEUsIG51bGwpLnN0cmluZ1ZhbHVlJywgJyIiJyk7CiAg ICAgc2hvdWxkQmUoJ0RPTS5ldmFsdWF0ZSgic3Vic3RyaW5nLWFmdGVyKFwnMy4xNEhpXCcsIFwn My4xNFwnKSIsIENISUxEMSwgbnVsbCwgWFBhdGhSZXN1bHQuQU5ZX1RZUEUsIG51bGwpLnN0cmlu Z1ZhbHVlJywgJyJIaSInKTsKLSAgICBzaG91bGRCZSgnRE9NLmV2YWx1YXRlKCJzdWJzdHJpbmct YWZ0ZXIoXCczLjE0SGlcJywgXCdcJykiLCBDSElMRDEsIG51bGwsIFhQYXRoUmVzdWx0LkFOWV9U WVBFLCBudWxsKS5zdHJpbmdWYWx1ZScsICciIicpOworICAgIHNob3VsZEJlKCdET00uZXZhbHVh dGUoInN1YnN0cmluZy1hZnRlcihcJzMuMTRIaVwnLCBcJ1wnKSIsIENISUxEMSwgbnVsbCwgWFBh dGhSZXN1bHQuQU5ZX1RZUEUsIG51bGwpLnN0cmluZ1ZhbHVlJywgJyIzLjE0SGkiJyk7CiAgICAg c2hvdWxkQmUoJ0RPTS5ldmFsdWF0ZSgic3Vic3RyaW5nKFwnMy4xNEhpXCcsIFwnMy4xNFwnKSIs IENISUxEMSwgbnVsbCwgWFBhdGhSZXN1bHQuQU5ZX1RZUEUsIG51bGwpLnN0cmluZ1ZhbHVlJywg JyIxNEhpIicpOwogICAgIHNob3VsZEJlKCdET00uZXZhbHVhdGUoInN1YnN0cmluZyhcJzMuMTRI aVwnLCBcJzMuMTRcJywgMSkiLCBDSElMRDEsIG51bGwsIFhQYXRoUmVzdWx0LkFOWV9UWVBFLCBu dWxsKS5zdHJpbmdWYWx1ZScsICciMSInKTsKICAgICBzaG91bGRCZSgnRE9NLmV2YWx1YXRlKCJz dWJzdHJpbmcoXCcxMjM0NVwnLCAyLCAzKSIsIENISUxEMSwgbnVsbCwgWFBhdGhSZXN1bHQuQU5Z X1RZUEUsIG51bGwpLnN0cmluZ1ZhbHVlJywgJyIyMzQiJyk7Cg==