154360 2016-02-17 15:52:24 -0800 Web Inspector: Add Context menu separators to Styles sidebar 2016-02-17 19:57:25 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 hi hi bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1165774 0 hi 2016-02-17 15:52:24 -0800 The styles sidebar currently has a lot of different context menu items, such that it can sometimes be a bit overwhelming. We should add some separators to help break them into different groups. 1165775 1 webkit-bug-importer 2016-02-17 15:52:46 -0800 <rdar://problem/24709157> 1165776 2 webkit-bug-importer 2016-02-17 15:52:48 -0800 <rdar://problem/24709158> 1165790 3 271603 hi 2016-02-17 16:15:59 -0800 Created attachment 271603 Patch 1165792 4 271603 joepeck 2016-02-17 16:17:59 -0800 Comment on attachment 271603 Patch r=me 1165876 5 271603 commit-queue 2016-02-17 19:57:22 -0800 Comment on attachment 271603 Patch Clearing flags on attachment: 271603 Committed r196739: <http://trac.webkit.org/changeset/196739> 1165877 6 commit-queue 2016-02-17 19:57:25 -0800 All reviewed patches have been landed. Closing bug. 271603 2016-02-17 16:15:59 -0800 2016-02-17 19:57:22 -0800 Patch bug-154360-20160217161539.patch text/plain 4009 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGQ0ODg5NzE1MjliOGE1YmE2Nzk2YTUxNDMzZGFj YzhhNmMxMDdlYmYuLjlmNGRjMzM3YzdlMTc1OWRhOTA5ODRlMTljYzMyNDdmZTZkMTA1MzQgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDE2LTAyLTE3ICBEZXZp biBSb3Vzc28gIDxkY3JvdXNzbyt3ZWJraXRAZ21haWwuY29tPgorCisgICAgICAgIFdlYiBJbnNw ZWN0b3I6IEFkZCBDb250ZXh0IG1lbnUgc2VwYXJhdG9ycyB0byBTdHlsZXMgc2lkZWJhcgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU0MzYwCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSW4gdGhlIFN0eWxl cyBzaWRlYmFyLCB0aGVyZSBhcmUgdGhyZWUgbWFpbiBzZWN0aW9ucyBmb3IgdGhlIGNvbnRleHQg bWVudToKKyAgICAgICAgLSBDb3B5IGFuZCBEdXBsaWNhdGUvU2hvdy1zb3VyY2UKKyAgICAgICAg LSBBZGQgcHNldWRvLWNsYXNzIHJ1bGVzCisgICAgICAgIC0gQWRkL1NlbGVjdCBwc2V1ZG8tZWxl bWVudCBydWxlcworICAgICAgICBUaGVzZSB0aHJlZSBzZWN0aW9ucyB3ZXJlIGFsbCBwdXQgdG9n ZXRoZXIgaW4gdGhlIHNhbWUgY29udGV4dCBtZW51LCB3aGljaAorICAgICAgICB3YXMgdmVyeSBj cm93ZGVkIGFzIGEgcmVzdWx0LiBTZXBhcmF0b3JzIGhhdmUgYmVlbiBhZGRlZCB0byBtYWtlIGl0 IHNvIHRoYXQKKyAgICAgICAgdGhlc2UgdGhyZWUgc2VjdGlvbnMgYXJlIG5vdyBzZXBhcmF0ZWQg YW5kIGNsZWFybHkgc2hvdyB0aGVpciBkaWZmZXJlbnQgdXNlcy4KKworICAgICAgICAqIFVzZXJJ bnRlcmZhY2UvVmlld3MvQ1NTU3R5bGVEZWNsYXJhdGlvblNlY3Rpb24uanM6CisgICAgICAgIChX ZWJJbnNwZWN0b3IuQ1NTU3R5bGVEZWNsYXJhdGlvblNlY3Rpb24ucHJvdG90eXBlLl9oYW5kbGVT ZWxlY3RvclBhc3RlKToKKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvVmlzdWFsU3R5 bGVTZWxlY3RvclRyZWVJdGVtLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlZpc3VhbFN0eWxl U2VsZWN0b3JUcmVlSXRlbS5wcm90b3R5cGUuX2hhbmRsZUNvbnRleHRNZW51RXZlbnQpOgorCiAy MDE2LTAyLTE3ICBNYXR0IEJha2VyICA8bWF0dGJha2VyQGFwcGxlLmNvbT4KIAogICAgICAgICBX ZWIgSW5zcGVjdG9yOiBhZGQgQ1NTIHZhcmlhYmxlcyBmb3IgY29tbW9uIGJvcmRlci9iYWNrZ3Jv dW5kIGNvbG9ycwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZh Y2UvVmlld3MvQ1NTU3R5bGVEZWNsYXJhdGlvblNlY3Rpb24uanMgYi9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9DU1NTdHlsZURlY2xhcmF0aW9uU2VjdGlvbi5qcwpp bmRleCA2NGUwOWQwMjAzNmU0NTc3ZTZmM2Q0MzcwOTU1ZGJhNzI3NDRmYzU1Li42MWJmMzEyZTk5 NDFmYzNlOGI1NmI3NjIyZmQxOTY5M2FlNDk4YjhmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5z cGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9DU1NTdHlsZURlY2xhcmF0aW9uU2VjdGlvbi5q cworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9DU1NTdHls ZURlY2xhcmF0aW9uU2VjdGlvbi5qcwpAQCAtNDYzLDYgKzQ2Myw4IEBAIFdlYkluc3BlY3Rvci5D U1NTdHlsZURlY2xhcmF0aW9uU2VjdGlvbiA9IGNsYXNzIENTU1N0eWxlRGVjbGFyYXRpb25TZWN0 aW9uIGV4dGVuCiAgICAgICAgICAgICByZXR1cm47CiAKICAgICAgICAgaWYgKFdlYkluc3BlY3Rv ci5DU1NTdHlsZU1hbmFnZXIuRm9yY2VhYmxlUHNldWRvQ2xhc3Nlcy5ldmVyeSgoY2xhc3NOYW1l KSA9PiAhdGhpcy5fc3R5bGUuc2VsZWN0b3JUZXh0LmluY2x1ZGVzKCI6IiArIGNsYXNzTmFtZSkp KSB7CisgICAgICAgICAgICBjb250ZXh0TWVudS5hcHBlbmRTZXBhcmF0b3IoKTsKKwogICAgICAg ICAgICAgZm9yIChsZXQgcHNldWRvQ2xhc3Mgb2YgV2ViSW5zcGVjdG9yLkNTU1N0eWxlTWFuYWdl ci5Gb3JjZWFibGVQc2V1ZG9DbGFzc2VzKSB7CiAgICAgICAgICAgICAgICAgaWYgKHBzZXVkb0Ns YXNzID09PSAidmlzaXRlZCIgJiYgdGhpcy5fc3R5bGUubm9kZS5ub2RlTmFtZSgpICE9PSAiQSIp CiAgICAgICAgICAgICAgICAgICAgIGNvbnRpbnVlOwpAQCAtNDg2LDYgKzQ4OCw4IEBAIFdlYklu c3BlY3Rvci5DU1NTdHlsZURlY2xhcmF0aW9uU2VjdGlvbiA9IGNsYXNzIENTU1N0eWxlRGVjbGFy YXRpb25TZWN0aW9uIGV4dGVuCiAgICAgICAgICAgICB9CiAgICAgICAgIH0KIAorICAgICAgICBj b250ZXh0TWVudS5hcHBlbmRTZXBhcmF0b3IoKTsKKwogICAgICAgICBmb3IgKGxldCBwc2V1ZG9F bGVtZW50IG9mIFdlYkluc3BlY3Rvci5DU1NTdHlsZU1hbmFnZXIuUHNldWRvRWxlbWVudE5hbWVz KSB7CiAgICAgICAgICAgICBsZXQgcHNldWRvRWxlbWVudFNlbGVjdG9yID0gIjo6IiArIHBzZXVk b0VsZW1lbnQ7CiAgICAgICAgICAgICBjb25zdCBzdHlsZVRleHQgPSAiY29udGVudDogXCJcIjsi OwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3Mv VmlzdWFsU3R5bGVTZWxlY3RvclRyZWVJdGVtLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1Vz ZXJJbnRlcmZhY2UvVmlld3MvVmlzdWFsU3R5bGVTZWxlY3RvclRyZWVJdGVtLmpzCmluZGV4IGRl NzY5NGYyYjNjOWI0MmY0NzBhZWFhMzZiY2M1ZmU5MjZkMGZiZTcuLmQ4YjZiOGQxNjc0NjcxOTcw MTM1ZTkwNDc0MzVkMTczM2JlNzEzOWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JV SS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1Zpc3VhbFN0eWxlU2VsZWN0b3JUcmVlSXRlbS5qcworKysg Yi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9WaXN1YWxTdHlsZVNl bGVjdG9yVHJlZUl0ZW0uanMKQEAgLTE2NCw2ICsxNjQsOCBAQCBXZWJJbnNwZWN0b3IuVmlzdWFs U3R5bGVTZWxlY3RvclRyZWVJdGVtID0gY2xhc3MgVmlzdWFsU3R5bGVTZWxlY3RvclRyZWVJdGVt IGV4dAogICAgICAgICAgICAgcmV0dXJuOwogCiAgICAgICAgIGlmIChXZWJJbnNwZWN0b3IuQ1NT U3R5bGVNYW5hZ2VyLkZvcmNlYWJsZVBzZXVkb0NsYXNzZXMuZXZlcnkoKGNsYXNzTmFtZSkgPT4g IXRoaXMucmVwcmVzZW50ZWRPYmplY3Quc2VsZWN0b3JUZXh0LmluY2x1ZGVzKCI6IiArIGNsYXNz TmFtZSkpKSB7CisgICAgICAgICAgICBjb250ZXh0TWVudS5hcHBlbmRTZXBhcmF0b3IoKTsKKwog ICAgICAgICAgICAgZm9yIChsZXQgcHNldWRvQ2xhc3Mgb2YgV2ViSW5zcGVjdG9yLkNTU1N0eWxl TWFuYWdlci5Gb3JjZWFibGVQc2V1ZG9DbGFzc2VzKSB7CiAgICAgICAgICAgICAgICAgaWYgKHBz ZXVkb0NsYXNzID09PSAidmlzaXRlZCIgJiYgdGhpcy5yZXByZXNlbnRlZE9iamVjdC5ub2RlLm5v ZGVOYW1lKCkgIT09ICJBIikKICAgICAgICAgICAgICAgICAgICAgY29udGludWU7CkBAIC0xNzgs NiArMTgwLDggQEAgV2ViSW5zcGVjdG9yLlZpc3VhbFN0eWxlU2VsZWN0b3JUcmVlSXRlbSA9IGNs YXNzIFZpc3VhbFN0eWxlU2VsZWN0b3JUcmVlSXRlbSBleHQKICAgICAgICAgICAgIH0KICAgICAg ICAgfQogCisgICAgICAgIGNvbnRleHRNZW51LmFwcGVuZFNlcGFyYXRvcigpOworCiAgICAgICAg IGZvciAobGV0IHBzZXVkb0VsZW1lbnQgb2YgV2ViSW5zcGVjdG9yLkNTU1N0eWxlTWFuYWdlci5Q c2V1ZG9FbGVtZW50TmFtZXMpIHsKICAgICAgICAgICAgIGxldCBwc2V1ZG9FbGVtZW50U2VsZWN0 b3IgPSAiOjoiICsgcHNldWRvRWxlbWVudDsKICAgICAgICAgICAgIGNvbnN0IHN0eWxlVGV4dCA9 ICJjb250ZW50OiBcIlwiOyI7Cg==