154335 2016-02-17 01:10:22 -0800 Web Inspector: Add singular and plural cases for "Ignore n times before stopping" label in breakpoint editor 2016-02-17 08:01:26 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 mattbaker mattbaker bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1165553 0 mattbaker 2016-02-17 01:10:22 -0800 * SUMMARY Add singular and plural cases for "Ignore n times before stopping" label in breakpoint editor. 1165554 1 mattbaker 2016-02-17 01:10:29 -0800 <rdar://problem/24655491> 1165557 2 271548 mattbaker 2016-02-17 01:45:52 -0800 Created attachment 271548 [Patch] Proposed Fix 1165580 3 271548 commit-queue 2016-02-17 08:01:22 -0800 Comment on attachment 271548 [Patch] Proposed Fix Clearing flags on attachment: 271548 Committed r196692: <http://trac.webkit.org/changeset/196692> 1165581 4 commit-queue 2016-02-17 08:01:26 -0800 All reviewed patches have been landed. Closing bug. 271548 2016-02-17 01:45:52 -0800 2016-02-17 08:01:22 -0800 [Patch] Proposed Fix bug-154335-20160217014533.patch text/plain 4260 mattbaker U3VidmVyc2lvbiBSZXZpc2lvbjogMTk2NjkwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCA0 ZTIxNWM2NjFhZGZmNTQ5M2ZhNGZkNjkwY2QzNDRlMThmZmZjZDgxLi45MGExYjkyOWUwNTc4MDY5 ZDhkN2Y4NGZjYjFjZTRlNTBjZGRkYzYwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyNCBAQAorMjAxNi0wMi0xNyAgTWF0dCBCYWtlciAgPG1hdHRiYWtlckBhcHBsZS5jb20+ CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogQWRkIHNpbmd1bGFyIGFuZCBwbHVyYWwgY2FzZXMg Zm9yICJJZ25vcmUgbiB0aW1lcyBiZWZvcmUgc3RvcHBpbmciIGxhYmVsIGluIGJyZWFrcG9pbnQg ZWRpdG9yCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x NTQzMzUKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzI0NjU1NDkxPgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogTG9jYWxpemF0aW9ucy9lbi5scHJv ai9sb2NhbGl6ZWRTdHJpbmdzLmpzOgorICAgICAgICBBZGRlZCBzdHJpbmcgZm9yIHNpbmd1bGFy IGlnbm9yZSBjb3VudC4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvQ29udHJvbGxlcnMvQnJl YWtwb2ludFBvcG92ZXJDb250cm9sbGVyLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkJyZWFr cG9pbnRQb3BvdmVyQ29udHJvbGxlci5wcm90b3R5cGUuX2NyZWF0ZVBvcG92ZXJDb250ZW50KToK KyAgICAgICAgUmVtb3ZlIHVudXNlZCB2YXJpYWJsZSAidGhpcy5faWdub3JlQ291bnQiIGFuZCB1 cGRhdGUgaWdub3JlIGNvdW50IHRleHQuCisKKyAgICAgICAgKFdlYkluc3BlY3Rvci5CcmVha3Bv aW50UG9wb3ZlckNvbnRyb2xsZXIucHJvdG90eXBlLl9wb3BvdmVySWdub3JlSW5wdXRDaGFuZ2Vk KToKKyAgICAgICAgVXBkYXRlIGlnbm9yZSBjb3VudCB0ZXh0IGFzIHZhbHVlIGNoYW5nZXMuCisK KyAgICAgICAgKFdlYkluc3BlY3Rvci5CcmVha3BvaW50UG9wb3ZlckNvbnRyb2xsZXIucHJvdG90 eXBlLl91cGRhdGVJZ25vcmVDb3VudFRleHQpOgorICAgICAgICBTZXQgc2luZ3VsYXIgdGV4dCB3 aGVuIGNvdW50ID09PSAxLCBvdGhlcndpc2Ugc2V0IHBsdXJhbCB0ZXh0LgorCiAyMDE2LTAyLTE2 ICBOaWtpdGEgVmFzaWx5ZXYgIDxudmFzaWx5ZXZAYXBwbGUuY29tPgogCiAgICAgICAgIFJFR1JF U1NJT04gKHIxOTY2MjApOiBXZWIgSW5zcGVjdG9yOiBTZWxlY3RpbmcgbGFzdCBtZXNzYWdlIGlu IHRoZSBjb25zb2xlIG1ha2VzIHRoZSBzY3JvbGxiYXIgdmlzaWJsZQpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkluc3BlY3RvclVJL0xvY2FsaXphdGlvbnMvZW4ubHByb2ovbG9jYWxpemVkU3RyaW5n cy5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Mb2NhbGl6YXRpb25zL2VuLmxwcm9qL2xvY2Fs aXplZFN0cmluZ3MuanMKaW5kZXggMzhlN2M0NjE5OGNiYTcxMGNjNjQ5YzlhN2M0ZjA4ZDgzNWIw OWM3ZC4uN2U3YTgyZGQ4NWJkM2M1NmY1MzYyZWI3MzBiYTFjZDRhZDIwY2QwMyAxMDA2NDQKR0lU IGJpbmFyeSBwYXRjaApkZWx0YSAzMgptY21YQE1uRHh2TylgbCZOUXY7QC00UGFFN3pCN1BQMipt USotVyRNWiRwYEBDM0pne04KCmRlbHRhIDE3ClpjbVhASmchUn5CKWBsJk5RdjxlMzJRbkhtMHN1 djAyMj1uNQoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNl L0NvbnRyb2xsZXJzL0JyZWFrcG9pbnRQb3BvdmVyQ29udHJvbGxlci5qcyBiL1NvdXJjZS9XZWJJ bnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0NvbnRyb2xsZXJzL0JyZWFrcG9pbnRQb3BvdmVyQ29u dHJvbGxlci5qcwppbmRleCA5ZmE2Y2ExNjA2NmM0ZjRmYTZiZTZiMTA2ZWZhOWJiODRmMTc2MDFl Li5kM2IyMTg3ODE0NWJhYmNjOTk4MmNkYzk2YmNjNmFlOGM1MTEzMTZhIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Db250cm9sbGVycy9CcmVha3BvaW50 UG9wb3ZlckNvbnRyb2xsZXIuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRl cmZhY2UvQ29udHJvbGxlcnMvQnJlYWtwb2ludFBvcG92ZXJDb250cm9sbGVyLmpzCkBAIC0xODAs MTMgKzE4MCwxNCBAQCBXZWJJbnNwZWN0b3IuQnJlYWtwb2ludFBvcG92ZXJDb250cm9sbGVyID0g Y2xhc3MgQnJlYWtwb2ludFBvcG92ZXJDb250cm9sbGVyIGV4dAogICAgICAgICAgICAgICAgIHRo aXMuX2lnbm9yZUNvdW50SW5wdXQuaWQgPSAiZWRpdC1icmVha3BvaW50LXBvcG92ZXItaWdub3Jl IjsKICAgICAgICAgICAgICAgICB0aGlzLl9pZ25vcmVDb3VudElucHV0LnR5cGUgPSAibnVtYmVy IjsKICAgICAgICAgICAgICAgICB0aGlzLl9pZ25vcmVDb3VudElucHV0Lm1pbiA9IDA7Ci0gICAg ICAgICAgICAgICAgdGhpcy5faWdub3JlQ291bnRJbnB1dC52YWx1ZSA9IHRoaXMuX2lnbm9yZUNv dW50IHx8IDA7CisgICAgICAgICAgICAgICAgdGhpcy5faWdub3JlQ291bnRJbnB1dC52YWx1ZSA9 IDA7CiAgICAgICAgICAgICAgICAgdGhpcy5faWdub3JlQ291bnRJbnB1dC5hZGRFdmVudExpc3Rl bmVyKCJjaGFuZ2UiLCB0aGlzLl9wb3BvdmVySWdub3JlSW5wdXRDaGFuZ2VkLmJpbmQodGhpcykp OwogCi0gICAgICAgICAgICAgICAgbGV0IGlnbm9yZUNvdW50VGV4dCA9IGlnbm9yZUNvdW50RGF0 YS5hcHBlbmRDaGlsZChkb2N1bWVudC5jcmVhdGVFbGVtZW50KCJzcGFuIikpOwogICAgICAgICAg ICAgICAgIGlnbm9yZUNvdW50TGFiZWwuc2V0QXR0cmlidXRlKCJmb3IiLCB0aGlzLl9pZ25vcmVD b3VudElucHV0LmlkKTsKICAgICAgICAgICAgICAgICBpZ25vcmVDb3VudExhYmVsLnRleHRDb250 ZW50ID0gV2ViSW5zcGVjdG9yLlVJU3RyaW5nKCJJZ25vcmUiKTsKLSAgICAgICAgICAgICAgICBp Z25vcmVDb3VudFRleHQudGV4dENvbnRlbnQgPSBXZWJJbnNwZWN0b3IuVUlTdHJpbmcoInRpbWVz IGJlZm9yZSBzdG9wcGluZyIpOworCisgICAgICAgICAgICAgICAgdGhpcy5faWdub3JlQ291bnRU ZXh0ID0gaWdub3JlQ291bnREYXRhLmFwcGVuZENoaWxkKGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQo InNwYW4iKSk7CisgICAgICAgICAgICAgICAgdGhpcy5fdXBkYXRlSWdub3JlQ291bnRUZXh0KCk7 CiAgICAgICAgICAgICB9CiAKICAgICAgICAgICAgIGxldCBhY3Rpb25Sb3cgPSB0YWJsZS5hcHBl bmRDaGlsZChkb2N1bWVudC5jcmVhdGVFbGVtZW50KCJ0ciIpKTsKQEAgLTI1OSw2ICsyNjAsOCBA QCBXZWJJbnNwZWN0b3IuQnJlYWtwb2ludFBvcG92ZXJDb250cm9sbGVyID0gY2xhc3MgQnJlYWtw b2ludFBvcG92ZXJDb250cm9sbGVyIGV4dAogCiAgICAgICAgIHRoaXMuX2lnbm9yZUNvdW50SW5w dXQudmFsdWUgPSBpZ25vcmVDb3VudDsKICAgICAgICAgdGhpcy5fYnJlYWtwb2ludC5pZ25vcmVD b3VudCA9IGlnbm9yZUNvdW50OworCisgICAgICAgIHRoaXMuX3VwZGF0ZUlnbm9yZUNvdW50VGV4 dCgpOwogICAgIH0KIAogICAgIF9wb3BvdmVyVG9nZ2xlQXV0b0NvbnRpbnVlQ2hlY2tib3hDaGFu Z2VkKGV2ZW50KQpAQCAtMjk4LDYgKzMwMSwxNCBAQCBXZWJJbnNwZWN0b3IuQnJlYWtwb2ludFBv cG92ZXJDb250cm9sbGVyID0gY2xhc3MgQnJlYWtwb2ludFBvcG92ZXJDb250cm9sbGVyIGV4dAog ICAgICAgICB9CiAgICAgfQogCisgICAgX3VwZGF0ZUlnbm9yZUNvdW50VGV4dCgpCisgICAgewor ICAgICAgICBpZiAodGhpcy5fYnJlYWtwb2ludC5pZ25vcmVDb3VudCA9PT0gMSkKKyAgICAgICAg ICAgIHRoaXMuX2lnbm9yZUNvdW50VGV4dC50ZXh0Q29udGVudCA9IFdlYkluc3BlY3Rvci5VSVN0 cmluZygidGltZSBiZWZvcmUgc3RvcHBpbmciKTsKKyAgICAgICAgZWxzZQorICAgICAgICAgICAg dGhpcy5faWdub3JlQ291bnRUZXh0LnRleHRDb250ZW50ID0gV2ViSW5zcGVjdG9yLlVJU3RyaW5n KCJ0aW1lcyBiZWZvcmUgc3RvcHBpbmciKTsKKyAgICB9CisKICAgICBicmVha3BvaW50QWN0aW9u Vmlld0FwcGVuZEFjdGlvblZpZXcoYnJlYWtwb2ludEFjdGlvblZpZXcsIG5ld0FjdGlvbikKICAg ICB7CiAgICAgICAgIGxldCBuZXdCcmVha3BvaW50QWN0aW9uVmlldyA9IG5ldyBXZWJJbnNwZWN0 b3IuQnJlYWtwb2ludEFjdGlvblZpZXcobmV3QWN0aW9uLCB0aGlzKTsK