154334 2016-02-17 00:59:19 -0800 JSDOMWindow::put should not do the same thing twice in different ways 2016-02-17 11:26:37 -0800 1 1 1 Unclassified WebKit Bindings Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 barraclough barraclough commit-queue keith_miller mark.lam msaboff saam oldest_to_newest 1165549 0 barraclough 2016-02-17 00:59:19 -0800 It either calls JSGlobalObject::put or Base::put. Hint: these are basically the same thing. In the latter case it might call lookupPut. That's redundant; JSObject::put handles static table entries. 1165550 1 271547 barraclough 2016-02-17 01:04:34 -0800 Created attachment 271547 Fix 1165551 2 barraclough 2016-02-17 01:05:15 -0800 All red patch! Whoooo! 1165590 3 271547 cdumez 2016-02-17 08:45:37 -0800 Comment on attachment 271547 Fix r=me 1165645 4 barraclough 2016-02-17 11:26:37 -0800 Transmitting file data .... Committed revision 196702. 271547 2016-02-17 01:04:34 -0800 2016-02-17 08:45:37 -0800 Fix 154334.1.patch text/plain 4768 barraclough SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTk2NjkwKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBA CisyMDE2LTAyLTE3ICBHYXZpbiBCYXJyYWNsb3VnaCAgPGJhcnJhY2xvdWdoQGFwcGxlLmNvbT4K KworICAgICAgICBKU0RPTVdpbmRvdzo6cHV0IHNob3VsZCBub3QgZG8gdGhlIHNhbWUgdGhpbmcg dHdpY2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1 NDMzNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEl0 IGVpdGhlciBjYWxscyBKU0dsb2JhbE9iamVjdDo6cHV0IG9yIEJhc2U6OnB1dC4gSGludDogdGhl c2UgYXJlIGJhc2ljYWxseSB0aGUgc2FtZSB0aGluZy4KKyAgICAgICAgSW4gdGhlIGxhdHRlciBj YXNlIGl0IG1pZ2h0IGNhbGwgbG9va3VwUHV0LiBUaGF0J3MgcmVkdW5kYW50OyBKU09iamVjdDo6 cHV0IGhhbmRsZXMgc3RhdGljCisgICAgICAgIHRhYmxlIGVudHJpZXMuCisKKyAgICAgICAgKiBy dW50aW1lL0pTR2xvYmFsT2JqZWN0Lmg6CisgICAgICAgIChKU0M6OkpTR2xvYmFsT2JqZWN0Ojpo YXNPd25Qcm9wZXJ0eUZvcldyaXRlKTogRGVsZXRlZC4KKyAgICAgICAgICAgIC0gbm8gbG9uZ2Vy IG5lZWRlZC4KKwogMjAxNi0wMi0xNiAgRmlsaXAgUGl6bG8gIDxmcGl6bG9AYXBwbGUuY29tPgog CiAgICAgICAgIEZUTF9VU0VTX0IzIHNob3VsZCBiZSB1bmNvbmRpdGlvbmFsbHkgdHJ1ZQpJbmRl eDogU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNHbG9iYWxPYmplY3QuaAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU0dsb2JhbE9iamVjdC5oCShy ZXZpc2lvbiAxOTY2ODIpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU0dsb2Jh bE9iamVjdC5oCSh3b3JraW5nIGNvcHkpCkBAIC0zOTYsNyArMzk2LDYgQEAgcHVibGljOgogICAg IEpTX0VYUE9SVF9QUklWQVRFIHN0YXRpYyB2b2lkIHZpc2l0Q2hpbGRyZW4oSlNDZWxsKiwgU2xv dFZpc2l0b3ImKTsKIAogICAgIEpTX0VYUE9SVF9QUklWQVRFIHN0YXRpYyBib29sIGdldE93blBy b3BlcnR5U2xvdChKU09iamVjdCosIEV4ZWNTdGF0ZSosIFByb3BlcnR5TmFtZSwgUHJvcGVydHlT bG90Jik7Ci0gICAgYm9vbCBoYXNPd25Qcm9wZXJ0eUZvcldyaXRlKEV4ZWNTdGF0ZSosIFByb3Bl cnR5TmFtZSk7CiAgICAgSlNfRVhQT1JUX1BSSVZBVEUgc3RhdGljIHZvaWQgcHV0KEpTQ2VsbCos IEV4ZWNTdGF0ZSosIFByb3BlcnR5TmFtZSwgSlNWYWx1ZSwgUHV0UHJvcGVydHlTbG90Jik7CiAK ICAgICBKU19FWFBPUlRfUFJJVkFURSBzdGF0aWMgdm9pZCBkZWZpbmVHZXR0ZXIoSlNPYmplY3Qq LCBFeGVjU3RhdGUqLCBQcm9wZXJ0eU5hbWUsIEpTT2JqZWN0KiBnZXR0ZXJGdW5jLCB1bnNpZ25l ZCBhdHRyaWJ1dGVzKTsKQEAgLTcxNywxNSArNzE2LDYgQEAgaW5saW5lIEpTR2xvYmFsT2JqZWN0 KiBhc0dsb2JhbE9iamVjdChKUwogICAgIHJldHVybiBqc0Nhc3Q8SlNHbG9iYWxPYmplY3QqPihh c09iamVjdCh2YWx1ZSkpOwogfQogCi1pbmxpbmUgYm9vbCBKU0dsb2JhbE9iamVjdDo6aGFzT3du UHJvcGVydHlGb3JXcml0ZShFeGVjU3RhdGUqIGV4ZWMsIFByb3BlcnR5TmFtZSBwcm9wZXJ0eU5h bWUpCi17Ci0gICAgUHJvcGVydHlTbG90IHNsb3QodGhpcyk7Ci0gICAgaWYgKEJhc2U6OmdldE93 blByb3BlcnR5U2xvdCh0aGlzLCBleGVjLCBwcm9wZXJ0eU5hbWUsIHNsb3QpKQotICAgICAgICBy ZXR1cm4gdHJ1ZTsKLSAgICBib29sIHNsb3RJc1dyaXRlYWJsZTsKLSAgICByZXR1cm4gc3ltYm9s VGFibGVHZXQodGhpcywgcHJvcGVydHlOYW1lLCBzbG90LCBzbG90SXNXcml0ZWFibGUpOwotfQot CiBpbmxpbmUgSlNBcnJheSogY29uc3RydWN0RW1wdHlBcnJheShFeGVjU3RhdGUqIGV4ZWMsIEFy cmF5QWxsb2NhdGlvblByb2ZpbGUqIHByb2ZpbGUsIEpTR2xvYmFsT2JqZWN0KiBnbG9iYWxPYmpl Y3QsIHVuc2lnbmVkIGluaXRpYWxMZW5ndGggPSAwLCBKU1ZhbHVlIG5ld1RhcmdldCA9IEpTVmFs dWUoKSkKIHsKICAgICBTdHJ1Y3R1cmUqIHN0cnVjdHVyZTsKSW5kZXg6IFNvdXJjZS9XZWJDb3Jl L0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cJKHJldmlz aW9uIDE5NjY4MikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDIwIEBACisyMDE2LTAyLTE3ICBHYXZpbiBCYXJyYWNsb3VnaCAgPGJhcnJhY2xv dWdoQGFwcGxlLmNvbT4KKworICAgICAgICBKU0RPTVdpbmRvdzo6cHV0IHNob3VsZCBub3QgZG8g dGhlIHNhbWUgdGhpbmcgdHdpY2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE1NDMzNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIEl0IGVpdGhlciBjYWxscyBKU0dsb2JhbE9iamVjdDo6cHV0IG9yIEJhc2U6 OnB1dC4gSGludDogdGhlc2UgYXJlIGJhc2ljYWxseSB0aGUgc2FtZSB0aGluZy4KKyAgICAgICAg SW4gdGhlIGxhdHRlciBjYXNlIGl0IG1pZ2h0IGNhbGwgbG9va3VwUHV0LiBUaGF0J3MgcmVkdW5k YW50OyBKU09iamVjdDo6cHV0IGhhbmRsZXMgc3RhdGljCisgICAgICAgIHRhYmxlIGVudHJpZXMu CisKKyAgICAgICAgKiBiaW5kaW5ncy9qcy9KU0RPTVdpbmRvd0N1c3RvbS5jcHA6CisgICAgICAg IChXZWJDb3JlOjpKU0RPTVdpbmRvdzo6cHV0KToKKyAgICAgICAgICAgIC0ganVzdCBjYWxsIEJh c2U6OnB1dC4KKyAgICAgICAgKFdlYkNvcmU6OkpTRE9NV2luZG93OjpwdXRCeUluZGV4KToKKyAg ICAgICAgICAgIC0ganVzdCBjYWxsIEJhc2U6OnB1dEJ5SW5kZXguCisKIDIwMTYtMDItMTYgIEdh dmluIEJhcnJhY2xvdWdoICA8YmFycmFjbG91Z2hAYXBwbGUuY29tPgogCiAgICAgICAgIEpTRE9N V2luZG93OjpnZXRPd25Qcm9wZXJ0eVNsb3Qgc2hvdWxkIGp1c3QgY2FsbCBnZXRTdGF0aWNQcm9w ZXJ0eVNsb3QKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTRE9NV2luZG93Q3Vz dG9tLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0RPTVdp bmRvd0N1c3RvbS5jcHAJKHJldmlzaW9uIDE5NjY4MikKKysrIFNvdXJjZS9XZWJDb3JlL2JpbmRp bmdzL2pzL0pTRE9NV2luZG93Q3VzdG9tLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzU2LDE3ICsz NTYsNiBAQCB2b2lkIEpTRE9NV2luZG93OjpwdXQoSlNDZWxsKiBjZWxsLCBFeGVjCiAgICAgICAg IHJldHVybjsKICAgICB9CiAKLSAgICAvLyBPcHRpbWl6YXRpb246IGFjY2VzcyBKYXZhU2NyaXB0 IGdsb2JhbCB2YXJpYWJsZXMgZGlyZWN0bHkgYmVmb3JlIGludm9sdmluZyB0aGUgRE9NLgotICAg IGlmICh0aGlzT2JqZWN0LT5KU0dsb2JhbE9iamVjdDo6aGFzT3duUHJvcGVydHlGb3JXcml0ZShl eGVjLCBwcm9wZXJ0eU5hbWUpKSB7Ci0gICAgICAgIEpTR2xvYmFsT2JqZWN0OjpwdXQodGhpc09i amVjdCwgZXhlYywgcHJvcGVydHlOYW1lLCB2YWx1ZSwgc2xvdCk7Ci0gICAgICAgIHJldHVybjsK LSAgICB9Ci0KLSAgICBpZiAoIXRoaXNPYmplY3QtPnN0YXRpY0Z1bmN0aW9uc1JlaWZpZWQoKSkg ewotICAgICAgICBpZiAobG9va3VwUHV0KGV4ZWMsIHByb3BlcnR5TmFtZSwgdGhpc09iamVjdCwg dmFsdWUsICpzX2luZm8uc3RhdGljUHJvcEhhc2hUYWJsZSwgc2xvdCkpCi0gICAgICAgICAgICBy ZXR1cm47Ci0gICAgfQotCiAgICAgQmFzZTo6cHV0KHRoaXNPYmplY3QsIGV4ZWMsIHByb3BlcnR5 TmFtZSwgdmFsdWUsIHNsb3QpOwogfQogCkBAIC0zNzYsMTIgKzM2NSw2IEBAIHZvaWQgSlNET01X aW5kb3c6OnB1dEJ5SW5kZXgoSlNDZWxsKiBjZWwKICAgICBpZiAoIXRoaXNPYmplY3QtPndyYXBw ZWQoKS5mcmFtZSgpIHx8ICFCaW5kaW5nU2VjdXJpdHk6OnNob3VsZEFsbG93QWNjZXNzVG9ET01X aW5kb3coZXhlYywgdGhpc09iamVjdC0+d3JhcHBlZCgpKSkKICAgICAgICAgcmV0dXJuOwogICAg IAotICAgIC8vIE9wdGltaXphdGlvbjogYWNjZXNzIEphdmFTY3JpcHQgZ2xvYmFsIHZhcmlhYmxl cyBkaXJlY3RseSBiZWZvcmUgaW52b2x2aW5nIHRoZSBET00uCi0gICAgaWYgKHRoaXNPYmplY3Qt PkpTR2xvYmFsT2JqZWN0OjpoYXNPd25Qcm9wZXJ0eUZvcldyaXRlKGV4ZWMsIElkZW50aWZpZXI6 OmZyb20oZXhlYywgaW5kZXgpKSkgewotICAgICAgICBKU0dsb2JhbE9iamVjdDo6cHV0QnlJbmRl eCh0aGlzT2JqZWN0LCBleGVjLCBpbmRleCwgdmFsdWUsIHNob3VsZFRocm93KTsKLSAgICAgICAg cmV0dXJuOwotICAgIH0KLSAgICAKICAgICBCYXNlOjpwdXRCeUluZGV4KHRoaXNPYmplY3QsIGV4 ZWMsIGluZGV4LCB2YWx1ZSwgc2hvdWxkVGhyb3cpOwogfQogCg==