154292 2016-02-16 10:48:23 -0800 AX: Change "dialog" role description to "web dialog" so users can distinguish from native alerts 2016-06-19 09:57:22 -0700 1 1 1 Unclassified WebKit Accessibility Safari 9 All All NEW InRadar P2 Normal --- 1 jcraig webkit-unassigned aboxhall apinheiro cfleizach commit-queue dmazzoni jdiggs mario mitz n_wang samuel_white webkit-bug-importer oldest_to_newest 1165172 0 jcraig 2016-02-16 10:48:23 -0800 AX: Change "dialog" role description to "web dialog" so users can distinguish from native alerts 1165178 1 webkit-bug-importer 2016-02-16 10:53:55 -0800 <rdar://problem/24679586> 1165758 2 jcraig 2016-02-17 14:55:04 -0800 Potentially need to do something separate for alert dialogs: "alert dialog (web)", "alert web dialog", "web alert dialog", or just "web alert"? 1177039 3 274663 n_wang 2016-03-22 10:58:05 -0700 Created attachment 274663 patch 1177080 4 n_wang 2016-03-22 12:19:06 -0700 https://trac.webkit.org/changeset/198543 1203615 5 mitz 2016-06-19 09:57:22 -0700 The strings file is automatically generated from source using update-webkit-localizable-strings, so the right fix for this is to change LocalizedStrings.cpp. Otherwise, the values will revert the next time the strings file is regenerated. I am going to include the change to LocalizedStrings.cpp in an upcoming patch, though. 274663 2016-03-22 10:58:05 -0700 2016-03-22 10:59:53 -0700 patch patch.txt text/plain 3914 n_wang SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE5ODUzNCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE2LTAzLTIyICBOYW4gV2Fu ZyAgPG5fd2FuZ0BhcHBsZS5jb20+CisKKyAgICAgICAgQVg6IENoYW5nZSAiZGlhbG9nIiByb2xl IGRlc2NyaXB0aW9uIHRvICJ3ZWIgZGlhbG9nIiBzbyB1c2VycyBjYW4gZGlzdGluZ3Vpc2ggZnJv bSBuYXRpdmUgYWxlcnRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xNTQyOTIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBDaGFuZ2VkIHJvbGUgZGVzY3JpcHRpb25zIGZvciAiZGlhbG9nIiBhbmQgImFsZXJ0 IGRpYWxvZyIgcm9sZXMgYXMgcmVxdWlyZWQuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIG5lZWRl ZC4KKworICAgICAgICAqIEVuZ2xpc2gubHByb2ovTG9jYWxpemFibGUuc3RyaW5nczoKKwogMjAx Ni0wMy0yMiAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAKICAg ICAgICAgW0dUS10gV2ViSW5zcGVjdG9yIGJyb2tlbiBhZnRlciByMTk3NjIwCkluZGV4OiBTb3Vy Y2UvV2ViQ29yZS9FbmdsaXNoLmxwcm9qL0xvY2FsaXphYmxlLnN0cmluZ3MKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL1dlYkNvcmUvRW5nbGlzaC5scHJvai9Mb2NhbGl6YWJsZS5zdHJpbmdzCShyZXZp c2lvbiAxOTg0OTYpCisrKyBTb3VyY2UvV2ViQ29yZS9FbmdsaXNoLmxwcm9qL0xvY2FsaXphYmxl LnN0cmluZ3MJKHdvcmtpbmcgY29weSkKQEAgLTcxMyw3ICs3MTMsNyBAQAogImFsZXJ0IiA9ICJh bGVydCI7CiAKIC8qIEFuIEFSSUEgYWNjZXNzaWJpbGl0eSBncm91cCB0aGF0IGFjdHMgYXMgYW4g YWxlcnQgZGlhbG9nLiAqLwotImFsZXJ0IGRpYWxvZyIgPSAiYWxlcnQgZGlhbG9nIjsKKyJhbGVy dCBkaWFsb2ciID0gIndlYiBhbGVydCBkaWFsb2ciOwogCiAvKiBBbiBBUklBIGFjY2Vzc2liaWxp dHkgZ3JvdXAgdGhhdCBhY3RzIGFzIGFuIGFwcGxpY2F0aW9uLiAqLwogImFwcGxpY2F0aW9uIiA9 ICJhcHBsaWNhdGlvbiI7CkBAIC03ODgsNyArNzg4LDcgQEAKICJkZXNjcmlwdGlvbiBsaXN0IiA9 ICJkZXNjcmlwdGlvbiBsaXN0IjsKIAogLyogQW4gQVJJQSBhY2Nlc3NpYmlsaXR5IGdyb3VwIHRo YXQgYWN0cyBhcyBhbiBkaWFsb2cuICovCi0iZGlhbG9nIiA9ICJkaWFsb2ciOworImRpYWxvZyIg PSAid2ViIGRpYWxvZyI7CiAKIC8qIEFuIEFSSUEgYWNjZXNzaWJpbGl0eSBncm91cCB0aGF0IGFj dHMgYXMgYSBkb2N1bWVudC4gKi8KICJkb2N1bWVudCIgPSAiZG9jdW1lbnQiOwpJbmRleDogTGF5 b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwko cmV2aXNpb24gMTk4NDk2KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkp CkBAIC0xLDMgKzEsMTQgQEAKKzIwMTYtMDMtMjIgIE5hbiBXYW5nICA8bl93YW5nQGFwcGxlLmNv bT4KKworICAgICAgICBBWDogQ2hhbmdlICJkaWFsb2ciIHJvbGUgZGVzY3JpcHRpb24gdG8gIndl YiBkaWFsb2ciIHNvIHVzZXJzIGNhbiBkaXN0aW5ndWlzaCBmcm9tIG5hdGl2ZSBhbGVydHMKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1NDI5MgorICAg ICAgICA8cmRhcjovL3Byb2JsZW0vMjQ2Nzk1ODY+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9tYWMtbWF2ZXJpY2tzL2FjY2Vzc2li aWxpdHkvcm9sZXMtZXhwb3NlZC1leHBlY3RlZC50eHQ6CisgICAgICAgICogcGxhdGZvcm0vbWFj L2FjY2Vzc2liaWxpdHkvcm9sZXMtZXhwb3NlZC1leHBlY3RlZC50eHQ6CisKIDIwMTYtMDMtMjEg IEVyaWMgQ2FybHNvbiAgPGVyaWMuY2FybHNvbkBhcHBsZS5jb20+CiAKICAgICAgICAgQWRkIGEg V2ViUlRDIHNwZWNpZmljIGNvbXBpbGUgZmxhZwpJbmRleDogTGF5b3V0VGVzdHMvcGxhdGZvcm0v bWFjLW1hdmVyaWNrcy9hY2Nlc3NpYmlsaXR5L3JvbGVzLWV4cG9zZWQtZXhwZWN0ZWQudHh0Cj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIExheW91dFRlc3RzL3BsYXRmb3JtL21hYy1tYXZlcmlja3MvYWNjZXNzaWJp bGl0eS9yb2xlcy1leHBvc2VkLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMTk4NDk2KQorKysgTGF5 b3V0VGVzdHMvcGxhdGZvcm0vbWFjLW1hdmVyaWNrcy9hY2Nlc3NpYmlsaXR5L3JvbGVzLWV4cG9z ZWQtZXhwZWN0ZWQudHh0CSh3b3JraW5nIGNvcHkpCkBAIC04MDcsNyArODA3LDcgQEAgZGl2W3Jv bGU9YWxlcnRdCiBkaXZbcm9sZT1hbGVydGRpYWxvZ10KICAgICAgIEFYUm9sZTogQVhHcm91cAog ICAgICAgQVhTdWJyb2xlOiBBWEFwcGxpY2F0aW9uQWxlcnREaWFsb2cKLSAgICAgIEFYUm9sZURl c2NyaXB0aW9uOiBhbGVydCBkaWFsb2cKKyAgICAgIEFYUm9sZURlc2NyaXB0aW9uOiB3ZWIgYWxl cnQgZGlhbG9nCiAgICAgICAKIGRpdltyb2xlPWFwcGxpY2F0aW9uXQogICAgICAgQVhSb2xlOiBB WEdyb3VwCkBAIC04NTcsNyArODU3LDcgQEAgZGl2W3JvbGU9ZGVmaW5pdGlvbl0KIGRpdltyb2xl PWRpYWxvZ10KICAgICAgIEFYUm9sZTogQVhHcm91cAogICAgICAgQVhTdWJyb2xlOiBBWEFwcGxp Y2F0aW9uRGlhbG9nCi0gICAgICBBWFJvbGVEZXNjcmlwdGlvbjogZGlhbG9nCisgICAgICBBWFJv bGVEZXNjcmlwdGlvbjogd2ViIGRpYWxvZwogICAgICAgCiBkaXZbcm9sZT1kaXJlY3RvcnldCiAg ICAgICBBWFJvbGU6IEFYTGlzdApJbmRleDogTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2FjY2Vz c2liaWxpdHkvcm9sZXMtZXhwb3NlZC1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0 VGVzdHMvcGxhdGZvcm0vbWFjL2FjY2Vzc2liaWxpdHkvcm9sZXMtZXhwb3NlZC1leHBlY3RlZC50 eHQJKHJldmlzaW9uIDE5ODQ5NikKKysrIExheW91dFRlc3RzL3BsYXRmb3JtL21hYy9hY2Nlc3Np YmlsaXR5L3JvbGVzLWV4cG9zZWQtZXhwZWN0ZWQudHh0CSh3b3JraW5nIGNvcHkpCkBAIC04MDcs NyArODA3LDcgQEAgZGl2W3JvbGU9YWxlcnRdCiBkaXZbcm9sZT1hbGVydGRpYWxvZ10KICAgICAg IEFYUm9sZTogQVhHcm91cAogICAgICAgQVhTdWJyb2xlOiBBWEFwcGxpY2F0aW9uQWxlcnREaWFs b2cKLSAgICAgIEFYUm9sZURlc2NyaXB0aW9uOiBhbGVydCBkaWFsb2cKKyAgICAgIEFYUm9sZURl c2NyaXB0aW9uOiB3ZWIgYWxlcnQgZGlhbG9nCiAgICAgICAKIGRpdltyb2xlPWFwcGxpY2F0aW9u XQogICAgICAgQVhSb2xlOiBBWEdyb3VwCkBAIC04NTcsNyArODU3LDcgQEAgZGl2W3JvbGU9ZGVm aW5pdGlvbl0KIGRpdltyb2xlPWRpYWxvZ10KICAgICAgIEFYUm9sZTogQVhHcm91cAogICAgICAg QVhTdWJyb2xlOiBBWEFwcGxpY2F0aW9uRGlhbG9nCi0gICAgICBBWFJvbGVEZXNjcmlwdGlvbjog ZGlhbG9nCisgICAgICBBWFJvbGVEZXNjcmlwdGlvbjogd2ViIGRpYWxvZwogICAgICAgCiBkaXZb cm9sZT1kaXJlY3RvcnldCiAgICAgICBBWFJvbGU6IEFYTGlzdAo=