154260 2016-02-15 14:27:03 -0800 RemoteInspector should forward new automation session requests to its client 2016-02-16 15:45:25 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 154012 1 bburg bburg bburg commit-queue graouts joepeck keith_miller mark.lam mattbaker msaboff nvasilyev saam timothy webkit-bug-importer oldest_to_newest 1164900 0 bburg 2016-02-15 14:27:03 -0800 Patch coming. 1164901 1 webkit-bug-importer 2016-02-15 14:27:18 -0800 <rdar://problem/24663313> 1164911 2 271375 bburg 2016-02-15 15:00:39 -0800 Created attachment 271375 Proposed Fix 1164914 3 271375 joepeck 2016-02-15 15:12:00 -0800 Comment on attachment 271375 Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=271375&action=review > Source/JavaScriptCore/inspector/remote/RemoteInspector.mm:532 > - [listing setObject:target.name() forKey:WIRTitleKey]; > + [listing setObject:target.name() forKey:WIRSessionIdentifierKey]; Shouldn't there be a title? I'd expect something like: [listing setObject:target.name() forKey:WIRTitleKey]; [listing setObject:target.sessionId() forKey:WIRSessionIdentifierKey]; > Source/JavaScriptCore/inspector/remote/RemoteInspectorConstants.h:88 > #define WIRAutomationTargetIsPairedKey @"WIRAutomationTargetIsPairedKey" > +#define WIRSessionIdentifierKey @"WIRSessionIdentifierKey" > +#define WIRAutomationSessionRequestMessage @"WIRAutomationSessionRequestMessage" Style: line up 1164927 4 bburg 2016-02-15 15:45:41 -0800 (In reply to comment #3) > Comment on attachment 271375 [details] > Proposed Fix > > View in context: > https://bugs.webkit.org/attachment.cgi?id=271375&action=review > > > Source/JavaScriptCore/inspector/remote/RemoteInspector.mm:532 > > - [listing setObject:target.name() forKey:WIRTitleKey]; > > + [listing setObject:target.name() forKey:WIRSessionIdentifierKey]; > > Shouldn't there be a title? I'd expect something like: > > [listing setObject:target.name() forKey:WIRTitleKey]; > [listing setObject:target.sessionId() forKey:WIRSessionIdentifierKey]; sessionIdentifier() is part of WebAutomationSession's interface, not RemoteAutomationTarget. I'm not sure that there is a meaningful user-facing title for an automation session. > > Source/JavaScriptCore/inspector/remote/RemoteInspectorConstants.h:88 > > #define WIRAutomationTargetIsPairedKey @"WIRAutomationTargetIsPairedKey" > > +#define WIRSessionIdentifierKey @"WIRSessionIdentifierKey" > > +#define WIRAutomationSessionRequestMessage @"WIRAutomationSessionRequestMessage" > > Style: line up 1165370 5 bburg 2016-02-16 15:45:25 -0800 Committed r196667: <http://trac.webkit.org/changeset/196667> 271375 2016-02-15 15:00:39 -0800 2016-02-16 10:06:50 -0800 Proposed Fix bug-154260-20160215150013.patch text/plain 4907 bburg U3VidmVyc2lvbiBSZXZpc2lvbjogMTk2NTk5CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA2 MGRkMzEwZjQ5ZDVjZDljYmY2YjQ3ODAwNDk1MmU3MzE2MTg3NGYyLi45ZTcwNDczYjBjNzEwYzAz NTkyZTJkMTBmZmY3Y2ZlYjFmNjk5OWQ0IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMSBAQAorMjAxNi0wMi0xNSAgQnJpYW4gQnVyZyAgPGJidXJnQGFwcGxlLmNvbT4KKwor ICAgICAgICBSZW1vdGVJbnNwZWN0b3Igc2hvdWxkIGZvcndhcmQgbmV3IGF1dG9tYXRpb24gc2Vz c2lvbiByZXF1ZXN0cyB0byBpdHMgY2xpZW50CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xNTQyNjAKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzI0NjYz MzEzPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog aW5zcGVjdG9yL3JlbW90ZS9SZW1vdGVJbnNwZWN0b3IuaDoKKyAgICAgICAgKiBpbnNwZWN0b3Iv cmVtb3RlL1JlbW90ZUluc3BlY3Rvci5tbToKKyAgICAgICAgKEluc3BlY3Rvcjo6UmVtb3RlSW5z cGVjdG9yOjp4cGNDb25uZWN0aW9uUmVjZWl2ZWRNZXNzYWdlKToKKyAgICAgICAgKEluc3BlY3Rv cjo6UmVtb3RlSW5zcGVjdG9yOjpsaXN0aW5nRm9yQXV0b21hdGlvblRhcmdldCk6CisgICAgICAg IFVzZSB0aGUgY29ycmVjdCBrZXkgZm9yIHRoZSBzZXNzaW9uIGlkZW50aWZpZXIgaW4gdGhlIGxp c3RpbmcuIFRoZSBuYW1lKCkKKyAgICAgICAgb3ZlcnJpZGUgZm9yIFJlbW90ZUF1dG9tYXRpb25U YXJnZXQgaXMgYWN0dWFsbHkgdGhlIHNlc3Npb24gaWRlbnRpZmllci4KKworICAgICAgICAoSW5z cGVjdG9yOjpSZW1vdGVJbnNwZWN0b3I6OnJlY2VpdmVkQXV0b21hdGlvblNlc3Npb25SZXF1ZXN0 TWVzc2FnZSk6CisgICAgICAgICogaW5zcGVjdG9yL3JlbW90ZS9SZW1vdGVJbnNwZWN0b3JDb25z dGFudHMuaDogQWRkIG5ldyBjb25zdGFudHMuCisKIDIwMTYtMDItMTUgIEpvc2VwaCBQZWNvcmFy byAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBXZWIgV29y a2VycyBoYXZlIG5vIGFjY2VzcyB0byBjb25zb2xlIGZvciBkZWJ1Z2dpbmcKZGlmZiAtLWdpdCBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3IvcmVtb3RlL1JlbW90ZUluc3BlY3Rvci5o IGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9yZW1vdGUvUmVtb3RlSW5zcGVjdG9y LmgKaW5kZXggNGIxYWExNTczOTU2ZTk4ZTQyNzU1ZGUzYmVlMmQ4YzE4YjYzMTBiNy4uM2YyYzUw Zjg4MDg2NTdkN2Y0MTc1NDNkMzU1NTZkM2UwMzE4ZmEwNSAxMDA2NDQKLS0tIGEvU291cmNlL0ph dmFTY3JpcHRDb3JlL2luc3BlY3Rvci9yZW1vdGUvUmVtb3RlSW5zcGVjdG9yLmgKKysrIGIvU291 cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9yZW1vdGUvUmVtb3RlSW5zcGVjdG9yLmgKQEAg LTExNyw2ICsxMTcsNyBAQCBwcml2YXRlOgogICAgIHZvaWQgcmVjZWl2ZWRDb25uZWN0aW9uRGll ZE1lc3NhZ2UoTlNEaWN0aW9uYXJ5ICp1c2VySW5mbyk7CiAgICAgdm9pZCByZWNlaXZlZEF1dG9t YXRpY0luc3BlY3Rpb25Db25maWd1cmF0aW9uTWVzc2FnZShOU0RpY3Rpb25hcnkgKnVzZXJJbmZv KTsKICAgICB2b2lkIHJlY2VpdmVkQXV0b21hdGljSW5zcGVjdGlvblJlamVjdE1lc3NhZ2UoTlNE aWN0aW9uYXJ5ICp1c2VySW5mbyk7CisgICAgdm9pZCByZWNlaXZlZEF1dG9tYXRpb25TZXNzaW9u UmVxdWVzdE1lc3NhZ2UoTlNEaWN0aW9uYXJ5ICp1c2VySW5mbyk7CiAKICAgICBzdGF0aWMgYm9v bCBzdGFydEVuYWJsZWQ7CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNw ZWN0b3IvcmVtb3RlL1JlbW90ZUluc3BlY3Rvci5tbSBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9p bnNwZWN0b3IvcmVtb3RlL1JlbW90ZUluc3BlY3Rvci5tbQppbmRleCA2ZjY0NTcwZjc0ZWNiMGM0 MzAzZDk2OTU4M2U5M2JlYzE1ZGE1M2ViLi4wYTA1ZjUwODU2NTY5MjY5N2UwYjgyMDM3NDVhYjFj NmE0YzIwN2VhIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL3Jl bW90ZS9SZW1vdGVJbnNwZWN0b3IubW0KKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3Bl Y3Rvci9yZW1vdGUvUmVtb3RlSW5zcGVjdG9yLm1tCkBAIC00NDAsNiArNDQwLDggQEAgdm9pZCBS ZW1vdGVJbnNwZWN0b3I6OnhwY0Nvbm5lY3Rpb25SZWNlaXZlZE1lc3NhZ2UoUmVtb3RlSW5zcGVj dG9yWFBDQ29ubmVjdGlvbioKICAgICAgICAgcmVjZWl2ZWRBdXRvbWF0aWNJbnNwZWN0aW9uQ29u ZmlndXJhdGlvbk1lc3NhZ2UodXNlckluZm8pOwogICAgIGVsc2UgaWYgKFttZXNzYWdlTmFtZSBp c0VxdWFsVG9TdHJpbmc6V0lSQXV0b21hdGljSW5zcGVjdGlvblJlamVjdE1lc3NhZ2VdKQogICAg ICAgICByZWNlaXZlZEF1dG9tYXRpY0luc3BlY3Rpb25SZWplY3RNZXNzYWdlKHVzZXJJbmZvKTsK KyAgICBlbHNlIGlmIChbbWVzc2FnZU5hbWUgaXNFcXVhbFRvU3RyaW5nOldJUkF1dG9tYXRpb25T ZXNzaW9uUmVxdWVzdE1lc3NhZ2VdKQorICAgICAgICByZWNlaXZlZEF1dG9tYXRpb25TZXNzaW9u UmVxdWVzdE1lc3NhZ2UodXNlckluZm8pOwogICAgIGVsc2UKICAgICAgICAgTlNMb2coQCJVbnJl Y29nbml6ZWQgUmVtb3RlSW5zcGVjdG9yIFhQQyBNZXNzYWdlOiAlQCIsIG1lc3NhZ2VOYW1lKTsK IH0KQEAgLTUyNyw3ICs1MjksNyBAQCBSZXRhaW5QdHI8TlNEaWN0aW9uYXJ5PiBSZW1vdGVJbnNw ZWN0b3I6Omxpc3RpbmdGb3JBdXRvbWF0aW9uVGFyZ2V0KGNvbnN0IFJlbW90ZQogCiAgICAgUmV0 YWluUHRyPE5TTXV0YWJsZURpY3Rpb25hcnk+IGxpc3RpbmcgPSBhZG9wdE5TKFtbTlNNdXRhYmxl RGljdGlvbmFyeSBhbGxvY10gaW5pdF0pOwogICAgIFtsaXN0aW5nIHNldE9iamVjdDpAKHRhcmdl dC50YXJnZXRJZGVudGlmaWVyKCkpIGZvcktleTpXSVJUYXJnZXRJZGVudGlmaWVyS2V5XTsKLSAg ICBbbGlzdGluZyBzZXRPYmplY3Q6dGFyZ2V0Lm5hbWUoKSBmb3JLZXk6V0lSVGl0bGVLZXldOwor ICAgIFtsaXN0aW5nIHNldE9iamVjdDp0YXJnZXQubmFtZSgpIGZvcktleTpXSVJTZXNzaW9uSWRl bnRpZmllcktleV07CiAgICAgW2xpc3Rpbmcgc2V0T2JqZWN0OldJUlR5cGVBdXRvbWF0aW9uIGZv cktleTpXSVJUeXBlS2V5XTsKICAgICBbbGlzdGluZyBzZXRPYmplY3Q6QCh0YXJnZXQuaXNQYWly ZWQoKSkgZm9yS2V5OldJUkF1dG9tYXRpb25UYXJnZXRJc1BhaXJlZEtleV07CiAKQEAgLTc3Niw2 ICs3NzgsMjEgQEAgdm9pZCBSZW1vdGVJbnNwZWN0b3I6OnJlY2VpdmVkQXV0b21hdGljSW5zcGVj dGlvblJlamVjdE1lc3NhZ2UoTlNEaWN0aW9uYXJ5ICp1c2UKICAgICAgICAgbV9hdXRvbWF0aWNJ bnNwZWN0aW9uUGF1c2VkID0gZmFsc2U7CiB9CiAKK3ZvaWQgUmVtb3RlSW5zcGVjdG9yOjpyZWNl aXZlZEF1dG9tYXRpb25TZXNzaW9uUmVxdWVzdE1lc3NhZ2UoTlNEaWN0aW9uYXJ5ICp1c2VySW5m bykKK3sKKyAgICBpZiAoIW1fY2xpZW50KQorICAgICAgICByZXR1cm47CisKKyAgICBpZiAoIW1f Y2xpZW50LT5yZW1vdGVBdXRvbWF0aW9uQWxsb3dlZCgpKQorICAgICAgICByZXR1cm47CisKKyAg ICBOU1N0cmluZyAqc3VnZ2VzdGVkU2Vzc2lvbklkZW50aWZpZXIgPSBbdXNlckluZm8gb2JqZWN0 Rm9yS2V5OldJUlNlc3Npb25JZGVudGlmaWVyS2V5XTsKKyAgICBpZiAoIXN1Z2dlc3RlZFNlc3Np b25JZGVudGlmaWVyKQorICAgICAgICByZXR1cm47CisKKyAgICBtX2NsaWVudC0+cmVxdWVzdEF1 dG9tYXRpb25TZXNzaW9uKHN1Z2dlc3RlZFNlc3Npb25JZGVudGlmaWVyKTsKK30KKwogfSAvLyBu YW1lc3BhY2UgSW5zcGVjdG9yCiAKICNlbmRpZiAvLyBFTkFCTEUoUkVNT1RFX0lOU1BFQ1RPUikK ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3IvcmVtb3RlL1JlbW90 ZUluc3BlY3RvckNvbnN0YW50cy5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9y ZW1vdGUvUmVtb3RlSW5zcGVjdG9yQ29uc3RhbnRzLmgKaW5kZXggMjBmMjgxYTI3MTdhZjlmMTcw NDdlM2RiODg5Yjc5ZmJjODM3YWM3MS4uZWRlZWQxN2NhNmMxNGVlMWEzMzhmNDhkMDVlNWI0MjRm MmY3OTg3ZSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9yZW1v dGUvUmVtb3RlSW5zcGVjdG9yQ29uc3RhbnRzLmgKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3Jl L2luc3BlY3Rvci9yZW1vdGUvUmVtb3RlSW5zcGVjdG9yQ29uc3RhbnRzLmgKQEAgLTg0LDYgKzg0 LDggQEAKICNkZWZpbmUgV0lSQXV0b21hdGljSW5zcGVjdGlvbkNhbmRpZGF0ZU1lc3NhZ2UgICAg IEAiV0lSQXV0b21hdGljSW5zcGVjdGlvbkNhbmRpZGF0ZU1lc3NhZ2UiCiAKICNkZWZpbmUgV0lS QXV0b21hdGlvblRhcmdldElzUGFpcmVkS2V5ICAgICAgICAgICAgIEAiV0lSQXV0b21hdGlvblRh cmdldElzUGFpcmVkS2V5IgorI2RlZmluZSBXSVJTZXNzaW9uSWRlbnRpZmllcktleSAgICAgICAg ICAgICAgICAgQCJXSVJTZXNzaW9uSWRlbnRpZmllcktleSIKKyNkZWZpbmUgV0lSQXV0b21hdGlv blNlc3Npb25SZXF1ZXN0TWVzc2FnZSAgICAgIEAiV0lSQXV0b21hdGlvblNlc3Npb25SZXF1ZXN0 TWVzc2FnZSIKIAogLy8gVGhlc2UgZGVmaW5pdGlvbnMgYXJlIHNoYXJlZCB3aXRoIGEgU2ltdWxh dG9yIHdlYmluc3BlY3RvcmQgYW5kCiAvLyBPUyBYIHByb2Nlc3MgY29tbXVuaWNhdGluZyB3aXRo IGl0Lgo=