154255 2016-02-15 13:42:10 -0800 stress/sampling-profiler-deep-stack.js fails on ARM 32bit 2022-02-27 23:38:10 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 saam saam benjamin fpizlo ggaren gskachkov keith_miller mark.lam msaboff oliver sukolsak webkit-bug-importer ysuzuki oldest_to_newest 1164876 0 saam 2016-02-15 13:42:10 -0800 ... 1164895 1 webkit-bug-importer 2016-02-15 14:15:48 -0800 <rdar://problem/24662996> 1165262 2 271468 saam 2016-02-16 12:35:07 -0800 Created attachment 271468 patch 1165267 3 271468 mark.lam 2016-02-16 12:43:26 -0800 Comment on attachment 271468 patch View in context: https://bugs.webkit.org/attachment.cgi?id=271468&action=review r=me with improved comment. > Source/JavaScriptCore/ChangeLog:12 > + The DFG was doing a good job at optimizing the function > + at the leaf of the recursion. Because of that, we often > + wouldn't sample it. I fixed this by making the leaf > + function do more work. It's not clear from this comment that this test failure does not reflect a bug in the VM. Instead, it is the test that is not set up to meet its own expectations. Hence, the fix requires that the test be modified. Can you update the comment to say something to that effect? 1165271 4 saam 2016-02-16 12:51:05 -0800 landed fix in: https://trac.webkit.org/changeset/196650 271468 2016-02-16 12:35:07 -0800 2022-02-27 23:38:10 -0800 patch a-backup.diff text/plain 1578 saam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTk2NjQ4KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBA CisyMDE2LTAyLTE2ICBTYWFtIGJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAg IHN0cmVzcy9zYW1wbGluZy1wcm9maWxlci1kZWVwLXN0YWNrLmpzIGZhaWxzIG9uIEFSTSAzMmJp dAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU0MjU1 CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8yNDY2Mjk5Nj4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgREZHIHdhcyBkb2luZyBhIGdvb2Qgam9i IGF0IG9wdGltaXppbmcgdGhlIGZ1bmN0aW9uCisgICAgICAgIGF0IHRoZSBsZWFmIG9mIHRoZSBy ZWN1cnNpb24uIEJlY2F1c2Ugb2YgdGhhdCwgd2Ugb2Z0ZW4KKyAgICAgICAgd291bGRuJ3Qgc2Ft cGxlIGl0LiBJIGZpeGVkIHRoaXMgYnkgbWFraW5nIHRoZSBsZWFmCisgICAgICAgIGZ1bmN0aW9u IGRvIG1vcmUgd29yay4KKworICAgICAgICAqIHRlc3RzL3N0cmVzcy9zYW1wbGluZy1wcm9maWxl ci1kZWVwLXN0YWNrLmpzOgorICAgICAgICAocGxhdGZvcm1TdXBwb3J0c1NhbXBsaW5nUHJvZmls ZXIuZm9vKToKKwogMjAxNi0wMi0xNiAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgog CiAgICAgICAgIFtXZWIgSURMXSBPcGVyYXRpb25zIHNob3VsZCBiZSBvbiB0aGUgaW5zdGFuY2Ug Zm9yIGdsb2JhbCBvYmplY3RzIG9yIGlmIFtVbmZvcmdlYWJsZV0KSW5kZXg6IFNvdXJjZS9KYXZh U2NyaXB0Q29yZS90ZXN0cy9zdHJlc3Mvc2FtcGxpbmctcHJvZmlsZXItZGVlcC1zdGFjay5qcwo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvdGVzdHMvc3RyZXNzL3NhbXBsaW5n LXByb2ZpbGVyLWRlZXAtc3RhY2suanMJKHJldmlzaW9uIDE5NjY0OCkKKysrIFNvdXJjZS9KYXZh U2NyaXB0Q29yZS90ZXN0cy9zdHJlc3Mvc2FtcGxpbmctcHJvZmlsZXItZGVlcC1zdGFjay5qcwko d29ya2luZyBjb3B5KQpAQCAtMiw5ICsyLDExIEBAIGlmIChwbGF0Zm9ybVN1cHBvcnRzU2FtcGxp bmdQcm9maWxlcigpKSAKICAgICBsb2FkKCIuL3NhbXBsaW5nLXByb2ZpbGVyL3NhbXBsaW5nUHJv ZmlsZXIuanMiKTsKIAogICAgIGZ1bmN0aW9uIGZvbyh4KSB7IAorICAgICAgICBsZXQgbyA9IHt9 OwogICAgICAgICBmb3IgKGxldCBpID0gMDsgaSA8IDEwMDA7IGkrKykgewogICAgICAgICAgICAg bGV0IHggPSBpOwogICAgICAgICAgICAgeC0tOworICAgICAgICAgICAgb1sieCIgKyB4XSA9IHg7 CiAgICAgICAgIH0KICAgICAgICAgcmV0dXJuIHg7IAogICAgIH0K