154244 2016-02-15 08:43:49 -0800 Parser::parseVariableDeclarationList should null check the node before attempting to create a new CommaExpr 2016-02-15 12:09:23 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build All All RESOLVED FIXED P2 Normal --- 1 fpizlo fpizlo commit-queue keith_miller mark.lam msaboff saam oldest_to_newest 1164750 0 fpizlo 2016-02-15 08:43:49 -0800 It's possible that en entry in the variable declaration list doesn't have a node. We don't want to create a comma expression with a null next. 1164751 1 271343 fpizlo 2016-02-15 08:45:37 -0800 Created attachment 271343 the patch 1164756 2 271343 msaboff 2016-02-15 08:49:48 -0800 Comment on attachment 271343 the patch r=me 1164804 3 fpizlo 2016-02-15 12:09:23 -0800 Landed in http://trac.webkit.org/changeset/196587 271343 2016-02-15 08:45:37 -0800 2016-02-15 08:49:48 -0800 the patch blah.patch text/plain 3547 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTk2NTc4KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBA CisyMDE2LTAyLTE1ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg UGFyc2VyOjpwYXJzZVZhcmlhYmxlRGVjbGFyYXRpb25MaXN0IHNob3VsZCBudWxsIGNoZWNrIHRo ZSBub2RlIGJlZm9yZSBhdHRlbXB0aW5nIHRvIGNyZWF0ZSBhIG5ldyBDb21tYUV4cHIKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1NDI0NAorICAgICAg ICByZGFyOi8vcHJvYmxlbS8yNDI5MDY3MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogcGFyc2VyL0FTVEJ1aWxkZXIuaDoKKyAgICAgICAgKEpTQzo6 QVNUQnVpbGRlcjo6YXBwZW5kVG9Db21tYUV4cHIpOiBDYXRjaCB0aGUgYnVnIHNvb25lciBpbiBk ZWJ1Zy4KKyAgICAgICAgKiBwYXJzZXIvUGFyc2VyLmNwcDoKKyAgICAgICAgKEpTQzo6UGFyc2Vy PExleGVyVHlwZT46OnBhcnNlVmFyaWFibGVEZWNsYXJhdGlvbkxpc3QpOiBGaXggdGhlIGJ1Zy4K KyAgICAgICAgKiB0ZXN0cy9zdHJlc3MvZm9yLWxldC1jb21tYS5qczogQWRkZWQuIFRoaXMgdXNl ZCB0byBjcmFzaCBpbiBkZWJ1ZyBhbmQgcmVsZWFzZS4KKwogMjAxNi0wMi0xNSAgQmVuamFtaW4g UG91bGFpbiAgPGJwb3VsYWluQGFwcGxlLmNvbT4KIAogICAgICAgICBbSlNDXSBJbXByb3ZlIHRo ZSBpbnRlcmZhY2Ugb2YgSW5zdDo6c2hvdWxkVHJ5QWxpYXNpbmdEZWYoKQpJbmRleDogU291cmNl L0phdmFTY3JpcHRDb3JlL3BhcnNlci9BU1RCdWlsZGVyLmgKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L0phdmFTY3JpcHRDb3JlL3BhcnNlci9BU1RCdWlsZGVyLmgJKHJldmlzaW9uIDE5NjUwMCkKKysr IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9wYXJzZXIvQVNUQnVpbGRlci5oCSh3b3JraW5nIGNvcHkp CkBAIC03MjksNiArNzI5LDcgQEAgcHVibGljOgogICAgIENvbW1hTm9kZSogYXBwZW5kVG9Db21t YUV4cHIoY29uc3QgSlNUb2tlbkxvY2F0aW9uJiBsb2NhdGlvbiwgRXhwcmVzc2lvbk5vZGUqLCBF eHByZXNzaW9uTm9kZSogdGFpbCwgRXhwcmVzc2lvbk5vZGUqIG5leHQpCiAgICAgewogICAgICAg ICBBU1NFUlQodGFpbC0+aXNDb21tYU5vZGUoKSk7CisgICAgICAgIEFTU0VSVChuZXh0KTsKICAg ICAgICAgQ29tbWFOb2RlKiBuZXdUYWlsID0gbmV3IChtX3BhcnNlckFyZW5hKSBDb21tYU5vZGUo bG9jYXRpb24sIG5leHQpOwogICAgICAgICBzdGF0aWNfY2FzdDxDb21tYU5vZGUqPih0YWlsKS0+ c2V0TmV4dChuZXdUYWlsKTsKICAgICAgICAgcmV0dXJuIG5ld1RhaWw7CkluZGV4OiBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvcGFyc2VyL1BhcnNlci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0ph dmFTY3JpcHRDb3JlL3BhcnNlci9QYXJzZXIuY3BwCShyZXZpc2lvbiAxOTY1MDApCisrKyBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvcGFyc2VyL1BhcnNlci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTc0 NCwxNCArNzQ0LDE2IEBAIHRlbXBsYXRlIDxjbGFzcyBUcmVlQnVpbGRlcj4gVHJlZUV4cHJlc3MK ICAgICAgICAgICAgICAgICBsYXN0SW5pdGlhbGl6ZXIgPSByaHM7CiAgICAgICAgICAgICB9CiAg ICAgICAgIH0KLSAgICAgICAgCi0gICAgICAgIGlmICghaGVhZCkKLSAgICAgICAgICAgIGhlYWQg PSBub2RlOwotICAgICAgICBlbHNlIGlmICghdGFpbCkgewotICAgICAgICAgICAgaGVhZCA9IGNv bnRleHQuY3JlYXRlQ29tbWFFeHByKGxvY2F0aW9uLCBoZWFkKTsKLSAgICAgICAgICAgIHRhaWwg PSBjb250ZXh0LmFwcGVuZFRvQ29tbWFFeHByKGxvY2F0aW9uLCBoZWFkLCBoZWFkLCBub2RlKTsK LSAgICAgICAgfSBlbHNlCi0gICAgICAgICAgICB0YWlsID0gY29udGV4dC5hcHBlbmRUb0NvbW1h RXhwcihsb2NhdGlvbiwgaGVhZCwgdGFpbCwgbm9kZSk7CisKKyAgICAgICAgaWYgKG5vZGUpIHsK KyAgICAgICAgICAgIGlmICghaGVhZCkKKyAgICAgICAgICAgICAgICBoZWFkID0gbm9kZTsKKyAg ICAgICAgICAgIGVsc2UgaWYgKCF0YWlsKSB7CisgICAgICAgICAgICAgICAgaGVhZCA9IGNvbnRl eHQuY3JlYXRlQ29tbWFFeHByKGxvY2F0aW9uLCBoZWFkKTsKKyAgICAgICAgICAgICAgICB0YWls ID0gY29udGV4dC5hcHBlbmRUb0NvbW1hRXhwcihsb2NhdGlvbiwgaGVhZCwgaGVhZCwgbm9kZSk7 CisgICAgICAgICAgICB9IGVsc2UKKyAgICAgICAgICAgICAgICB0YWlsID0gY29udGV4dC5hcHBl bmRUb0NvbW1hRXhwcihsb2NhdGlvbiwgaGVhZCwgdGFpbCwgbm9kZSk7CisgICAgICAgIH0KICAg ICB9IHdoaWxlIChtYXRjaChDT01NQSkpOwogICAgIGlmIChsYXN0SWRlbnQpCiAgICAgICAgIGxh c3RQYXR0ZXJuID0gY29udGV4dC5jcmVhdGVCaW5kaW5nTG9jYXRpb24obGFzdElkZW50VG9rZW4u bV9sb2NhdGlvbiwgKmxhc3RJZGVudCwgbGFzdElkZW50VG9rZW4ubV9zdGFydFBvc2l0aW9uLCBs YXN0SWRlbnRUb2tlbi5tX2VuZFBvc2l0aW9uLCBhc3NpZ25tZW50Q29udGV4dCk7CkluZGV4OiBT b3VyY2UvSmF2YVNjcmlwdENvcmUvdGVzdHMvc3RyZXNzL2Zvci1sZXQtY29tbWEuanMKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL3Rlc3RzL3N0cmVzcy9mb3ItbGV0LWNvbW1h LmpzCShyZXZpc2lvbiAwKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL3Rlc3RzL3N0cmVzcy9m b3ItbGV0LWNvbW1hLmpzCSh3b3JraW5nIGNvcHkpCkBAIC0wLDAgKzEsMTYgQEAKK2Z1bmN0aW9u IGZvbygpIHsKKyAgICB2YXIgYXJyYXkgPSBbXTsKKyAgICBmb3IgKGxldCB4ID0gMCwgW107IHgg PCAxMDsgKyt4KSB7IGFycmF5LnB1c2goeCk7IH0KKyAgICByZXR1cm4gYXJyYXk7Cit9CisKK3Zh ciByZXN1bHQgPSBmb28oKTsKK2lmIChyZXN1bHQubGVuZ3RoICE9IDEwKQorICAgIHRocm93ICJF cnJvcjogYmFkIGxlbmd0aDogIiArIHJlc3VsdC5sZW5ndGg7Citmb3IgKHZhciBpID0gMDsgaSA8 IDEwOyArK2kpIHsKKyAgICBpZiAocmVzdWx0W2ldICE9IGkpCisgICAgICAgIHRocm93ICJFcnJv cjogYmFkIGVudHJ5IGF0IGkgPSAiICsgaSArICI6ICIgKyByZXN1bHRbaV07Cit9CitpZiAocmVz dWx0Lmxlbmd0aCAhPSAxMCkKKyAgICB0aHJvdyAiRXJyb3I6IGJhZCBsZW5ndGg6ICIgKyByZXN1 bHQubGVuZ3RoOworCg==