154219 2016-02-13 11:46:14 -0800 [cmake] Consolidated Linux-specific file lists. 2016-02-15 07:53:57 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Local Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 annulen webkit-unassigned commit-queue gyuyoung.kim lforschler mcatanzaro ossy oldest_to_newest 1164560 0 annulen 2016-02-13 11:46:14 -0800 Consolidated Linux-specific file lists. 1164566 1 271297 annulen 2016-02-13 12:35:43 -0800 Created attachment 271297 Patch 1164597 2 271297 mcatanzaro 2016-02-13 17:48:05 -0800 Comment on attachment 271297 Patch I am having second thoughts about putting the files in the top-level Platform directory. That is a really messy directory; it's going to be hard to find them. Could these files be placed e.g. under platform/linux instead? 1164613 3 annulen 2016-02-14 01:10:19 -0800 1. I think that these files should be put either (a) into one directory, or (b) each of them should be placed where its sources are located. Solution (b) does not work for GStreamer, and it won't work for things like Cairo, so we need to choose one directory. 2. I had the same concerns about clutter in WebCore/platform as you do. In https://bugs.webkit.org/attachment.cgi?id=270993&action=review I've put ImageDecoders.cmake into WebCore root, but Alex disagreed. 3. platform/linux is acceptable only for Linux.cmake, and certainly not for other components, since they are cross-platform or at least not specific to Linux. 1164643 4 gyuyoung.kim 2016-02-14 16:49:14 -0800 (In reply to comment #3) > 1. I think that these files should be put either (a) into one directory, or > (b) each of them should be placed where its sources are located. Solution > (b) does not work for GStreamer, and it won't work for things like Cairo, so > we need to choose one directory. > > 2. I had the same concerns about clutter in WebCore/platform as you do. In > https://bugs.webkit.org/attachment.cgi?id=270993&action=review I've put > ImageDecoders.cmake into WebCore root, but Alex disagreed. > > 3. platform/linux is acceptable only for Linux.cmake, and certainly not for > other components, since they are cross-platform or at least not specific to > Linux. I also like to put Linux.cmake into platform/linux in order not to messy webCore/platform directory. 1164739 5 271297 mcatanzaro 2016-02-15 07:07:29 -0800 Comment on attachment 271297 Patch Thinking about this some more, I've come to think alternative solutions are worse; having all the CMake files under platform live in the top-level platform directory seems easiest. 1164743 6 271297 commit-queue 2016-02-15 07:53:54 -0800 Comment on attachment 271297 Patch Clearing flags on attachment: 271297 Committed r196578: <http://trac.webkit.org/changeset/196578> 1164744 7 commit-queue 2016-02-15 07:53:57 -0800 All reviewed patches have been landed. Closing bug. 271297 2016-02-13 12:35:43 -0800 2016-02-15 07:53:54 -0800 Patch bug-154219-20160213233522.patch text/plain 3630 annulen U3VidmVyc2lvbiBSZXZpc2lvbjogMTk2NTUyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODRlNDYyMjRiNDY5N2M2 ODJkN2Y0Y2MwOGM4YjM4NGMzZmRkOWVmOS4uYmZlOTNkNmI0NjY5Nzc5Y2VlYmIxY2QwYjc1ODcw Zjg0OGI1MGE1MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE4IEBACiAyMDE2LTAyLTEzICBLb25z dGFudGluIFRva2FyZXYgIDxhbm51bGVuQHlhbmRleC5ydT4KIAorICAgICAgICBbY21ha2VdIENv bnNvbGlkYXRlZCBMaW51eC1zcGVjaWZpYyBmaWxlIGxpc3RzLgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU0MjE5CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIG5lZWRlZC4KKworICAg ICAgICAqIFBsYXRmb3JtRWZsLmNtYWtlOiBNb3ZlZCBMaW51eCBmaWxlcyBhbmQgaW5jbHVkZSBk aXIgdG8gTGludXguY21ha2UuCisgICAgICAgICogUGxhdGZvcm1HVEsuY21ha2U6IERpdHRvLgor ICAgICAgICAqIHBsYXRmb3JtL0xpbnV4LmNtYWtlOiBBZGRlZC4KKworMjAxNi0wMi0xMyAgS29u c3RhbnRpbiBUb2thcmV2ICA8YW5udWxlbkB5YW5kZXgucnU+CisKICAgICAgICAgW2NtYWtlXSBD b25zb2xpZGF0ZSBidWlsZGluZyBvZiBHU3RyZWFtZXIgYW5kIE9wZW5XZWJSVEMgY29kZS4KICAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1NDExNgogCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9QbGF0Zm9ybUVmbC5jbWFrZSBiL1NvdXJjZS9XZWJD b3JlL1BsYXRmb3JtRWZsLmNtYWtlCmluZGV4IDUxZmE2MDVmOTMwZmMzM2FjMjdmN2NiMDMwMGZm NTBkNjJjOTFkY2UuLmU4MzIzYzc0ZjQ5MjQxZmVhOGFlNGFlMzIxMzRlNTA3NWRiZjA0OGYgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL1BsYXRmb3JtRWZsLmNtYWtlCisrKyBiL1NvdXJjZS9X ZWJDb3JlL1BsYXRmb3JtRWZsLmNtYWtlCkBAIC0xLDUgKzEsNiBAQAogaW5jbHVkZShwbGF0Zm9y bS9HU3RyZWFtZXIuY21ha2UpCiBpbmNsdWRlKHBsYXRmb3JtL0ltYWdlRGVjb2RlcnMuY21ha2Up CitpbmNsdWRlKHBsYXRmb3JtL0xpbnV4LmNtYWtlKQogaW5jbHVkZShwbGF0Zm9ybS9UZXh0dXJl TWFwcGVyLmNtYWtlKQogCiBsaXN0KEFQUEVORCBXZWJDb3JlX0lOQ0xVREVfRElSRUNUT1JJRVMK QEAgLTQwLDcgKzQxLDYgQEAgbGlzdChBUFBFTkQgV2ViQ29yZV9JTkNMVURFX0RJUkVDVE9SSUVT CiAgICAgIiR7V0VCQ09SRV9ESVJ9L3BsYXRmb3JtL2dyYXBoaWNzL3N1cmZhY2VzL2VmbCIKICAg ICAiJHtXRUJDT1JFX0RJUn0vcGxhdGZvcm0vZ3JhcGhpY3Mvc3VyZmFjZXMvZ2x4IgogICAgICIk e1dFQkNPUkVfRElSfS9wbGF0Zm9ybS9ncmFwaGljcy94MTEiCi0gICAgIiR7V0VCQ09SRV9ESVJ9 L3BsYXRmb3JtL2xpbnV4IgogICAgICIke1dFQkNPUkVfRElSfS9wbGF0Zm9ybS9tb2NrL21lZGlh c291cmNlIgogICAgICIke1dFQkNPUkVfRElSfS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAiCiAgICAg IiR7V0VCQ09SRV9ESVJ9L3BsYXRmb3JtL3RleHQvZWZsIgpAQCAtMTg3LDkgKzE4Nyw2IEBAIGxp c3QoQVBQRU5EIFdlYkNvcmVfU09VUkNFUwogCiAgICAgcGxhdGZvcm0vaW1hZ2UtZGVjb2RlcnMv Y2Fpcm8vSW1hZ2VEZWNvZGVyQ2Fpcm8uY3BwCiAKLSAgICBwbGF0Zm9ybS9saW51eC9HYW1lcGFk RGV2aWNlTGludXguY3BwCi0gICAgcGxhdGZvcm0vbGludXgvTWVtb3J5UHJlc3N1cmVIYW5kbGVy TGludXguY3BwCi0KICAgICBwbGF0Zm9ybS9uZXR3b3JrL2VmbC9OZXR3b3JrU3RhdGVOb3RpZmll ckVmbC5jcHAKIAogICAgIHBsYXRmb3JtL25ldHdvcmsvc291cC9BdXRoZW50aWNhdGlvbkNoYWxs ZW5nZVNvdXAuY3BwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9QbGF0Zm9ybUdUSy5jbWFr ZSBiL1NvdXJjZS9XZWJDb3JlL1BsYXRmb3JtR1RLLmNtYWtlCmluZGV4IGY4NTgyYWE0NDVlYWNi ODI4ODg2MDBkZjZhNzYxZDIxNGExMThhM2QuLmRkNGZhODQ4YjdkZjFiZjNjN2ExZmEyOWU5MjRk NDMxMjc3ODE3NzQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL1BsYXRmb3JtR1RLLmNtYWtl CisrKyBiL1NvdXJjZS9XZWJDb3JlL1BsYXRmb3JtR1RLLmNtYWtlCkBAIC0xLDUgKzEsNiBAQAog aW5jbHVkZShwbGF0Zm9ybS9HU3RyZWFtZXIuY21ha2UpCiBpbmNsdWRlKHBsYXRmb3JtL0ltYWdl RGVjb2RlcnMuY21ha2UpCitpbmNsdWRlKHBsYXRmb3JtL0xpbnV4LmNtYWtlKQogaW5jbHVkZShw bGF0Zm9ybS9UZXh0dXJlTWFwcGVyLmNtYWtlKQogCiBzZXQoV2ViQ29yZV9PVVRQVVRfTkFNRSBX ZWJDb3JlR1RLKQpAQCAtNDMsNyArNDQsNiBAQCBsaXN0KEFQUEVORCBXZWJDb3JlX0lOQ0xVREVf RElSRUNUT1JJRVMKICAgICAiJHtXRUJDT1JFX0RJUn0vcGxhdGZvcm0vZ3JhcGhpY3Mvb3BlbnR5 cGUiCiAgICAgIiR7V0VCQ09SRV9ESVJ9L3BsYXRmb3JtL2dyYXBoaWNzL3dheWxhbmQiCiAgICAg IiR7V0VCQ09SRV9ESVJ9L3BsYXRmb3JtL2dyYXBoaWNzL3gxMSIKLSAgICAiJHtXRUJDT1JFX0RJ Un0vcGxhdGZvcm0vbGludXgiCiAgICAgIiR7V0VCQ09SRV9ESVJ9L3BsYXRmb3JtL21vY2svbWVk aWFzb3VyY2UiCiAgICAgIiR7V0VCQ09SRV9ESVJ9L3BsYXRmb3JtL25ldHdvcmsvZ3RrIgogICAg ICIke1dFQkNPUkVfRElSfS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAiCkBAIC0xNTIsOSArMTUyLDYg QEAgbGlzdChBUFBFTkQgV2ViQ29yZV9TT1VSQ0VTCiAKICAgICBwbGF0Zm9ybS9pbWFnZS1kZWNv ZGVycy9jYWlyby9JbWFnZURlY29kZXJDYWlyby5jcHAKIAotICAgIHBsYXRmb3JtL2xpbnV4L0dh bWVwYWREZXZpY2VMaW51eC5jcHAKLSAgICBwbGF0Zm9ybS9saW51eC9NZW1vcnlQcmVzc3VyZUhh bmRsZXJMaW51eC5jcHAKLQogICAgIHBsYXRmb3JtL25ldHdvcmsvZ3RrL0NyZWRlbnRpYWxCYWNr aW5nU3RvcmUuY3BwCiAKICAgICBwbGF0Zm9ybS9uZXR3b3JrL3NvdXAvQXV0aGVudGljYXRpb25D aGFsbGVuZ2VTb3VwLmNwcApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vTGlu dXguY21ha2UgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9MaW51eC5jbWFrZQpuZXcgZmlsZSBt b2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw Li42NTgzZmY4NjVkZGYzNjFkZjAxYjIwMWQ1ZTMzMjRiNDJlMGFmNmU5Ci0tLSAvZGV2L251bGwK KysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vTGludXguY21ha2UKQEAgLTAsMCArMSw4IEBA CitsaXN0KEFQUEVORCBXZWJDb3JlX0lOQ0xVREVfRElSRUNUT1JJRVMKKyAgICAiJHtXRUJDT1JF X0RJUn0vcGxhdGZvcm0vbGludXgiCispCisKK2xpc3QoQVBQRU5EIFdlYkNvcmVfU09VUkNFUwor ICAgIHBsYXRmb3JtL2xpbnV4L0dhbWVwYWREZXZpY2VMaW51eC5jcHAKKyAgICBwbGF0Zm9ybS9s aW51eC9NZW1vcnlQcmVzc3VyZUhhbmRsZXJMaW51eC5jcHAKKykK