154211 2016-02-12 22:28:48 -0800 Change the last RefPtr::get() to release() in String.prototype.normalize 2016-02-21 17:01:33 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 sukolsak webkit-unassigned commit-queue keith_miller mark.lam msaboff saam oldest_to_newest 1164496 0 sukolsak 2016-02-12 22:28:48 -0800 Change the last RefPtr::get() to release() in String.prototype.normalize 1164497 1 271272 sukolsak 2016-02-12 22:30:32 -0800 Created attachment 271272 Patch 1164500 2 271272 commit-queue 2016-02-12 23:22:00 -0800 Comment on attachment 271272 Patch Clearing flags on attachment: 271272 Committed r196547: <http://trac.webkit.org/changeset/196547> 1164501 3 commit-queue 2016-02-12 23:22:03 -0800 All reviewed patches have been landed. Closing bug. 1166891 4 271272 darin 2016-02-21 17:01:33 -0800 Comment on attachment 271272 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=271272&action=review > Source/JavaScriptCore/runtime/StringPrototype.cpp:1922 > + return jsString(exec, impl.release()); Should be WTFMove, not release, in new code. 271272 2016-02-12 22:30:32 -0800 2016-02-12 23:22:00 -0800 Patch bug-154211-20160212223320.patch text/plain 1481 sukolsak U3VidmVyc2lvbiBSZXZpc2lvbjogMTk2NTM2CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAz ZTk2NDI2NzA4NmNhNjllZjYzNThkMzI2OGFkMmFlN2I4OTY2MDhiLi5lMjNjMDhmZmExYjNjM2Fh NzJjOGU3YWRjNzgyYjRkM2Y4OTE2N2Y4IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNSBAQAorMjAxNi0wMi0xMiAgU3Vrb2xzYWsgU2Frc2h1d29uZyAgPHN1a29sc2FrQGdt YWlsLmNvbT4KKworICAgICAgICBDaGFuZ2UgdGhlIGxhc3QgUmVmUHRyOjpnZXQoKSB0byByZWxl YXNlKCkgaW4gU3RyaW5nLnByb3RvdHlwZS5ub3JtYWxpemUKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1NDIxMQorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENoYW5nZSB0aGUgbGFzdCBSZWZQdHI6OmdldCgp IHRvIHJlbGVhc2UoKSBpbiBTdHJpbmcucHJvdG90eXBlLm5vcm1hbGl6ZS4KKworICAgICAgICAq IHJ1bnRpbWUvU3RyaW5nUHJvdG90eXBlLmNwcDoKKyAgICAgICAgKEpTQzo6bm9ybWFsaXplKToK KwogMjAxNi0wMi0xMiAgU2FhbSBiYXJhdGkgIDxzYmFyYXRpQGFwcGxlLmNvbT4KIAogICAgICAg ICBUaGUgcGFyc2VyIGRvZXNuJ3QgcHJvcGVybHkgcHJvdGVjdCBhZ2FpbnN0IGdsb2JhbCB2YXJp YWJsZSByZWZlcmVuY2VzIGluIGJ1aWx0aW5zCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvcnVudGltZS9TdHJpbmdQcm90b3R5cGUuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3Jl L3J1bnRpbWUvU3RyaW5nUHJvdG90eXBlLmNwcAppbmRleCA3ZGY5M2U1ZjlkMjg2ZTI0YmI3YzJj OTgyMzE4MjkyN2FkN2MxZTY4Li45YTdjZmRiODE2MGY2OTdhODRkZjI4YmI1YTYyMmY3MjM3MzBm M2VjIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9TdHJpbmdQcm90 b3R5cGUuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1N0cmluZ1Byb3Rv dHlwZS5jcHAKQEAgLTE5MTksNyArMTkxOSw3IEBAIHN0YXRpYyBKU1ZhbHVlIG5vcm1hbGl6ZShF eGVjU3RhdGUqIGV4ZWMsIGNvbnN0IFVDaGFyKiBzb3VyY2UsIHNpemVfdCBzb3VyY2VMZW5nCiAg ICAgaWYgKFVfRkFJTFVSRShzdGF0dXMpKQogICAgICAgICByZXR1cm4gdGhyb3dUeXBlRXJyb3Io ZXhlYyk7CiAKLSAgICByZXR1cm4ganNTdHJpbmcoZXhlYywgaW1wbC5nZXQoKSk7CisgICAgcmV0 dXJuIGpzU3RyaW5nKGV4ZWMsIGltcGwucmVsZWFzZSgpKTsKIH0KIAogRW5jb2RlZEpTVmFsdWUg SlNDX0hPU1RfQ0FMTCBzdHJpbmdQcm90b0Z1bmNOb3JtYWxpemUoRXhlY1N0YXRlKiBleGVjKQo=