154202 2016-02-12 16:11:23 -0800 Eliminate the need for WTFCrashImpl(). 2016-02-15 09:22:35 -0800 1 1 1 Unclassified WebKit Web Template Framework WebKit Local Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mark.lam mark.lam achristensen benjamin cdumez cmarcelo commit-queue ddkilzer ossy peavo oldest_to_newest 1164412 0 mark.lam 2016-02-12 16:11:23 -0800 Patch coming. 1164423 1 271243 mark.lam 2016-02-12 16:25:14 -0800 Created attachment 271243 proposed patch. 1164439 2 commit-queue 2016-02-12 17:02:56 -0800 Attachment 271243 did not pass style-queue: ERROR: Source/WTF/wtf/Assertions.h:245: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WTF/wtf/Assertions.h:252: Multi line control clauses should use braces. [whitespace/braces] [4] Total errors found: 2 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 1164573 3 271243 ap 2016-02-13 13:52:10 -0800 Comment on attachment 271243 proposed patch. I'm also marking this cq+, so that it lands ASAP. The change in crash signatures due to WTFCrashImpl is a huge problem, so if this doesn't work, we'll just need to roll out the whole set of patches. 1164575 4 271243 commit-queue 2016-02-13 14:39:53 -0800 Comment on attachment 271243 proposed patch. Clearing flags on attachment: 271243 Committed r196554: <http://trac.webkit.org/changeset/196554> 1164576 5 commit-queue 2016-02-13 14:39:58 -0800 All reviewed patches have been landed. Closing bug. 1164612 6 ossy 2016-02-14 00:03:00 -0800 It broke the Wincairo build, cc-ing port maintainers. 1164759 7 mark.lam 2016-02-15 09:18:58 -0800 (In reply to comment #6) > It broke the Wincairo build, cc-ing port maintainers. Ossy, any details on the breakage? What is the error message? Thanks. 1164760 8 achristensen 2016-02-15 09:22:35 -0800 https://build.webkit.org/builders/WinCairo%2064-Bit%20Release/builds/53937/steps/compile-webkit/logs/stdio Not a problem with this patch. I think the forwarding headers from WTF are being copied pre-link instead of pre-build when using Ninja instead of Visual Studio to drive the build. I'll need to look into this, but this is not a problem with this patch. 271243 2016-02-12 16:25:14 -0800 2016-02-13 14:39:53 -0800 proposed patch. bug-154202.patch text/plain 5873 mark.lam SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAxOTY1MjUpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDE2LTAyLTEyICBNYXJrIExhbSAgPG1hcmsubGFt QGFwcGxlLmNvbT4KKworICAgICAgICBFbGltaW5hdGUgdGhlIG5lZWQgZm9yIFdURkNyYXNoSW1w bCgpLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU0 MjAyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiB3 dGYvQXNzZXJ0aW9ucy5jcHA6CisgICAgICAgICogd3RmL0Fzc2VydGlvbnMuaDoKKwogMjAxNi0w Mi0xMiAgU3Vrb2xzYWsgU2Frc2h1d29uZyAgPHN1a29sc2FrQGdtYWlsLmNvbT4KIAogICAgICAg ICBVcGRhdGUgSUNVIGhlYWRlciBmaWxlcyB0byB2ZXJzaW9uIDUyCkluZGV4OiBTb3VyY2UvV1RG L3d0Zi9Bc3NlcnRpb25zLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV1RGL3d0Zi9Bc3NlcnRp b25zLmNwcAkocmV2aXNpb24gMTk2NDgxKQorKysgU291cmNlL1dURi93dGYvQXNzZXJ0aW9ucy5j cHAJKHdvcmtpbmcgY29weSkKQEAgLTMxMyw3ICszMTMsNyBAQCB2b2lkIFdURlNldENyYXNoSG9v ayhXVEZDcmFzaEhvb2tGdW5jdGlvCiB9CiAKICNpZiAhZGVmaW5lZChOREVCVUcpIHx8ICFPUyhE QVJXSU4pCi12b2lkIFdURkNyYXNoSW1wbCgpCit2b2lkIFdURkNyYXNoKCkKIHsKICAgICBpZiAo Z2xvYmFsSG9vaykKICAgICAgICAgZ2xvYmFsSG9vaygpOwpAQCAtMzI3LDggKzMyNyw3IEBAIHZv aWQgV1RGQ3Jhc2hJbXBsKCkKICAgICAoKHZvaWQoKikoKSkwKSgpOwogI2VuZGlmCiB9Ci0jZW5k aWYgLy8gIWRlZmluZWQoTkRFQlVHKSB8fCAhT1MoREFSV0lOKQotICAgIAorI2Vsc2UKIC8vIFdl IG5lZWQgdG8ga2VlcCBXVEZDcmFzaCgpIGFyb3VuZCAoZXZlbiBvbiBub24tZGVidWcgT1MoREFS V0lOKSBidWlsZHMpIGFzIGEgd29ya2Fyb3VuZAogLy8gZm9yIHByZXNlbnRseSBzaGlwcGluZyAo Y2lyY2EgZWFybHkgMjAxNikgU2FmYXJpRm9yV2ViS2l0RGV2ZWxvcG1lbnQgYmluYXJpZXMgd2hp Y2ggc3RpbGwKIC8vIGV4cGVjdHMgdG8gbGluayB0byBpdC4KQEAgLTMzNiw2ICszMzUsNyBAQCB2 b2lkIFdURkNyYXNoKCkKIHsKICAgICBDUkFTSCgpOwogfQorI2VuZGlmIC8vICFkZWZpbmVkKE5E RUJVRykgfHwgIU9TKERBUldJTikKIAogdm9pZCBXVEZDcmFzaFdpdGhTZWN1cml0eUltcGxpY2F0 aW9uKCkKIHsKSW5kZXg6IFNvdXJjZS9XVEYvd3RmL0Fzc2VydGlvbnMuaAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvV1RGL3d0Zi9Bc3NlcnRpb25zLmgJKHJldmlzaW9uIDE5NjQ4MSkKKysrIFNvdXJj ZS9XVEYvd3RmL0Fzc2VydGlvbnMuaAkod29ya2luZyBjb3B5KQpAQCAtMTUyLDMwICsxNTIsMzEg QEAgV1RGX0VYUE9SVF9QUklWQVRFIHZvaWQgV1RGSW5zdGFsbFJlcG9ydAogV1RGX0VYUE9SVF9Q UklWQVRFIGJvb2wgV1RGSXNEZWJ1Z2dlckF0dGFjaGVkKCk7CiAKICNpZm5kZWYgQ1JBU0gKLSNk ZWZpbmUgQ1JBU0goKSBXVEZDcmFzaEltcGwoKQotI2VuZGlmCiAKICNpZiBkZWZpbmVkKE5ERUJV RykgJiYgT1MoREFSV0lOKQotQUxXQVlTX0lOTElORSBOT19SRVRVUk5fRFVFX1RPX0NSQVNIIHZv aWQgV1RGQ3Jhc2hJbXBsKCkKLXsKLSAgICAvLyBDcmFzaCB3aXRoIGEgU0lHVFJBUCBpLmUgRVhD X0JSRUFLUE9JTlQuCi0gICAgLy8gV2UgYXJlIG5vdCB1c2luZyBfX2J1aWx0aW5fdHJhcCBiZWNh dXNlIGl0IGlzIG9ubHkgZ3VhcmFudGVlZCB0byBhYm9ydCwgYnV0IG5vdCBuZWNlc3NhcmlseQot ICAgIC8vIHRyaWdnZXIgYSBTSUdUUkFQLiBJbnN0ZWFkLCB3ZSB1c2UgaW5saW5lIGFzbSB0byBl bnN1cmUgdGhhdCB3ZSB0cmlnZ2VyIHRoZSBTSUdUUkFQLgogI2lmIENQVShYODZfNjQpIHx8IENQ VShYODYpCi0gICAgYXNtIHZvbGF0aWxlICgiaW50MyIpOworI2RlZmluZSBXVEZCcmVha3BvaW50 VHJhcCgpICBhc20gdm9sYXRpbGUgKCJpbnQzIikKICNlbGlmIENQVShBUk1fVEhVTUIyKQotICAg IGFzbSB2b2xhdGlsZSAoImJrcHQgIzAiKTsKKyNkZWZpbmUgV1RGQnJlYWtwb2ludFRyYXAoKSAg YXNtIHZvbGF0aWxlICgiYmtwdCAjMCIpCiAjZWxpZiBDUFUoQVJNNjQpCi0gICAgYXNtIHZvbGF0 aWxlICgiYnJrICMwIik7CisjZGVmaW5lIFdURkJyZWFrcG9pbnRUcmFwKCkgIGFzbSB2b2xhdGls ZSAoImJyayAjMCIpCiAjZWxzZQogI2Vycm9yICJVbnN1cHBvcnRlZCBDUFUiLgogI2VuZGlmCi0g ICAgX19idWlsdGluX3VucmVhY2hhYmxlKCk7Ci19CisKKy8vIENyYXNoIHdpdGggYSBTSUdUUkFQ IGkuZSBFWENfQlJFQUtQT0lOVC4KKy8vIFdlIGFyZSBub3QgdXNpbmcgX19idWlsdGluX3RyYXAg YmVjYXVzZSBpdCBpcyBvbmx5IGd1YXJhbnRlZWQgdG8gYWJvcnQsIGJ1dCBub3QgbmVjZXNzYXJp bHkKKy8vIHRyaWdnZXIgYSBTSUdUUkFQLiBJbnN0ZWFkLCB3ZSB1c2UgaW5saW5lIGFzbSB0byBl bnN1cmUgdGhhdCB3ZSB0cmlnZ2VyIHRoZSBTSUdUUkFQLgorI2RlZmluZSBDUkFTSCgpIGRvIHsg XAorICAgIFdURkJyZWFrcG9pbnRUcmFwKCk7IFwKKyAgICBfX2J1aWx0aW5fdW5yZWFjaGFibGUo KTsgXAorfSB3aGlsZSAoMCkKICNlbHNlCi1XVEZfRVhQT1JUX1BSSVZBVEUgTk9fUkVUVVJOX0RV RV9UT19DUkFTSCB2b2lkIFdURkNyYXNoSW1wbCgpOworI2RlZmluZSBDUkFTSCgpIFdURkNyYXNo KCkKICNlbmRpZgogCisjZW5kaWYgLy8gQ1JBU0gKKwogV1RGX0VYUE9SVF9QUklWQVRFIE5PX1JF VFVSTl9EVUVfVE9fQ1JBU0ggdm9pZCBXVEZDcmFzaCgpOwogCiAjaWZuZGVmIENSQVNIX1dJVEhf U0VDVVJJVFlfSU1QTElDQVRJT04KQEAgLTI0MCwxNyArMjQxLDE5IEBAIFdURl9FWFBPUlRfUFJJ VkFURSBOT19SRVRVUk5fRFVFX1RPX0NSQVMKIAogI2Vsc2UKIAotI2RlZmluZSBBU1NFUlQoYXNz ZXJ0aW9uKSBcCi0gICAgKCEoYXNzZXJ0aW9uKSA/IFwKLSAgICAgICAgKFdURlJlcG9ydEFzc2Vy dGlvbkZhaWx1cmUoX19GSUxFX18sIF9fTElORV9fLCBXVEZfUFJFVFRZX0ZVTkNUSU9OLCAjYXNz ZXJ0aW9uKSwgXAotICAgICAgICAgQ1JBU0goKSkgOiBcCi0gICAgICAgICh2b2lkKTApCisjZGVm aW5lIEFTU0VSVChhc3NlcnRpb24pIGRvIHsgXAorICAgIGlmICghKGFzc2VydGlvbikpIHsgXAor ICAgICAgICBXVEZSZXBvcnRBc3NlcnRpb25GYWlsdXJlKF9fRklMRV9fLCBfX0xJTkVfXywgV1RG X1BSRVRUWV9GVU5DVElPTiwgI2Fzc2VydGlvbik7IFwKKyAgICAgICAgQ1JBU0goKTsgXAorICAg IH0gXAorfSB3aGlsZSAoMCkKIAotI2RlZmluZSBBU1NFUlRfQVQoYXNzZXJ0aW9uLCBmaWxlLCBs aW5lLCBmdW5jdGlvbikgXAotICAgICghKGFzc2VydGlvbikgPyBcCi0gICAgICAgIChXVEZSZXBv cnRBc3NlcnRpb25GYWlsdXJlKGZpbGUsIGxpbmUsIGZ1bmN0aW9uLCAjYXNzZXJ0aW9uKSwgXAot ICAgICAgICAgQ1JBU0goKSkgOiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIFwKLSAgICAgICAgKHZvaWQpMCkKKyNkZWZpbmUgQVNTRVJUX0FUKGFzc2Vy dGlvbiwgZmlsZSwgbGluZSwgZnVuY3Rpb24pIGRvIHsgXAorICAgIGlmICghKGFzc2VydGlvbikp IHsgXAorICAgICAgICBXVEZSZXBvcnRBc3NlcnRpb25GYWlsdXJlKGZpbGUsIGxpbmUsIGZ1bmN0 aW9uLCAjYXNzZXJ0aW9uKTsgXAorICAgICAgICBDUkFTSCgpOyBcCisgICAgfSBcCit9IHdoaWxl ICgwKQogCiAjZGVmaW5lIEFTU0VSVF9OT1RfUkVBQ0hFRCgpIGRvIHsgXAogICAgIFdURlJlcG9y dEFzc2VydGlvbkZhaWx1cmUoX19GSUxFX18sIF9fTElORV9fLCBXVEZfUFJFVFRZX0ZVTkNUSU9O LCAwKTsgXApAQCAtMjgyLDEyICsyODUsMTIgQEAgV1RGX0VYUE9SVF9QUklWQVRFIE5PX1JFVFVS Tl9EVUVfVE9fQ1JBUwogI2lmIEFTU0VSVF9NU0dfRElTQUJMRUQKICNkZWZpbmUgQVNTRVJUX1dJ VEhfTUVTU0FHRShhc3NlcnRpb24sIC4uLikgKCh2b2lkKTApCiAjZWxzZQotI2RlZmluZSBBU1NF UlRfV0lUSF9NRVNTQUdFKGFzc2VydGlvbiwgLi4uKSBkbyBcCisjZGVmaW5lIEFTU0VSVF9XSVRI X01FU1NBR0UoYXNzZXJ0aW9uLCAuLi4pIGRvIHsgXAogICAgIGlmICghKGFzc2VydGlvbikpIHsg XAogICAgICAgICBXVEZSZXBvcnRBc3NlcnRpb25GYWlsdXJlV2l0aE1lc3NhZ2UoX19GSUxFX18s IF9fTElORV9fLCBXVEZfUFJFVFRZX0ZVTkNUSU9OLCAjYXNzZXJ0aW9uLCBfX1ZBX0FSR1NfXyk7 IFwKICAgICAgICAgQ1JBU0goKTsgXAogICAgIH0gXAotd2hpbGUgKDApCit9IHdoaWxlICgwKQog I2VuZGlmCiAKIC8qIEFTU0VSVF9XSVRIX01FU1NBR0VfVU5VU0VEICovCkBAIC0yOTUsMTIgKzI5 OCwxMiBAQCB3aGlsZSAoMCkKICNpZiBBU1NFUlRfTVNHX0RJU0FCTEVECiAjZGVmaW5lIEFTU0VS VF9XSVRIX01FU1NBR0VfVU5VU0VEKHZhcmlhYmxlLCBhc3NlcnRpb24sIC4uLikgKCh2b2lkKXZh cmlhYmxlKQogI2Vsc2UKLSNkZWZpbmUgQVNTRVJUX1dJVEhfTUVTU0FHRV9VTlVTRUQodmFyaWFi bGUsIGFzc2VydGlvbiwgLi4uKSBkbyBcCisjZGVmaW5lIEFTU0VSVF9XSVRIX01FU1NBR0VfVU5V U0VEKHZhcmlhYmxlLCBhc3NlcnRpb24sIC4uLikgZG8geyBcCiAgICAgaWYgKCEoYXNzZXJ0aW9u KSkgeyBcCiAgICAgICAgIFdURlJlcG9ydEFzc2VydGlvbkZhaWx1cmVXaXRoTWVzc2FnZShfX0ZJ TEVfXywgX19MSU5FX18sIFdURl9QUkVUVFlfRlVOQ1RJT04sICNhc3NlcnRpb24sIF9fVkFfQVJH U19fKTsgXAogICAgICAgICBDUkFTSCgpOyBcCiAgICAgfSBcCi13aGlsZSAoMCkKK30gd2hpbGUg KDApCiAjZW5kaWYKICAgICAgICAgICAgICAgICAgICAgICAgIAogICAgICAgICAgICAgICAgICAg ICAgICAgCkBAIC0zMTIsMTIgKzMxNSwxMiBAQCB3aGlsZSAoMCkKIAogI2Vsc2UKIAotI2RlZmlu ZSBBU1NFUlRfQVJHKGFyZ05hbWUsIGFzc2VydGlvbikgZG8gXAorI2RlZmluZSBBU1NFUlRfQVJH KGFyZ05hbWUsIGFzc2VydGlvbikgZG8geyBcCiAgICAgaWYgKCEoYXNzZXJ0aW9uKSkgeyBcCiAg ICAgICAgIFdURlJlcG9ydEFyZ3VtZW50QXNzZXJ0aW9uRmFpbHVyZShfX0ZJTEVfXywgX19MSU5F X18sIFdURl9QUkVUVFlfRlVOQ1RJT04sICNhcmdOYW1lLCAjYXNzZXJ0aW9uKTsgXAogICAgICAg ICBDUkFTSCgpOyBcCiAgICAgfSBcCi13aGlsZSAoMCkKK30gd2hpbGUgKDApCiAKICNlbmRpZgog CkBAIC0zNzEsNyArMzc0LDEwIEBAIHdoaWxlICgwKQogLyogUkVMRUFTRV9BU1NFUlQgKi8KIAog I2lmIEFTU0VSVF9ESVNBQkxFRAotI2RlZmluZSBSRUxFQVNFX0FTU0VSVChhc3NlcnRpb24pIChV TkxJS0VMWSghKGFzc2VydGlvbikpID8gKENSQVNIKCkpIDogKHZvaWQpMCkKKyNkZWZpbmUgUkVM RUFTRV9BU1NFUlQoYXNzZXJ0aW9uKSBkbyB7IFwKKyAgICBpZiAoVU5MSUtFTFkoIShhc3NlcnRp b24pKSkgXAorICAgICAgICBDUkFTSCgpOyBcCit9IHdoaWxlICgwKQogI2RlZmluZSBSRUxFQVNF X0FTU0VSVF9XSVRIX01FU1NBR0UoYXNzZXJ0aW9uLCAuLi4pIFJFTEVBU0VfQVNTRVJUKGFzc2Vy dGlvbikKICNkZWZpbmUgUkVMRUFTRV9BU1NFUlRfTk9UX1JFQUNIRUQoKSBDUkFTSCgpCiAjZWxz ZQo=