154194 2016-02-12 13:51:53 -0800 Web Inspector: Rename domAgent to domTreeManager in DOMNode 2016-02-12 14:44:25 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED DoNotImportToRadar P2 Normal --- 1 joepeck joepeck bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1164316 0 joepeck 2016-02-12 13:51:53 -0800 * SUMMARY Rename domAgent to domTreeManager in DOMNode. The name "domAgent" is inaccurate and misleading. 1164319 1 271220 joepeck 2016-02-12 13:52:59 -0800 Created attachment 271220 [PATCH] Proposed Fix 1164364 2 271220 commit-queue 2016-02-12 14:44:23 -0800 Comment on attachment 271220 [PATCH] Proposed Fix Clearing flags on attachment: 271220 Committed r196517: <http://trac.webkit.org/changeset/196517> 1164365 3 commit-queue 2016-02-12 14:44:25 -0800 All reviewed patches have been landed. Closing bug. 271220 2016-02-12 13:52:59 -0800 2016-02-12 14:44:23 -0800 [PATCH] Proposed Fix rename-domagent.patch text/plain 4496 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDA1MGFkMzcuLjNmNDc4MzYgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE1IEBACiAyMDE2LTAyLTEyICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogUmVuYW1l IGRvbUFnZW50IHRvIGRvbVRyZWVNYW5hZ2VyIGluIERPTU5vZGUKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1NDE5NAorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9Nb2RlbHMvRE9N Tm9kZS5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5ET01Ob2RlKToKKworMjAxNi0wMi0xMiAg Sm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgorCiAgICAgICAgIFdlYiBJbnNw ZWN0b3I6IFRhYnM6IENvbmZsaWN0cyB3aXRoIG11bHRpcGxlIEZvcm1hdHRlcnMgcGVyIFNvdXJj ZUNvZGUKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0 NDcxNwogICAgICAgICA8cmRhcjovL3Byb2JsZW0vMjA4NDUxNjM+CmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Nb2RlbHMvRE9NTm9kZS5qcyBiL1NvdXJj ZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL01vZGVscy9ET01Ob2RlLmpzCmluZGV4IDAz MTFlN2EuLjBiMmU0NzAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50 ZXJmYWNlL01vZGVscy9ET01Ob2RlLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2Vy SW50ZXJmYWNlL01vZGVscy9ET01Ob2RlLmpzCkBAIC0zMiwxNSArMzIsMTUgQEAKIAogV2ViSW5z cGVjdG9yLkRPTU5vZGUgPSBjbGFzcyBET01Ob2RlIGV4dGVuZHMgV2ViSW5zcGVjdG9yLk9iamVj dAogewotICAgIGNvbnN0cnVjdG9yKGRvbUFnZW50LCBkb2MsIGlzSW5TaGFkb3dUcmVlLCBwYXls b2FkKQorICAgIGNvbnN0cnVjdG9yKGRvbVRyZWVNYW5hZ2VyLCBkb2MsIGlzSW5TaGFkb3dUcmVl LCBwYXlsb2FkKQogICAgIHsKICAgICAgICAgc3VwZXIoKTsKIAotICAgICAgICB0aGlzLl9kb21B Z2VudCA9IGRvbUFnZW50OworICAgICAgICB0aGlzLl9kb21UcmVlTWFuYWdlciA9IGRvbVRyZWVN YW5hZ2VyOwogICAgICAgICB0aGlzLl9pc0luU2hhZG93VHJlZSA9IGlzSW5TaGFkb3dUcmVlOwog CiAgICAgICAgIHRoaXMuaWQgPSBwYXlsb2FkLm5vZGVJZDsKLSAgICAgICAgZG9tQWdlbnQuX2lk VG9ET01Ob2RlW3RoaXMuaWRdID0gdGhpczsKKyAgICAgICAgdGhpcy5fZG9tVHJlZU1hbmFnZXIu X2lkVG9ET01Ob2RlW3RoaXMuaWRdID0gdGhpczsKIAogICAgICAgICB0aGlzLl9ub2RlVHlwZSA9 IHBheWxvYWQubm9kZVR5cGU7CiAgICAgICAgIHRoaXMuX25vZGVOYW1lID0gcGF5bG9hZC5ub2Rl TmFtZTsKQEAgLTc0LDEzICs3NCwxMyBAQCBXZWJJbnNwZWN0b3IuRE9NTm9kZSA9IGNsYXNzIERP TU5vZGUgZXh0ZW5kcyBXZWJJbnNwZWN0b3IuT2JqZWN0CiAgICAgICAgIGlmIChwYXlsb2FkLnNo YWRvd1Jvb3RzKSB7CiAgICAgICAgICAgICBmb3IgKHZhciBpID0gMDsgaSA8IHBheWxvYWQuc2hh ZG93Um9vdHMubGVuZ3RoOyArK2kpIHsKICAgICAgICAgICAgICAgICB2YXIgcm9vdCA9IHBheWxv YWQuc2hhZG93Um9vdHNbaV07Ci0gICAgICAgICAgICAgICAgdmFyIG5vZGUgPSBuZXcgV2ViSW5z cGVjdG9yLkRPTU5vZGUodGhpcy5fZG9tQWdlbnQsIHRoaXMub3duZXJEb2N1bWVudCwgdHJ1ZSwg cm9vdCk7CisgICAgICAgICAgICAgICAgdmFyIG5vZGUgPSBuZXcgV2ViSW5zcGVjdG9yLkRPTU5v ZGUodGhpcy5fZG9tVHJlZU1hbmFnZXIsIHRoaXMub3duZXJEb2N1bWVudCwgdHJ1ZSwgcm9vdCk7 CiAgICAgICAgICAgICAgICAgdGhpcy5fc2hhZG93Um9vdHMucHVzaChub2RlKTsKICAgICAgICAg ICAgIH0KICAgICAgICAgfQogCiAgICAgICAgIGlmIChwYXlsb2FkLnRlbXBsYXRlQ29udGVudCkg ewotICAgICAgICAgICAgdGhpcy5fdGVtcGxhdGVDb250ZW50ID0gbmV3IFdlYkluc3BlY3Rvci5E T01Ob2RlKHRoaXMuX2RvbUFnZW50LCB0aGlzLm93bmVyRG9jdW1lbnQsIHRydWUsIHBheWxvYWQu dGVtcGxhdGVDb250ZW50KTsKKyAgICAgICAgICAgIHRoaXMuX3RlbXBsYXRlQ29udGVudCA9IG5l dyBXZWJJbnNwZWN0b3IuRE9NTm9kZSh0aGlzLl9kb21UcmVlTWFuYWdlciwgdGhpcy5vd25lckRv Y3VtZW50LCB0cnVlLCBwYXlsb2FkLnRlbXBsYXRlQ29udGVudCk7CiAgICAgICAgICAgICB0aGlz Ll90ZW1wbGF0ZUNvbnRlbnQucGFyZW50Tm9kZSA9IHRoaXM7CiAgICAgICAgIH0KIApAQCAtOTAs MTQgKzkwLDE0IEBAIFdlYkluc3BlY3Rvci5ET01Ob2RlID0gY2xhc3MgRE9NTm9kZSBleHRlbmRz IFdlYkluc3BlY3Rvci5PYmplY3QKICAgICAgICAgdGhpcy5fcHNldWRvRWxlbWVudHMgPSBuZXcg TWFwOwogICAgICAgICBpZiAocGF5bG9hZC5wc2V1ZG9FbGVtZW50cykgewogICAgICAgICAgICAg Zm9yICh2YXIgaSA9IDA7IGkgPCBwYXlsb2FkLnBzZXVkb0VsZW1lbnRzLmxlbmd0aDsgKytpKSB7 Ci0gICAgICAgICAgICAgICAgdmFyIG5vZGUgPSBuZXcgV2ViSW5zcGVjdG9yLkRPTU5vZGUodGhp cy5fZG9tQWdlbnQsIHRoaXMub3duZXJEb2N1bWVudCwgdGhpcy5faXNJblNoYWRvd1RyZWUsIHBh eWxvYWQucHNldWRvRWxlbWVudHNbaV0pOworICAgICAgICAgICAgICAgIHZhciBub2RlID0gbmV3 IFdlYkluc3BlY3Rvci5ET01Ob2RlKHRoaXMuX2RvbVRyZWVNYW5hZ2VyLCB0aGlzLm93bmVyRG9j dW1lbnQsIHRoaXMuX2lzSW5TaGFkb3dUcmVlLCBwYXlsb2FkLnBzZXVkb0VsZW1lbnRzW2ldKTsK ICAgICAgICAgICAgICAgICBub2RlLnBhcmVudE5vZGUgPSB0aGlzOwogICAgICAgICAgICAgICAg IHRoaXMuX3BzZXVkb0VsZW1lbnRzLnNldChub2RlLnBzZXVkb1R5cGUoKSwgbm9kZSk7CiAgICAg ICAgICAgICB9CiAgICAgICAgIH0KIAogICAgICAgICBpZiAocGF5bG9hZC5jb250ZW50RG9jdW1l bnQpIHsKLSAgICAgICAgICAgIHRoaXMuX2NvbnRlbnREb2N1bWVudCA9IG5ldyBXZWJJbnNwZWN0 b3IuRE9NTm9kZShkb21BZ2VudCwgbnVsbCwgZmFsc2UsIHBheWxvYWQuY29udGVudERvY3VtZW50 KTsKKyAgICAgICAgICAgIHRoaXMuX2NvbnRlbnREb2N1bWVudCA9IG5ldyBXZWJJbnNwZWN0b3Iu RE9NTm9kZSh0aGlzLl9kb21UcmVlTWFuYWdlciwgbnVsbCwgZmFsc2UsIHBheWxvYWQuY29udGVu dERvY3VtZW50KTsKICAgICAgICAgICAgIHRoaXMuX2NoaWxkcmVuID0gW3RoaXMuX2NvbnRlbnRE b2N1bWVudF07CiAgICAgICAgICAgICB0aGlzLl9yZW51bWJlcigpOwogICAgICAgICB9CkBAIC01 MjYsNyArNTI2LDcgQEAgV2ViSW5zcGVjdG9yLkRPTU5vZGUgPSBjbGFzcyBET01Ob2RlIGV4dGVu ZHMgV2ViSW5zcGVjdG9yLk9iamVjdAogCiAgICAgX2luc2VydENoaWxkKHByZXYsIHBheWxvYWQp CiAgICAgewotICAgICAgICB2YXIgbm9kZSA9IG5ldyBXZWJJbnNwZWN0b3IuRE9NTm9kZSh0aGlz Ll9kb21BZ2VudCwgdGhpcy5vd25lckRvY3VtZW50LCB0aGlzLl9pc0luU2hhZG93VHJlZSwgcGF5 bG9hZCk7CisgICAgICAgIHZhciBub2RlID0gbmV3IFdlYkluc3BlY3Rvci5ET01Ob2RlKHRoaXMu X2RvbVRyZWVNYW5hZ2VyLCB0aGlzLm93bmVyRG9jdW1lbnQsIHRoaXMuX2lzSW5TaGFkb3dUcmVl LCBwYXlsb2FkKTsKICAgICAgICAgaWYgKCFwcmV2KSB7CiAgICAgICAgICAgICBpZiAoIXRoaXMu X2NoaWxkcmVuKSB7CiAgICAgICAgICAgICAgICAgLy8gRmlyc3Qgbm9kZQpAQCAtNTYwLDcgKzU2 MCw3IEBAIFdlYkluc3BlY3Rvci5ET01Ob2RlID0gY2xhc3MgRE9NTm9kZSBleHRlbmRzIFdlYklu c3BlY3Rvci5PYmplY3QKIAogICAgICAgICB0aGlzLl9jaGlsZHJlbiA9IHRoaXMuX3NoYWRvd1Jv b3RzLnNsaWNlKCk7CiAgICAgICAgIGZvciAodmFyIGkgPSAwOyBpIDwgcGF5bG9hZHMubGVuZ3Ro OyArK2kpIHsKLSAgICAgICAgICAgIHZhciBub2RlID0gbmV3IFdlYkluc3BlY3Rvci5ET01Ob2Rl KHRoaXMuX2RvbUFnZW50LCB0aGlzLm93bmVyRG9jdW1lbnQsIHRoaXMuX2lzSW5TaGFkb3dUcmVl LCBwYXlsb2Fkc1tpXSk7CisgICAgICAgICAgICB2YXIgbm9kZSA9IG5ldyBXZWJJbnNwZWN0b3Iu RE9NTm9kZSh0aGlzLl9kb21UcmVlTWFuYWdlciwgdGhpcy5vd25lckRvY3VtZW50LCB0aGlzLl9p c0luU2hhZG93VHJlZSwgcGF5bG9hZHNbaV0pOwogICAgICAgICAgICAgdGhpcy5fY2hpbGRyZW4u cHVzaChub2RlKTsKICAgICAgICAgfQogICAgICAgICB0aGlzLl9yZW51bWJlcigpOwo=