154179 2016-02-12 11:56:57 -0800 Re-name isClickableElement in InteractionInformationAtPosition to isElement 2016-02-12 12:32:03 -0800 1 1 1 Unclassified WebKit WebKit Misc. Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 bdakin webkit-unassigned bdakin enrica thorton oldest_to_newest 1164245 0 bdakin 2016-02-12 11:56:57 -0800 Re-name isClickableElement in InteractionInformationAtPosition to isElement 1164249 1 271199 bdakin 2016-02-12 11:58:51 -0800 Created attachment 271199 Patch 1164268 2 271199 enrica 2016-02-12 12:28:49 -0800 Comment on attachment 271199 Patch Yay!! 1164273 3 bdakin 2016-02-12 12:32:03 -0800 Thank you, Enrica! http://trac.webkit.org/changeset/196496 271199 2016-02-12 11:58:51 -0800 2016-02-12 12:28:49 -0800 Patch for-review.txt text/plain 4680 bdakin SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE5NjQ5MCkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIyIEBACisyMDE2LTAyLTEyICBCZXRoIERh a2luICA8YmRha2luQGFwcGxlLmNvbT4KKworICAgICAgICBSZS1uYW1lIGlzQ2xpY2thYmxlRWxl bWVudCBpbiBJbnRlcmFjdGlvbkluZm9ybWF0aW9uQXRQb3NpdGlvbiB0byBpc0VsZW1lbnQKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1NDE3OQorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBib29sIGlz IHNldCBmb3IgYWxsIGVsZW1lbnRzLCBzbyBpdOKAmXMganVzdCBjb25mdXNpbmcgdG8gY2FsbCBp dCBhIAorICAgICAgICBjbGlja2FibGVFbGVtZW50IGluc3RlYWQgb2YganVzdCBlbGVtZW50Lgor ICAgICAgICAqIFNoYXJlZC9pb3MvSW50ZXJhY3Rpb25JbmZvcm1hdGlvbkF0UG9zaXRpb24uaDoK KyAgICAgICAgKiBTaGFyZWQvaW9zL0ludGVyYWN0aW9uSW5mb3JtYXRpb25BdFBvc2l0aW9uLm1t OgorICAgICAgICAoV2ViS2l0OjpJbnRlcmFjdGlvbkluZm9ybWF0aW9uQXRQb3NpdGlvbjo6ZW5j b2RlKToKKyAgICAgICAgKFdlYktpdDo6SW50ZXJhY3Rpb25JbmZvcm1hdGlvbkF0UG9zaXRpb246 OmRlY29kZSk6CisgICAgICAgICogVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rp b24ubW06CisgICAgICAgICgtW1dLQ29udGVudFZpZXcgZ2VzdHVyZVJlY29nbml6ZXJTaG91bGRC ZWdpbjpdKToKKyAgICAgICAgKC1bV0tDb250ZW50VmlldyBfaGlnaGxpZ2h0TG9uZ1ByZXNzUmVj b2duaXplZDpdKToKKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYlBhZ2UvaW9zL1dlYlBhZ2VJT1Mu bW06CisgICAgICAgIChXZWJLaXQ6OldlYlBhZ2U6OmdldFBvc2l0aW9uSW5mb3JtYXRpb24pOgor CiAyMDE2LTAyLTEyICBCcmlhbiBCdXJnICA8YmJ1cmdAYXBwbGUuY29tPgogCiAgICAgICAgIEFk ZCBhIFdlYktpdCBTUEkgZm9yIGNyZWF0aW5nIGFuIGF1dG9tYXRpb24gc2Vzc2lvbiBhbmQgYWR2 ZXJ0aXNlIHRoZSBhY3RpdmUgc2Vzc2lvbiB2aWEgUmVtb3RlSW5zcGVjdG9yCkluZGV4OiBTb3Vy Y2UvV2ViS2l0Mi9TaGFyZWQvaW9zL0ludGVyYWN0aW9uSW5mb3JtYXRpb25BdFBvc2l0aW9uLmgK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvU2hhcmVkL2lvcy9JbnRlcmFjdGlvbkluZm9y bWF0aW9uQXRQb3NpdGlvbi5oCShyZXZpc2lvbiAxOTY0ODMpCisrKyBTb3VyY2UvV2ViS2l0Mi9T aGFyZWQvaW9zL0ludGVyYWN0aW9uSW5mb3JtYXRpb25BdFBvc2l0aW9uLmgJKHdvcmtpbmcgY29w eSkKQEAgLTQ2LDcgKzQ2LDcgQEAgc3RydWN0IEludGVyYWN0aW9uSW5mb3JtYXRpb25BdFBvc2l0 aW9uIAogICAgIGJvb2wgaXNMaW5rIHsgZmFsc2UgfTsKICAgICBib29sIGlzSW1hZ2UgeyBmYWxz ZSB9OwogICAgIGJvb2wgaXNBbmltYXRlZEltYWdlIHsgZmFsc2UgfTsKLSAgICBib29sIGlzQ2xp Y2thYmxlRWxlbWVudCB7IGZhbHNlIH07CisgICAgYm9vbCBpc0VsZW1lbnQgeyBmYWxzZSB9Owog I2lmIEVOQUJMRShEQVRBX0RFVEVDVElPTikKICAgICBib29sIGlzRGF0YURldGVjdG9yTGluayB7 IGZhbHNlIH07CiAjZW5kaWYKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1NoYXJlZC9pb3MvSW50ZXJh Y3Rpb25JbmZvcm1hdGlvbkF0UG9zaXRpb24ubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktp dDIvU2hhcmVkL2lvcy9JbnRlcmFjdGlvbkluZm9ybWF0aW9uQXRQb3NpdGlvbi5tbQkocmV2aXNp b24gMTk2NDgzKQorKysgU291cmNlL1dlYktpdDIvU2hhcmVkL2lvcy9JbnRlcmFjdGlvbkluZm9y bWF0aW9uQXRQb3NpdGlvbi5tbQkod29ya2luZyBjb3B5KQpAQCAtNDksNyArNDksNyBAQCB2b2lk IEludGVyYWN0aW9uSW5mb3JtYXRpb25BdFBvc2l0aW9uOjplCiAgICAgZW5jb2RlciA8PCBpc0xp bms7CiAgICAgZW5jb2RlciA8PCBpc0ltYWdlOwogICAgIGVuY29kZXIgPDwgaXNBbmltYXRlZElt YWdlOwotICAgIGVuY29kZXIgPDwgaXNDbGlja2FibGVFbGVtZW50OworICAgIGVuY29kZXIgPDwg aXNFbGVtZW50OwogICAgIGVuY29kZXIgPDwgdXJsOwogICAgIGVuY29kZXIgPDwgaW1hZ2VVUkw7 CiAgICAgZW5jb2RlciA8PCB0aXRsZTsKQEAgLTEwMSw3ICsxMDEsNyBAQCBib29sIEludGVyYWN0 aW9uSW5mb3JtYXRpb25BdFBvc2l0aW9uOjpkCiAgICAgaWYgKCFkZWNvZGVyLmRlY29kZShyZXN1 bHQuaXNBbmltYXRlZEltYWdlKSkKICAgICAgICAgcmV0dXJuIGZhbHNlOwogICAgIAotICAgIGlm ICghZGVjb2Rlci5kZWNvZGUocmVzdWx0LmlzQ2xpY2thYmxlRWxlbWVudCkpCisgICAgaWYgKCFk ZWNvZGVyLmRlY29kZShyZXN1bHQuaXNFbGVtZW50KSkKICAgICAgICAgcmV0dXJuIGZhbHNlOwog CiAgICAgaWYgKCFkZWNvZGVyLmRlY29kZShyZXN1bHQudXJsKSkKSW5kZXg6IFNvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9u Lm1tCShyZXZpc2lvbiAxOTY0ODMpCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvaW9zL1dL Q29udGVudFZpZXdJbnRlcmFjdGlvbi5tbQkod29ya2luZyBjb3B5KQpAQCAtMTEzMSw3ICsxMTMx LDcgQEAgLSAoQk9PTClnZXN0dXJlUmVjb2duaXplclNob3VsZEJlZ2luOihVSQogICAgICAgICAg ICAgLy8gVGhpcyBpcyBhIGRpZmZlcmVudCBub2RlIHRoYW4gdGhlIGFzc2lzdGVkIG9uZS4KICAg ICAgICAgICAgIC8vIFByZXZlbnQgdGhlIGdlc3R1cmUgaWYgdGhlcmUgaXMgbm8gbm9kZS4KICAg ICAgICAgICAgIC8vIEFsbG93IHRoZSBnZXN0dXJlIGlmIGl0IGlzIGEgbm9kZSB0aGF0IHdhbnRz IGhpZ2hsaWdodCBvciBpZiB0aGVyZSBpcyBhbiBhY3Rpb24gZm9yIGl0LgotICAgICAgICAgICAg aWYgKCFfcG9zaXRpb25JbmZvcm1hdGlvbi5pc0NsaWNrYWJsZUVsZW1lbnQpCisgICAgICAgICAg ICBpZiAoIV9wb3NpdGlvbkluZm9ybWF0aW9uLmlzRWxlbWVudCkKICAgICAgICAgICAgICAgICBy ZXR1cm4gTk87CiAgICAgICAgICAgICByZXR1cm4gW3NlbGYgX2FjdGlvbkZvckxvbmdQcmVzc10g IT0gbmlsOwogICAgICAgICB9IGVsc2UgewpAQCAtMTI0NSw3ICsxMjQ1LDcgQEAgLSAodm9pZClf aGlnaGxpZ2h0TG9uZ1ByZXNzUmVjb2duaXplZDooVQogICAgICAgICBfaXNUYXBIaWdobGlnaHRJ RFZhbGlkID0gWUVTOwogICAgICAgICBicmVhazsKICAgICBjYXNlIFVJR2VzdHVyZVJlY29nbml6 ZXJTdGF0ZUVuZGVkOgotICAgICAgICBpZiAoX2hpZ2hsaWdodExvbmdQcmVzc0NhbkNsaWNrICYm IF9wb3NpdGlvbkluZm9ybWF0aW9uLmlzQ2xpY2thYmxlRWxlbWVudCkgeworICAgICAgICBpZiAo X2hpZ2hsaWdodExvbmdQcmVzc0NhbkNsaWNrICYmIF9wb3NpdGlvbkluZm9ybWF0aW9uLmlzRWxl bWVudCkgewogICAgICAgICAgICAgW3NlbGYgX2F0dGVtcHRDbGlja0F0TG9jYXRpb246W2dlc3R1 cmVSZWNvZ25pemVyIHN0YXJ0UG9pbnRdXTsKICAgICAgICAgICAgIFtzZWxmIF9maW5pc2hJbnRl cmFjdGlvbl07CiAgICAgICAgIH0gZWxzZQpJbmRleDogU291cmNlL1dlYktpdDIvV2ViUHJvY2Vz cy9XZWJQYWdlL2lvcy9XZWJQYWdlSU9TLm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQy L1dlYlByb2Nlc3MvV2ViUGFnZS9pb3MvV2ViUGFnZUlPUy5tbQkocmV2aXNpb24gMTk2NDgzKQor KysgU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL2lvcy9XZWJQYWdlSU9TLm1tCSh3 b3JraW5nIGNvcHkpCkBAIC0yMTc5LDcgKzIxNzksNyBAQCB2b2lkIFdlYlBhZ2U6OmdldFBvc2l0 aW9uSW5mb3JtYXRpb24oY29uCiAgICAgaWYgKGhpdE5vZGUpIHsKICAgICAgICAgRWxlbWVudCog ZWxlbWVudCA9IGlzPEVsZW1lbnQ+KCpoaXROb2RlKSA/IGRvd25jYXN0PEVsZW1lbnQ+KGhpdE5v ZGUpIDogbnVsbHB0cjsKICAgICAgICAgaWYgKGVsZW1lbnQpIHsKLSAgICAgICAgICAgIGluZm8u aXNDbGlja2FibGVFbGVtZW50ID0gdHJ1ZTsKKyAgICAgICAgICAgIGluZm8uaXNFbGVtZW50ID0g dHJ1ZTsKICAgICAgICAgICAgIEVsZW1lbnQqIGxpbmtFbGVtZW50ID0gbnVsbHB0cjsKICAgICAg ICAgICAgIGlmIChlbGVtZW50LT5yZW5kZXJlcigpICYmIGVsZW1lbnQtPnJlbmRlcmVyKCktPmlz UmVuZGVySW1hZ2UoKSkgewogICAgICAgICAgICAgICAgIGVsZW1lbnRJc0xpbmtPckltYWdlID0g dHJ1ZTsK