154174 2016-02-12 10:52:10 -0800 NSRangeIsRelativeTo should not have NS prefix 2016-02-12 12:22:52 -0800 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 bdakin webkit-unassigned ap thorton oldest_to_newest 1164202 0 bdakin 2016-02-12 10:52:10 -0800 NSRangeIsRelativeTo should not have NS prefix. 1164203 1 271187 bdakin 2016-02-12 10:53:17 -0800 Created attachment 271187 Patch 1164237 2 bdakin 2016-02-12 11:43:34 -0800 Thanks Tim! http://trac.webkit.org/changeset/196489 1164250 3 ap 2016-02-12 12:02:50 -0800 Do we usually use "WKNS" prefix for this sort of thing? 1164261 4 bdakin 2016-02-12 12:22:52 -0800 (In reply to comment #3) > Do we usually use "WKNS" prefix for this sort of thing? I don't see any use of that in WebKit 1 (except for a stray WebKitSystemInterface function name). Generally I feel like we use "Web" in WebKit1 and "WK" in WebKit2, so WebNS might be better, but I think just Web is okay too? 271187 2016-02-12 10:53:17 -0800 2016-02-12 11:29:57 -0800 Patch for-review.txt text/plain 4692 bdakin SW5kZXg6IFNvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L21hYy9DaGFuZ2VMb2cJKHJldmlzaW9uIDE5NjQ4MykKKysrIFNvdXJjZS9XZWJLaXQv bWFjL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE2LTAyLTEy ICBCZXRoIERha2luICA8YmRha2luQGFwcGxlLmNvbT4KKworICAgICAgICBOU1JhbmdlSXNSZWxh dGl2ZVRvIHNob3VsZCBub3QgaGF2ZSBOUyBwcmVmaXgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1NDE3NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIE5TUmFuZ2VJc1JlbGF0aXZlVG8gLT4gV2ViUmFuZ2VJ c1JlbGF0aXZlVG8KKyAgICAgICAgKiBXZWJWaWV3L1dlYkZyYW1lLm1tOgorICAgICAgICAoLVtX ZWJGcmFtZSBfY29udmVydFRvRE9NUmFuZ2U6XSk6CisgICAgICAgICgtW1dlYkZyYW1lIF9jb252 ZXJ0VG9ET01SYW5nZTpyYW5nZUlzUmVsYXRpdmVUbzpdKToKKyAgICAgICAgKiBXZWJWaWV3L1dl YkZyYW1lSW50ZXJuYWwuaDoKKyAgICAgICAgKiBXZWJWaWV3L1dlYkhUTUxWaWV3Lm1tOgorICAg ICAgICAoLVtXZWJIVE1MVmlldyBpbnNlcnRUZXh0Ol0pOgorCiAyMDE2LTAyLTExICBCZXRoIERh a2luICA8YmRha2luQGFwcGxlLmNvbT4KIAogICAgICAgICBFZGl0aW5nUmFuZ2VJc1JlbGF0aXZl VG86OkRvY3VtZW50IGFuZCBOU1JhbmdlSXNSZWxhdGl2ZVRvOjpEb2N1bWVudCBzaG91bGQgCklu ZGV4OiBTb3VyY2UvV2ViS2l0L21hYy9XZWJWaWV3L1dlYkZyYW1lLm1tCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9XZWJLaXQvbWFjL1dlYlZpZXcvV2ViRnJhbWUubW0JKHJldmlzaW9uIDE5NjQ1NikK KysrIFNvdXJjZS9XZWJLaXQvbWFjL1dlYlZpZXcvV2ViRnJhbWUubW0JKHdvcmtpbmcgY29weSkK QEAgLTc5MywxNyArNzkzLDE3IEBAIC0gKE5TUmFuZ2UpX2NvbnZlcnRUb05TUmFuZ2U6KFJhbmdl ICopcmEKIAogLSAoUGFzc1JlZlB0cjxSYW5nZT4pX2NvbnZlcnRUb0RPTVJhbmdlOihOU1Jhbmdl KW5zcmFuZ2UKIHsKLSAgICByZXR1cm4gW3NlbGYgX2NvbnZlcnRUb0RPTVJhbmdlOm5zcmFuZ2Ug cmFuZ2VJc1JlbGF0aXZlVG86TlNSYW5nZUlzUmVsYXRpdmVUbzo6RWRpdGFibGVSb290XTsKKyAg ICByZXR1cm4gW3NlbGYgX2NvbnZlcnRUb0RPTVJhbmdlOm5zcmFuZ2UgcmFuZ2VJc1JlbGF0aXZl VG86V2ViUmFuZ2VJc1JlbGF0aXZlVG86OkVkaXRhYmxlUm9vdF07CiB9CiAKLS0gKFBhc3NSZWZQ dHI8UmFuZ2U+KV9jb252ZXJ0VG9ET01SYW5nZTooTlNSYW5nZSluc3JhbmdlIHJhbmdlSXNSZWxh dGl2ZVRvOihOU1JhbmdlSXNSZWxhdGl2ZVRvKXJhbmdlSXNSZWxhdGl2ZVRvCistIChQYXNzUmVm UHRyPFJhbmdlPilfY29udmVydFRvRE9NUmFuZ2U6KE5TUmFuZ2UpbnNyYW5nZSByYW5nZUlzUmVs YXRpdmVUbzooV2ViUmFuZ2VJc1JlbGF0aXZlVG8pcmFuZ2VJc1JlbGF0aXZlVG8KIHsKICAgICBp ZiAobnNyYW5nZS5sb2NhdGlvbiA+IElOVF9NQVgpCiAgICAgICAgIHJldHVybiAwOwogICAgIGlm IChuc3JhbmdlLmxlbmd0aCA+IElOVF9NQVggfHwgbnNyYW5nZS5sb2NhdGlvbiArIG5zcmFuZ2Uu bGVuZ3RoID4gSU5UX01BWCkKICAgICAgICAgbnNyYW5nZS5sZW5ndGggPSBJTlRfTUFYIC0gbnNy YW5nZS5sb2NhdGlvbjsKIAotICAgIGlmIChyYW5nZUlzUmVsYXRpdmVUbyA9PSBOU1JhbmdlSXNS ZWxhdGl2ZVRvOjpFZGl0YWJsZVJvb3QpIHsKKyAgICBpZiAocmFuZ2VJc1JlbGF0aXZlVG8gPT0g V2ViUmFuZ2VJc1JlbGF0aXZlVG86OkVkaXRhYmxlUm9vdCkgewogICAgICAgICAvLyBPdXIgY3Jp dGljYWwgYXNzdW1wdGlvbiBpcyB0aGF0IHRoaXMgY29kZSBwYXRoIGlzIG9ubHkgY2FsbGVkIGJ5 IGlucHV0IG1ldGhvZHMgdGhhdAogICAgICAgICAvLyBjb25jZW50cmF0ZSBvbiBhIGdpdmVuIGFy ZWEgY29udGFpbmluZyB0aGUgc2VsZWN0aW9uCiAgICAgICAgIC8vIFdlIGhhdmUgdG8gZG8gdGhp cyBiZWNhdXNlIG9mIHRleHQgZmllbGRzIGFuZCB0ZXh0YXJlYXMuIFRoZSBET00gZm9yIHRob3Nl IGlzIG5vdApAQCAtODE2LDcgKzgxNiw3IEBAIC0gKFBhc3NSZWZQdHI8UmFuZ2U+KV9jb252ZXJ0 VG9ET01SYW5nZToKICAgICAgICAgcmV0dXJuIFRleHRJdGVyYXRvcjo6cmFuZ2VGcm9tTG9jYXRp b25BbmRMZW5ndGgoZWxlbWVudCwgbnNyYW5nZS5sb2NhdGlvbiwgbnNyYW5nZS5sZW5ndGgpOwog ICAgIH0KIAotICAgIEFTU0VSVChyYW5nZUlzUmVsYXRpdmVUbyA9PSBOU1JhbmdlSXNSZWxhdGl2 ZVRvOjpQYXJhZ3JhcGgpOworICAgIEFTU0VSVChyYW5nZUlzUmVsYXRpdmVUbyA9PSBXZWJSYW5n ZUlzUmVsYXRpdmVUbzo6UGFyYWdyYXBoKTsKIAogICAgIGNvbnN0IFZpc2libGVTZWxlY3Rpb24m IHNlbGVjdGlvbiA9IF9wcml2YXRlLT5jb3JlRnJhbWUtPnNlbGVjdGlvbigpLnNlbGVjdGlvbigp OwogICAgIFJlZlB0cjxSYW5nZT4gc2VsZWN0ZWRSYW5nZSA9IHNlbGVjdGlvbi50b05vcm1hbGl6 ZWRSYW5nZSgpOwpJbmRleDogU291cmNlL1dlYktpdC9tYWMvV2ViVmlldy9XZWJGcmFtZUludGVy bmFsLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9tYWMvV2ViVmlldy9XZWJGcmFtZUlu dGVybmFsLmgJKHJldmlzaW9uIDE5NjQ1NikKKysrIFNvdXJjZS9XZWJLaXQvbWFjL1dlYlZpZXcv V2ViRnJhbWVJbnRlcm5hbC5oCSh3b3JraW5nIGNvcHkpCkBAIC02Myw3ICs2Myw3IEBAIG5hbWVz cGFjZSBXZWJDb3JlIHsKIAogdHlwZWRlZiBXZWJDb3JlOjpIaXN0b3J5SXRlbSBXZWJDb3JlSGlz dG9yeUl0ZW07CiAKLWVudW0gY2xhc3MgTlNSYW5nZUlzUmVsYXRpdmVUbyA6IHVpbnQ4X3Qgewor ZW51bSBjbGFzcyBXZWJSYW5nZUlzUmVsYXRpdmVUbyA6IHVpbnQ4X3QgewogICAgIEVkaXRhYmxl Um9vdCwKICAgICBQYXJhZ3JhcGgsCiB9OwpAQCAtMTY1LDcgKzE2NSw3IEBAIEBpbnRlcmZhY2Ug V2ViRnJhbWUgKFdlYkludGVybmFsKQogI2VuZGlmCiAtIChOU1JhbmdlKV9jb252ZXJ0VG9OU1Jh bmdlOihXZWJDb3JlOjpSYW5nZSopcmFuZ2U7CiAtIChQYXNzUmVmUHRyPFdlYkNvcmU6OlJhbmdl PilfY29udmVydFRvRE9NUmFuZ2U6KE5TUmFuZ2UpbnNyYW5nZTsKLS0gKFBhc3NSZWZQdHI8V2Vi Q29yZTo6UmFuZ2U+KV9jb252ZXJ0VG9ET01SYW5nZTooTlNSYW5nZSluc3JhbmdlIHJhbmdlSXNS ZWxhdGl2ZVRvOihOU1JhbmdlSXNSZWxhdGl2ZVRvKXJhbmdlSXNSZWxhdGl2ZVRvOworLSAoUGFz c1JlZlB0cjxXZWJDb3JlOjpSYW5nZT4pX2NvbnZlcnRUb0RPTVJhbmdlOihOU1JhbmdlKW5zcmFu Z2UgcmFuZ2VJc1JlbGF0aXZlVG86KFdlYlJhbmdlSXNSZWxhdGl2ZVRvKXJhbmdlSXNSZWxhdGl2 ZVRvOwogCiAtIChET01Eb2N1bWVudEZyYWdtZW50ICopX2RvY3VtZW50RnJhZ21lbnRXaXRoTWFy a3VwU3RyaW5nOihOU1N0cmluZyAqKW1hcmt1cFN0cmluZyBiYXNlVVJMU3RyaW5nOihOU1N0cmlu ZyAqKWJhc2VVUkxTdHJpbmc7CiAtIChET01Eb2N1bWVudEZyYWdtZW50ICopX2RvY3VtZW50RnJh Z21lbnRXaXRoTm9kZXNBc1BhcmFncmFwaHM6KE5TQXJyYXkgKilub2RlczsKSW5kZXg6IFNvdXJj ZS9XZWJLaXQvbWFjL1dlYlZpZXcvV2ViSFRNTFZpZXcubW0KPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L1dlYktpdC9tYWMvV2ViVmlldy9XZWJIVE1MVmlldy5tbQkocmV2aXNpb24gMTk2NDU2KQorKysg U291cmNlL1dlYktpdC9tYWMvV2ViVmlldy9XZWJIVE1MVmlldy5tbQkod29ya2luZyBjb3B5KQpA QCAtNzExNCw3ICs3MTE0LDcgQEAgLSAodm9pZClpbnNlcnRUZXh0OihpZClzdHJpbmcKICNlbmRp ZgogCiAgICAgaWYgKHJlcGxhY2VtZW50UmFuZ2UubG9jYXRpb24gIT0gTlNOb3RGb3VuZCkgewot ICAgICAgICBOU1JhbmdlSXNSZWxhdGl2ZVRvIHJhbmdlSXNSZWxhdGl2ZVRvID0gbmVlZFRvUmVt b3ZlU29mdFNwYWNlID8gTlNSYW5nZUlzUmVsYXRpdmVUbzo6UGFyYWdyYXBoIDogTlNSYW5nZUlz UmVsYXRpdmVUbzo6RWRpdGFibGVSb290OworICAgICAgICBXZWJSYW5nZUlzUmVsYXRpdmVUbyBy YW5nZUlzUmVsYXRpdmVUbyA9IG5lZWRUb1JlbW92ZVNvZnRTcGFjZSA/IFdlYlJhbmdlSXNSZWxh dGl2ZVRvOjpQYXJhZ3JhcGggOiBXZWJSYW5nZUlzUmVsYXRpdmVUbzo6RWRpdGFibGVSb290Owog ICAgICAgICBSZWZQdHI8UmFuZ2U+IGRvbVJhbmdlID0gW1tzZWxmIF9mcmFtZV0gX2NvbnZlcnRU b0RPTVJhbmdlOnJlcGxhY2VtZW50UmFuZ2UgcmFuZ2VJc1JlbGF0aXZlVG86cmFuZ2VJc1JlbGF0 aXZlVG9dOwogICAgICAgICBpZiAoZG9tUmFuZ2UpCiAgICAgICAgICAgICBjb3JlRnJhbWUtPnNl bGVjdGlvbigpLnNldFNlbGVjdGlvbihWaXNpYmxlU2VsZWN0aW9uKCpkb21SYW5nZSwgU0VMX0RF RkFVTFRfQUZGSU5JVFkpKTsK