15416 2007-10-07 20:47:43 -0700 dtoa Falls into infinite loop on ARMEL 2008-09-03 06:38:03 -0700 1 1 1 Unclassified WebKit JavaScriptCore 523.x (Safari 3) Other All RESOLVED FIXED P2 Normal --- 17923 1 weihong.zeng webkit-unassigned david.krause ddkilzer martinwguy oldest_to_newest 58059 0 weihong.zeng 2007-10-07 20:47:43 -0700 predefined marco in arm-linux-cpp #define __DBL_MIN_EXP__ (-1021) #define __FLT_MIN__ 1.17549435e-38F #define __CHAR_BIT__ 8 #define __WCHAR_MAX__ 2147483647 #define __DBL_DENORM_MIN__ 4.9406564584124654e-324 #define __FLT_EVAL_METHOD__ 0 #define __unix__ 1 #define unix 1 #define __SIZE_TYPE__ unsigned int #define __ELF__ 1 #define __DBL_MIN_10_EXP__ (-307) #define __FINITE_MATH_ONLY__ 0 #define __ARMEL__ 1 #define __FLT_RADIX__ 2 #define __LDBL_EPSILON__ 2.2204460492503131e-16L #define __ARM_ARCH_4__ 1 #define __SHRT_MAX__ 32767 #define __LDBL_MAX__ 1.7976931348623157e+308L #define __linux 1 #define __CHAR_UNSIGNED__ 1 #define __LDBL_MAX_EXP__ 1024 #define __LONG_MAX__ 2147483647L #define __linux__ 1 #define __unix 1 #define __SCHAR_MAX__ 127 #define __DBL_DIG__ 15 #define __USER_LABEL_PREFIX__ #define linux 1 #define __STDC_HOSTED__ 1 #define __LDBL_MANT_DIG__ 53 #define __FLT_EPSILON__ 1.19209290e-7F #define __APCS_32__ 1 #define __LDBL_MIN__ 2.2250738585072014e-308L #define __WCHAR_TYPE__ long int #define __FLT_DIG__ 6 #define __FLT_MAX_10_EXP__ 38 #define __INT_MAX__ 2147483647 #define __gnu_linux__ 1 #define __FLT_MAX_EXP__ 128 #define __DECIMAL_DIG__ 17 #define __DBL_MANT_DIG__ 53 #define __WINT_TYPE__ unsigned int #define __LDBL_MIN_EXP__ (-1021) #define __arm__ 1 #define __LDBL_MAX_10_EXP__ 308 #define __DBL_EPSILON__ 2.2204460492503131e-16 #define __DBL_MAX__ 1.7976931348623157e+308 #define __USING_SJLJ_EXCEPTIONS__ 1 #define __DBL_MAX_EXP__ 1024 #define __FLT_DENORM_MIN__ 1.40129846e-45F #define __LONG_LONG_MAX__ 9223372036854775807LL #define __FLT_MAX__ 3.40282347e+38F #define __GXX_ABI_VERSION 102 #define __FLT_MIN_10_EXP__ (-37) #define __FLT_MIN_EXP__ (-125) #define __DBL_MAX_10_EXP__ 308 #define __LDBL_DENORM_MIN__ 4.9406564584124654e-324L #define __DBL_MIN__ 2.2250738585072014e-308 #define __PTRDIFF_TYPE__ int #define __LDBL_MIN_10_EXP__ (-307) #define __REGISTER_PREFIX__ #define __LDBL_DIG__ 15 #define __NO_INLINE__ 1 #define __FLT_MANT_DIG__ 24 #define __VERSION__ "3.3.2" 58076 1 mrowe 2007-10-08 00:06:34 -0700 I'm not sure what the purpose of including the predefined macros was. Perhaps more useful would be determining where in the infinite loop is occurring? 71949 2 19364 weihong.zeng 2008-02-25 17:25:35 -0800 Created attachment 19364 for mixed-endian ARM processor #define IEEE_ARM for IEEE-arithmetic machines where the two words in a double are stored in big endian order but the two shorts in a word are still stored in little endian order. 71955 3 ddkilzer 2008-02-25 17:51:52 -0800 If you'd like this patch reviewed, please set the "review?" flag. You will need a ChangeLog entry before this patch may land. Please see this page for more details: http://webkit.org/coding/contributing.html 72325 4 19444 weihong.zeng 2008-02-28 23:55:39 -0800 Created attachment 19444 fix mixed-endian for mixed-endian ARM processor #define IEEE_ARM for IEEE-arithmetic machines where the two words in a double are stored in big endian order but the two shorts in a word are still stored in little endian order. 72334 5 19444 ddkilzer 2008-02-29 03:21:16 -0800 Comment on attachment 19444 fix mixed-endian Please set the "review?" flag, not the "review+" flag, to have your patch reviewed. >+2008-02-28 weihongzeng <set EMAIL_ADDRESS environment variable> Please set your first/last name (not just your account) and your email address in the ChangeLog file. >+ Reviewed by NOBODY (OOPS!). >+ >+ * kjs/dtoa.cpp: >+ (Bigint::): >+ (Bigint::freedtoa): Please refer to this bug in the ChangeLog entry, and describe what you fixed. (See other ChangeLog entries for examples.) >+#ifdef USE_LOCALE >+ s1 = localeconv()->decimal_point; >+ if (c == *s1) { >+ c = '.'; >+ if (*++s1) { >+ s2 = s; >+ for(;;) { >+ if (*++s2 != *s1) { >+ c = 0; >+ break; >+ } >+ if (!*++s1) { >+ s = s2; >+ break; >+ } >+ } >+ } >+ } >+#endif This is incorrect style. Curly braces appear below their corresponding if statement. See this page for more information: http://webkit.org/coding/coding-style.html >- while (*--s == '0') { } >+ while(*--s == '0'); >- while (*--s == '0') { } >+ while(*--s == '0'); Why were these changes made? I recall that some compilers require the empty block instead of a semi-colon. These seem unnecessary. r- for code style issues and incomplete ChangeLog. 73158 6 19624 weihong.zeng 2008-03-09 19:17:07 -0700 Created attachment 19624 fix mixed-endian fix mixed-endian 73162 7 19624 darin 2008-03-09 19:55:39 -0700 Comment on attachment 19624 fix mixed-endian Why did you add the USE_LOCALE code? This change is not appropriate for JavaScriptCore. 73171 8 19628 weihong.zeng 2008-03-09 23:07:08 -0700 Created attachment 19628 fix mixed-endian fix mixed-endian 73172 9 weihong.zeng 2008-03-09 23:08:35 -0700 ok, I remove USE_LOCAL and submit attachment again. 73936 10 david.krause 2008-03-16 12:17:10 -0700 I'm working on recent WebKit on a standard ARM platform (little-endian), and this bug is also affecting us. The patch resolves our issue. The comment on line 287 in the latest patch isn't quite accurate (should also mention ARM). Is there anything else to be done to get this patch landed? 73991 11 19628 darin 2008-03-16 15:24:09 -0700 Comment on attachment 19628 fix mixed-endian Looks fine, at least harmless to non-middle-endian platforms. r=me 74024 12 darin 2008-03-16 20:27:11 -0700 Committed revision 31088. [But I don't see how this could help for little-endian ARM, since the patch is triggered by PLATFORM(MIDDLE_ENDIAN).] 74028 13 david.krause 2008-03-16 20:49:33 -0700 I think it helps us because the defines in JavaScriptCore/wtf/Platform.h for ARM set either WTF_PLATFORM_BIG_ENDIAN or WTF_PLATFORM_MIDDLE_ENDIAN - there is no little endian define. Maybe I'm mis-using my terms and we are "middle-endian", but regular 32-bit numbers are little-endian. The platform has an ARM9 running Linux. 74198 14 ddkilzer 2008-03-17 18:56:01 -0700 (In reply to comment #13) > I think it helps us because the defines in JavaScriptCore/wtf/Platform.h for > ARM set either WTF_PLATFORM_BIG_ENDIAN or WTF_PLATFORM_MIDDLE_ENDIAN - there is > no little endian define. Maybe I'm mis-using my terms and we are > "middle-endian", but regular 32-bit numbers are little-endian. The platform > has an ARM9 running Linux. Fixed in r31115. <http://trac.webkit.org/projects/webkit/changeset/31115> 74244 15 david.krause 2008-03-18 06:42:30 -0700 The last patch (r31115) may not provide correct behavior for all ARM platforms. It seems that __ARMEL__ isn't enough to define the layout of the floating-point doubles. On the particular platform we're working on, the layout does actually match that shown by MIDDLE_ENDIAN in JavaScriptCore/kjs/vaue.cpp, even though __ARMEL__ is defined. Not an expert on the different ARM floating-point layouts (FPA vs. VFP), but the actual arrangement of the bytes varies - FPA is the "middle endian" format as it's called by WebKit, and VFP is "natural endian". In our particular case, we still want MIDDLE_ENDIAN defined to get the proper behavior in the two places it's used (value.cpp and dtoa.cpp) since we are using FPA. Some other searching turns up that the pre-processor define of __SOFTFP__ might be good enough to trigger that. Our arm-linux-gcc does defines that, but the original bug report didn't have that or __VFP_FP__ defined. If a change is warranted at all in Platform.h, having only our compiler here, I'd use __SOFTFP__ and __ARMEL__ to enable the WTF_PLATFORM_MIDDLE_ENDIAN define, but I'm not sure if that will break for those using VFP. Maybe this at line 151 in Platform.h: #elif !defined(__ARM_EABI__) && !defined(__ARMEB__) && defined(__ARMEL__) && defined(__SOFTFP__) Backing out the change in Platform.h would also likely work, and not affect anyone that wasn't already having issues. Sorry if my previous post (#13) led to confusion, but the net result is that the r31115 change will probably break ARM systems using FPA. 74293 16 ddkilzer 2008-03-18 12:46:17 -0700 (In reply to comment #15) > The last patch (r31115) may not provide correct behavior for all ARM platforms. Thanks for the follow-up, David! Could you please file a new bug to track this issue and copy me on it? Thanks! 74330 17 ddkilzer 2008-03-18 15:16:32 -0700 (In reply to comment #16) > Thanks for the follow-up, David! Could you please file a new bug to track this > issue and copy me on it? Thanks! Bug 17923. 89990 18 martinwguy 2008-09-03 01:46:04 -0700 Hi! I found this bug report while searching for something else. I had to wrangle ARM FP variants over the last few years for wiki.debian.org/ArmEabiPort so can shed some light... Unfortunately there is no single define to isolate the bizarre 45670123-order doubles as used in ancient ARM FPA and the old-abi FP emulator, but to the code in Platform.h: #elif !defined(__ARM_EABI__) && !defined(__ARMEB__) && !defined(__VFP_FP__) #define WTF_PLATFORM_MIDDLE_ENDIAN 1 you might add && !defined(__MAVERICK__), which is the other true-little-endian FP coprocessor from Cirrus. __VFP_FP__ is also defined if soft-float is in use, so that case is alrady covered correctly by this code. Also, the following phrase #if !defined(__ARM_EABI__) #define WTF_PLATFORM_FORCE_PACK 1 #endif is suspect, since ARMs require data accesses to be aligned to a multiple of their size for 2- and 4-byte words regardless of ABI; the only difference is that in EABI, doubles should be 8-byte-aligned instead of 4. However WTF_PLATFORM_FORCE_PACK is not used anywhere in the rest of WebKit, so it looks redundant now. Cheers! 90017 19 ddkilzer 2008-09-03 06:38:03 -0700 (In reply to comment #18) > I found this bug report while searching for something else. I had to wrangle > ARM FP variants over the last few years for wiki.debian.org/ArmEabiPort so can > shed some light... Martin, please open a new bug with a patch if you'd like to see these changes made. Thanks! 19364 2008-02-25 17:25:35 -0800 2008-02-28 23:55:39 -0800 for mixed-endian ARM processor dtoa-r30583.patch text/plain 3161 weihong.zeng SW5kZXg6IGR0b2EuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIGR0b2EuY3BwCe+8iOS/ruiuoueJiCAzMDU4 M++8iQorKysgZHRvYS5jcHAJ77yI5bel5L2c5ou36LSd77yJCkBAIC0xNTAsNiArMTUwLDcgQEAK ICAqCXNvbWUgY29tcGlsZXJzIGFuZCB3YXMgYWx3YXlzIHVzZWQgcHJpb3IgdG8gMTk5OTA5MTYs IGJ1dCBpdAogICoJaXMgbm90IHN0cmljdGx5IGxlZ2FsIGFuZCBjYW4gY2F1c2UgdHJvdWJsZSB3 aXRoIGFnZ3Jlc3NpdmVseQogICoJb3B0aW1pemluZyBjb21waWxlcnMgKGUuZy4sIGdjYyAyLjk1 LjEgdW5kZXIgLU8yKS4KKyAqICNkZWZpbmUgVVNFX0xPQ0FMRSB0byB1c2UgdGhlIGN1cnJlbnQg bG9jYWxlJ3MgZGVjaW1hbF9wb2ludCB2YWx1ZS4KICAqICNkZWZpbmUgU0VUX0lORVhBQ1QgaWYg SUVFRSBhcml0aG1ldGljIGlzIGJlaW5nIHVzZWQgYW5kIGV4dHJhCiAgKgljb21wdXRhdGlvbiBz aG91bGQgYmUgZG9uZSB0byBzZXQgdGhlIGluZXhhY3QgZmxhZyB3aGVuIHRoZQogICoJcmVzdWx0 IGlzIGluZXhhY3QgYW5kIGF2b2lkIHNldHRpbmcgaW5leGFjdCB3aGVuIHRoZSByZXN1bHQKQEAg LTE3OSw2ICsxODAsOCBAQAogCiAjaWYgUExBVEZPUk0oQklHX0VORElBTikKICNkZWZpbmUgSUVF RV9NQzY4aworI2VsaWYgUExBVEZPUk0oTUlERExFX0VORElBTikKKyNkZWZpbmUgSUVFRV9BUk0K ICNlbHNlCiAjZGVmaW5lIElFRUVfODA4NwogI2VuZGlmCkBAIC0yMDEsNiArMjA0LDEwIEBACiAj aW5jbHVkZSA8c3RkbGliLmg+CiAjaW5jbHVkZSA8c3RyaW5nLmg+CiAKKyNpZmRlZiBVU0VfTE9D QUxFCisjaW5jbHVkZSA8bG9jYWxlLmg+CisjZW5kaWYKKwogI2lmZGVmIE1BTExPQwogI2lmZGVm IEtSX2hlYWRlcnMKIGV4dGVybiBjaGFyICpNQUxMT0MoKTsKQEAgLTIyNyw2ICsyMzQsOSBAQAog I2lmZGVmIElFRUVfODA4NwogI2RlZmluZSBJRUVFX0FyaXRoCiAjZW5kaWYKKyNpZmRlZiBJRUVF X0FSTQorI2RlZmluZSBJRUVFX0FyaXRoCisjZW5kaWYKIAogI2luY2x1ZGUgPGVycm5vLmg+CiAK QEAgLTI4Myw4ICsyOTMsOCBAQAogI2VuZGlmCiAjZW5kaWYKIAotI2lmIGRlZmluZWQoSUVFRV84 MDg3KSArIGRlZmluZWQoSUVFRV9NQzY4aykgKyBkZWZpbmVkKFZBWCkgKyBkZWZpbmVkKElCTSkg IT0gMQotRXhhY3RseSBvbmUgb2YgSUVFRV84MDg3LCBJRUVFX01DNjhrLCBWQVgsIG9yIElCTSBz aG91bGQgYmUgZGVmaW5lZC4KKyNpZiBkZWZpbmVkKElFRUVfODA4NykgKyBkZWZpbmVkKElFRUVf TUM2OGspICsgZGVmaW5lZChJRUVFX0FSTSkgKyBkZWZpbmVkKFZBWCkgKyBkZWZpbmVkKElCTSkg IT0gMQorRXhhY3RseSBvbmUgb2YgSUVFRV84MDg3LCBJRUVFX0FSTSwgSUVFRV9NQzY4aywgVkFY LCBvciBJQk0gc2hvdWxkIGJlIGRlZmluZWQuCiAjZW5kaWYKIAogdHlwZWRlZiB1bmlvbiB7IGRv dWJsZSBkOyBVTG9uZyBMWzJdOyB9IFU7CkBAIC0zMTMsNyArMzIzLDcgQEAKICAqIEFuIGFsdGVy bmF0aXZlIHRoYXQgbWlnaHQgYmUgYmV0dGVyIG9uIHNvbWUgbWFjaGluZXMgaXMKICAqICNkZWZp bmUgU3RvcmVpbmMoYSxiLGMpICgqYSsrID0gYiA8PCAxNiB8IGMgJiAweGZmZmYpCiAgKi8KLSNp ZiBkZWZpbmVkKElFRUVfODA4NykgKyBkZWZpbmVkKFZBWCkKKyNpZiBkZWZpbmVkKElFRUVfODA4 NykgKyBkZWZpbmVkKElFRUVfQVJNKSArIGRlZmluZWQoVkFYKQogI2RlZmluZSBTdG9yZWluYyhh LGIsYykgKCgodW5zaWduZWQgc2hvcnQgKilhKVsxXSA9ICh1bnNpZ25lZCBzaG9ydCliLCBcCiAo KHVuc2lnbmVkIHNob3J0ICopYSlbMF0gPSAodW5zaWduZWQgc2hvcnQpYywgYSsrKQogI2Vsc2UK QEAgLTE1NTQsNiArMTU2NCw5IEBACiAjaWZkZWYgSG9ub3JfRkxUX1JPVU5EUwogCWludCByb3Vu ZGluZzsKICNlbmRpZgorI2lmZGVmIFVTRV9MT0NBTEUKKwlDT05TVF8gY2hhciAqczI7CisjZW5k aWYKIAogCXNpZ24gPSBuejAgPSBueiA9IDA7CiAJZHZhbChydikgPSAwLjsKQEAgLTE1OTIsNiAr MTYwNSwyNSBAQAogCQllbHNlIGlmIChuZCA8IDE2KQogCQkJeiA9IDEwKnogKyBjIC0gJzAnOwog CW5kMCA9IG5kOworI2lmZGVmIFVTRV9MT0NBTEUKKwlzMSA9IGxvY2FsZWNvbnYoKS0+ZGVjaW1h bF9wb2ludDsKKwlpZiAoYyA9PSAqczEpIHsKKwkJYyA9ICcuJzsKKwkJaWYgKCorK3MxKSB7CisJ CQlzMiA9IHM7CisJCQlmb3IoOzspIHsKKwkJCQlpZiAoKisrczIgIT0gKnMxKSB7CisJCQkJCWMg PSAwOworCQkJCQlicmVhazsKKwkJCQkJfQorCQkJCWlmICghKisrczEpIHsKKwkJCQkJcyA9IHMy OworCQkJCQlicmVhazsKKwkJCQkJfQorCQkJCX0KKwkJCX0KKwkJfQorI2VuZGlmCiAJaWYgKGMg PT0gJy4nKSB7CiAJCWMgPSAqKytzOwogCQlpZiAoIW5kKSB7CkBAIC0yMzk2LDcgKzI0MjgsNyBA QAogCWlmIChzZSkKIAkJKnNlID0gKGNoYXIgKilzOwogCXJldHVybiBzaWduID8gLWR2YWwocnYp IDogZHZhbChydik7Ci0JfQorfQogCiAgc3RhdGljIGludAogcXVvcmVtCkBAIC0yNTc5LDcgKzI2 MTEsNyBAQAogCWlmIChzID09IGR0b2FfcmVzdWx0KQogCQlkdG9hX3Jlc3VsdCA9IDA7CiAjZW5k aWYKLQl9Cit9CiAKIC8qIGR0b2EgZm9yIElFRUUgYXJpdGhtZXRpYyAoZG1nKTogY29udmVydCBk b3VibGUgdG8gQVNDSUkgc3RyaW5nLgogICoKQEAgLTI5NDcsNyArMjk3OSw3IEBACiAJCQkJCWlm IChkdmFsKGQpID4gMC41ICsgZHZhbChlcHMpKQogCQkJCQkJZ290byBidW1wX3VwOwogCQkJCQll bHNlIGlmIChkdmFsKGQpIDwgMC41IC0gZHZhbChlcHMpKSB7Ci0JCQkJCQl3aGlsZSAoKi0tcyA9 PSAnMCcpIHsgfQorCQkJCQkJd2hpbGUoKi0tcyA9PSAnMCcpOwogCQkJCQkJcysrOwogCQkJCQkJ Z290byByZXQxOwogCQkJCQkJfQpAQCAtMzI2Niw3ICszMjk4LDcgQEAKICNpZmRlZiBIb25vcl9G TFRfUk9VTkRTCiB0cmltemVyb3M6CiAjZW5kaWYKLQkJd2hpbGUgKCotLXMgPT0gJzAnKSB7IH0K KwkJd2hpbGUoKi0tcyA9PSAnMCcpOwogCQlzKys7CiAJCX0KICByZXQ6CkBAIC0zMjk0LDcgKzMz MjYsNyBAQAogCWlmIChydmUpCiAJCSpydmUgPSBzOwogCXJldHVybiBzMDsKLQl9Cit9CiAjaWZk ZWYgX19jcGx1c3BsdXMKIH0KICNlbmRpZgo= 19444 2008-02-28 23:55:39 -0800 2008-03-09 23:07:08 -0700 fix mixed-endian patch-javascriptcore-b30651.patch text/plain 3786 weihong.zeng SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDMwNjU2 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTEgQEAKKzIwMDgtMDIt MjggIHdlaWhvbmd6ZW5nICA8c2V0IEVNQUlMX0FERFJFU1MgZW52aXJvbm1lbnQgdmFyaWFibGU+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBranMv ZHRvYS5jcHA6CisgICAgICAgIChCaWdpbnQ6Oik6CisgICAgICAgIChCaWdpbnQ6OmZyZWVkdG9h KToKKwogMjAwOC0wMi0yOCAgRXJpYyBDaHJpc3RvcGhlciAgPGVjaHJpc3RvQGFwcGxlLmNvbT4K IAogICAgICAgICBSZXZpZXdlZCBieSBHZW9mZnJleSBHYXJlbi4KSW5kZXg6IGtqcy9kdG9hLmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBranMvZHRvYS5jcHAJKHJldmlzaW9uIDMwNjU2KQorKysga2pzL2R0 b2EuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xNTAsNiArMTUwLDcgQEAKICAqCXNvbWUgY29tcGls ZXJzIGFuZCB3YXMgYWx3YXlzIHVzZWQgcHJpb3IgdG8gMTk5OTA5MTYsIGJ1dCBpdAogICoJaXMg bm90IHN0cmljdGx5IGxlZ2FsIGFuZCBjYW4gY2F1c2UgdHJvdWJsZSB3aXRoIGFnZ3Jlc3NpdmVs eQogICoJb3B0aW1pemluZyBjb21waWxlcnMgKGUuZy4sIGdjYyAyLjk1LjEgdW5kZXIgLU8yKS4K KyAqICNkZWZpbmUgVVNFX0xPQ0FMRSB0byB1c2UgdGhlIGN1cnJlbnQgbG9jYWxlJ3MgZGVjaW1h bF9wb2ludCB2YWx1ZS4KICAqICNkZWZpbmUgU0VUX0lORVhBQ1QgaWYgSUVFRSBhcml0aG1ldGlj IGlzIGJlaW5nIHVzZWQgYW5kIGV4dHJhCiAgKgljb21wdXRhdGlvbiBzaG91bGQgYmUgZG9uZSB0 byBzZXQgdGhlIGluZXhhY3QgZmxhZyB3aGVuIHRoZQogICoJcmVzdWx0IGlzIGluZXhhY3QgYW5k IGF2b2lkIHNldHRpbmcgaW5leGFjdCB3aGVuIHRoZSByZXN1bHQKQEAgLTE3OSw2ICsxODAsOCBA QAogCiAjaWYgUExBVEZPUk0oQklHX0VORElBTikKICNkZWZpbmUgSUVFRV9NQzY4aworI2VsaWYg UExBVEZPUk0oTUlERExFX0VORElBTikKKyNkZWZpbmUgSUVFRV9BUk0KICNlbHNlCiAjZGVmaW5l IElFRUVfODA4NwogI2VuZGlmCkBAIC0yMDEsNiArMjA0LDEwIEBAIHR5cGVkZWYgdW5zaWduZWQg TG9uZyBVTG9uZzsKICNpbmNsdWRlIDxzdGRsaWIuaD4KICNpbmNsdWRlIDxzdHJpbmcuaD4KIAor I2lmZGVmIFVTRV9MT0NBTEUKKyNpbmNsdWRlIDxsb2NhbGUuaD4KKyNlbmRpZgorCiAjaWZkZWYg TUFMTE9DCiAjaWZkZWYgS1JfaGVhZGVycwogZXh0ZXJuIGNoYXIgKk1BTExPQygpOwpAQCAtMjI3 LDYgKzIzNCw5IEBAIHN0YXRpYyBkb3VibGUgcHJpdmF0ZV9tZW1bUFJJVkFURV9tZW1dLCAKICNp ZmRlZiBJRUVFXzgwODcKICNkZWZpbmUgSUVFRV9Bcml0aAogI2VuZGlmCisjaWZkZWYgSUVFRV9B Uk0KKyNkZWZpbmUgSUVFRV9Bcml0aAorI2VuZGlmCiAKICNpbmNsdWRlIDxlcnJuby5oPgogCkBA IC0yODMsOCArMjkzLDggQEAgZXh0ZXJuICJDIiB7CiAjZW5kaWYKICNlbmRpZgogCi0jaWYgZGVm aW5lZChJRUVFXzgwODcpICsgZGVmaW5lZChJRUVFX01DNjhrKSArIGRlZmluZWQoVkFYKSArIGRl ZmluZWQoSUJNKSAhPSAxCi1FeGFjdGx5IG9uZSBvZiBJRUVFXzgwODcsIElFRUVfTUM2OGssIFZB WCwgb3IgSUJNIHNob3VsZCBiZSBkZWZpbmVkLgorI2lmIGRlZmluZWQoSUVFRV84MDg3KSArIGRl ZmluZWQoSUVFRV9NQzY4aykgKyBkZWZpbmVkKElFRUVfQVJNKSArIGRlZmluZWQoVkFYKSArIGRl ZmluZWQoSUJNKSAhPSAxCitFeGFjdGx5IG9uZSBvZiBJRUVFXzgwODcsIElFRUVfQVJNLCBJRUVF X01DNjhrLCBWQVgsIG9yIElCTSBzaG91bGQgYmUgZGVmaW5lZC4KICNlbmRpZgogCiB0eXBlZGVm IHVuaW9uIHsgZG91YmxlIGQ7IFVMb25nIExbMl07IH0gVTsKQEAgLTMxMyw3ICszMjMsNyBAQCB0 eXBlZGVmIHVuaW9uIHsgZG91YmxlIGQ7IFVMb25nIExbMl07IH0gCiAgKiBBbiBhbHRlcm5hdGl2 ZSB0aGF0IG1pZ2h0IGJlIGJldHRlciBvbiBzb21lIG1hY2hpbmVzIGlzCiAgKiAjZGVmaW5lIFN0 b3JlaW5jKGEsYixjKSAoKmErKyA9IGIgPDwgMTYgfCBjICYgMHhmZmZmKQogICovCi0jaWYgZGVm aW5lZChJRUVFXzgwODcpICsgZGVmaW5lZChWQVgpCisjaWYgZGVmaW5lZChJRUVFXzgwODcpICsg ZGVmaW5lZChJRUVFX0FSTSkgKyBkZWZpbmVkKFZBWCkKICNkZWZpbmUgU3RvcmVpbmMoYSxiLGMp ICgoKHVuc2lnbmVkIHNob3J0ICopYSlbMV0gPSAodW5zaWduZWQgc2hvcnQpYiwgXAogKCh1bnNp Z25lZCBzaG9ydCAqKWEpWzBdID0gKHVuc2lnbmVkIHNob3J0KWMsIGErKykKICNlbHNlCkBAIC0x NTU0LDYgKzE1NjQsOSBAQCBzdHJ0b2QKICNpZmRlZiBIb25vcl9GTFRfUk9VTkRTCiAJaW50IHJv dW5kaW5nOwogI2VuZGlmCisjaWZkZWYgVVNFX0xPQ0FMRQorCUNPTlNUXyBjaGFyICpzMjsKKyNl bmRpZgogCiAJc2lnbiA9IG56MCA9IG56ID0gMDsKIAlkdmFsKHJ2KSA9IDAuOwpAQCAtMTU5Miw2 ICsxNjA1LDI1IEBAIHN0cnRvZAogCQllbHNlIGlmIChuZCA8IDE2KQogCQkJeiA9IDEwKnogKyBj IC0gJzAnOwogCW5kMCA9IG5kOworI2lmZGVmIFVTRV9MT0NBTEUKKwlzMSA9IGxvY2FsZWNvbnYo KS0+ZGVjaW1hbF9wb2ludDsKKwlpZiAoYyA9PSAqczEpIHsKKwkJYyA9ICcuJzsKKwkJaWYgKCor K3MxKSB7CisJCQlzMiA9IHM7CisJCQlmb3IoOzspIHsKKwkJCQlpZiAoKisrczIgIT0gKnMxKSB7 CisJCQkJCWMgPSAwOworCQkJCQlicmVhazsKKwkJCQkJfQorCQkJCWlmICghKisrczEpIHsKKwkJ CQkJcyA9IHMyOworCQkJCQlicmVhazsKKwkJCQkJfQorCQkJCX0KKwkJCX0KKwkJfQorI2VuZGlm CiAJaWYgKGMgPT0gJy4nKSB7CiAJCWMgPSAqKytzOwogCQlpZiAoIW5kKSB7CkBAIC0yMzk2LDcg KzI0MjgsNyBAQCBzdHJ0b2QKIAlpZiAoc2UpCiAJCSpzZSA9IChjaGFyICopczsKIAlyZXR1cm4g c2lnbiA/IC1kdmFsKHJ2KSA6IGR2YWwocnYpOwotCX0KK30KIAogIHN0YXRpYyBpbnQKIHF1b3Jl bQpAQCAtMjU3OSw3ICsyNjExLDcgQEAgZnJlZWR0b2EoY2hhciAqcykKIAlpZiAocyA9PSBkdG9h X3Jlc3VsdCkKIAkJZHRvYV9yZXN1bHQgPSAwOwogI2VuZGlmCi0JfQorfQogCiAvKiBkdG9hIGZv ciBJRUVFIGFyaXRobWV0aWMgKGRtZyk6IGNvbnZlcnQgZG91YmxlIHRvIEFTQ0lJIHN0cmluZy4K ICAqCkBAIC0yOTQ3LDcgKzI5NzksNyBAQCBkdG9hCiAJCQkJCWlmIChkdmFsKGQpID4gMC41ICsg ZHZhbChlcHMpKQogCQkJCQkJZ290byBidW1wX3VwOwogCQkJCQllbHNlIGlmIChkdmFsKGQpIDwg MC41IC0gZHZhbChlcHMpKSB7Ci0JCQkJCQl3aGlsZSAoKi0tcyA9PSAnMCcpIHsgfQorCQkJCQkJ d2hpbGUoKi0tcyA9PSAnMCcpOwogCQkJCQkJcysrOwogCQkJCQkJZ290byByZXQxOwogCQkJCQkJ fQpAQCAtMzI2Niw3ICszMjk4LDcgQEAgZHRvYQogI2lmZGVmIEhvbm9yX0ZMVF9ST1VORFMKIHRy aW16ZXJvczoKICNlbmRpZgotCQl3aGlsZSAoKi0tcyA9PSAnMCcpIHsgfQorCQl3aGlsZSgqLS1z ID09ICcwJyk7CiAJCXMrKzsKIAkJfQogIHJldDoKQEAgLTMyOTQsNyArMzMyNiw3IEBAIHRyaW16 ZXJvczoKIAlpZiAocnZlKQogCQkqcnZlID0gczsKIAlyZXR1cm4gczA7Ci0JfQorfQogI2lmZGVm IF9fY3BsdXNwbHVzCiB9CiAjZW5kaWYK 19624 2008-03-09 19:17:07 -0700 2008-03-09 23:07:08 -0700 fix mixed-endian patch-javascriptcore-b30913.patch text/plain 3237 weihong.zeng SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDMwOTE0 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDQgKzEsMTMgQEAKLTIwMDgtMDMt MDkgIEr8cmcgQmlsbGV0ZXIgIDxqQGJpdHJvbi5jaD4KKzIwMDgtMDMtMDkgIHdlaWhvbmd6ZW5n ICA8d2VpaG9uZy56ZW5nQGhvdG1haWwuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IERhcmlu IEFkbGVyLgorCisgICAgICAgIGh0dHA6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE1NDE2CisgICAgICAgIEFkZCBzdXBwb3J0IGZvciBtaXhlZC1lbmRpYW4gcHJvY2Vzc29ycwor CisgICAgICAgICoga2pzL2R0b2EuY3BwOgorCisyMDA4LTAzLTA5ICBKP3JnIEJpbGxldGVyICA8 akBiaXRyb24uY2g+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQWxwIFRva2VyLgogCkluZGV4OiBr anMvZHRvYS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0ga2pzL2R0b2EuY3BwCShyZXZpc2lvbiAzMDkxNCkK KysrIGtqcy9kdG9hLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTUwLDYgKzE1MCw3IEBACiAgKglz b21lIGNvbXBpbGVycyBhbmQgd2FzIGFsd2F5cyB1c2VkIHByaW9yIHRvIDE5OTkwOTE2LCBidXQg aXQKICAqCWlzIG5vdCBzdHJpY3RseSBsZWdhbCBhbmQgY2FuIGNhdXNlIHRyb3VibGUgd2l0aCBh Z2dyZXNzaXZlbHkKICAqCW9wdGltaXppbmcgY29tcGlsZXJzIChlLmcuLCBnY2MgMi45NS4xIHVu ZGVyIC1PMikuCisgKiAjZGVmaW5lIFVTRV9MT0NBTEUgdG8gdXNlIHRoZSBjdXJyZW50IGxvY2Fs ZSdzIGRlY2ltYWxfcG9pbnQgdmFsdWUuCiAgKiAjZGVmaW5lIFNFVF9JTkVYQUNUIGlmIElFRUUg YXJpdGhtZXRpYyBpcyBiZWluZyB1c2VkIGFuZCBleHRyYQogICoJY29tcHV0YXRpb24gc2hvdWxk IGJlIGRvbmUgdG8gc2V0IHRoZSBpbmV4YWN0IGZsYWcgd2hlbiB0aGUKICAqCXJlc3VsdCBpcyBp bmV4YWN0IGFuZCBhdm9pZCBzZXR0aW5nIGluZXhhY3Qgd2hlbiB0aGUgcmVzdWx0CkBAIC0xNzks NiArMTgwLDggQEAKIAogI2lmIFBMQVRGT1JNKEJJR19FTkRJQU4pCiAjZGVmaW5lIElFRUVfTUM2 OGsKKyNlbGlmIFBMQVRGT1JNKE1JRERMRV9FTkRJQU4pCisjZGVmaW5lIElFRUVfQVJNCiAjZWxz ZQogI2RlZmluZSBJRUVFXzgwODcKICNlbmRpZgpAQCAtMjAxLDYgKzIwNCwxMCBAQCB0eXBlZGVm IHVuc2lnbmVkIExvbmcgVUxvbmc7CiAjaW5jbHVkZSA8c3RkbGliLmg+CiAjaW5jbHVkZSA8c3Ry aW5nLmg+CiAKKyNpZmRlZiBVU0VfTE9DQUxFCisjaW5jbHVkZSA8bG9jYWxlLmg+CisjZW5kaWYK KwogI2lmZGVmIE1BTExPQwogI2lmZGVmIEtSX2hlYWRlcnMKIGV4dGVybiBjaGFyICpNQUxMT0Mo KTsKQEAgLTIyNyw2ICsyMzQsOSBAQCBzdGF0aWMgZG91YmxlIHByaXZhdGVfbWVtW1BSSVZBVEVf bWVtXSwgCiAjaWZkZWYgSUVFRV84MDg3CiAjZGVmaW5lIElFRUVfQXJpdGgKICNlbmRpZgorI2lm ZGVmIElFRUVfQVJNCisjZGVmaW5lIElFRUVfQXJpdGgKKyNlbmRpZgogCiAjaW5jbHVkZSA8ZXJy bm8uaD4KIApAQCAtMjgzLDggKzI5Myw4IEBAIGV4dGVybiAiQyIgewogI2VuZGlmCiAjZW5kaWYK IAotI2lmIGRlZmluZWQoSUVFRV84MDg3KSArIGRlZmluZWQoSUVFRV9NQzY4aykgKyBkZWZpbmVk KFZBWCkgKyBkZWZpbmVkKElCTSkgIT0gMQotRXhhY3RseSBvbmUgb2YgSUVFRV84MDg3LCBJRUVF X01DNjhrLCBWQVgsIG9yIElCTSBzaG91bGQgYmUgZGVmaW5lZC4KKyNpZiBkZWZpbmVkKElFRUVf ODA4NykgKyBkZWZpbmVkKElFRUVfTUM2OGspICsgZGVmaW5lZChJRUVFX0FSTSkgKyBkZWZpbmVk KFZBWCkgKyBkZWZpbmVkKElCTSkgIT0gMQorRXhhY3RseSBvbmUgb2YgSUVFRV84MDg3LCBJRUVF X0FSTSwgSUVFRV9NQzY4aywgVkFYLCBvciBJQk0gc2hvdWxkIGJlIGRlZmluZWQuCiAjZW5kaWYK IAogdHlwZWRlZiB1bmlvbiB7IGRvdWJsZSBkOyBVTG9uZyBMWzJdOyB9IFU7CkBAIC0zMTMsNyAr MzIzLDcgQEAgdHlwZWRlZiB1bmlvbiB7IGRvdWJsZSBkOyBVTG9uZyBMWzJdOyB9IAogICogQW4g YWx0ZXJuYXRpdmUgdGhhdCBtaWdodCBiZSBiZXR0ZXIgb24gc29tZSBtYWNoaW5lcyBpcwogICog I2RlZmluZSBTdG9yZWluYyhhLGIsYykgKCphKysgPSBiIDw8IDE2IHwgYyAmIDB4ZmZmZikKICAq LwotI2lmIGRlZmluZWQoSUVFRV84MDg3KSArIGRlZmluZWQoVkFYKQorI2lmIGRlZmluZWQoSUVF RV84MDg3KSArIGRlZmluZWQoSUVFRV9BUk0pICsgZGVmaW5lZChWQVgpCiAjZGVmaW5lIFN0b3Jl aW5jKGEsYixjKSAoKCh1bnNpZ25lZCBzaG9ydCAqKWEpWzFdID0gKHVuc2lnbmVkIHNob3J0KWIs IFwKICgodW5zaWduZWQgc2hvcnQgKilhKVswXSA9ICh1bnNpZ25lZCBzaG9ydCljLCBhKyspCiAj ZWxzZQpAQCAtMTU1NCw2ICsxNTY0LDkgQEAgc3RydG9kCiAjaWZkZWYgSG9ub3JfRkxUX1JPVU5E UwogCWludCByb3VuZGluZzsKICNlbmRpZgorI2lmZGVmIFVTRV9MT0NBTEUKKyAgICBDT05TVF8g Y2hhciAqczI7CisjZW5kaWYKIAogCXNpZ24gPSBuejAgPSBueiA9IDA7CiAJZHZhbChydikgPSAw LjsKQEAgLTE1OTIsNiArMTYwNSwyNSBAQCBzdHJ0b2QKIAkJZWxzZSBpZiAobmQgPCAxNikKIAkJ CXogPSAxMCp6ICsgYyAtICcwJzsKIAluZDAgPSBuZDsKKyNpZmRlZiBVU0VfTE9DQUxFCisgICAg czEgPSBsb2NhbGVjb252KCktPmRlY2ltYWxfcG9pbnQ7CisgICAgaWYgKGMgPT0gKnMxKSB7Cisg ICAgICAgIGMgPSAnLic7CisgICAgICAgIGlmICgqKytzMSkgeworICAgICAgICAgICAgczIgPSBz OworICAgICAgICAgICAgZm9yKDs7KSB7CisgICAgICAgICAgICAgICAgaWYgKCorK3MyICE9ICpz MSkgeworICAgICAgICAgICAgICAgICAgICBjID0gMDsKKyAgICAgICAgICAgICAgICAgICAgYnJl YWs7CisgICAgICAgICAgICAgICAgfQorICAgICAgICAgICAgICAgIGlmICghKisrczEpIHsKKyAg ICAgICAgICAgICAgICAgICAgcyA9IHMyOworICAgICAgICAgICAgICAgICAgICBicmVhazsKKyAg ICAgICAgICAgICAgICB9CisgICAgICAgICAgICB9CisgICAgICAgIH0KKyAgICB9CisjZW5kaWYK IAlpZiAoYyA9PSAnLicpIHsKIAkJYyA9ICorK3M7CiAJCWlmICghbmQpIHsK 19628 2008-03-09 23:07:08 -0700 2008-03-16 15:24:09 -0700 fix mixed-endian patch-javascriptcore-b30913.patch text/plain 1838 weihong.zeng SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDMwOTE5 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDQgKzEsMTMgQEAKLTIwMDgtMDMt MDkgIEr8cmcgQmlsbGV0ZXIgIDxqQGJpdHJvbi5jaD4KKzIwMDgtMDMtMDkgIHdlaWhvbmd6ZW5n ICA8d2VpaG9uZy56ZW5nQGhvdG1haWwuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IERhcmlu IEFkbGVyLgorCisgICAgICAgIGh0dHA6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE1NDE2CisgICAgICAgIEFkZCBzdXBwb3J0IGZvciBtaXhlZC1lbmRpYW4gcHJvY2Vzc29ycwor CisgICAgICAgICoga2pzL2R0b2EuY3BwOgorCisyMDA4LTAzLTA5ICBKP3JnIEJpbGxldGVyICA8 akBiaXRyb24uY2g+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQWxwIFRva2VyLgogCkluZGV4OiBr anMvZHRvYS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0ga2pzL2R0b2EuY3BwCShyZXZpc2lvbiAzMDkyMCkK KysrIGtqcy9kdG9hLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTc5LDYgKzE3OSw4IEBACiAKICNp ZiBQTEFURk9STShCSUdfRU5ESUFOKQogI2RlZmluZSBJRUVFX01DNjhrCisjZWxpZiBQTEFURk9S TShNSURETEVfRU5ESUFOKQorI2RlZmluZSBJRUVFX0FSTQogI2Vsc2UKICNkZWZpbmUgSUVFRV84 MDg3CiAjZW5kaWYKQEAgLTIyNyw2ICsyMjksOSBAQCBzdGF0aWMgZG91YmxlIHByaXZhdGVfbWVt W1BSSVZBVEVfbWVtXSwgCiAjaWZkZWYgSUVFRV84MDg3CiAjZGVmaW5lIElFRUVfQXJpdGgKICNl bmRpZgorI2lmZGVmIElFRUVfQVJNCisjZGVmaW5lIElFRUVfQXJpdGgKKyNlbmRpZgogCiAjaW5j bHVkZSA8ZXJybm8uaD4KIApAQCAtMjgzLDggKzI4OCw4IEBAIGV4dGVybiAiQyIgewogI2VuZGlm CiAjZW5kaWYKIAotI2lmIGRlZmluZWQoSUVFRV84MDg3KSArIGRlZmluZWQoSUVFRV9NQzY4aykg KyBkZWZpbmVkKFZBWCkgKyBkZWZpbmVkKElCTSkgIT0gMQotRXhhY3RseSBvbmUgb2YgSUVFRV84 MDg3LCBJRUVFX01DNjhrLCBWQVgsIG9yIElCTSBzaG91bGQgYmUgZGVmaW5lZC4KKyNpZiBkZWZp bmVkKElFRUVfODA4NykgKyBkZWZpbmVkKElFRUVfTUM2OGspICsgZGVmaW5lZChJRUVFX0FSTSkg KyBkZWZpbmVkKFZBWCkgKyBkZWZpbmVkKElCTSkgIT0gMQorRXhhY3RseSBvbmUgb2YgSUVFRV84 MDg3LCBJRUVFX0FSTSwgSUVFRV9NQzY4aywgVkFYLCBvciBJQk0gc2hvdWxkIGJlIGRlZmluZWQu CiAjZW5kaWYKIAogdHlwZWRlZiB1bmlvbiB7IGRvdWJsZSBkOyBVTG9uZyBMWzJdOyB9IFU7CkBA IC0zMTMsNyArMzE4LDcgQEAgdHlwZWRlZiB1bmlvbiB7IGRvdWJsZSBkOyBVTG9uZyBMWzJdOyB9 IAogICogQW4gYWx0ZXJuYXRpdmUgdGhhdCBtaWdodCBiZSBiZXR0ZXIgb24gc29tZSBtYWNoaW5l cyBpcwogICogI2RlZmluZSBTdG9yZWluYyhhLGIsYykgKCphKysgPSBiIDw8IDE2IHwgYyAmIDB4 ZmZmZikKICAqLwotI2lmIGRlZmluZWQoSUVFRV84MDg3KSArIGRlZmluZWQoVkFYKQorI2lmIGRl ZmluZWQoSUVFRV84MDg3KSArIGRlZmluZWQoSUVFRV9BUk0pICsgZGVmaW5lZChWQVgpCiAjZGVm aW5lIFN0b3JlaW5jKGEsYixjKSAoKCh1bnNpZ25lZCBzaG9ydCAqKWEpWzFdID0gKHVuc2lnbmVk IHNob3J0KWIsIFwKICgodW5zaWduZWQgc2hvcnQgKilhKVswXSA9ICh1bnNpZ25lZCBzaG9ydClj LCBhKyspCiAjZWxzZQo=