154159 2016-02-12 01:01:33 -0800 [GTK] HTTP auth dialog incorrectly rendered with Accelerated Compositing enabled 2016-02-12 08:40:23 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Local Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 154066 1 cgarcia webkit-unassigned berto bugs-noreply commit-queue gustavo mcatanzaro mrobinson yoon oldest_to_newest 1164058 0 cgarcia 2016-02-12 01:01:33 -0800 It's blurry, the check button is rendered as a black box, there are some black borders around entries and button, and the web view background gray effect doesn't work either. 1164065 1 cgarcia 2016-02-12 01:48:09 -0800 I still don't know what the problem is, but I'm thinking that maybe we could convert the HTTP auth dialog into a PageOverlay. 1164069 2 cgarcia 2016-02-12 01:55:57 -0800 I've just realized that this is not a problem of the threaded compositor, but exactly the same happens if you run without threaded compositor but forxing AC mode always on (WEBKIT_FORCE_COMPOSITING_MODE). So, is the threaded compositor forcing AC mode always? 1164079 3 cgarcia 2016-02-12 02:55:32 -0800 There are two problems here, first we are changing the cairo operator when rendering the xcomposite window pixmap without a proper save/restore, so it affects the drawing that happens after that, and second problem is tyhat we are not rendering the gray background in AC mode. I'll submit a patch. 1164081 4 271156 cgarcia 2016-02-12 02:57:23 -0800 Created attachment 271156 Patch 1164083 5 commit-queue 2016-02-12 02:59:17 -0800 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 1164088 6 271156 yoon 2016-02-12 03:06:38 -0800 Comment on attachment 271156 Patch I love this patch :). 1164141 7 271156 mcatanzaro 2016-02-12 08:00:52 -0800 Comment on attachment 271156 Patch rs=me with Yoon's approval 1164145 8 cgarcia 2016-02-12 08:40:23 -0800 Committed r196475: <http://trac.webkit.org/changeset/196475> 271156 2016-02-12 02:57:23 -0800 2016-02-12 08:00:52 -0800 Patch wk2-auth-dialog-ac-mode.diff text/plain 3654 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA0MDc5YWY3Li5kMGIyYThhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAg QEAKKzIwMTYtMDItMTIgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIFtHVEtdIEhUVFAgYXV0aCBkaWFsb2cgaW5jb3JyZWN0bHkgcmVuZGVyZWQg d2l0aCBBY2NlbGVyYXRlZCBDb21wb3NpdGluZyBlbmFibGVkCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTQxNTkKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGVyZSBhcmUgdHdvIHByb2JsZW1zIGhlcmUs IGZpcnN0IHdlIGFyZSBjaGFuZ2luZyB0aGUgY2Fpcm8KKyAgICAgICAgb3BlcmF0b3Igd2hlbiBy ZW5kZXJpbmcgdGhlIHhjb21wb3NpdGUgd2luZG93IHBpeG1hcCB3aXRob3V0IGEKKyAgICAgICAg cHJvcGVyIHNhdmUvcmVzdG9yZSwgc28gaXQgYWZmZWN0cyB0aGUgZHJhd2luZyB0aGF0IGhhcHBl bnMgYWZ0ZXIKKyAgICAgICAgdGhhdCwgYW5kIHNlY29uZCBwcm9ibGVtIGlzIHRoYXQgd2UgYXJl IG5vdCByZW5kZXJpbmcgdGhlIGdyYXkKKyAgICAgICAgYmFja2dyb3VuZCBpbiBBQyBtb2RlIGJl Y2F1c2Ugd2UgYXJlIHJldHVybmluZyBlYXJsaWVyLgorCisgICAgICAgICogVUlQcm9jZXNzL0FQ SS9ndGsvV2ViS2l0V2ViVmlld0Jhc2UuY3BwOgorICAgICAgICAod2Via2l0V2ViVmlld1JlbmRl ckFjY2VsZXJhdGVkQ29tcG9zaXRpbmdSZXN1bHRzKToKKyAgICAgICAgKHdlYmtpdFdlYlZpZXdC YXNlRHJhdyk6CisKIDIwMTYtMDItMTEgIENvbW1pdCBRdWV1ZSAgPGNvbW1pdC1xdWV1ZUB3ZWJr aXQub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIxOTY0NTMuCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3QmFz ZS5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3QmFz ZS5jcHAKaW5kZXggNjllNTkyYy4uZTVmMDc1OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmlld0Jhc2UuY3BwCisrKyBiL1NvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdlYlZpZXdCYXNlLmNwcApAQCAtNTI4LDE1ICs1 MjgsMTQgQEAgc3RhdGljIHZvaWQgd2Via2l0V2ViVmlld0Jhc2VDb25zdHJ1Y3RlZChHT2JqZWN0 KiBvYmplY3QpCiAgICAgcHJpdi0+YXV0aGVudGljYXRpb25EaWFsb2cgPSAwOwogfQogCi0jaWYg VVNFKFRFWFRVUkVfTUFQUEVSKQogc3RhdGljIGJvb2wgd2Via2l0V2ViVmlld1JlbmRlckFjY2Vs ZXJhdGVkQ29tcG9zaXRpbmdSZXN1bHRzKFdlYktpdFdlYlZpZXdCYXNlKiB3ZWJWaWV3QmFzZSwg RHJhd2luZ0FyZWFQcm94eUltcGwqIGRyYXdpbmdBcmVhLCBjYWlyb190KiBjciwgR2RrUmVjdGFu Z2xlKiBjbGlwUmVjdCkKIHsKKyNpZiBVU0UoVEVYVFVSRV9NQVBQRVIpICYmIFVTRShSRURJUkVD VEVEX1hDT01QT1NJVEVfV0lORE9XKQogICAgIEFTU0VSVChkcmF3aW5nQXJlYSk7CiAKICAgICBp ZiAoIWRyYXdpbmdBcmVhLT5pc0luQWNjZWxlcmF0ZWRDb21wb3NpdGluZ01vZGUoKSkKICAgICAg ICAgcmV0dXJuIGZhbHNlOwogCi0jaWYgVVNFKFJFRElSRUNURURfWENPTVBPU0lURV9XSU5ET1cp CiAgICAgLy8gVG8gYXZvaWQgZmxhc2hlcyB3aGVuIGluaXRpYWxpemluZyBhY2NlbGVyYXRlZCBj b21wb3NpdGluZyBmb3IgdGhlIGZpcnN0CiAgICAgLy8gdGltZSwgd2Ugd2FpdCB1bnRpbCB3ZSBr bm93IHRoZXJlJ3MgYSBmcmFtZSByZWFkeSBiZWZvcmUgcmVuZGVyaW5nLgogICAgIFdlYktpdFdl YlZpZXdCYXNlUHJpdmF0ZSogcHJpdiA9IHdlYlZpZXdCYXNlLT5wcml2OwpAQCAtNTQ3LDEwICs1 NDYsMTIgQEAgc3RhdGljIGJvb2wgd2Via2l0V2ViVmlld1JlbmRlckFjY2VsZXJhdGVkQ29tcG9z aXRpbmdSZXN1bHRzKFdlYktpdFdlYlZpZXdCYXNlKgogICAgIHByaXYtPnJlZGlyZWN0ZWRXaW5k b3ctPnJlc2l6ZShkcmF3aW5nQXJlYS0+c2l6ZSgpKTsKIAogICAgIGlmIChjYWlyb19zdXJmYWNl X3QqIHN1cmZhY2UgPSBwcml2LT5yZWRpcmVjdGVkV2luZG93LT5zdXJmYWNlKCkpIHsKKyAgICAg ICAgY2Fpcm9fc2F2ZShjcik7CiAgICAgICAgIGNhaXJvX3JlY3RhbmdsZShjciwgY2xpcFJlY3Qt PngsIGNsaXBSZWN0LT55LCBjbGlwUmVjdC0+d2lkdGgsIGNsaXBSZWN0LT5oZWlnaHQpOwogICAg ICAgICBjYWlyb19zZXRfc291cmNlX3N1cmZhY2UoY3IsIHN1cmZhY2UsIDAsIDApOwogICAgICAg ICBjYWlyb19zZXRfb3BlcmF0b3IoY3IsIENBSVJPX09QRVJBVE9SX1NPVVJDRSk7CiAgICAgICAg IGNhaXJvX2ZpbGwoY3IpOworICAgICAgICBjYWlyb19yZXN0b3JlKGNyKTsKICAgICB9CiAKICAg ICByZXR1cm4gdHJ1ZTsKQEAgLTU2MSw3ICs1NjIsNiBAQCBzdGF0aWMgYm9vbCB3ZWJraXRXZWJW aWV3UmVuZGVyQWNjZWxlcmF0ZWRDb21wb3NpdGluZ1Jlc3VsdHMoV2ViS2l0V2ViVmlld0Jhc2Uq CiAgICAgcmV0dXJuIGZhbHNlOwogI2VuZGlmCiB9Ci0jZW5kaWYKIAogc3RhdGljIGdib29sZWFu IHdlYmtpdFdlYlZpZXdCYXNlRHJhdyhHdGtXaWRnZXQqIHdpZGdldCwgY2Fpcm9fdCogY3IpCiB7 CkBAIC01NzQsMTMgKzU3NCwxMCBAQCBzdGF0aWMgZ2Jvb2xlYW4gd2Via2l0V2ViVmlld0Jhc2VE cmF3KEd0a1dpZGdldCogd2lkZ2V0LCBjYWlyb190KiBjcikKICAgICBpZiAoIWdka19jYWlyb19n ZXRfY2xpcF9yZWN0YW5nbGUoY3IsICZjbGlwUmVjdCkpCiAgICAgICAgIHJldHVybiBGQUxTRTsK IAotI2lmIFVTRShURVhUVVJFX01BUFBFUikKLSAgICBpZiAod2Via2l0V2ViVmlld1JlbmRlckFj Y2VsZXJhdGVkQ29tcG9zaXRpbmdSZXN1bHRzKHdlYlZpZXdCYXNlLCBkcmF3aW5nQXJlYSwgY3Is ICZjbGlwUmVjdCkpCi0gICAgICAgIHJldHVybiBHVEtfV0lER0VUX0NMQVNTKHdlYmtpdF93ZWJf dmlld19iYXNlX3BhcmVudF9jbGFzcyktPmRyYXcod2lkZ2V0LCBjcik7Ci0jZW5kaWYKLQotICAg IFdlYkNvcmU6OlJlZ2lvbiB1bnBhaW50ZWRSZWdpb247IC8vIFRoaXMgaXMgc2ltcGx5IHVudXNl ZC4KLSAgICBkcmF3aW5nQXJlYS0+cGFpbnQoY3IsIGNsaXBSZWN0LCB1bnBhaW50ZWRSZWdpb24p OworICAgIGlmICghd2Via2l0V2ViVmlld1JlbmRlckFjY2VsZXJhdGVkQ29tcG9zaXRpbmdSZXN1 bHRzKHdlYlZpZXdCYXNlLCBkcmF3aW5nQXJlYSwgY3IsICZjbGlwUmVjdCkpIHsKKyAgICAgICAg V2ViQ29yZTo6UmVnaW9uIHVucGFpbnRlZFJlZ2lvbjsgLy8gVGhpcyBpcyBzaW1wbHkgdW51c2Vk LgorICAgICAgICBkcmF3aW5nQXJlYS0+cGFpbnQoY3IsIGNsaXBSZWN0LCB1bnBhaW50ZWRSZWdp b24pOworICAgIH0KIAogICAgIGlmICh3ZWJWaWV3QmFzZS0+cHJpdi0+YXV0aGVudGljYXRpb25E aWFsb2cpIHsKICAgICAgICAgY2Fpcm9fc2V0X29wZXJhdG9yKGNyLCBDQUlST19PUEVSQVRPUl9P VkVSKTsK