154158 2016-02-12 00:34:28 -0800 [GTK] Properly handle classes inheriting from EventTarget 2016-02-12 08:41:16 -0800 1 1 1 Unclassified WebKit Bindings WebKit Local Build Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 1 cgarcia webkit-unassigned bugs-noreply cdumez oldest_to_newest 1164050 0 cgarcia 2016-02-12 00:34:28 -0800 Instead of removing its parent we could handle the case of classes having EventTarget as parent to make them implement the interface instead. 1164055 1 271147 cgarcia 2016-02-12 00:40:51 -0800 Created attachment 271147 Patch 1164144 2 cgarcia 2016-02-12 08:37:22 -0800 Committed r196474: <http://trac.webkit.org/changeset/196474> 1164146 3 271147 cdumez 2016-02-12 08:41:16 -0800 Comment on attachment 271147 Patch Looks great, thanks! 271147 2016-02-12 00:40:51 -0800 2016-02-12 07:53:51 -0800 Patch wcore-dom-event-target.diff text/plain 4898 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA3MTA4NzFiLi4wMzg0NjM3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjkg QEAKKzIwMTYtMDItMTIgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIFtHVEtdIFByb3Blcmx5IGhhbmRsZSBjbGFzc2VzIGluaGVyaXRpbmcgZnJv bSBFdmVudFRhcmdldAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTU0MTU4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgSW5zdGVhZCBvZiByZW1vdmluZyBpdHMgcGFyZW50IHdlIG5vdyBoYW5kbGUgdGhlIGNh c2Ugb2YgY2xhc3NlcworICAgICAgICBoYXZpbmcgRXZlbnRUYXJnZXQgYXMgcGFyZW50IHRvIG1h a2UgdGhlbSBpbXBsZW1lbnQgdGhlIGludGVyZmFjZQorICAgICAgICBpbnN0ZWFkLgorCisgICAg ICAgICogYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yR09iamVjdC5wbToKKyAgICAgICAg KFNob3VsZEJlRXhwb3NlZEFzSW50ZXJmYWNlKTogV2hldGhlciB0aGUgcGFyZW50IGdpdmVuIGNs YXNzCisgICAgICAgIHNob3VsZCBiZSBleHBvc2VkIGFzIGFuIGludGVyZmFjZSBpbnN0ZWFkIG9m IGEgcGFyZW50IGNsYXNzLgorICAgICAgICAoR2V0UGFyZW50Q2xhc3NOYW1lKTogUmV0dXJuIE9i amVjdCBhcyBwYXJlbnQgZm9yIGNsYXNzZXMgaGF2aW5nCisgICAgICAgIGEgcGFyZW50IHRoYXQg c2hvdWxkIGJlIGV4cG9zZWQgYXMgYW4gaW50ZXJmYWNlLgorICAgICAgICAoR2V0UGFyZW50SW1w bENsYXNzTmFtZSk6IERpdHRvLgorICAgICAgICAoR2V0QmFzZUNsYXNzKTogRGl0dG8uCisgICAg ICAgIChHZXRQYXJlbnRHT2JqVHlwZSk6IERpdHRvLgorICAgICAgICAoU2tpcEZ1bmN0aW9uKTog QWRkIEZJWE1FIGNvbW1lbnQuCisgICAgICAgIChJbXBsZW1lbnRzSW50ZXJmYWNlKTogSGVscGVy IGZ1bmN0aW9uIHRvIGNoZWNrIGlmIGEgY2xhc3MKKyAgICAgICAgaW1wbGVtZW50cyB0aGUgZ2l2 ZW4gaW50ZXJmYWNlLgorICAgICAgICAoR2VuZXJhdGVDRmlsZSk6IENoZWNrIHdoZXRoZXIgdGhl IGNsYXNzIGltcGxlbWVudHMgRXZlbnRUYXJnZXQgdG8KKyAgICAgICAgZ2VuZXJhdGUgdGhlIGlu dGVyZmFjZSBpbXBsZW1lbnRhdGlvbi4KKyAgICAgICAgKEdlbmVyYXRlSW50ZXJmYWNlKTogRG8g bm90IHJlbW92ZSB0aGUgcGFyZW50IGNsYXNzIHdoZW4gaXQncyBFdmVudFRhcmdldC4KKwogMjAx Ni0wMi0xMSAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIFtXZWIg SURMXSBpbnRlcmZhY2VzIHNob3VsZCBpbmhlcml0IEV2ZW50VGFyZ2V0IGluc3RlYWQgb2YgZHVw bGljYXRpbmcgdGhlIEV2ZW50VGFyZ2V0IEFQSQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv YmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yR09iamVjdC5wbSBiL1NvdXJjZS9XZWJDb3Jl L2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckdPYmplY3QucG0KaW5kZXggNTE1ZTA5ZS4u NTQyZDhkNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2Rl R2VuZXJhdG9yR09iamVjdC5wbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRz L0NvZGVHZW5lcmF0b3JHT2JqZWN0LnBtCkBAIC0xMTksMTggKzExOSwyNiBAQCBteSAkbGljZW5j ZVRlbXBsYXRlID0gPDwgIkVPRiI7CiAgKi8KIEVPRgogCitzdWIgU2hvdWxkQmVFeHBvc2VkQXNJ bnRlcmZhY2UgeworICAgIG15ICRpbnRlcmZhY2UgPSBzaGlmdDsKKworICAgIHJldHVybiAkaW50 ZXJmYWNlIGVxICJFdmVudFRhcmdldCI7Cit9CisKIHN1YiBHZXRQYXJlbnRDbGFzc05hbWUgewog ICAgIG15ICRpbnRlcmZhY2UgPSBzaGlmdDsKKyAgICBteSAkcGFyZW50ID0gJGludGVyZmFjZS0+ cGFyZW50OwogCi0gICAgcmV0dXJuICJXZWJLaXRET01PYmplY3QiIHVubGVzcyAkaW50ZXJmYWNl LT5wYXJlbnQ7Ci0gICAgcmV0dXJuICJXZWJLaXRET00iIC4gJGludGVyZmFjZS0+cGFyZW50Owor ICAgIHJldHVybiAiV2ViS2l0RE9NT2JqZWN0IiB1bmxlc3MgJHBhcmVudCBhbmQgIVNob3VsZEJl RXhwb3NlZEFzSW50ZXJmYWNlKCRwYXJlbnQpOworICAgIHJldHVybiAiV2ViS2l0RE9NIiAuICRw YXJlbnQ7CiB9CiAKIHN1YiBHZXRQYXJlbnRJbXBsQ2xhc3NOYW1lIHsKICAgICBteSAkaW50ZXJm YWNlID0gc2hpZnQ7CisgICAgbXkgJHBhcmVudCA9ICRpbnRlcmZhY2UtPnBhcmVudDsKIAotICAg IHJldHVybiAiT2JqZWN0IiB1bmxlc3MgJGludGVyZmFjZS0+cGFyZW50OwotICAgIHJldHVybiAk aW50ZXJmYWNlLT5wYXJlbnQ7CisgICAgcmV0dXJuICJPYmplY3QiIHVubGVzcyAkcGFyZW50IGFu ZCAhU2hvdWxkQmVFeHBvc2VkQXNJbnRlcmZhY2UoJHBhcmVudCk7CisgICAgcmV0dXJuICRwYXJl bnQ7CiB9CiAKIHN1YiBJc0Jhc2VUeXBlCkBAIC0xNDcsNiArMTU1LDcgQEAgc3ViIEdldEJhc2VD bGFzcwogICAgICRpbnRlcmZhY2UgPSBzaGlmdDsKIAogICAgIHJldHVybiAkcGFyZW50IGlmICRw YXJlbnQgZXEgIk9iamVjdCIgb3IgSXNCYXNlVHlwZSgkcGFyZW50KTsKKyAgICByZXR1cm4gIk9i amVjdCIgaWYgU2hvdWxkQmVFeHBvc2VkQXNJbnRlcmZhY2UoJHBhcmVudCk7CiAgICAgcmV0dXJu ICJFdmVudCIgaWYgJGNvZGVHZW5lcmF0b3ItPkluaGVyaXRzSW50ZXJmYWNlKCRpbnRlcmZhY2Us ICJFdmVudCIpOwogICAgIHJldHVybiAiQ1NTVmFsdWUiIGlmICRwYXJlbnQgZXEgIlNWR0NvbG9y IiBvciAkcGFyZW50IGVxICJDU1NWYWx1ZUxpc3QiOwogICAgIHJldHVybiAiTm9kZSI7CkBAIC0y MDgsOSArMjE3LDEwIEBAIHN1YiBIdW1hblJlYWRhYmxlQ29uZGl0aW9uYWwgewogCiBzdWIgR2V0 UGFyZW50R09ialR5cGUgewogICAgIG15ICRpbnRlcmZhY2UgPSBzaGlmdDsKKyAgICBteSAkcGFy ZW50ID0gJGludGVyZmFjZS0+cGFyZW50OwogCi0gICAgcmV0dXJuICJXRUJLSVRfRE9NX1RZUEVf T0JKRUNUIiB1bmxlc3MgJGludGVyZmFjZS0+cGFyZW50OwotICAgIHJldHVybiAiV0VCS0lUX0RP TV9UWVBFXyIgLiB1YyhkZWNhbWVsaXplKCgkaW50ZXJmYWNlLT5wYXJlbnQpKSk7CisgICAgcmV0 dXJuICJXRUJLSVRfRE9NX1RZUEVfT0JKRUNUIiB1bmxlc3MgJHBhcmVudCBhbmQgIVNob3VsZEJl RXhwb3NlZEFzSW50ZXJmYWNlKCRwYXJlbnQpOworICAgIHJldHVybiAiV0VCS0lUX0RPTV9UWVBF XyIgLiB1YyhkZWNhbWVsaXplKCgkcGFyZW50KSkpOwogfQogCiBzdWIgR2V0Q2xhc3NOYW1lIHsK QEAgLTMyNiw2ICszMzYsNyBAQCBzdWIgU2tpcEZ1bmN0aW9uIHsKICAgICB9CiAKICAgICAjIFNr aXAgZGlzcGF0Y2hfZXZlbnQgbWV0aG9kcy4KKyAgICAjIEZJWE1FOiBUaGlzIGNhbiBiZSByZW1v dmVkIG9uY2UgYWxsIGNsYXNzZXMgaW1wbGVtZW50aW5nIEV2ZW50VGFyZ2V0IGluaGVyaXQgZnJv bSBpdCBpbnN0ZWFkLgogICAgIGlmICgkcGFyZW50Tm9kZS0+ZXh0ZW5kZWRBdHRyaWJ1dGVzLT57 IkV2ZW50VGFyZ2V0In0gJiYgJGZ1bmN0aW9uLT5zaWduYXR1cmUtPm5hbWUgZXEgImRpc3BhdGNo RXZlbnQiKSB7CiAgICAgICAgIHJldHVybiAxOwogICAgIH0KQEAgLTE0OTAsMTAgKzE1MDEsMjAg QEAgc3ViIEdlbmVyYXRlRnVuY3Rpb25zIHsKICAgICB9CiB9CiAKK3N1YiBJbXBsZW1lbnRzSW50 ZXJmYWNlIHsKKyAgICBteSAkaW50ZXJmYWNlID0gc2hpZnQ7CisgICAgbXkgJGltcGxlbWVudElu dGVyZmFjZSA9IHNoaWZ0OworCisgICAgIyBGSVhNRTogQ2hlY2sgb25seSB0aGUgcGFyZW50IGNs YXNzIG9uY2UgYWxsIGNsYXNzZXMgaW1wbGVtZW50aW5nIEV2ZW50VGFyZ2V0IGluaGVyaXQgZnJv bSBpdCBpbnN0ZWFkLgorICAgIHJldHVybiAxIGlmICRpbnRlcmZhY2UtPnBhcmVudCBhbmQgJGlu dGVyZmFjZS0+cGFyZW50IGVxIGltcGxlbWVudEludGVyZmFjZSBhbmQgU2hvdWxkQmVFeHBvc2Vk QXNJbnRlcmZhY2UoJGludGVyZmFjZS0+cGFyZW50KTsKKyAgICByZXR1cm4gMSBpZiAkaW50ZXJm YWNlLT5leHRlbmRlZEF0dHJpYnV0ZXMtPnskaW1wbGVtZW50SW50ZXJmYWNlfTsKKyAgICByZXR1 cm4gMDsKK30KKwogc3ViIEdlbmVyYXRlQ0ZpbGUgewogICAgIG15ICgkb2JqZWN0LCAkaW50ZXJm YWNlTmFtZSwgJHBhcmVudENsYXNzTmFtZSwgJHBhcmVudEdPYmpUeXBlLCAkaW50ZXJmYWNlKSA9 IEBfOwogCi0gICAgaWYgKCRpbnRlcmZhY2UtPmV4dGVuZGVkQXR0cmlidXRlcy0+eyJFdmVudFRh cmdldCJ9KSB7CisgICAgaWYgKEltcGxlbWVudHNJbnRlcmZhY2UoJGludGVyZmFjZSwgIkV2ZW50 VGFyZ2V0IikpIHsKICAgICAgICAgJG9iamVjdC0+R2VuZXJhdGVFdmVudFRhcmdldElmYWNlKCRp bnRlcmZhY2UpOwogICAgIH0KIApAQCAtMTkyMSw5ICsxOTQyLDYgQEAgc3ViIFJlYWRTdGFibGVT eW1ib2xzIHsKIHN1YiBHZW5lcmF0ZUludGVyZmFjZSB7CiAgICAgbXkgKCRvYmplY3QsICRpbnRl cmZhY2UsICRkZWZpbmVzKSA9IEBfOwogCi0gICAgIyBGSVhNRTogR09iamVjdCBiaW5kaW5ncyBk byBub3Qgc3VwcG9ydCBFdmVudFRhcmdldCBhcyBiYXNlIGNsYXNzLgotICAgICRpbnRlcmZhY2Ut PnBhcmVudCh1bmRlZikgaWYgJGludGVyZmFjZS0+cGFyZW50ICYmICRpbnRlcmZhY2UtPnBhcmVu dCBlcSAiRXZlbnRUYXJnZXQiOwotCiAgICAgIyBTZXQgdXAgc29tZSBnbG9iYWwgdmFyaWFibGVz CiAgICAgJGNsYXNzTmFtZSA9IEdldENsYXNzTmFtZSgkaW50ZXJmYWNlLT5uYW1lKTsKIAo=