154150 2016-02-11 19:51:16 -0800 Web Inspector: SourceCodeTextEditor close() generates removeEventListener warnings 2016-02-11 21:17:15 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED DoNotImportToRadar P2 Normal --- 1 joepeck joepeck bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1163996 0 joepeck 2016-02-11 19:51:16 -0800 * SUMMARY SourceCodeTextEditor close() generates removeEventListener warnings: Resources/Base/Object.js:97:23: CONSOLE ERROR removeEventListener cannot remove issue-manager-issue-was-added because it doesn't exist. Resources/Base/Object.js:97:23: CONSOLE ERROR removeEventListener cannot remove source-code-source-map-added because it doesn't exist. * STEPS TO REPRODUCE 1. Inspect this page 2. Open a bunch of scripts 3. Reload => warnings * NOTES - We should only removeEventListener if we directly added an event listener. We know that pretty easily here. 1163997 1 271124 joepeck 2016-02-11 19:52:40 -0800 Created attachment 271124 [PATCH] Proposed Fix 1164013 2 271124 commit-queue 2016-02-11 21:17:12 -0800 Comment on attachment 271124 [PATCH] Proposed Fix Clearing flags on attachment: 271124 Committed r196464: <http://trac.webkit.org/changeset/196464> 1164014 3 commit-queue 2016-02-11 21:17:15 -0800 All reviewed patches have been landed. Closing bug. 271124 2016-02-11 19:52:40 -0800 2016-02-11 21:17:12 -0800 [PATCH] Proposed Fix reduce-noise.patch text/plain 2235 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGM2MGVjYTMuLmExNzE2NmIgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE2LTAyLTExICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogU291cmNl Q29kZVRleHRFZGl0b3IgY2xvc2UoKSBnZW5lcmF0ZXMgcmVtb3ZlRXZlbnRMaXN0ZW5lciB3YXJu aW5ncworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU0 MTUwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBV c2VySW50ZXJmYWNlL1ZpZXdzL1NvdXJjZUNvZGVUZXh0RWRpdG9yLmpzOgorICAgICAgICAoV2Vi SW5zcGVjdG9yLlNvdXJjZUNvZGVUZXh0RWRpdG9yLnByb3RvdHlwZS5jbG9zZSk6CisgICAgICAg IFJlbW92ZSB0aGUgZXZlbnQgbGlzdGVuZXJzIGluIHRoZSBjYXNlcyB0aGF0IHdlIHdvdWxkIGhh dmUgYWRkZWQgdGhlbS4KKyAgICAgICAgSWYgd2UgaGF2ZSBTb3VyY2VNYXAgaW5mb3JtYXRpb24g d2Ugc2hvdWxkIHJlbW92ZSB0aGUga2V5IGxpc3RlbmVyLAorICAgICAgICBhbmQgaWYgd2UgZG9u J3Qgd2Ugc2hvdWxkIHJlbW92ZSB0aGUgU291cmNlTWFwQWRkZWQgbGlzdGVuZXIuCisKIDIwMTYt MDItMTAgIFRpbW90aHkgSGF0Y2hlciAgPHRpbW90aHlAYXBwbGUuY29tPgogCiAgICAgICAgIFdl YiBJbnNwZWN0b3I6IEFkZCBuZXcgaWNvbiBmb3IgdGhlIFRpbWVsaW5lIFJlY29yZGluZyBuYXZp Z2F0aW9uIGJhciBpdGVtCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlcklu dGVyZmFjZS9WaWV3cy9Tb3VyY2VDb2RlVGV4dEVkaXRvci5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0 b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1NvdXJjZUNvZGVUZXh0RWRpdG9yLmpzCmluZGV4IGNj ODQ5NTkuLmFlMzE2OGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50 ZXJmYWNlL1ZpZXdzL1NvdXJjZUNvZGVUZXh0RWRpdG9yLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNw ZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1NvdXJjZUNvZGVUZXh0RWRpdG9yLmpzCkBAIC0x MzksOCArMTM5LDEwIEBAIFdlYkluc3BlY3Rvci5Tb3VyY2VDb2RlVGV4dEVkaXRvciA9IGNsYXNz IFNvdXJjZUNvZGVUZXh0RWRpdG9yIGV4dGVuZHMgV2ViSW5zcGVjCiAKICAgICAgICAgV2ViSW5z cGVjdG9yLmlzc3VlTWFuYWdlci5yZW1vdmVFdmVudExpc3RlbmVyKFdlYkluc3BlY3Rvci5Jc3N1 ZU1hbmFnZXIuRXZlbnQuSXNzdWVXYXNBZGRlZCwgdGhpcy5faXNzdWVXYXNBZGRlZCwgdGhpcyk7 CiAKLSAgICAgICAgV2ViSW5zcGVjdG9yLm5vdGlmaWNhdGlvbnMucmVtb3ZlRXZlbnRMaXN0ZW5l cihXZWJJbnNwZWN0b3IuTm90aWZpY2F0aW9uLkdsb2JhbE1vZGlmaWVyS2V5c0RpZENoYW5nZSwg dGhpcy5fdXBkYXRlVG9rZW5UcmFja2luZ0NvbnRyb2xsZXJTdGF0ZSwgdGhpcyk7Ci0gICAgICAg IHRoaXMuX3NvdXJjZUNvZGUucmVtb3ZlRXZlbnRMaXN0ZW5lcihXZWJJbnNwZWN0b3IuU291cmNl Q29kZS5FdmVudC5Tb3VyY2VNYXBBZGRlZCwgdGhpcy5fc291cmNlQ29kZVNvdXJjZU1hcEFkZGVk LCB0aGlzKTsKKyAgICAgICAgaWYgKHRoaXMuX3NvdXJjZUNvZGUgaW5zdGFuY2VvZiBXZWJJbnNw ZWN0b3IuU291cmNlTWFwUmVzb3VyY2UgfHwgdGhpcy5fc291cmNlQ29kZS5zb3VyY2VNYXBzLmxl bmd0aCA+IDApCisgICAgICAgICAgICBXZWJJbnNwZWN0b3Iubm90aWZpY2F0aW9ucy5yZW1vdmVF dmVudExpc3RlbmVyKFdlYkluc3BlY3Rvci5Ob3RpZmljYXRpb24uR2xvYmFsTW9kaWZpZXJLZXlz RGlkQ2hhbmdlLCB0aGlzLl91cGRhdGVUb2tlblRyYWNraW5nQ29udHJvbGxlclN0YXRlLCB0aGlz KTsKKyAgICAgICAgZWxzZQorICAgICAgICAgICAgdGhpcy5fc291cmNlQ29kZS5yZW1vdmVFdmVu dExpc3RlbmVyKFdlYkluc3BlY3Rvci5Tb3VyY2VDb2RlLkV2ZW50LlNvdXJjZU1hcEFkZGVkLCB0 aGlzLl9zb3VyY2VDb2RlU291cmNlTWFwQWRkZWQsIHRoaXMpOwogICAgIH0KIAogICAgIGNhbkJl Rm9ybWF0dGVkKCkK