154147 2016-02-11 18:32:05 -0800 [GTK] Allow applications to disable Accelerated Compositing mode 2016-02-12 03:37:35 -0800 1 1 1 Unclassified WebKit WebKitGTK Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=150558 https://bugs.webkit.org/show_bug.cgi?id=126122 P2 Normal --- 1 clopez clopez bugs-noreply cgarcia commit-queue darin mario mcatanzaro oldest_to_newest 1163973 0 clopez 2016-02-11 18:32:05 -0800 In bug 150558 we added the possibility to force AC to be always on if the environment variable WEBKIT_FORCE_COMPOSITING_MODE is defined. Sometimes, because of bad graphics drivers or other grahpic related bugs (for example see bug 126122) it may be desirable to do the contrary thing: force AC to be off. So I'm proposing here to add another variable, lets name it WEBKIT_DISABLE_COMPOSITING_MODE for consistency with the previous one to disable AC. 1163975 1 271115 clopez 2016-02-11 18:37:32 -0800 Created attachment 271115 Patch 1163978 2 clopez 2016-02-11 18:44:00 -0800 (In reply to comment #0) > So I'm proposing here to add another variable, lets name it > WEBKIT_DISABLE_COMPOSITING_MODE for consistency with the previous one to > disable AC. I mean ^ for consistency with the previous one to force AC mode always on. 1164029 3 271115 cgarcia 2016-02-11 22:39:04 -0800 Comment on attachment 271115 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=271115&action=review > Source/WebKit2/UIProcess/gtk/WebPreferencesGtk.cpp:50 > + if (getenv("WEBKIT_DISABLE_COMPOSITING_MODE")) > + setAcceleratedCompositingEnabled(false); Is this enough? We are enabling AC unconditionally in DrawingAreaImpl::setNativeSurfaceHandleForCompositing(), but only when m_layerTreeHost has been created. I guess we would never enter AC mode if the setting is disabled in first place. 1164076 4 clopez 2016-02-12 02:49:30 -0800 (In reply to comment #3) > Comment on attachment 271115 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=271115&action=review > > > Source/WebKit2/UIProcess/gtk/WebPreferencesGtk.cpp:50 > > + if (getenv("WEBKIT_DISABLE_COMPOSITING_MODE")) > > + setAcceleratedCompositingEnabled(false); > > Is this enough? We are enabling AC unconditionally in > DrawingAreaImpl::setNativeSurfaceHandleForCompositing(), but only when > m_layerTreeHost has been created. I guess we would never enter AC mode if > the setting is disabled in first place. Yes, my tests indicate it is. For example, if I load poster circle I see a 2D animation instead of the 3D tube. 1164092 5 271115 commit-queue 2016-02-12 03:37:33 -0800 Comment on attachment 271115 Patch Clearing flags on attachment: 271115 Committed r196467: <http://trac.webkit.org/changeset/196467> 1164093 6 commit-queue 2016-02-12 03:37:35 -0800 All reviewed patches have been landed. Closing bug. 271115 2016-02-11 18:37:32 -0800 2016-02-12 03:37:33 -0800 Patch bug-154147-20160212033710.patch text/plain 1413 clopez U3VidmVyc2lvbiBSZXZpc2lvbjogMTk2NDYxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNDA3OWFmN2E2MTVhZmNm ZjA3YTUyNTg4ZDZmNDYzNjdmYjZlNzNhZS4uMjMzNjk3Y2ZmNTI4YTI0ZjhlNTkyMjQ0YTdkOGNh NTVkMjZlYTk0YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE2LTAyLTExICBDYXJs b3MgQWxiZXJ0byBMb3BleiBQZXJleiAgPGNsb3BlekBpZ2FsaWEuY29tPgorCisgICAgICAgIFtH VEtdIEFsbG93IGFwcGxpY2F0aW9ucyB0byBkaXNhYmxlIEFjY2VsZXJhdGVkIENvbXBvc2l0aW5n IG1vZGUuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x NTQxNDcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IFVJUHJvY2Vzcy9ndGsvV2ViUHJlZmVyZW5jZXNHdGsuY3BwOgorICAgICAgICAoV2ViS2l0OjpX ZWJQcmVmZXJlbmNlczo6cGxhdGZvcm1Jbml0aWFsaXplU3RvcmUpOiBpZiB0aGUgZW52aXJvbm1l bnQKKyAgICAgICAgdmFyaWFibGUgIFdFQktJVF9ESVNBQkxFX0NPTVBPU0lUSU5HX01PREUgaXMg ZGVmaW5lZCwgdGhlbiBkaXNhYmxlIEFDLgorCiAyMDE2LTAyLTExICBDb21taXQgUXVldWUgIDxj b21taXQtcXVldWVAd2Via2l0Lm9yZz4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91 dCByMTk2NDUzLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2d0ay9XZWJQ cmVmZXJlbmNlc0d0ay5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvZ3RrL1dlYlByZWZl cmVuY2VzR3RrLmNwcAppbmRleCBjNzI0MmM0OWVkZDZjN2IxMDVhZTUyNWFlOWY4OGU2MGIxMTRm ZDY2Li5lZWQyMzRmNDlmY2UwZjdiMDk4ODY3NjI5YzAwNDliYTJjYmZjYTY0IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvZ3RrL1dlYlByZWZlcmVuY2VzR3RrLmNwcAorKysg Yi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvZ3RrL1dlYlByZWZlcmVuY2VzR3RrLmNwcApAQCAt NDYsNiArNDYsOCBAQCB2b2lkIFdlYlByZWZlcmVuY2VzOjpwbGF0Zm9ybUluaXRpYWxpemVTdG9y ZSgpCiAjZWxzZQogICAgIGlmIChnZXRlbnYoIldFQktJVF9GT1JDRV9DT01QT1NJVElOR19NT0RF IikpCiAgICAgICAgIHNldEZvcmNlQ29tcG9zaXRpbmdNb2RlKHRydWUpOworICAgIGlmIChnZXRl bnYoIldFQktJVF9ESVNBQkxFX0NPTVBPU0lUSU5HX01PREUiKSkKKyAgICAgICAgc2V0QWNjZWxl cmF0ZWRDb21wb3NpdGluZ0VuYWJsZWQoZmFsc2UpOwogI2VuZGlmCiB9CiAK