154134 2016-02-11 14:30:21 -0800 AnalysisResultsViewer never uses this._smallerIsBetter 2016-02-11 14:52:39 -0800 1 1 1 Unclassified WebKit WebKit Website WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rniwa rniwa jond timothy oldest_to_newest 1163882 0 rniwa 2016-02-11 14:30:21 -0800 Remove this useless instance variable. 1163884 1 271090 rniwa 2016-02-11 14:32:33 -0800 Created attachment 271090 Cleanup 1163885 2 271090 cdumez 2016-02-11 14:33:27 -0800 Comment on attachment 271090 Cleanup r=me 1163896 3 rniwa 2016-02-11 14:52:39 -0800 Committed r196443: <http://trac.webkit.org/changeset/196443> 271090 2016-02-11 14:32:33 -0800 2016-02-11 14:33:27 -0800 Cleanup bug-154134-20160211143212.patch text/plain 3863 rniwa SW5kZXg6IFdlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g V2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL0NoYW5nZUxvZwkocmV2aXNpb24gMTk2NDQxKQorKysg V2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDIwIEBACisyMDE2LTAyLTExICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgor CisgICAgICAgIEFuYWx5c2lzUmVzdWx0c1ZpZXdlciBuZXZlciB1c2VzIHRoaXMuX3NtYWxsZXJJ c0JldHRlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTU0MTM0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg UmVtb3ZlZCB0aGUgdW51c2VkIGluc3RhbmNlIHZhcmlhYmxlIF9zbWFsbGVySXNCZXR0ZXIgZnJv bSBBbmFseXNpc1Jlc3VsdHNWaWV3ZXIgYW5kIFRlc3RHcm91cFN0YWNraW5nQmxvY2suCisKKyAg ICAgICAgKiBwdWJsaWMvdjMvY29tcG9uZW50cy9hbmFseXNpcy1yZXN1bHRzLXZpZXdlci5qczoK KyAgICAgICAgKEFuYWx5c2lzUmVzdWx0c1ZpZXdlcik6IFJlbW92ZWQgdGhlIHVudXNlZCBfc21h bGxlcklzQmV0dGVyLgorICAgICAgICAoQW5hbHlzaXNSZXN1bHRzVmlld2VyLnByb3RvdHlwZS5z ZXRTbWFsbGVySXNCZXR0ZXIpOiBEZWxldGVkLgorICAgICAgICAoQW5hbHlzaXNSZXN1bHRzVmll d2VyLnByb3RvdHlwZS5idWlsZFJvd0dyb3Vwcyk6CisgICAgICAgIChBbmFseXNpc1Jlc3VsdHNW aWV3ZXIuVGVzdEdyb3VwU3RhY2tpbmdCbG9jayk6IFJlbW92ZWQgdGhlIHVudXNlZCBfc21hbGxl cklzQmV0dGVyLgorICAgICAgICAqIHB1YmxpYy92My9wYWdlcy9hbmFseXNpcy10YXNrLXBhZ2Uu anM6CisgICAgICAgIChBbmFseXNpc1Rhc2tQYWdlLnByb3RvdHlwZS5fZGlkRmV0Y2hUYXNrKToK KwogMjAxNi0wMi0xMSAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9yZz4KIAogICAgICAg ICBCdWlsZCBmaXggYWZ0ZXIgcjE5NjQ0MC4KSW5kZXg6IFdlYnNpdGVzL3BlcmYud2Via2l0Lm9y Zy9wdWJsaWMvdjMvY29tcG9uZW50cy9hbmFseXNpcy1yZXN1bHRzLXZpZXdlci5qcwo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBXZWJzaXRlcy9wZXJmLndlYmtpdC5vcmcvcHVibGljL3YzL2NvbXBvbmVudHMvYW5h bHlzaXMtcmVzdWx0cy12aWV3ZXIuanMJKHJldmlzaW9uIDE5NjQ0MCkKKysrIFdlYnNpdGVzL3Bl cmYud2Via2l0Lm9yZy9wdWJsaWMvdjMvY29tcG9uZW50cy9hbmFseXNpcy1yZXN1bHRzLXZpZXdl ci5qcwkod29ya2luZyBjb3B5KQpAQCAtMyw3ICszLDYgQEAgY2xhc3MgQW5hbHlzaXNSZXN1bHRz Vmlld2VyIGV4dGVuZHMgUmVzdQogICAgIGNvbnN0cnVjdG9yKCkKICAgICB7CiAgICAgICAgIHN1 cGVyKCdhbmFseXNpcy1yZXN1bHRzLXZpZXdlcicpOwotICAgICAgICB0aGlzLl9zbWFsbGVySXNC ZXR0ZXIgPSBmYWxzZTsKICAgICAgICAgdGhpcy5fc3RhcnRQb2ludCA9IG51bGw7CiAgICAgICAg IHRoaXMuX2VuZFBvaW50ID0gbnVsbDsKICAgICAgICAgdGhpcy5fdGVzdEdyb3VwcyA9IG51bGw7 CkBAIC0xNiwxMiArMTUsNiBAQCBjbGFzcyBBbmFseXNpc1Jlc3VsdHNWaWV3ZXIgZXh0ZW5kcyBS ZXN1CiAKICAgICBzZXRUZXN0R3JvdXBDYWxsYmFjayhjYWxsYmFjaykgeyB0aGlzLl90ZXN0R3Jv dXBDYWxsYmFjayA9IGNhbGxiYWNrOyB9CiAKLSAgICBzZXRTbWFsbGVySXNCZXR0ZXIoc21hbGxl cklzQmV0dGVyKQotICAgIHsKLSAgICAgICAgdGhpcy5fc21hbGxlcklzQmV0dGVyID0gc21hbGxl cklzQmV0dGVyOwotICAgICAgICB0aGlzLl9zaG91bGRSZW5kZXJUYWJsZSA9IHRydWU7Ci0gICAg fQotCiAgICAgc2V0Q3VycmVudFRlc3RHcm91cCh0ZXN0R3JvdXApCiAgICAgewogICAgICAgICB0 aGlzLl9jdXJyZW50VGVzdEdyb3VwID0gdGVzdEdyb3VwOwpAQCAtMTA0LDcgKzk3LDcgQEAgY2xh c3MgQW5hbHlzaXNSZXN1bHRzVmlld2VyIGV4dGVuZHMgUmVzdQogICAgICAgICAgICAgICAgIHZh ciBibG9jayA9IHRlc3RHcm91cExheW91dE1hcC5nZXQodGVzdEdyb3VwKTsKICAgICAgICAgICAg ICAgICBpZiAoIWJsb2NrKSB7CiAgICAgICAgICAgICAgICAgICAgIGJsb2NrID0gbmV3IEFuYWx5 c2lzUmVzdWx0c1ZpZXdlci5UZXN0R3JvdXBTdGFja2luZ0Jsb2NrKAotICAgICAgICAgICAgICAg ICAgICAgICAgdGVzdEdyb3VwLCBzZWxmLl9zbWFsbGVySXNCZXR0ZXIsIHNlbGYuX2NsYXNzRm9y VGVzdEdyb3VwKHRlc3RHcm91cCksIHNlbGYuX29wZW5TdGFja2luZ0Jsb2NrLmJpbmQoc2VsZiwg dGVzdEdyb3VwKSk7CisgICAgICAgICAgICAgICAgICAgICAgICB0ZXN0R3JvdXAsIHNlbGYuX2Ns YXNzRm9yVGVzdEdyb3VwKHRlc3RHcm91cCksIHNlbGYuX29wZW5TdGFja2luZ0Jsb2NrLmJpbmQo c2VsZiwgdGVzdEdyb3VwKSk7CiAgICAgICAgICAgICAgICAgICAgIHRlc3RHcm91cExheW91dE1h cC5zZXQodGVzdEdyb3VwLCBibG9jayk7CiAgICAgICAgICAgICAgICAgfQogICAgICAgICAgICAg ICAgIGJsb2NrLmFkZFJvd0luZGV4KGVudHJ5LCByb3dJbmRleCk7CkBAIC0zMDgsMTAgKzMwMSw5 IEBAIEFuYWx5c2lzUmVzdWx0c1ZpZXdlci5Sb290U2V0SW5UZXN0R3JvdXAKIH0KIAogQW5hbHlz aXNSZXN1bHRzVmlld2VyLlRlc3RHcm91cFN0YWNraW5nQmxvY2sgPSBjbGFzcyB7Ci0gICAgY29u c3RydWN0b3IodGVzdEdyb3VwLCBzbWFsbGVySXNCZXR0ZXIsIGNsYXNzTmFtZSwgY2FsbGJhY2sp CisgICAgY29uc3RydWN0b3IodGVzdEdyb3VwLCBjbGFzc05hbWUsIGNhbGxiYWNrKQogICAgIHsK ICAgICAgICAgdGhpcy5fdGVzdEdyb3VwID0gdGVzdEdyb3VwOwotICAgICAgICB0aGlzLl9zbWFs bGVySXNCZXR0ZXIgPSBzbWFsbGVySXNCZXR0ZXI7CiAgICAgICAgIHRoaXMuX3Jvb3RTZXRJbmRl eFJvd0luZGV4TWFwID0gW107CiAgICAgICAgIHRoaXMuX2NsYXNzTmFtZSA9IGNsYXNzTmFtZTsK ICAgICAgICAgdGhpcy5fbGFiZWwgPSBudWxsOwpJbmRleDogV2Vic2l0ZXMvcGVyZi53ZWJraXQu b3JnL3B1YmxpYy92My9wYWdlcy9hbmFseXNpcy10YXNrLXBhZ2UuanMKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g V2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL3B1YmxpYy92My9wYWdlcy9hbmFseXNpcy10YXNrLXBh Z2UuanMJKHJldmlzaW9uIDE5NjQ0MCkKKysrIFdlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy9wdWJs aWMvdjMvcGFnZXMvYW5hbHlzaXMtdGFzay1wYWdlLmpzCSh3b3JraW5nIGNvcHkpCkBAIC02OCw3 ICs2OCw2IEBAIGNsYXNzIEFuYWx5c2lzVGFza1BhZ2UgZXh0ZW5kcyBQYWdlV2l0aEgKIAogICAg ICAgICB2YXIgZm9ybWF0dGVyID0gbWV0cmljLm1ha2VGb3JtYXR0ZXIoNCk7CiAgICAgICAgIHRo aXMuX2FuYWx5c2lzUmVzdWx0c1ZpZXdlci5zZXRWYWx1ZUZvcm1hdHRlcihmb3JtYXR0ZXIpOwot ICAgICAgICB0aGlzLl9hbmFseXNpc1Jlc3VsdHNWaWV3ZXIuc2V0U21hbGxlcklzQmV0dGVyKG1l dHJpYy5pc1NtYWxsZXJCZXR0ZXIoKSk7CiAgICAgICAgIHRoaXMuX3Rlc3RHcm91cFJlc3VsdHNU YWJsZS5zZXRWYWx1ZUZvcm1hdHRlcihmb3JtYXR0ZXIpOwogCiAgICAgICAgIHRoaXMuX2NoYXJ0 UGFuZS5jb25maWd1cmUocGxhdGZvcm0uaWQoKSwgbWV0cmljLmlkKCkpOwo=