154123 2016-02-11 12:46:47 -0800 The sampling profiler's stack walker methods should be marked with SUPPRESS_ASAN 2016-02-11 14:15:53 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 saam saam benjamin fpizlo ggaren gskachkov joepeck keith_miller mark.lam msaboff oliver sukolsak ysuzuki oldest_to_newest 1163820 0 saam 2016-02-11 12:46:47 -0800 The whole premise here is that we're walking another thread's stack, so ASan won't be happy about this. 1163821 1 271072 saam 2016-02-11 12:52:48 -0800 Created attachment 271072 patch 1163823 2 271072 mark.lam 2016-02-11 12:53:41 -0800 Comment on attachment 271072 patch r=me 1163830 3 saam 2016-02-11 13:05:00 -0800 landed in: http://trac.webkit.org/changeset/196432 1163872 4 joepeck 2016-02-11 14:15:53 -0800 <rdar://problem/24589661> 271072 2016-02-11 12:52:48 -0800 2016-02-11 12:53:41 -0800 patch a-backup.diff text/plain 1751 saam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTk2NDMwKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBA CisyMDE2LTAyLTExICBTYWFtIGJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAg IFRoZSBzYW1wbGluZyBwcm9maWxlcidzIHN0YWNrIHdhbGtlciBtZXRob2RzIHNob3VsZCBiZSBt YXJrZWQgd2l0aCBTVVBQUkVTU19BU0FOCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xNTQxMjMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBUaGUgZW50aXJlIHByZW1pc2Ugb2YgdGhlIHNhbXBsaW5nIHByb2Zp bGVyIGlzIHRvIGxvYWQgZnJvbQorICAgICAgICBhbm90aGVyIHRocmVhZCdzIG1lbW9yeS4gV2Ug c2hvdWxkIFNVUFBSRVNTX0FTQU4gb24gdGhlCisgICAgICAgIG1ldGhvZHMgdGhhdCBkbyB0aGlz LgorCisgICAgICAgICogcnVudGltZS9TYW1wbGluZ1Byb2ZpbGVyLmNwcDoKKyAgICAgICAgKEpT Qzo6RnJhbWVXYWxrZXI6OkZyYW1lV2Fsa2VyKToKKyAgICAgICAgKEpTQzo6RnJhbWVXYWxrZXI6 OndhbGspOgorICAgICAgICAoSlNDOjpGcmFtZVdhbGtlcjo6YWR2YW5jZVRvUGFyZW50RnJhbWUp OgorICAgICAgICAoSlNDOjpGcmFtZVdhbGtlcjo6aXNBdFRvcCk6CisgICAgICAgIChKU0M6OkZy YW1lV2Fsa2VyOjpyZXNldEF0TWFjaGluZUZyYW1lKToKKwogMjAxNi0wMi0xMSAgQ3NhYmEgT3N6 dHJvZ29uw6FjICA8b3NzeUB3ZWJraXQub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQgdHlwbyBm aXggYWZ0ZXIgcjE5MDA2My4KSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1Nh bXBsaW5nUHJvZmlsZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9y dW50aW1lL1NhbXBsaW5nUHJvZmlsZXIuY3BwCShyZXZpc2lvbiAxOTY0MzApCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvcnVudGltZS9TYW1wbGluZ1Byb2ZpbGVyLmNwcAkod29ya2luZyBjb3B5 KQpAQCAtODIsNiArODIsNyBAQCBwdWJsaWM6CiAgICAgewogICAgIH0KIAorICAgIFNVUFBSRVNT X0FTQU4KICAgICBzaXplX3Qgd2FsayhWZWN0b3I8VW5wcm9jZXNzZWRTdGFja0ZyYW1lPiYgc3Rh Y2tUcmFjZSwgYm9vbCYgZGlkUnVuT3V0T2ZTcGFjZSkKICAgICB7CiAgICAgICAgIGlmIChzUmVw b3J0U3RhdHMpCkBAIC0xMTMsNiArMTE0LDcgQEAgcHVibGljOgogCiBwcml2YXRlOgogCisgICAg U1VQUFJFU1NfQVNBTgogICAgIHZvaWQgYWR2YW5jZVRvUGFyZW50RnJhbWUoKQogICAgIHsKICAg ICAgICAgbV9jYWxsRnJhbWUgPSBtX2NhbGxGcmFtZS0+Y2FsbGVyRnJhbWUobV92bUVudHJ5RnJh bWUpOwpAQCAtMTIzLDYgKzEyNSw3IEBAIHByaXZhdGU6CiAgICAgICAgIHJldHVybiAhbV9jYWxs RnJhbWU7CiAgICAgfQogCisgICAgU1VQUFJFU1NfQVNBTgogICAgIHZvaWQgcmVzZXRBdE1hY2hp bmVGcmFtZSgpCiAgICAgewogICAgICAgICBpZiAoaXNBdFRvcCgpKQo=