154118 2016-02-11 11:18:40 -0800 WebContent process crashes when performing data detection on content with existing data detector links 2016-02-22 15:12:30 -0800 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 enrica enrica andersca thorton oldest_to_newest 1163799 0 enrica 2016-02-11 11:18:40 -0800 Loading content that has existing data detector links causes the WebProcess to crash. The DOM mutation caused by removing the existing links, can shift the range endpoints. rdar://problem/24511860 1163800 1 271069 enrica 2016-02-11 11:24:06 -0800 Created attachment 271069 Patch 1163863 2 271069 thorton 2016-02-11 14:09:13 -0800 Comment on attachment 271069 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=271069&action=review > Source/WebCore/ChangeLog:8 > + Where's the test! > Source/WebCore/editing/cocoa/DataDetection.mm:529 > + // Store the range boundaries as Position, in case the DOM changes if we find > + // old data detector link. This comment has slightly weird grammar towards the end. 1163902 3 enrica 2016-02-11 15:04:21 -0800 Committed revision 196445. 271069 2016-02-11 11:24:06 -0800 2016-02-11 14:09:13 -0800 Patch ddcrash.txt text/plain 3883 enrica SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE5NjQyNCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDE2LTAyLTExICBFbnJpY2Eg Q2FzdWNjaSAgPGVucmljYUBhcHBsZS5jb20+CisKKyAgICAgICAgV2ViQ29udGVudCBwcm9jZXNz IGNyYXNoZXMgd2hlbiBwZXJmb3JtaW5nIGRhdGEgZGV0ZWN0aW9uIG9uIGNvbnRlbnQgd2l0aCBl eGlzdGluZyBkYXRhIGRldGVjdG9yIGxpbmtzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU0MTE4CisgICAgICAgIHJkYXI6Ly9wcm9ibGVtLzI0NTEx ODYwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhl IERPTSBtdXRhdGlvbiBjYXVzZWQgYnkgcmVtb3ZpbmcgdGhlIGV4aXN0aW5nIGxpbmtzLCBjYW4g c2hpZnQgdGhlIHJhbmdlIGVuZHBvaW50cy4KKyAgICAgICAgV2Ugbm93IHNhdmUgdGhlIHJhbmdl IGVucG9pbnRzIGFzIHBvc2l0aW9ucyBzbyB0aGF0IHdlIGNhbiByZWNyZWF0ZSB0aGUgcmFuZ2Vz LAorICAgICAgICBpZiBhIERPTSBtdXRhdGlvbiBvY2N1cnJlZC4KKworICAgICAgICAqIGVkaXRp bmcvY29jb2EvRGF0YURldGVjdGlvbi5tbToKKyAgICAgICAgKFdlYkNvcmU6OnJlbW92ZVJlc3Vs dExpbmtzRnJvbUFuY2hvcik6CisgICAgICAgIChXZWJDb3JlOjpzZWFyY2hGb3JMaW5rUmVtb3Zp bmdFeGlzdGluZ0RETGlua3MpOgorICAgICAgICAoV2ViQ29yZTo6RGF0YURldGVjdGlvbjo6ZGV0 ZWN0Q29udGVudEluUmFuZ2UpOgorCiAyMDE2LTAyLTExICBDaHJpcyBEdW1leiAgPGNkdW1lekBh cHBsZS5jb20+CiAKICAgICAgICAgTW92ZSAnbGVuZ3RoJyBwcm9wZXJ0eSB0byB0aGUgcHJvdG90 eXBlCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9lZGl0aW5nL2NvY29hL0RhdGFEZXRlY3Rpb24ubW0K PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvZWRpdGluZy9jb2NvYS9EYXRhRGV0ZWN0aW9u Lm1tCShyZXZpc2lvbiAxOTYwNzkpCisrKyBTb3VyY2UvV2ViQ29yZS9lZGl0aW5nL2NvY29hL0Rh dGFEZXRlY3Rpb24ubW0JKHdvcmtpbmcgY29weSkKQEAgLTI0MCwxNCArMjQwLDE2IEBAIHN0YXRp YyB2b2lkIHJlbW92ZVJlc3VsdExpbmtzRnJvbUFuY2hvcigKICAgICB9CiB9CiAKLXN0YXRpYyBi b29sIHNlYXJjaEZvckxpbmtSZW1vdmluZ0V4aXN0aW5nRERMaW5rcyhOb2RlKiBzdGFydE5vZGUs IE5vZGUqIGVuZE5vZGUpCitzdGF0aWMgYm9vbCBzZWFyY2hGb3JMaW5rUmVtb3ZpbmdFeGlzdGlu Z0RETGlua3MoTm9kZSogc3RhcnROb2RlLCBOb2RlKiBlbmROb2RlLCBib29sICZkaWRNb2RpZnlE T00pCiB7CisgICAgZGlkTW9kaWZ5RE9NID0gZmFsc2U7CiAgICAgTm9kZSAqbm9kZSA9IHN0YXJ0 Tm9kZTsKICAgICB3aGlsZSAobm9kZSkgewogICAgICAgICBpZiAoaXM8SFRNTEFuY2hvckVsZW1l bnQ+KCpub2RlKSkgewogICAgICAgICAgICAgaWYgKGRvd25jYXN0PEVsZW1lbnQ+KCpub2RlKS5n ZXRBdHRyaWJ1dGUoZGF0YURldGVjdG9yc1VSTFNjaGVtZSkgIT0gInRydWUiKQogICAgICAgICAg ICAgICAgIHJldHVybiB0cnVlOwogICAgICAgICAgICAgcmVtb3ZlUmVzdWx0TGlua3NGcm9tQW5j aG9yKG5vZGUsIG5vZGUtPnBhcmVudEVsZW1lbnQoKSk7CisgICAgICAgICAgICBkaWRNb2RpZnlE T00gPSB0cnVlOwogICAgICAgICB9CiAgICAgICAgIAogICAgICAgICBpZiAobm9kZSA9PSBlbmRO b2RlKSB7CkBAIC0yNTksNiArMjYxLDcgQEAgc3RhdGljIGJvb2wgc2VhcmNoRm9yTGlua1JlbW92 aW5nRXhpc3RpbgogICAgICAgICAgICAgICAgICAgICBpZiAoZG93bmNhc3Q8RWxlbWVudD4oKm5v ZGUpLmdldEF0dHJpYnV0ZShkYXRhRGV0ZWN0b3JzVVJMU2NoZW1lKSAhPSAidHJ1ZSIpCiAgICAg ICAgICAgICAgICAgICAgICAgICByZXR1cm4gdHJ1ZTsKICAgICAgICAgICAgICAgICAgICAgcmVt b3ZlUmVzdWx0TGlua3NGcm9tQW5jaG9yKG5vZGUsIG5vZGUtPnBhcmVudEVsZW1lbnQoKSk7Cisg ICAgICAgICAgICAgICAgICAgIGRpZE1vZGlmeURPTSA9IHRydWU7CiAgICAgICAgICAgICAgICAg fQogICAgICAgICAgICAgICAgIG5vZGUgPSBub2RlLT5wYXJlbnROb2RlKCk7CiAgICAgICAgICAg ICB9CkBAIC01MjAsMTAgKzUyMywyNSBAQCBOU0FycmF5ICpEYXRhRGV0ZWN0aW9uOjpkZXRlY3RD b250ZW50SW5SCiAKICAgICAgICAgTlNTdHJpbmcgKmlkZW50aWZpZXIgPSBkYXRhRGV0ZWN0b3JT dHJpbmdGb3JQYXRoKGluZGV4UGF0aHNbcmVzdWx0SW5kZXhdLmdldCgpKTsKICAgICAgICAgTlNT dHJpbmcgKmNvcnJlc3BvbmRpbmdVUkwgPSBjb25zdHJ1Y3RVUkxTdHJpbmdGb3JSZXN1bHQoY29y ZVJlc3VsdCwgaWRlbnRpZmllciwgcmVmZXJlbmNlRGF0ZSwgKE5TVGltZVpvbmUgKil0eiwgdHlw ZXMpOworICAgICAgICBib29sIGRpZE1vZGlmeURPTSA9IGZhbHNlOwogICAgICAgICAKLSAgICAg ICAgaWYgKCFjb3JyZXNwb25kaW5nVVJMIHx8IHNlYXJjaEZvckxpbmtSZW1vdmluZ0V4aXN0aW5n RERMaW5rcygmcmVzdWx0UmFuZ2VzLmZpcnN0KCktPnN0YXJ0Q29udGFpbmVyKCksICZyZXN1bHRS YW5nZXMubGFzdCgpLT5lbmRDb250YWluZXIoKSkpCisgICAgICAgIC8vIFN0b3JlIHRoZSByYW5n ZSBib3VuZGFyaWVzIGFzIFBvc2l0aW9uLCBpbiBjYXNlIHRoZSBET00gY2hhbmdlcyBpZiB3ZSBm aW5kCisgICAgICAgIC8vIG9sZCBkYXRhIGRldGVjdG9yIGxpbmsuCisgICAgICAgIFZlY3Rvcjxz dGQ6OnBhaXI8UG9zaXRpb24sIFBvc2l0aW9uPj4gcmFuZ2VCb3VuZGFyaWVzOworICAgICAgICBm b3IgKGF1dG8mIHJhbmdlIDogcmVzdWx0UmFuZ2VzKQorICAgICAgICAgICAgcmFuZ2VCb3VuZGFy aWVzLmFwcGVuZChzdGQ6Om1ha2VfcGFpcihyYW5nZS0+c3RhcnRQb3NpdGlvbigpLCByYW5nZS0+ ZW5kUG9zaXRpb24oKSkpOworCisgICAgICAgIGlmICghY29ycmVzcG9uZGluZ1VSTCB8fCBzZWFy Y2hGb3JMaW5rUmVtb3ZpbmdFeGlzdGluZ0RETGlua3MoJnJlc3VsdFJhbmdlcy5maXJzdCgpLT5z dGFydENvbnRhaW5lcigpLCAmcmVzdWx0UmFuZ2VzLmxhc3QoKS0+ZW5kQ29udGFpbmVyKCksIGRp ZE1vZGlmeURPTSkpCiAgICAgICAgICAgICBjb250aW51ZTsKICAgICAgICAgCisgICAgICAgIGlm IChkaWRNb2RpZnlET00pIHsKKyAgICAgICAgICAgIC8vIElmIHRoZSBET00gd2FzIG1vZGlmaWVk IGJlY2F1c2Ugc29tZSBvbGQgbGlua3Mgd2VyZSByZW1vdmVkLAorICAgICAgICAgICAgLy8gd2Ug bmVlZCB0byByZWNyZWF0ZSB0aGUgcmFuZ2VzIGJlY2F1c2UgdGhleSBjb3VsZCBubyBsb25nZXIg YmUgdmFsaWQuCisgICAgICAgICAgICByZXN1bHRSYW5nZXMuY2xlYXIoKTsKKyAgICAgICAgICAg IGZvciAoYXV0byYgcmFuZ2VCb3VuZGFyeSA6IHJhbmdlQm91bmRhcmllcykKKyAgICAgICAgICAg ICAgICByZXN1bHRSYW5nZXMuYXBwZW5kKFJhbmdlOjpjcmVhdGUoKnJhbmdlQm91bmRhcnkuZmly c3QuZG9jdW1lbnQoKSwgcmFuZ2VCb3VuZGFyeS5maXJzdCwgcmFuZ2VCb3VuZGFyeS5zZWNvbmQp KTsKKyAgICAgICAgfQorICAgICAgICAKICAgICAgICAgbGFzdE1vZGlmaWVkUXVlcnlPZmZzZXQg PSBxdWVyeVJhbmdlLmVuZDsKIAogICAgICAgICBmb3IgKGF1dG8mIHJhbmdlIDogcmVzdWx0UmFu Z2VzKSB7Cg==