154103 2016-02-11 02:34:09 -0800 [GTK] Build error after bug 154046 2016-02-11 06:30:58 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 154046 1 fred.wang fred.wang berto bugs-noreply cgarcia commit-queue gustavo mcatanzaro mrobinson oldest_to_newest 1163725 0 fred.wang 2016-02-11 02:34:09 -0800 ../../Source/WebKit2/UIProcess/API/gtk/WebKitUserContentManager.cpp ../../Source/WebKit2/UIProcess/API/gtk/WebKitUserContentManager.cpp: In function ‘void webkit_user_content_manager_add_style_sheet(WebKitUserContentManager*, WebKitUserStyleSheet*)’: ../../Source/WebKit2/UIProcess/API/gtk/WebKitUserContentManager.cpp:130:110: error: no matching function for call to ‘WebKit::WebUserContentControllerProxy::addUserStyleSheet(const WebCore::UserStyleSheet&)’ manager->priv->userContentController->addUserStyleSheet(webkitUserStyleSheetGetUserStyleSheet(styleSheet)); ^ ../../Source/WebKit2/UIProcess/API/gtk/WebKitUserContentManager.cpp:130:110: note: candidate is: In file included from ../../Source/WebKit2/UIProcess/API/gtk/WebKitUserContentManagerPrivate.h:24:0, from ../../Source/WebKit2/UIProcess/API/gtk/WebKitUserContentManager.cpp:26: ../../Source/WebKit2/UIProcess/UserContent/WebUserContentControllerProxy.h:80:10: note: void WebKit::WebUserContentControllerProxy::addUserStyleSheet(API::UserStyleSheet&) void addUserStyleSheet(API::UserStyleSheet&); ^ ../../Source/WebKit2/UIProcess/UserContent/WebUserContentControllerProxy.h:80:10: note: no known conversion for argument 1 from ‘const WebCore::UserStyleSheet’ to ‘API::UserStyleSheet&’ ninja: build stopped: subcommand failed. 1163726 1 271054 fred.wang 2016-02-11 02:36:52 -0800 Created attachment 271054 Patch 1163727 2 commit-queue 2016-02-11 02:38:32 -0800 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 1163742 3 271054 commit-queue 2016-02-11 06:30:55 -0800 Comment on attachment 271054 Patch Clearing flags on attachment: 271054 Committed r196420: <http://trac.webkit.org/changeset/196420> 1163743 4 commit-queue 2016-02-11 06:30:58 -0800 All reviewed patches have been landed. Closing bug. 271054 2016-02-11 02:36:52 -0800 2016-02-11 06:30:55 -0800 Patch bug-154103-20160211113630.patch text/plain 3339 fred.wang U3VidmVyc2lvbiBSZXZpc2lvbjogMTk2NDE2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggODg0MjY4ZDcxODAyOTAx YjcwMTg3OTkxNjZjNzg2YWRjZWI3ZmFiMC4uOTkwZDFlNzEwNDIwMjM1M2JiZDNjMjAxOTUzODkx NjhjOTNhMDQ2MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE2LTAyLTExICBGcmVk ZXJpYyBXYW5nICA8ZnJlZC53YW5nQGZyZWUuZnI+CisKKyAgICAgICAgQnVnIDE1NDEwMyAtIFtH VEtdIEJ1aWxkIGVycm9yIGFmdGVyIGJ1ZyAxNTQwNDYKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1NDEwMworCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0VXNlckNv bnRlbnQuY3BwOgorICAgICAgICAoX1dlYktpdFVzZXJTdHlsZVNoZWV0OjpfV2ViS2l0VXNlclN0 eWxlU2hlZXQpOgorICAgICAgICAod2Via2l0VXNlclN0eWxlU2hlZXRHZXRVc2VyU3R5bGVTaGVl dCk6CisgICAgICAgICogVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0VXNlckNvbnRlbnRQcml2YXRl Lmg6CisKIDIwMTYtMDItMTAgIEppZXdlbiBUYW4gIDxqaWV3ZW5fdGFuQGFwcGxlLmNvbT4KIAog ICAgICAgICBSZW5hbWUgKkV2ZW50OjpjcmVhdGUqIHdoaWNoIGNyZWF0ZXMgZXZlbnRzIGZvciBi aW5kaW5ncyB0byAqRXZlbnQ6OmNyZWF0ZUZvckJpbmRpbmdzKiBhbmQgY2xlYW51cCBjb3JyZXNw b25kaW5nIHBhdGhzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0 ay9XZWJLaXRVc2VyQ29udGVudC5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0 ay9XZWJLaXRVc2VyQ29udGVudC5jcHAKaW5kZXggYjgxZWUyNjY2ZTJmZWY3ZjM0OWQ5OGI2NGJk MDBiYTk4M2Y0ZWE2NS4uNzgzNGMyMTUyMDU5MjlmNWUzMGM0NWZmYTFlMzAxZmM3YmUzMzVlYSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0VXNlckNv bnRlbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFVz ZXJDb250ZW50LmNwcApAQCAtODksMTYgKzg5LDE2IEBAIHN0YXRpYyBpbmxpbmUgVmVjdG9yPFN0 cmluZz4gdG9TdHJpbmdWZWN0b3IoY29uc3QgY2hhciogY29uc3QqIHN0cnYpCiAKIHN0cnVjdCBf V2ViS2l0VXNlclN0eWxlU2hlZXQgewogICAgIF9XZWJLaXRVc2VyU3R5bGVTaGVldChjb25zdCBn Y2hhciogc291cmNlLCBXZWJLaXRVc2VyQ29udGVudEluamVjdGVkRnJhbWVzIGluamVjdGVkRnJh bWVzLCBXZWJLaXRVc2VyU3R5bGVMZXZlbCBsZXZlbCwgY29uc3QgY2hhciogY29uc3QqIHdoaXRl bGlzdCwgY29uc3QgY2hhciogY29uc3QqIGJsYWNrbGlzdCkKLSAgICAgICAgOiB1c2VyU3R5bGVT aGVldChzdGQ6Om1ha2VfdW5pcXVlPFVzZXJTdHlsZVNoZWV0PigKKyAgICAgICAgOiB1c2VyU3R5 bGVTaGVldChhZG9wdFJlZihuZXcgQVBJOjpVc2VyU3R5bGVTaGVldChVc2VyU3R5bGVTaGVldCB7 CiAgICAgICAgICAgICBTdHJpbmc6OmZyb21VVEY4KHNvdXJjZSksIFVSTCB7IH0sCiAgICAgICAg ICAgICB0b1N0cmluZ1ZlY3Rvcih3aGl0ZWxpc3QpLCB0b1N0cmluZ1ZlY3RvcihibGFja2xpc3Qp LAogICAgICAgICAgICAgdG9Vc2VyQ29udGVudEluamVjdGVkRnJhbWVzKGluamVjdGVkRnJhbWVz KSwKLSAgICAgICAgICAgIHRvVXNlclN0eWxlTGV2ZWwobGV2ZWwpKSkKKyAgICAgICAgICAgIHRv VXNlclN0eWxlTGV2ZWwobGV2ZWwpIH0pKSkKICAgICAgICAgLCByZWZlcmVuY2VDb3VudCgxKQog ICAgIHsKICAgICB9CiAKLSAgICBzdGQ6OnVuaXF1ZV9wdHI8VXNlclN0eWxlU2hlZXQ+IHVzZXJT dHlsZVNoZWV0OworICAgIFJlZlB0cjxBUEk6OlVzZXJTdHlsZVNoZWV0PiB1c2VyU3R5bGVTaGVl dDsKICAgICBpbnQgcmVmZXJlbmNlQ291bnQ7CiB9OwogCkBAIC0xNjgsNyArMTY4LDcgQEAgV2Vi S2l0VXNlclN0eWxlU2hlZXQqIHdlYmtpdF91c2VyX3N0eWxlX3NoZWV0X25ldyhjb25zdCBnY2hh ciogc291cmNlLCBXZWJLaXRVc2UKICAgICByZXR1cm4gdXNlclN0eWxlU2hlZXQ7CiB9CiAKLWNv bnN0IFVzZXJTdHlsZVNoZWV0JiB3ZWJraXRVc2VyU3R5bGVTaGVldEdldFVzZXJTdHlsZVNoZWV0 KFdlYktpdFVzZXJTdHlsZVNoZWV0KiB1c2VyU3R5bGVTaGVldCkKK0FQSTo6VXNlclN0eWxlU2hl ZXQmIHdlYmtpdFVzZXJTdHlsZVNoZWV0R2V0VXNlclN0eWxlU2hlZXQoV2ViS2l0VXNlclN0eWxl U2hlZXQqIHVzZXJTdHlsZVNoZWV0KQogewogICAgIHJldHVybiAqdXNlclN0eWxlU2hlZXQtPnVz ZXJTdHlsZVNoZWV0OwogfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQ SS9ndGsvV2ViS2l0VXNlckNvbnRlbnRQcml2YXRlLmggYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvQVBJL2d0ay9XZWJLaXRVc2VyQ29udGVudFByaXZhdGUuaAppbmRleCBlNmEyOTU5NDhmMzUw MTEwNTVlODdmYTJlMzc2MzBkMGVlYWQxZWNiLi40NDRlMmNhYWE3MjYyY2U2ZmMzMTYwYWYyOWJl ZGFjNDJlMjZiN2QwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0 ay9XZWJLaXRVc2VyQ29udGVudFByaXZhdGUuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvQVBJL2d0ay9XZWJLaXRVc2VyQ29udGVudFByaXZhdGUuaApAQCAtMjEsMTEgKzIxLDEyIEBA CiAjZGVmaW5lIFdlYktpdFVzZXJDb250ZW50UHJpdmF0ZV9oCiAKICNpbmNsdWRlICJBUElVc2Vy U2NyaXB0LmgiCisjaW5jbHVkZSAiQVBJVXNlclN0eWxlU2hlZXQuaCIKICNpbmNsdWRlICJXZWJL aXRVc2VyQ29udGVudC5oIgogI2luY2x1ZGUgPFdlYkNvcmUvVXNlclNjcmlwdC5oPgogI2luY2x1 ZGUgPFdlYkNvcmUvVXNlclN0eWxlU2hlZXQuaD4KIAogQVBJOjpVc2VyU2NyaXB0JiB3ZWJraXRV c2VyU2NyaXB0R2V0VXNlclNjcmlwdChXZWJLaXRVc2VyU2NyaXB0Kik7Ci1jb25zdCBXZWJDb3Jl OjpVc2VyU3R5bGVTaGVldCYgd2Via2l0VXNlclN0eWxlU2hlZXRHZXRVc2VyU3R5bGVTaGVldChX ZWJLaXRVc2VyU3R5bGVTaGVldCopOworQVBJOjpVc2VyU3R5bGVTaGVldCYgd2Via2l0VXNlclN0 eWxlU2hlZXRHZXRVc2VyU3R5bGVTaGVldChXZWJLaXRVc2VyU3R5bGVTaGVldCopOwogCiAjZW5k aWYgLy8gV2ViS2l0VXNlckNvbnRlbnRQcml2YXRlX2gK