154100 2016-02-10 21:38:24 -0800 [ThreadedCompositor] position:fixed elements do not have their own layers when threaded compositor is enabled. 2016-02-15 21:40:02 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 154066 1 changseok changseok bugs-noreply cgarcia commit-queue gustavo ryuan.choi yoon oldest_to_newest 1163693 0 271043 changseok 2016-02-10 21:38:24 -0800 Created attachment 271043 a test case SSIA. Run the attached test case on threaded compositor enabled webkit build. 1164061 1 271150 changseok 2016-02-12 01:22:48 -0800 Created attachment 271150 Patch 1164064 2 271150 yoon 2016-02-12 01:44:44 -0800 Comment on attachment 271150 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=271150&action=review Nice patch, thanks! Some nitpiks in the changelog.. > Source/WebKit2/ChangeLog:9 > + embeded environment. Probably main concern was increasing video memory for fixed elements. s/embeded/embedded/, I'm not sure whether is it correct reason or not. As we talked in IRC, it is because the fixed element is not considered to be a new stacking context at first. This feature was added later because of the scrolling performance in the embedded system. > Source/WebKit2/ChangeLog:10 > + However, it is time to rethink spliting the elements out to separate layers. Currently the fixed spliting/splitting and how about adding a comma after "Currently" ? > Source/WebKit2/ChangeLog:11 > + elements are redrawn to a backing store every time layout or scroll happens. It results in bad Also maybe you missed "the" before bad effect 1164070 3 271150 changseok 2016-02-12 01:58:35 -0800 Comment on attachment 271150 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=271150&action=review Thanks for your review! >> Source/WebKit2/ChangeLog:9 >> + embeded environment. Probably main concern was increasing video memory for fixed elements. > > s/embeded/embedded/, > I'm not sure whether is it correct reason or not. As we talked in IRC, it is because the fixed element is not considered to be a new stacking context at first. This feature was added later because of the scrolling performance in the embedded system. I see. Then Let's get rid of the whole lines. >> Source/WebKit2/ChangeLog:10 >> + However, it is time to rethink spliting the elements out to separate layers. Currently the fixed > > spliting/splitting > and how about adding a comma after "Currently" ? Yep. >> Source/WebKit2/ChangeLog:11 >> + elements are redrawn to a backing store every time layout or scroll happens. It results in bad > > Also maybe you missed "the" before bad effect Done. 1164072 4 271154 changseok 2016-02-12 02:00:25 -0800 Created attachment 271154 Patch 1164692 5 changseok 2016-02-15 01:16:05 -0800 Any concern? 1164693 6 yoon 2016-02-15 01:20:20 -0800 I'm okay with this patch. Maybe cgarcia can help you. :) 1165029 7 271154 changseok 2016-02-15 20:49:48 -0800 Comment on attachment 271154 Patch Thanks. 1165046 8 271154 commit-queue 2016-02-15 21:39:56 -0800 Comment on attachment 271154 Patch Clearing flags on attachment: 271154 Committed r196623: <http://trac.webkit.org/changeset/196623> 1165047 9 commit-queue 2016-02-15 21:40:02 -0800 All reviewed patches have been landed. Closing bug. 271043 2016-02-10 21:38:24 -0800 2016-02-10 21:38:24 -0800 a test case scroll.html text/html 237 changseok PCFET0NUWVBFIGh0bWw+CjxkaXYgc3R5bGU9IndpZHRoOjEwMHB4O2hlaWdodDoxMDAwMHB4O2Jh Y2tncm91bmQtY29sb3I6eWVsbG93O3Bvc2l0aW9uOmFic29sdXRlO2Rpc3BsYXk6YmxvY2s7Ij5U ZXN0PC9kaXY+CjxkaXYgc3R5bGU9ImxlZnQ6MTA4cHg7d2lkdGg6MTAwcHg7aGVpZ2h0OjEwMHB4 O2JhY2tncm91bmQtY29sb3I6Ymx1ZTtwb3NpdGlvbjpmaXhlZDtkaXNwbGF5OmJsb2NrOyI+Rml4 ZWQ8L2Rpdj4K 271150 2016-02-12 01:22:48 -0800 2016-02-12 02:00:19 -0800 Patch bug-154100-20160212182226.patch text/plain 2573 changseok U3VidmVyc2lvbiBSZXZpc2lvbjogMTk2MzY0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNzYxNGY4ODljZmMwNTNh Zjk3OWUxZjE2MDA2NTIwZjY4YWM1YTUwZi4uMjMzOGI2MGQyYWMxOGYwZWRiYzkwNWQ0NmUxZjY3 ZjJiMWQ4NTVjOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE2LTAyLTEyICBDaGFu Z1Nlb2sgT2ggIDxjaGFuZ3Nlb2sub2hAY29sbGFib3JhLmNvbT4KKworICAgICAgICBbVGhyZWFk ZWRDb21wb3NpdG9yXSBwb3NpdGlvbjpmaXhlZCBlbGVtZW50cyBkbyBub3QgaGF2ZSB0aGVpciBv d24gbGF5ZXJzIHdoZW4gdGhyZWFkZWQgY29tcG9zaXRvciBpcyBlbmFibGVkLgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU0MTAwCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQXMgSSBoZWFyZCwgZ3RrIHBv cnQgaGFzIG5vdCBsYXllcmVkIG91dCBmaXhlZCBlbGVtZW50cyBkdWUgdG8gYSBoaXN0b3JpY2Fs IHJlYXNvbiBvZiBzdXBwb3J0aW5nCisgICAgICAgIGVtYmVkZWQgZW52aXJvbm1lbnQuIFByb2Jh Ymx5IG1haW4gY29uY2VybiB3YXMgaW5jcmVhc2luZyB2aWRlbyBtZW1vcnkgZm9yIGZpeGVkIGVs ZW1lbnRzLgorICAgICAgICBIb3dldmVyLCBpdCBpcyB0aW1lIHRvIHJldGhpbmsgc3BsaXRpbmcg dGhlIGVsZW1lbnRzIG91dCB0byBzZXBhcmF0ZSBsYXllcnMuIEN1cnJlbnRseSB0aGUgZml4ZWQK KyAgICAgICAgZWxlbWVudHMgYXJlIHJlZHJhd24gdG8gYSBiYWNraW5nIHN0b3JlIGV2ZXJ5IHRp bWUgbGF5b3V0IG9yIHNjcm9sbCBoYXBwZW5zLiBJdCByZXN1bHRzIGluIGJhZAorICAgICAgICBl ZmZlY3Qgb24gcGVyZm9ybWFuY2Utd2lzZS4gTGV0dGluZyBmaXhlZCBlbGVtZW50IGhhdmUgc2Vw YXJhdGUgbGF5ZXJzIGlzIG5lY2Vzc2FyeSB3aGVuIHRocmVhZGVkCisgICAgICAgIGNvbXBvc2l0 b3IgaXMgZW5hYmxlZCBhdCBsZWFzdC4gQmVjYXVzZSBhc3luYyBzY3JvbGxpbmcgcmVxdWlyZXMg aXQuCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYlBhZ2UvRHJhd2luZ0FyZWFJbXBsLmNwcDoK KyAgICAgICAgKFdlYktpdDo6RHJhd2luZ0FyZWFJbXBsOjp1cGRhdGVQcmVmZXJlbmNlcyk6CisK IDIwMTYtMDItMDkgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgog CiAgICAgICAgIFJFR1JFU1NJT04ocjE5NjE4Myk6IFtHVEtdIEJyb2tlIFRlc3RJbnNwZWN0b3IK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9EcmF3aW5nQXJl YUltcGwuY3BwIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL0RyYXdpbmdBcmVh SW1wbC5jcHAKaW5kZXggMDkzYTUwMjFiOWQ2MGM2N2QxOWNiNGJmYTVjZjhhMWU2Y2UxMDcyOC4u NWU1ODU3YjVkOGYyMTNlZTY3ZGUwZTc1MzM0MWQ3NTZhY2RmNjU3MSAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL0RyYXdpbmdBcmVhSW1wbC5jcHAKKysrIGIv U291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL0RyYXdpbmdBcmVhSW1wbC5jcHAKQEAg LTI0OCw3ICsyNDgsMTUgQEAgdm9pZCBEcmF3aW5nQXJlYUltcGw6Om1haW5GcmFtZUNvbnRlbnRT aXplQ2hhbmdlZChjb25zdCBXZWJDb3JlOjpJbnRTaXplJiBuZXdTaXoKIAogdm9pZCBEcmF3aW5n QXJlYUltcGw6OnVwZGF0ZVByZWZlcmVuY2VzKGNvbnN0IFdlYlByZWZlcmVuY2VzU3RvcmUmIHN0 b3JlKQogewotICAgIG1fd2ViUGFnZS5jb3JlUGFnZSgpLT5zZXR0aW5ncygpLnNldEZvcmNlQ29t cG9zaXRpbmdNb2RlKHN0b3JlLmdldEJvb2xWYWx1ZUZvcktleShXZWJQcmVmZXJlbmNlc0tleTo6 Zm9yY2VDb21wb3NpdGluZ01vZGVLZXkoKSkpOworICAgIFNldHRpbmdzJiBzZXR0aW5ncyA9IG1f d2ViUGFnZS5jb3JlUGFnZSgpLT5zZXR0aW5ncygpOworICAgIHNldHRpbmdzLnNldEZvcmNlQ29t cG9zaXRpbmdNb2RlKHN0b3JlLmdldEJvb2xWYWx1ZUZvcktleShXZWJQcmVmZXJlbmNlc0tleTo6 Zm9yY2VDb21wb3NpdGluZ01vZGVLZXkoKSkpOworCisjaWYgVVNFKENPT1JESU5BVEVEX0dSQVBI SUNTX1RIUkVBREVEKQorICAgIC8vIEZpeGVkIHBvc2l0aW9uIGVsZW1lbnRzIG5lZWQgdG8gYmUg Y29tcG9zaXRlZCBhbmQgY3JlYXRlIHN0YWNraW5nIGNvbnRleHRzCisgICAgLy8gaW4gb3JkZXIg dG8gYmUgc2Nyb2xsZWQgYnkgdGhlIFNjcm9sbGluZ0Nvb3JkaW5hdG9yLgorICAgIHNldHRpbmdz LnNldEFjY2VsZXJhdGVkQ29tcG9zaXRpbmdGb3JGaXhlZFBvc2l0aW9uRW5hYmxlZCh0cnVlKTsK KyAgICBzZXR0aW5ncy5zZXRGaXhlZFBvc2l0aW9uQ3JlYXRlc1N0YWNraW5nQ29udGV4dCh0cnVl KTsKKyNlbmRpZgogfQogCiB2b2lkIERyYXdpbmdBcmVhSW1wbDo6bGF5ZXJIb3N0RGlkRmx1c2hM YXllcnMoKQo= 271154 2016-02-12 02:00:25 -0800 2016-02-15 21:39:56 -0800 Patch bug-154100-20160212190003.patch text/plain 2282 changseok U3VidmVyc2lvbiBSZXZpc2lvbjogMTk2MzY0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNzYxNGY4ODljZmMwNTNh Zjk3OWUxZjE2MDA2NTIwZjY4YWM1YTUwZi4uMDQxNWIyYTA2MDkwMzJjZDBmNTcwZWI5MzE2NWQw ZmY5OGI1MDU4OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE2LTAyLTEyICBDaGFu Z1Nlb2sgT2ggIDxjaGFuZ3Nlb2sub2hAY29sbGFib3JhLmNvbT4KKworICAgICAgICBbVGhyZWFk ZWRDb21wb3NpdG9yXSBwb3NpdGlvbjpmaXhlZCBlbGVtZW50cyBkbyBub3QgaGF2ZSB0aGVpciBv d24gbGF5ZXJzIHdoZW4gdGhyZWFkZWQgY29tcG9zaXRvciBpcyBlbmFibGVkLgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU0MTAwCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ3VycmVudGx5LCBmaXhlZCBl bGVtZW50cyBhcmUgcmVkcmF3biB0byBhIGJhY2tpbmcgc3RvcmUgZXZlcnkgdGltZSBsYXlvdXQg b3Igc2Nyb2xsIGhhcHBlbnMuCisgICAgICAgIEl0IHJlc3VsdHMgaW4gdGhlIGJhZCBlZmZlY3Qg b24gcGVyZm9ybWFuY2Utd2lzZS4gTGV0dGluZyBmaXhlZCBlbGVtZW50IGhhdmUgc2VwYXJhdGUg bGF5ZXJzIGlzCisgICAgICAgIG5lY2Vzc2FyeSB3aGVuIHRocmVhZGVkIGNvbXBvc2l0b3IgaXMg ZW5hYmxlZCBhdCBsZWFzdC4gQmVjYXVzZSBhc3luYyBzY3JvbGxpbmcgcmVxdWlyZXMgaXQuCisK KyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYlBhZ2UvRHJhd2luZ0FyZWFJbXBsLmNwcDoKKyAgICAg ICAgKFdlYktpdDo6RHJhd2luZ0FyZWFJbXBsOjp1cGRhdGVQcmVmZXJlbmNlcyk6CisKIDIwMTYt MDItMDkgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAg ICAgIFJFR1JFU1NJT04ocjE5NjE4Myk6IFtHVEtdIEJyb2tlIFRlc3RJbnNwZWN0b3IKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9EcmF3aW5nQXJlYUltcGwu Y3BwIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL0RyYXdpbmdBcmVhSW1wbC5j cHAKaW5kZXggMDkzYTUwMjFiOWQ2MGM2N2QxOWNiNGJmYTVjZjhhMWU2Y2UxMDcyOC4uNWU1ODU3 YjVkOGYyMTNlZTY3ZGUwZTc1MzM0MWQ3NTZhY2RmNjU3MSAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL0RyYXdpbmdBcmVhSW1wbC5jcHAKKysrIGIvU291cmNl L1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL0RyYXdpbmdBcmVhSW1wbC5jcHAKQEAgLTI0OCw3 ICsyNDgsMTUgQEAgdm9pZCBEcmF3aW5nQXJlYUltcGw6Om1haW5GcmFtZUNvbnRlbnRTaXplQ2hh bmdlZChjb25zdCBXZWJDb3JlOjpJbnRTaXplJiBuZXdTaXoKIAogdm9pZCBEcmF3aW5nQXJlYUlt cGw6OnVwZGF0ZVByZWZlcmVuY2VzKGNvbnN0IFdlYlByZWZlcmVuY2VzU3RvcmUmIHN0b3JlKQog ewotICAgIG1fd2ViUGFnZS5jb3JlUGFnZSgpLT5zZXR0aW5ncygpLnNldEZvcmNlQ29tcG9zaXRp bmdNb2RlKHN0b3JlLmdldEJvb2xWYWx1ZUZvcktleShXZWJQcmVmZXJlbmNlc0tleTo6Zm9yY2VD b21wb3NpdGluZ01vZGVLZXkoKSkpOworICAgIFNldHRpbmdzJiBzZXR0aW5ncyA9IG1fd2ViUGFn ZS5jb3JlUGFnZSgpLT5zZXR0aW5ncygpOworICAgIHNldHRpbmdzLnNldEZvcmNlQ29tcG9zaXRp bmdNb2RlKHN0b3JlLmdldEJvb2xWYWx1ZUZvcktleShXZWJQcmVmZXJlbmNlc0tleTo6Zm9yY2VD b21wb3NpdGluZ01vZGVLZXkoKSkpOworCisjaWYgVVNFKENPT1JESU5BVEVEX0dSQVBISUNTX1RI UkVBREVEKQorICAgIC8vIEZpeGVkIHBvc2l0aW9uIGVsZW1lbnRzIG5lZWQgdG8gYmUgY29tcG9z aXRlZCBhbmQgY3JlYXRlIHN0YWNraW5nIGNvbnRleHRzCisgICAgLy8gaW4gb3JkZXIgdG8gYmUg c2Nyb2xsZWQgYnkgdGhlIFNjcm9sbGluZ0Nvb3JkaW5hdG9yLgorICAgIHNldHRpbmdzLnNldEFj Y2VsZXJhdGVkQ29tcG9zaXRpbmdGb3JGaXhlZFBvc2l0aW9uRW5hYmxlZCh0cnVlKTsKKyAgICBz ZXR0aW5ncy5zZXRGaXhlZFBvc2l0aW9uQ3JlYXRlc1N0YWNraW5nQ29udGV4dCh0cnVlKTsKKyNl bmRpZgogfQogCiB2b2lkIERyYXdpbmdBcmVhSW1wbDo6bGF5ZXJIb3N0RGlkRmx1c2hMYXllcnMo KQo=