154086 2016-02-10 14:00:16 -0800 [JSC] The destination of Sqrt should be Def, not UseDef 2016-02-11 14:01:48 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 benjamin benjamin commit-queue fpizlo keith_miller mark.lam msaboff saam oldest_to_newest 1163601 0 benjamin 2016-02-10 14:00:16 -0800 [JSC] The destination of Sqrt should be Def, not UseDef 1163602 1 271025 benjamin 2016-02-10 14:01:09 -0800 Created attachment 271025 Patch 1163611 2 271025 ggaren 2016-02-10 14:22:21 -0800 Comment on attachment 271025 Patch r=me 1163684 3 271025 commit-queue 2016-02-10 17:35:43 -0800 Comment on attachment 271025 Patch Clearing flags on attachment: 271025 Committed r196409: <http://trac.webkit.org/changeset/196409> 1163685 4 commit-queue 2016-02-10 17:35:46 -0800 All reviewed patches have been landed. Closing bug. 1163844 5 fpizlo 2016-02-11 13:26:36 -0800 Did you test performance? The last time we did a fix like this it affected performance adversely because we forgot some other stuff. It looks like SqrtFloat doesn't have an entry in FixPartialRegisterStalls so this could be an issue here. 1163859 6 benjamin 2016-02-11 14:01:48 -0800 (In reply to comment #5) > Did you test performance? > > The last time we did a fix like this it affected performance adversely > because we forgot some other stuff. It looks like SqrtFloat doesn't have an > entry in FixPartialRegisterStalls so this could be an issue here. This is a subpart of the aliasing patch, the perf was fine when I did it (2 kraken tests improve a tiny bit but that was it). 271025 2016-02-10 14:01:09 -0800 2016-02-10 17:35:43 -0800 Patch bug-154086-20160210140047.patch text/plain 1461 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTk2MzkwCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAz ZDI1NWMyNWJkZDQwNzY5YTQ1Nzk4YmVlY2Q5MDg2MzIyYmNhMDlhLi5mNzdlZGM1ZThhMDBkOGE1 ZDVkYjAxYWI2NjQ2ZjVkYzBmYmU0NWFjIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAxNi0wMi0xMCAgQmVuamFtaW4gUG91bGFpbiAgPGJlbmphbWluQHdlYmtp dC5vcmc+CisKKyAgICAgICAgW0pTQ10gVGhlIGRlc3RpbmF0aW9uIG9mIFNxcnQgc2hvdWxkIGJl IERlZiwgbm90IFVzZURlZgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTU0MDg2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgQW4gdW5mb3J0dW5hdGUgY29weS1wYXN0ZTogdGhlIGRlc3RpbmF0aW9uIG9mIFNx cnREb3VibGUgYW5kIFNxcnRGbG9hdAorICAgICAgICB3YXMgZGVmaW5lZCBhcyBVc2VEZWYuIEFz IGEgcmVzdWx0LCB0aGUgYXJndW1lbnQgd291bGQgYmUgaW50ZXJmZXJpbmcKKyAgICAgICAgd2l0 aCBldmVyeXRoaW5nIGRlZmluZWQgcHJpb3IuCisKKyAgICAgICAgKiBiMy9haXIvQWlyT3Bjb2Rl Lm9wY29kZXM6CisKIDIwMTYtMDItMTAgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4K IAogICAgICAgICBBdHRyaWJ1dGVzIG9uIHRoZSBXaW5kb3cgaW5zdGFuY2Ugc2hvdWxkIGJlIGNv bmZpZ3VyYWJsZSB1bmxlc3MgW1VuZm9yZ2VhYmxlXQpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFT Y3JpcHRDb3JlL2IzL2Fpci9BaXJPcGNvZGUub3Bjb2RlcyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9iMy9haXIvQWlyT3Bjb2RlLm9wY29kZXMKaW5kZXggMWRiYjhkY2ZjNzU5OWQzYWRiYzJiNWVm NmRkZDVhMzM3NTI3NDM4Zi4uNGVkNDhmMjIxMWQ1YjVkMDdlMmRkOGIyMGEwY2Y0M2ViOGM2MTg5 ZiAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2IzL2Fpci9BaXJPcGNvZGUub3Bj b2RlcworKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYjMvYWlyL0Fpck9wY29kZS5vcGNvZGVz CkBAIC0zODYsMTEgKzM4NiwxMSBAQCBDZWlsRmxvYXQgVTpGOjMyLCBEOkY6MzIKICAgICBUbXAs IFRtcAogICAgIHg4NjogQWRkciwgVG1wCiAKLVNxcnREb3VibGUgVTpGOjY0LCBVRDpGOjY0CitT cXJ0RG91YmxlIFU6Rjo2NCwgRDpGOjY0CiAgICAgVG1wLCBUbXAKICAgICB4ODY6IEFkZHIsIFRt cAogCi1TcXJ0RmxvYXQgVTpGOjMyLCBVRDpGOjMyCitTcXJ0RmxvYXQgVTpGOjMyLCBEOkY6MzIK ICAgICBUbXAsIFRtcAogICAgIHg4NjogQWRkciwgVG1wCiAK