154058 2016-02-09 17:52:26 -0800 Add internal benchmark tests for CSS mix-blend-modes and filters 2016-02-10 17:08:14 -0800 1 1 1 Unclassified WebKit Animations WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 sabouhallawa sabouhallawa cdumez commit-queue dino rniwa oldest_to_newest 1163362 0 sabouhallawa 2016-02-09 17:52:26 -0800 These tests will be based on the bouncing particles css tests but slightly modified to apply the css mix-blend-modes and filters. 1163364 1 270966 sabouhallawa 2016-02-09 18:01:23 -0800 Created attachment 270966 Patch 1163423 2 270966 jonlee 2016-02-09 23:36:45 -0800 Comment on attachment 270966 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=270966&action=review Unofficial r=me > PerformanceTests/Animometer/resources/extensions.js:87 > + browserPrefix: function () No space between function and (). This result is derived and never cached; seems better to rename this to getBrowserPrefix()? > PerformanceTests/Animometer/resources/extensions.js:93 > + .match(/-(moz|webkit|ms)-/) || (styles.OLink === '' && ['', 'o']) This is hard to read. Can we unfold this using if clauses instead? 1163567 3 sabouhallawa 2016-02-10 12:45:49 -0800 Committed r196381: <http://trac.webkit.org/changeset/196381> 270966 2016-02-09 18:01:23 -0800 2016-02-10 17:08:14 -0800 Patch bug-154058-20160209180101.patch text/plain 6678 sabouhallawa SW5kZXg6IFBlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFBlcmZvcm1h bmNlVGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAxOTYzNTApCisrKyBQZXJmb3JtYW5jZVRlc3Rz L0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDMwIEBACisyMDE2LTAyLTA5ICBT YWlkIEFib3UtSGFsbGF3YSAgPHNhYm91aGFsbGF3YUBhcHBsZS5jb20+CisKKyAgICAgICAgQWRk IGludGVybmFsIGJlbmNobWFyayB0ZXN0cyBmb3IgQ1NTIG1peC1ibGVuZC1tb2RlcyBhbmQgZmls dGVycworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU0 MDU4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBB bmltb21ldGVyL3Jlc291cmNlcy9kZWJ1Zy1ydW5uZXIvdGVzdHMuanM6IEluY2x1ZGUgdGhlIG5l dyB0ZXN0cyBpbiB0aGUKKyAgICAgICAgIkhUTUwgc3VpdGUiIG9mIHRoZSBkZWJ1ZyBydW5uZXIu CisgICAgICAgIAorICAgICAgICAqIEFuaW1vbWV0ZXIvcmVzb3VyY2VzL2V4dGVuc2lvbnMuanM6 CisgICAgICAgIChVdGlsaXRpZXMuYnJvd3NlclByZWZpeCk6CisgICAgICAgIChVdGlsaXRpZXMu c2V0RWxlbWVudFByZWZpeGVkUHJvcGVydHkpOiBVdGlsaXR5IGZ1bmN0aW9ucyB0byBhbGxvdyBz ZXR0aW5nCisgICAgICAgIHByZWZpeGVkIHN0eWxlIHByb3BlcnRpZXMuCisgICAgICAgIAorICAg ICAgICAqIEFuaW1vbWV0ZXIvdGVzdHMvYm91bmNpbmctcGFydGljbGVzL3Jlc291cmNlcy9ib3Vu Y2luZy1jc3Mtc2hhcGVzLmpzOgorICAgICAgICBTZXQgdGhlIG1peC1ibGVuZC1tb2RlIGFuZCB0 aGUgZmlsdGVyIHRvIHNvbWUgcmFuZG9tIHZhbHVlcyBpZiB0aGUgb3B0aW9ucworICAgICAgICBv ZiB0aGUgdGVzdCByZXF1ZXN0ZWQgdGhhdC4KKyAgICAgICAgCisgICAgICAgICogQW5pbW9tZXRl ci90ZXN0cy9ib3VuY2luZy1wYXJ0aWNsZXMvcmVzb3VyY2VzL2JvdW5jaW5nLXBhcnRpY2xlcy5q czoKKyAgICAgICAgKHBhcnNlU2hhcGVQYXJhbWV0ZXJzKTogUGFyc2UgdGhlIHVybCBvcHRpb25z ICJibGVuZCIgYW5kICJmaWx0ZXIiIGFuZCBzZXQKKyAgICAgICAgdGhlIGNvcnJlc3BvbmRpbmcg ZmxhZ3MuCisgICAgICAgIAorICAgICAgICAqIEFuaW1vbWV0ZXIvdGVzdHMvcmVzb3VyY2VzL21h aW4uanM6CisgICAgICAgIChyYW5kb21TdHlsZU1peEJsZW5kTW9kZSk6CisgICAgICAgIChyYW5k b21TdHlsZUZpbHRlcik6IFJldHVybiByYW5kb20gbWl4LWJsZW5kLW1vZGUgYW5kIGZpbHRlci4K KwogMjAxNi0wMi0wOCAgSm9uIExlZSAgPGpvbmxlZUBhcHBsZS5jb20+CiAKICAgICAgICAgQWRk cmVzcyBTYWlkJ3MgY29tbWVudHMgb24gdGhlIGJlbmNobWFyaywgYW5kIGRvIHNvbWUgY2xlYW4g dXAuCkluZGV4OiBQZXJmb3JtYW5jZVRlc3RzL0FuaW1vbWV0ZXIvcmVzb3VyY2VzL2V4dGVuc2lv bnMuanMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gUGVyZm9ybWFuY2VUZXN0cy9Bbmltb21ldGVyL3Jlc291cmNl cy9leHRlbnNpb25zLmpzCShyZXZpc2lvbiAxOTYzNTApCisrKyBQZXJmb3JtYW5jZVRlc3RzL0Fu aW1vbWV0ZXIvcmVzb3VyY2VzL2V4dGVuc2lvbnMuanMJKHdvcmtpbmcgY29weSkKQEAgLTgyLDYg KzgyLDI4IEBAIFV0aWxpdGllcyA9CiAKICAgICAgICAgcGFyZW50RWxlbWVudC5hcHBlbmRDaGls ZChlbGVtZW50KTsKICAgICAgICAgcmV0dXJuIGVsZW1lbnQ7CisgICAgfSwKKyAgICAKKyAgICBi cm93c2VyUHJlZml4OiBmdW5jdGlvbiAoKQorICAgIHsKKyAgICAgICAgdmFyIHN0eWxlcyA9IHdp bmRvdy5nZXRDb21wdXRlZFN0eWxlKGRvY3VtZW50LmRvY3VtZW50RWxlbWVudCwgJycpOworICAg ICAgICB2YXIgcHJlZml4ID0gKEFycmF5LnByb3RvdHlwZS5zbGljZQorICAgICAgICAgICAgLmNh bGwoc3R5bGVzKQorICAgICAgICAgICAgLmpvaW4oJycpIAorICAgICAgICAgICAgLm1hdGNoKC8t KG1venx3ZWJraXR8bXMpLS8pIHx8IChzdHlsZXMuT0xpbmsgPT09ICcnICYmIFsnJywgJ28nXSkK KyAgICAgICAgKVsxXTsKKyAgICAgICAgdmFyIGRvbSA9ICgnV2ViS2l0fE1venxNU3xPJykubWF0 Y2gobmV3IFJlZ0V4cCgnKCcgKyBwcmVmaXggKyAnKScsICdpJykpWzFdOworICAgICAgICByZXR1 cm4geworICAgICAgICAgICAgZG9tOiBkb20sCisgICAgICAgICAgICBsb3dlcmNhc2U6IHByZWZp eCwKKyAgICAgICAgICAgIGNzczogJy0nICsgcHJlZml4ICsgJy0nLAorICAgICAgICAgICAganM6 IHByZWZpeFswXS50b1VwcGVyQ2FzZSgpICsgcHJlZml4LnN1YnN0cigxKQorICAgICAgICB9Owor ICAgIH0sCisgICAgCisgICAgc2V0RWxlbWVudFByZWZpeGVkUHJvcGVydHk6IGZ1bmN0aW9uKGVs ZW1lbnQsIHByb3BlcnR5LCB2YWx1ZSkKKyAgICB7CisgICAgICAgIGVsZW1lbnQuc3R5bGVbcHJv cGVydHldID0gZWxlbWVudC5zdHlsZVt0aGlzLmJyb3dzZXJQcmVmaXgoKS5qcyArIHByb3BlcnR5 WzBdLnRvVXBwZXJDYXNlKCkgKyBwcm9wZXJ0eS5zdWJzdHIoMSldID0gdmFsdWU7CiAgICAgfQog fTsKIApJbmRleDogUGVyZm9ybWFuY2VUZXN0cy9Bbmltb21ldGVyL3Jlc291cmNlcy9kZWJ1Zy1y dW5uZXIvdGVzdHMuanMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gUGVyZm9ybWFuY2VUZXN0cy9Bbmltb21ldGVy L3Jlc291cmNlcy9kZWJ1Zy1ydW5uZXIvdGVzdHMuanMJKHJldmlzaW9uIDE5NjM1MCkKKysrIFBl cmZvcm1hbmNlVGVzdHMvQW5pbW9tZXRlci9yZXNvdXJjZXMvZGVidWctcnVubmVyL3Rlc3RzLmpz CSh3b3JraW5nIGNvcHkpCkBAIC04Niw2ICs4NiwxNCBAQCBTdWl0ZXMucHVzaChuZXcgU3VpdGUo IkhUTUwgc3VpdGUiLAogICAgICAgICAgICAgbmFtZTogIkNTUyBib3VuY2luZyBncmFkaWVudCBj aXJjbGVzIgogICAgICAgICB9LAogICAgICAgICB7CisgICAgICAgICAgICB1cmw6ICJib3VuY2lu Zy1wYXJ0aWNsZXMvYm91bmNpbmctY3NzLXNoYXBlcy5odG1sP3BhcnRpY2xlV2lkdGg9ODAmcGFy dGljbGVIZWlnaHQ9ODAmc2hhcGU9Y2lyY2xlJmJsZW5kIiwKKyAgICAgICAgICAgIG5hbWU6ICJD U1MgYm91bmNpbmcgYmxlbmQgY2lyY2xlcyIKKyAgICAgICAgfSwKKyAgICAgICAgeworICAgICAg ICAgICAgdXJsOiAiYm91bmNpbmctcGFydGljbGVzL2JvdW5jaW5nLWNzcy1zaGFwZXMuaHRtbD9w YXJ0aWNsZVdpZHRoPTgwJnBhcnRpY2xlSGVpZ2h0PTgwJnNoYXBlPWNpcmNsZSZmaWx0ZXIiLAor ICAgICAgICAgICAgbmFtZTogIkNTUyBib3VuY2luZyBmaWx0ZXIgY2lyY2xlcyIKKyAgICAgICAg fSwKKyAgICAgICAgewogICAgICAgICAgICAgdXJsOiAiYm91bmNpbmctcGFydGljbGVzL2JvdW5j aW5nLWNzcy1pbWFnZXMuaHRtbD9wYXJ0aWNsZVdpZHRoPTgwJnBhcnRpY2xlSGVpZ2h0PTgwJmlt YWdlU3JjPS4uL3Jlc291cmNlcy95aW4teWFuZy5zdmciLAogICAgICAgICAgICAgbmFtZTogIkNT UyBib3VuY2luZyBTVkcgaW1hZ2VzIgogICAgICAgICB9LApJbmRleDogUGVyZm9ybWFuY2VUZXN0 cy9Bbmltb21ldGVyL3Rlc3RzL2JvdW5jaW5nLXBhcnRpY2xlcy9yZXNvdXJjZXMvYm91bmNpbmct Y3NzLXNoYXBlcy5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBQZXJmb3JtYW5jZVRlc3RzL0FuaW1vbWV0ZXIv dGVzdHMvYm91bmNpbmctcGFydGljbGVzL3Jlc291cmNlcy9ib3VuY2luZy1jc3Mtc2hhcGVzLmpz CShyZXZpc2lvbiAxOTYzNTApCisrKyBQZXJmb3JtYW5jZVRlc3RzL0FuaW1vbWV0ZXIvdGVzdHMv Ym91bmNpbmctcGFydGljbGVzL3Jlc291cmNlcy9ib3VuY2luZy1jc3Mtc2hhcGVzLmpzCSh3b3Jr aW5nIGNvcHkpCkBAIC0xOCw2ICsxOCwxMiBAQCBCb3VuY2luZ0Nzc1NoYXBlID0gVXRpbGl0aWVz LmNyZWF0ZVN1YmNsCiAgICAgICAgICAgICBicmVhazsKICAgICAgICAgfQogCisgICAgICAgIGlm IChzdGFnZS5ibGVuZCkKKyAgICAgICAgICAgIHRoaXMuZWxlbWVudC5zdHlsZS5taXhCbGVuZE1v ZGUgPSBTdGFnZS5yYW5kb21TdHlsZU1peEJsZW5kTW9kZSgpOworICAgICAgICAKKyAgICAgICAg aWYgKHN0YWdlLmZpbHRlcikKKyAgICAgICAgICAgIFV0aWxpdGllcy5zZXRFbGVtZW50UHJlZml4 ZWRQcm9wZXJ0eSh0aGlzLmVsZW1lbnQsICJmaWx0ZXIiLCBTdGFnZS5yYW5kb21TdHlsZUZpbHRl cigpKTsKKwogICAgICAgICB0aGlzLl9tb3ZlKCk7CiAgICAgfSwgewogCkluZGV4OiBQZXJmb3Jt YW5jZVRlc3RzL0FuaW1vbWV0ZXIvdGVzdHMvYm91bmNpbmctcGFydGljbGVzL3Jlc291cmNlcy9i b3VuY2luZy1wYXJ0aWNsZXMuanMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gUGVyZm9ybWFuY2VUZXN0cy9Bbmlt b21ldGVyL3Rlc3RzL2JvdW5jaW5nLXBhcnRpY2xlcy9yZXNvdXJjZXMvYm91bmNpbmctcGFydGlj bGVzLmpzCShyZXZpc2lvbiAxOTYzNTApCisrKyBQZXJmb3JtYW5jZVRlc3RzL0FuaW1vbWV0ZXIv dGVzdHMvYm91bmNpbmctcGFydGljbGVzL3Jlc291cmNlcy9ib3VuY2luZy1wYXJ0aWNsZXMuanMJ KHdvcmtpbmcgY29weSkKQEAgLTg0LDYgKzg0LDggQEAgQm91bmNpbmdQYXJ0aWNsZXNTdGFnZSA9 IFV0aWxpdGllcy5jcmVhdAogICAgICAgICB0aGlzLnNoYXBlID0gb3B0aW9uc1sic2hhcGUiXSB8 fCAiY2lyY2xlIjsKICAgICAgICAgdGhpcy5maWxsID0gb3B0aW9uc1siZmlsbCJdIHx8ICJzb2xp ZCI7CiAgICAgICAgIHRoaXMuY2xpcCA9IG9wdGlvbnNbImNsaXAiXSB8fCAiIjsKKyAgICAgICAg dGhpcy5ibGVuZCA9IG9wdGlvbnNbImJsZW5kIl0gfHwgZmFsc2U7CisgICAgICAgIHRoaXMuZmls dGVyID0gb3B0aW9uc1siZmlsdGVyIl0gfHwgZmFsc2U7CiAgICAgfSwKIAogICAgIGFuaW1hdGU6 IGZ1bmN0aW9uKHRpbWVEZWx0YSkKSW5kZXg6IFBlcmZvcm1hbmNlVGVzdHMvQW5pbW9tZXRlci90 ZXN0cy9yZXNvdXJjZXMvbWFpbi5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBQZXJmb3JtYW5jZVRlc3RzL0Fu aW1vbWV0ZXIvdGVzdHMvcmVzb3VyY2VzL21haW4uanMJKHJldmlzaW9uIDE5NjM1MCkKKysrIFBl cmZvcm1hbmNlVGVzdHMvQW5pbW9tZXRlci90ZXN0cy9yZXNvdXJjZXMvbWFpbi5qcwkod29ya2lu ZyBjb3B5KQpAQCAtMzUwLDYgKzM1MCw0OCBAQCBVdGlsaXRpZXMuZXh0ZW5kT2JqZWN0KFN0YWdl LCB7CiAgICAgICAgICAgICArIHRoaXMucmFuZG9tSW50KG1pbiwgbWF4KS50b1N0cmluZygxNik7 CiAgICAgfSwKIAorICAgIHJhbmRvbVN0eWxlTWl4QmxlbmRNb2RlOiBmdW5jdGlvbigpCisgICAg eworICAgICAgICB2YXIgbWl4QmxlbmRNb2RlTGlzdCA9IFsKKyAgICAgICAgICAnbm9ybWFsJywK KyAgICAgICAgICAnbXVsdGlwbHknLAorICAgICAgICAgICdzY3JlZW4nLAorICAgICAgICAgICdv dmVybGF5JywKKyAgICAgICAgICAnZGFya2VuJywKKyAgICAgICAgICAnbGlnaHRlbicsCisgICAg ICAgICAgJ2NvbG9yLWRvZGdlJywKKyAgICAgICAgICAnY29sb3ItYnVybicsCisgICAgICAgICAg J2hhcmQtbGlnaHQnLAorICAgICAgICAgICdzb2Z0LWxpZ2h0JywKKyAgICAgICAgICAnZGlmZmVy ZW5jZScsCisgICAgICAgICAgJ2V4Y2x1c2lvbicsCisgICAgICAgICAgJ2h1ZScsCisgICAgICAg ICAgJ3NhdHVyYXRpb24nLAorICAgICAgICAgICdjb2xvcicsCisgICAgICAgICAgJ2x1bWlub3Np dHknCisgICAgICAgIF07CisgICAgICAgIAorICAgICAgICByZXR1cm4gbWl4QmxlbmRNb2RlTGlz dFt0aGlzLnJhbmRvbUludCgwLCBtaXhCbGVuZE1vZGVMaXN0Lmxlbmd0aCldOworICAgIH0sCisK KyAgICByYW5kb21TdHlsZUZpbHRlcjogZnVuY3Rpb24oKQorICAgIHsKKyAgICAgICAgdmFyIGZp bHRlckxpc3QgPSBbCisgICAgICAgICAgICAnZ3JheXNjYWxlKDUwJSknLAorICAgICAgICAgICAg J3NlcGlhKDUwJSknLAorICAgICAgICAgICAgJ3NhdHVyYXRlKDUwJSknLAorICAgICAgICAgICAg J2h1ZS1yb3RhdGUoMTgwKScsCisgICAgICAgICAgICAnaW52ZXJ0KDUwJSknLAorICAgICAgICAg ICAgJ29wYWNpdHkoNTAlKScsCisgICAgICAgICAgICAnYnJpZ2h0bmVzcyg1MCUpJywKKyAgICAg ICAgICAgICdjb250cmFzdCg1MCUpJywKKyAgICAgICAgICAgICdibHVyKDEwcHgpJywKKyAgICAg ICAgICAgICdkcm9wLXNoYWRvdygxMHB4IDEwcHggMTBweCBncmF5KScKKyAgICAgICAgXTsKKyAg ICAgICAgCisgICAgICAgIHJldHVybiBmaWx0ZXJMaXN0W3RoaXMucmFuZG9tSW50KDAsIGZpbHRl ckxpc3QubGVuZ3RoKV07CisgICAgfSwKKwogICAgIHJvdGF0aW5nQ29sb3I6IGZ1bmN0aW9uKGN5 Y2xlTGVuZ3RoTXMsIHNhdHVyYXRpb24sIGxpZ2h0bmVzcykKICAgICB7CiAgICAgICAgIHJldHVy biAiaHNsKCIK