154054 2016-02-09 16:09:57 -0800 Modern IDB: TransactionOperation objects leak 2016-02-23 09:53:43 -0800 1 1 1 Unclassified WebKit WebCore Misc. Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 149117 154015 1 beidson beidson achristensen alecflett ap commit-queue jsbell oldest_to_newest 1163320 0 beidson 2016-02-09 16:09:57 -0800 Modern IDB: TransactionOperation objects leak 1163332 1 270961 beidson 2016-02-09 16:17:16 -0800 Created attachment 270961 Patch v1 1163334 2 commit-queue 2016-02-09 16:18:22 -0800 Attachment 270961 did not pass style-queue: ERROR: Source/WebCore/Modules/indexeddb/client/TransactionOperation.h:104: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/Modules/indexeddb/client/TransactionOperation.h:124: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 2 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 1163356 3 270961 commit-queue 2016-02-09 17:15:11 -0800 Comment on attachment 270961 Patch v1 Clearing flags on attachment: 270961 Committed r196349: <http://trac.webkit.org/changeset/196349> 1163357 4 commit-queue 2016-02-09 17:15:13 -0800 All reviewed patches have been landed. Closing bug. 1167438 5 ap 2016-02-23 09:52:45 -0800 This change has cut the total amount of leaks on the leaks bot roughly in half. Nice! 1167439 6 beidson 2016-02-23 09:53:43 -0800 (In reply to comment #5) > This change has cut the total amount of leaks on the leaks bot roughly in > half. Nice! 👍👏 270961 2016-02-09 16:17:16 -0800 2016-02-09 17:15:11 -0800 Patch v1 patch text/plain 5819 beidson ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA4YmEyOGJiLi5lYWM5ZWQ4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIg QEAKKzIwMTYtMDItMDkgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgorCisgICAg ICAgIE1vZGVybiBJREI6IFRyYW5zYWN0aW9uT3BlcmF0aW9uIG9iamVjdHMgbGVhay4KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1NDA1NAorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyAo Q3VycmVudGx5IHVudGVzdGFibGUpLgorCisgICAgICAgICogTW9kdWxlcy9pbmRleGVkZGIvY2xp ZW50L0lEQlRyYW5zYWN0aW9uSW1wbC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpJREJDbGllbnQ6 OklEQlRyYW5zYWN0aW9uOjphYm9ydE9uU2VydmVyQW5kQ2FuY2VsUmVxdWVzdHMpOiBSZW1vdmUg dGhlIFRyYW5zYWN0aW9uT3BlcmF0aW9uIGZyb20KKyAgICAgICAgICB0aGUgbWFwLCBhcyB0aGlz IG9wZXJhdGlvbiBkb2Vzbid0IGNvbXBsZXRlICJub3JtYWxseSIgbGlrZSBtb3N0IG90aGVycy4K KyAgICAgICAgKFdlYkNvcmU6OklEQkNsaWVudDo6SURCVHJhbnNhY3Rpb246OmNvbW1pdE9uU2Vy dmVyKTogRGl0dG8uCisgICAgICAgIAorICAgICAgICAqIE1vZHVsZXMvaW5kZXhlZGRiL2NsaWVu dC9UcmFuc2FjdGlvbk9wZXJhdGlvbi5oOgorICAgICAgICAoV2ViQ29yZTo6SURCQ2xpZW50OjpU cmFuc2FjdGlvbk9wZXJhdGlvbjo6cGVyZm9ybSk6IENsZWFyIHRoZSBtX3BlcmZvcm1GdW5jdGlv biBhZnRlciB1c2UsCisgICAgICAgICAgYXMgaXQgaG9sZHMgYSBsYW1iZGEgdGhhdCBob2xkcyBh IFJlZlB0ciB0byB0aGUgSURCVHJhbnNhY3Rpb24sIGFzIHdlbGwgYXMgYSBzZWxmLXJlZi4KKyAg ICAgICAgKFdlYkNvcmU6OklEQkNsaWVudDo6VHJhbnNhY3Rpb25PcGVyYXRpb246OmNvbXBsZXRl ZCk6IENsZWFyIG1fY29tcGxldGVGdW5jdGlvbiBmb3IgdGhlIHNhbWUgcmVhc29ucy4KKwogMjAx Ni0wMi0wOCAgTmFuIFdhbmcgIDxuX3dhbmdAYXBwbGUuY29tPgogCiAgICAgICAgIEFYOiBjcmFz aCBhdCBXZWJDb3JlOjpSYW5nZTo6c2VsZWN0Tm9kZUNvbnRlbnRzKFdlYkNvcmU6Ok5vZGUqLCBp bnQmKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9pbmRleGVkZGIvY2xpZW50 L0lEQlRyYW5zYWN0aW9uSW1wbC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2luZGV4ZWRk Yi9jbGllbnQvSURCVHJhbnNhY3Rpb25JbXBsLmNwcAppbmRleCBlNTI4OGNiLi5mYTA3MDc1IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2luZGV4ZWRkYi9jbGllbnQvSURCVHJh bnNhY3Rpb25JbXBsLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2luZGV4ZWRkYi9j bGllbnQvSURCVHJhbnNhY3Rpb25JbXBsLmNwcApAQCAtMjAxLDcgKzIwMSw3IEBAIHZvaWQgSURC VHJhbnNhY3Rpb246OmFib3J0KEV4Y2VwdGlvbkNvZGVXaXRoTWVzc2FnZSYgZWMpCiAgICAgc2No ZWR1bGVPcGVyYXRpb24oV1RGTW92ZShvcGVyYXRpb24pKTsKIH0KIAotdm9pZCBJREJUcmFuc2Fj dGlvbjo6YWJvcnRPblNlcnZlckFuZENhbmNlbFJlcXVlc3RzKFRyYW5zYWN0aW9uT3BlcmF0aW9u JikKK3ZvaWQgSURCVHJhbnNhY3Rpb246OmFib3J0T25TZXJ2ZXJBbmRDYW5jZWxSZXF1ZXN0cyhU cmFuc2FjdGlvbk9wZXJhdGlvbiYgb3BlcmF0aW9uKQogewogICAgIExPRyhJbmRleGVkREIsICJJ REJUcmFuc2FjdGlvbjo6YWJvcnRPblNlcnZlckFuZENhbmNlbFJlcXVlc3RzIik7CiAKQEAgLTIw OSw2ICsyMDksOSBAQCB2b2lkIElEQlRyYW5zYWN0aW9uOjphYm9ydE9uU2VydmVyQW5kQ2FuY2Vs UmVxdWVzdHMoVHJhbnNhY3Rpb25PcGVyYXRpb24mKQogCiAgICAgc2VydmVyQ29ubmVjdGlvbigp LmFib3J0VHJhbnNhY3Rpb24oKnRoaXMpOwogCisgICAgQVNTRVJUKG1fdHJhbnNhY3Rpb25PcGVy YXRpb25NYXAuY29udGFpbnMob3BlcmF0aW9uLmlkZW50aWZpZXIoKSkpOworICAgIG1fdHJhbnNh Y3Rpb25PcGVyYXRpb25NYXAucmVtb3ZlKG9wZXJhdGlvbi5pZGVudGlmaWVyKCkpOworCiAgICAg SURCRXJyb3IgZXJyb3IoSURCRGF0YWJhc2VFeGNlcHRpb246OkFib3J0RXJyb3IpOwogICAgIGZv ciAoYXV0byYgb3BlcmF0aW9uIDogbV9hYm9ydFF1ZXVlKQogICAgICAgICBvcGVyYXRpb24tPmNv bXBsZXRlZChJREJSZXN1bHREYXRhOjplcnJvcihvcGVyYXRpb24tPmlkZW50aWZpZXIoKSwgZXJy b3IpKTsKQEAgLTMyMywxMCArMzI2LDEzIEBAIHZvaWQgSURCVHJhbnNhY3Rpb246OmNvbW1pdCgp CiAgICAgc2NoZWR1bGVPcGVyYXRpb24oV1RGTW92ZShvcGVyYXRpb24pKTsKIH0KIAotdm9pZCBJ REJUcmFuc2FjdGlvbjo6Y29tbWl0T25TZXJ2ZXIoVHJhbnNhY3Rpb25PcGVyYXRpb24mKQordm9p ZCBJREJUcmFuc2FjdGlvbjo6Y29tbWl0T25TZXJ2ZXIoVHJhbnNhY3Rpb25PcGVyYXRpb24mIG9w ZXJhdGlvbikKIHsKICAgICBMT0coSW5kZXhlZERCLCAiSURCVHJhbnNhY3Rpb246OmNvbW1pdE9u U2VydmVyIik7CiAgICAgc2VydmVyQ29ubmVjdGlvbigpLmNvbW1pdFRyYW5zYWN0aW9uKCp0aGlz KTsKKworICAgIEFTU0VSVChtX3RyYW5zYWN0aW9uT3BlcmF0aW9uTWFwLmNvbnRhaW5zKG9wZXJh dGlvbi5pZGVudGlmaWVyKCkpKTsKKyAgICBtX3RyYW5zYWN0aW9uT3BlcmF0aW9uTWFwLnJlbW92 ZShvcGVyYXRpb24uaWRlbnRpZmllcigpKTsKIH0KIAogdm9pZCBJREJUcmFuc2FjdGlvbjo6Zmlu aXNoQWJvcnRPckNvbW1pdCgpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2lu ZGV4ZWRkYi9jbGllbnQvVHJhbnNhY3Rpb25PcGVyYXRpb24uaCBiL1NvdXJjZS9XZWJDb3JlL01v ZHVsZXMvaW5kZXhlZGRiL2NsaWVudC9UcmFuc2FjdGlvbk9wZXJhdGlvbi5oCmluZGV4IGVhOWRj ZTAuLmM5Mzk2MDUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvaW5kZXhlZGRi L2NsaWVudC9UcmFuc2FjdGlvbk9wZXJhdGlvbi5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVs ZXMvaW5kZXhlZGRiL2NsaWVudC9UcmFuc2FjdGlvbk9wZXJhdGlvbi5oCkBAIC00NiwxMyArNDYs MTcgQEAgY2xhc3MgVHJhbnNhY3Rpb25PcGVyYXRpb24gOiBwdWJsaWMgUmVmQ291bnRlZDxUcmFu c2FjdGlvbk9wZXJhdGlvbj4gewogcHVibGljOgogICAgIHZvaWQgcGVyZm9ybSgpCiAgICAgewor ICAgICAgICBBU1NFUlQobV9wZXJmb3JtRnVuY3Rpb24pOwogICAgICAgICBtX3BlcmZvcm1GdW5j dGlvbigpOworICAgICAgICBtX3BlcmZvcm1GdW5jdGlvbiA9IHsgfTsKICAgICB9CiAKICAgICB2 b2lkIGNvbXBsZXRlZChjb25zdCBJREJSZXN1bHREYXRhJiBkYXRhKQogICAgIHsKKyAgICAgICAg QVNTRVJUKG1fY29tcGxldGVGdW5jdGlvbik7CiAgICAgICAgIG1fY29tcGxldGVGdW5jdGlvbihk YXRhKTsKICAgICAgICAgbV90cmFuc2FjdGlvbi0+b3BlcmF0aW9uRGlkQ29tcGxldGUoKnRoaXMp OworICAgICAgICBtX2NvbXBsZXRlRnVuY3Rpb24gPSB7IH07CiAgICAgfQogCiAgICAgY29uc3Qg SURCUmVzb3VyY2VJZGVudGlmaWVyJiBpZGVudGlmaWVyKCkgY29uc3QgeyByZXR1cm4gbV9pZGVu dGlmaWVyOyB9CkBAIC05MCwzMSArOTQsMzggQEAgcHVibGljOgogICAgIHsKICAgICAgICAgcmVs YXhBZG9wdGlvblJlcXVpcmVtZW50KCk7CiAgICAgICAgIFJlZlB0cjxUcmFuc2FjdGlvbk9wZXJh dGlvbj4gc2VsZih0aGlzKTsKKworICAgICAgICBBU1NFUlQocGVyZm9ybU1ldGhvZCk7CiAgICAg ICAgIG1fcGVyZm9ybUZ1bmN0aW9uID0gW3NlbGYsIHRoaXMsIHBlcmZvcm1NZXRob2QsIGFyZ3Vt ZW50cy4uLl0gewogICAgICAgICAgICAgKCZtX3RyYW5zYWN0aW9uLmdldCgpLT4qcGVyZm9ybU1l dGhvZCkoKnRoaXMsIGFyZ3VtZW50cy4uLik7CiAgICAgICAgIH07CiAKLSAgICAgICAgbV9jb21w bGV0ZUZ1bmN0aW9uID0gW3NlbGYsIHRoaXMsIGNvbXBsZXRlTWV0aG9kXShjb25zdCBJREJSZXN1 bHREYXRhJiByZXN1bHREYXRhKSB7Ci0gICAgICAgICAgICBpZiAoY29tcGxldGVNZXRob2QpCi0g ICAgICAgICAgICAgICAgKCZtX3RyYW5zYWN0aW9uLmdldCgpLT4qY29tcGxldGVNZXRob2QpKHJl c3VsdERhdGEpOwotICAgICAgICB9OworICAgICAgICBpZiAoY29tcGxldGVNZXRob2QpIHsKKyAg ICAgICAgICAgIG1fY29tcGxldGVGdW5jdGlvbiA9IFtzZWxmLCB0aGlzLCBjb21wbGV0ZU1ldGhv ZF0oY29uc3QgSURCUmVzdWx0RGF0YSYgcmVzdWx0RGF0YSkgeworICAgICAgICAgICAgICAgIGlm IChjb21wbGV0ZU1ldGhvZCkKKyAgICAgICAgICAgICAgICAgICAgKCZtX3RyYW5zYWN0aW9uLmdl dCgpLT4qY29tcGxldGVNZXRob2QpKHJlc3VsdERhdGEpOworICAgICAgICAgICAgfTsKKyAgICAg ICAgfQogICAgIH0KIAogICAgIFRyYW5zYWN0aW9uT3BlcmF0aW9uSW1wbChJREJUcmFuc2FjdGlv biYgdHJhbnNhY3Rpb24sIElEQlJlcXVlc3QmIHJlcXVlc3QsIHZvaWQgKElEQlRyYW5zYWN0aW9u OjoqY29tcGxldGVNZXRob2QpKElEQlJlcXVlc3QmLCBjb25zdCBJREJSZXN1bHREYXRhJiksIHZv aWQgKElEQlRyYW5zYWN0aW9uOjoqcGVyZm9ybU1ldGhvZCkoVHJhbnNhY3Rpb25PcGVyYXRpb24m LCBBcmd1bWVudHMuLi4pLCBBcmd1bWVudHMmJi4uLiBhcmd1bWVudHMpCiAgICAgICAgIDogVHJh bnNhY3Rpb25PcGVyYXRpb24odHJhbnNhY3Rpb24sIHJlcXVlc3QpCiAgICAgewogICAgICAgICBy ZWxheEFkb3B0aW9uUmVxdWlyZW1lbnQoKTsKLQogICAgICAgICBSZWZQdHI8VHJhbnNhY3Rpb25P cGVyYXRpb24+IHNlbGYodGhpcyk7CisKKyAgICAgICAgQVNTRVJUKHBlcmZvcm1NZXRob2QpOwog ICAgICAgICBtX3BlcmZvcm1GdW5jdGlvbiA9IFtzZWxmLCB0aGlzLCBwZXJmb3JtTWV0aG9kLCBh cmd1bWVudHMuLi5dIHsKICAgICAgICAgICAgICgmbV90cmFuc2FjdGlvbi5nZXQoKS0+KnBlcmZv cm1NZXRob2QpKCp0aGlzLCBhcmd1bWVudHMuLi4pOwogICAgICAgICB9OwogCi0gICAgICAgIFJl ZlB0cjxJREJSZXF1ZXN0PiByZWZSZXF1ZXN0KCZyZXF1ZXN0KTsKLSAgICAgICAgbV9jb21wbGV0 ZUZ1bmN0aW9uID0gW3NlbGYsIHRoaXMsIHJlZlJlcXVlc3QsIGNvbXBsZXRlTWV0aG9kXShjb25z dCBJREJSZXN1bHREYXRhJiByZXN1bHREYXRhKSB7Ci0gICAgICAgICAgICBpZiAoY29tcGxldGVN ZXRob2QpCi0gICAgICAgICAgICAgICAgKCZtX3RyYW5zYWN0aW9uLmdldCgpLT4qY29tcGxldGVN ZXRob2QpKCpyZWZSZXF1ZXN0LCByZXN1bHREYXRhKTsKLSAgICAgICAgfTsKKyAgICAgICAgaWYg KGNvbXBsZXRlTWV0aG9kKSB7CisgICAgICAgICAgICBSZWZQdHI8SURCUmVxdWVzdD4gcmVmUmVx dWVzdCgmcmVxdWVzdCk7CisgICAgICAgICAgICBtX2NvbXBsZXRlRnVuY3Rpb24gPSBbc2VsZiwg dGhpcywgcmVmUmVxdWVzdCwgY29tcGxldGVNZXRob2RdKGNvbnN0IElEQlJlc3VsdERhdGEmIHJl c3VsdERhdGEpIHsKKyAgICAgICAgICAgICAgICBpZiAoY29tcGxldGVNZXRob2QpCisgICAgICAg ICAgICAgICAgICAgICgmbV90cmFuc2FjdGlvbi5nZXQoKS0+KmNvbXBsZXRlTWV0aG9kKSgqcmVm UmVxdWVzdCwgcmVzdWx0RGF0YSk7CisgICAgICAgICAgICB9OworICAgICAgICB9CiAgICAgfQog fTsKIAo=